On Thu, 29 Jul 2021 01:30:37 GMT, Vladimir Kozlov wrote:
>> Hi all,
>>
>> could you please review this big tedious and trivial(-ish) patch which moves
>> `sun.hotspot.WhiteBox` and related classes to `jdk.test.whitebox` package?
>>
>> the majority of the patch is the following substitutions:
On Wed, 28 Jul 2021 17:13:49 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review this big tedious and trivial(-ish) patch which moves
> `sun.hotspot.WhiteBox` and related classes to `jdk.test.whitebox` package?
>
> the majority of the patch is the following substitutions:
> -
Hi all,
could you please review this big tedious and trivial(-ish) patch which moves
`sun.hotspot.WhiteBox` and related classes to `jdk.test.whitebox` package?
the majority of the patch is the following substitutions:
- `s~sun/hotspot/WhiteBox~jdk/test/whitebox/WhiteBox~g`
-
On Wed, 7 Jul 2021 04:03:27 GMT, xpbob
wrote:
> …ocess cpu usage in containers
This pull request has now been integrated.
Changeset: 25f00d78
Author:bobpengxie
Committer: Jie Fu
URL:
https://git.openjdk.java.net/jdk/commit/25f00d787cf56f6cdca6949115d04e7d8e675554
Stats: 218
On Wed, 28 Jul 2021 14:22:07 GMT, Thomas Stuefe wrote:
>> If a thread is attaching via JNI and has not yet created its Thread object
>> it can be caught in a ThreadSnapshot during a thread dump (VM_DumpThreads)
>> of all threads**, and the threadObj() will be NULL, so we can't pass it to
>>
On 7/27/21 6:14 PM, Jakob Cornell wrote:
Thanks for the help Chris. With the JBS ticket set up are we ready
for a PR to be opened, or should I wait for the CSR review?
Jakob
It looks like some more discussion is needed before creating the CSR.
You can still create a PR if you want to show
On Wed, 3 Feb 2021 19:12:25 GMT, Emmanuel Bourg
wrote:
> This PR fixes the following spelling errors:
>
> choosen -> chosen
> commad -> command
> hiearchy -> hierarchy
> leagacy -> legacy
> minium -> minimum
> subsytem -> subsystem
> unamed -> unnamed
Thanks for awt/swing
On Wed, 3 Feb 2021 19:12:25 GMT, Emmanuel Bourg
wrote:
> This PR fixes the following spelling errors:
>
> choosen -> chosen
> commad -> command
> hiearchy -> hierarchy
> leagacy -> legacy
> minium -> minimum
> subsytem -> subsystem
> unamed -> unnamed
Marked as reviewed by iris
On Wed, 28 Jul 2021 08:38:04 GMT, Yi Yang wrote:
>> For hotspot changes, it would be better to have a second review & wait for
>> 24 hours before integration.
>> Thanks.
>
>> For hotspot changes, it would be better to have a second review & wait for
>> 24 hours before integration.
>> Thanks.
> This PR fixes the following spelling errors:
>
> choosen -> chosen
> commad -> command
> hiearchy -> hierarchy
> leagacy -> legacy
> minium -> minimum
> subsytem -> subsystem
> unamed -> unnamed
Emmanuel Bourg has updated the pull request with a new target base due to a
merge
On Wed, 3 Feb 2021 19:12:25 GMT, Emmanuel Bourg
wrote:
> This PR fixes the following spelling errors:
>
> choosen -> chosen
> commad -> command
> hiearchy -> hierarchy
> leagacy -> legacy
> minium -> minimum
> subsytem -> subsystem
> unamed -> unnamed
.
.
Thank you!
The PR
On Wed, 28 Jul 2021 17:20:37 GMT, Kevin Rushforth wrote:
>> @FrauBoes thank you, the PR has been updated to modify the copyright year
>
> @ebourg for future PRs please do not force push after the PR is out for
> review. Just push incremental commits normally. The Skara tooling will squash
>
On Wed, 28 Jul 2021 17:12:04 GMT, Emmanuel Bourg
wrote:
>> This PR fixes the following spelling errors:
>>
>> choosen -> chosen
>> commad -> command
>> hiearchy -> hierarchy
>> leagacy -> legacy
>> minium -> minimum
>> subsytem -> subsystem
>> unamed -> unnamed
>
> Emmanuel
On Wed, 28 Jul 2021 17:08:01 GMT, Emmanuel Bourg
wrote:
>> I'm happy to sponsor this change, but could you please update the copyright
>> year where necessary, e.g. in
>> src/java.desktop/unix/classes/sun/awt/X11/XMSelection.java:
>> `Copyright (c) 2003, 2018, Oracle...` -> `Copyright (c)
On Wed, 28 Jul 2021 16:26:49 GMT, Julia Boes wrote:
>> This PR fixes the following spelling errors:
>>
>> choosen -> chosen
>> commad -> command
>> hiearchy -> hierarchy
>> leagacy -> legacy
>> minium -> minimum
>> subsytem -> subsystem
>> unamed -> unnamed
>
> I'm happy to
On Wed, 3 Feb 2021 19:12:25 GMT, Emmanuel Bourg
wrote:
> This PR fixes the following spelling errors:
>
> choosen -> chosen
> commad -> command
> hiearchy -> hierarchy
> leagacy -> legacy
> minium -> minimum
> subsytem -> subsystem
> unamed -> unnamed
I'm happy to sponsor this
On Wed, 3 Feb 2021 19:12:25 GMT, Emmanuel Bourg
wrote:
> This PR fixes the following spelling errors:
>
> choosen -> chosen
> commad -> command
> hiearchy -> hierarchy
> leagacy -> legacy
> minium -> minimum
> subsytem -> subsystem
> unamed -> unnamed
jdi, jvmti, and dcmd
On Wed, 3 Feb 2021 19:12:25 GMT, Emmanuel Bourg
wrote:
> This PR fixes the following spelling errors:
>
> choosen -> chosen
> commad -> command
> hiearchy -> hierarchy
> leagacy -> legacy
> minium -> minimum
> subsytem -> subsystem
> unamed -> unnamed
Hi, I've filed
On Wed, 3 Feb 2021 19:12:25 GMT, Emmanuel Bourg
wrote:
> This PR fixes the following spelling errors:
>
> choosen -> chosen
> commad -> command
> hiearchy -> hierarchy
> leagacy -> legacy
> minium -> minimum
> subsytem -> subsystem
> unamed -> unnamed
Trivially, looks ok to me.
On Wed, 3 Feb 2021 19:12:25 GMT, Emmanuel Bourg
wrote:
> This PR fixes the following spelling errors:
>
> choosen -> chosen
> commad -> command
> hiearchy -> hierarchy
> leagacy -> legacy
> minium -> minimum
> subsytem -> subsystem
> unamed -> unnamed
Lgtm.
-
This PR fixes the following spelling errors:
choosen -> chosen
commad -> command
hiearchy -> hierarchy
leagacy -> legacy
minium -> minimum
subsytem -> subsystem
unamed -> unnamed
-
Commit messages:
- 8271396: Fix spelling errors
Changes:
On Wed, 28 Jul 2021 10:03:10 GMT, David Holmes wrote:
> If a thread is attaching via JNI and has not yet created its Thread object it
> can be caught in a ThreadSnapshot during a thread dump (VM_DumpThreads) of
> all threads**, and the threadObj() will be NULL, so we can't pass it to
>
On Wed, 28 Jul 2021 10:03:10 GMT, David Holmes wrote:
> If a thread is attaching via JNI and has not yet created its Thread object it
> can be caught in a ThreadSnapshot during a thread dump (VM_DumpThreads) of
> all threads**, and the threadObj() will be NULL, so we can't pass it to
>
If a thread is attaching via JNI and has not yet created its Thread object it
can be caught in a ThreadSnapshot during a thread dump (VM_DumpThreads) of all
threads**, and the threadObj() will be NULL, so we can't pass it to
get_thread_status().
** JMM dumpThreads API
The initial fix simply
On Wed, 28 Jul 2021 08:24:41 GMT, Jie Fu wrote:
> For hotspot changes, it would be better to have a second review & wait for 24
> hours before integration.
> Thanks.
Well, it seems a trivial change, maybe one review is okay. For non-trivial
changes, we really need more reviews and wait for
On Wed, 28 Jul 2021 08:06:56 GMT, Yi Yang wrote:
>> Should be PHASE_CCP instead of PHASE_CPP, it also affects dumped ideal graph
>> XML.
>
> Yi Yang has updated the pull request incrementally with one additional commit
> since the last revision:
>
> update copyright year
For hotspot
On Wed, 28 Jul 2021 07:19:08 GMT, Yi Yang wrote:
> Should be PHASE_CCP instead of PHASE_CPP, it also affects dumped ideal graph
> XML.
Thank you Jie for review!
-
PR: https://git.openjdk.java.net/jdk/pull/4917
On Wed, 28 Jul 2021 07:19:08 GMT, Yi Yang wrote:
> Should be PHASE_CCP instead of PHASE_CPP, it also affects dumped ideal graph
> XML.
This pull request has now been integrated.
Changeset: 072fe486
Author:Yi Yang
URL:
> Should be PHASE_CCP instead of PHASE_CPP, it also affects dumped ideal graph
> XML.
Yi Yang has updated the pull request incrementally with one additional commit
since the last revision:
update copyright year
-
Changes:
- all:
On Wed, 28 Jul 2021 07:19:08 GMT, Yi Yang wrote:
> Should be PHASE_CCP instead of PHASE_CPP, it also affects dumped ideal graph
> XML.
Looks good to me.
The copyright year should also be updated.
Thanks.
-
Marked as reviewed by jiefu (Reviewer).
PR:
Should be PHASE_CCP instead of PHASE_CPP, it also affects dumped ideal graph
XML.
-
Commit messages:
- typo
Changes: https://git.openjdk.java.net/jdk/pull/4917/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=4917=00
Issue:
31 matches
Mail list logo
