Re: RFR: 8269934: RunThese24H.java failed with EXCEPTION_ACCESS_VIOLATION in java_lang_Thread::get_thread_status

2021-08-02 Thread David Holmes
On Tue, 3 Aug 2021 06:11:37 GMT, Serguei Spitsyn wrote: >> src/hotspot/share/services/threadService.cpp line 879: >> >>> 877: // If thread is still attaching then threadObj will be NULL. >>> 878: _thread_status = threadObj == NULL ? JavaThreadStatus::NEW >>> 879:

Re: RFR: 8269934: RunThese24H.java failed with EXCEPTION_ACCESS_VIOLATION in java_lang_Thread::get_thread_status

2021-08-02 Thread David Holmes
On Tue, 3 Aug 2021 06:12:35 GMT, Serguei Spitsyn wrote: >> If a thread is attaching via JNI and has not yet created its Thread object >> it can be caught in a ThreadSnapshot during a thread dump (VM_DumpThreads) >> of all threads**, and the threadObj() will be NULL, so we can't pass it to >> g

Re: RFR: 8269934: RunThese24H.java failed with EXCEPTION_ACCESS_VIOLATION in java_lang_Thread::get_thread_status

2021-08-02 Thread Serguei Spitsyn
On Wed, 28 Jul 2021 15:17:19 GMT, Daniel D. Daugherty wrote: >> If a thread is attaching via JNI and has not yet created its Thread object >> it can be caught in a ThreadSnapshot during a thread dump (VM_DumpThreads) >> of all threads**, and the threadObj() will be NULL, so we can't pass it to

Re: RFR: 8269934: RunThese24H.java failed with EXCEPTION_ACCESS_VIOLATION in java_lang_Thread::get_thread_status

2021-08-02 Thread Serguei Spitsyn
On Wed, 28 Jul 2021 10:03:10 GMT, David Holmes wrote: > If a thread is attaching via JNI and has not yet created its Thread object it > can be caught in a ThreadSnapshot during a thread dump (VM_DumpThreads) of > all threads**, and the threadObj() will be NULL, so we can't pass it to > get_thr

Re: RFR: 8213714: AttachingConnector/attach/attach001 failed due to "bind failed: Address already in use"

2021-08-02 Thread Serguei Spitsyn
On Sat, 17 Jul 2021 00:38:44 GMT, Alex Menkov wrote: > The fix updates the tests to use dynamic port launching debuggee and get the > listening port from the debugee output Hi Alex, The fix looks good to me. While you are a this code, may I ask you to do a minor cleanup and get rid of several

Re: RFR: 8213714: AttachingConnector/attach/attach001 failed due to "bind failed: Address already in use"

2021-08-02 Thread Serguei Spitsyn
On Sat, 17 Jul 2021 00:38:44 GMT, Alex Menkov wrote: > The fix updates the tests to use dynamic port launching debuggee and get the > listening port from the debugee output test/hotspot/jtreg/vmTestbase/nsk/share/IORedirector.java line 74: > 72: this(); > 73: this.bin = in; >

Integrated: Merge jdk17

2021-08-02 Thread Jesper Wilhelmsson
On Mon, 2 Aug 2021 23:30:55 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 17 -> JDK 18 This pull request has now been integrated. Changeset: c8add223 Author:Jesper Wilhelmsson URL: https://git.openjdk.java.net/jdk/commit/c8add223a10030e40ccef42e081fd0d8f00e0593 Stats: 534 li

Re: RFR: Merge jdk17 [v2]

2021-08-02 Thread Mikael Vidstedt
On Mon, 2 Aug 2021 23:53:59 GMT, Jesper Wilhelmsson wrote: >> Forwardport JDK 17 -> JDK 18 > > Jesper Wilhelmsson has updated the pull request incrementally with one > additional commit since the last revision: > > Revert "8271150: Remove EA from JDK 17 version string starting with Initial

Re: RFR: Merge jdk17 [v2]

2021-08-02 Thread Jesper Wilhelmsson
> Forwardport JDK 17 -> JDK 18 Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: Revert "8271150: Remove EA from JDK 17 version string starting with Initial RC promotion on Aug 5, 2021(B34)" This reverts commit f8fb5713074b8

RFR: Merge jdk17

2021-08-02 Thread Jesper Wilhelmsson
Forwardport JDK 17 -> JDK 18 - Commit messages: - Merge - 8067223: [TESTBUG] Rename Whitebox API package - 8271150: Remove EA from JDK 17 version string starting with Initial RC promotion on Aug 5, 2021(B34) The webrevs contain the adjustments done while merging with regards to e

Re: RFR: 8269934: RunThese24H.java failed with EXCEPTION_ACCESS_VIOLATION in java_lang_Thread::get_thread_status

2021-08-02 Thread David Holmes
On Wed, 28 Jul 2021 10:03:10 GMT, David Holmes wrote: > If a thread is attaching via JNI and has not yet created its Thread object it > can be caught in a ThreadSnapshot during a thread dump (VM_DumpThreads) of > all threads**, and the threadObj() will be NULL, so we can't pass it to > get_thr

Re: [jdk17] RFR: 8067223: [TESTBUG] Rename Whitebox API package [v2]

2021-08-02 Thread David Holmes
On 3/08/2021 2:25 am, Igor Ignatyev wrote: On Sat, 31 Jul 2021 20:42:10 GMT, Igor Ignatyev wrote: Hi all, could you please review this big tedious and trivial(-ish) patch which moves `sun.hotspot.WhiteBox` and related classes to `jdk.test.whitebox` package? the majority of the patch is the

[jdk17] Integrated: 8067223: [TESTBUG] Rename Whitebox API package

2021-08-02 Thread Igor Ignatyev
On Wed, 28 Jul 2021 17:13:49 GMT, Igor Ignatyev wrote: > Hi all, > > could you please review this big tedious and trivial(-ish) patch which moves > `sun.hotspot.WhiteBox` and related classes to `jdk.test.whitebox` package? > > the majority of the patch is the following substitutions: > - `s~s

Re: RFR: 8271514: support JFR use of new ThreadsList::Iterator [v2]

2021-08-02 Thread Daniel D . Daugherty
> A trivial fix to support JFR use of new ThreadsList::Iterator. > > This fix was tested with Mach5 Tier[1-3]. Daniel D. Daugherty has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase

Re: [jdk17] RFR: 8067223: [TESTBUG] Rename Whitebox API package [v2]

2021-08-02 Thread Igor Ignatyev
On Mon, 2 Aug 2021 15:56:39 GMT, Vladimir Kozlov wrote: > I agree with these revised changes for JDK 17. Thanks for your review, Vladimir. I'll rerun my testing before integrating (just for good luck). -- Igor - PR: https://git.openjdk.java.net/jdk17/pull/290

Re: [jdk17] RFR: 8067223: [TESTBUG] Rename Whitebox API package [v2]

2021-08-02 Thread Igor Ignatyev
On Sat, 31 Jul 2021 20:42:10 GMT, Igor Ignatyev wrote: >> Hi all, >> >> could you please review this big tedious and trivial(-ish) patch which moves >> `sun.hotspot.WhiteBox` and related classes to `jdk.test.whitebox` package? >> >> the majority of the patch is the following substitutions: >>

Re: [jdk17] RFR: 8067223: [TESTBUG] Rename Whitebox API package [v3]

2021-08-02 Thread Igor Ignatyev
> Hi all, > > could you please review this big tedious and trivial(-ish) patch which moves > `sun.hotspot.WhiteBox` and related classes to `jdk.test.whitebox` package? > > the majority of the patch is the following substitutions: > - `s~sun/hotspot/WhiteBox~jdk/test/whitebox/WhiteBox~g` > - `s

Re: [jdk17] RFR: 8067223: [TESTBUG] Rename Whitebox API package [v2]

2021-08-02 Thread Vladimir Kozlov
On Sat, 31 Jul 2021 20:42:10 GMT, Igor Ignatyev wrote: >> Hi all, >> >> could you please review this big tedious and trivial(-ish) patch which moves >> `sun.hotspot.WhiteBox` and related classes to `jdk.test.whitebox` package? >> >> the majority of the patch is the following substitutions: >>

Re: RFR: 8269685: Optimize HeapHprofBinWriter implementation [v3]

2021-08-02 Thread Lin Zang
On Mon, 5 Jul 2021 12:04:17 GMT, Lin Zang wrote: >> This PR rewrite the implementation of the HeapHprofBinWriter, which could >> simplify the logic of current implementation. >> please see detail description at >> https://bugs.openjdk.java.net/browse/JDK-8269685. > > Lin Zang has updated the pu

Re: RFR: 8269909: getStack method in hprof.parser.Reader should use try-with-resource [v4]

2021-08-02 Thread Lin Zang
On Thu, 15 Jul 2021 17:22:31 GMT, Serguei Spitsyn wrote: >> Lin Zang has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains five additional commits >>