Re: RFR: 8178287: AsyncGetCallTrace fails to traverse valid Java stacks [v4]

2021-08-17 Thread Serguei Spitsyn
On Mon, 19 Jul 2021 09:25:59 GMT, Ludovic Henry wrote: >> When the signal sent for AsyncGetCallTrace or JFR would land on a runtime >> stub (like arraycopy), a vtable stub, or the prolog of a compiled method, >> it wouldn't be able to detect the sender (caller) frame for multiple >> reasons.

Integrated: 8272398: Update DockerTestUtils.buildJdkDockerImage()

2021-08-17 Thread Mikhailo Seledtsov
On Mon, 16 Aug 2021 23:31:41 GMT, Mikhailo Seledtsov wrote: > Please review this change that updates the buildJdkDockerImage() test library > API. > > This work originated while working on "8195809: [TESTBUG] jps and jcmd -l > support for containers is not tested". > The initial intent was to

Re: RFR: 8272398: Update DockerTestUtils.buildJdkDockerImage() [v3]

2021-08-17 Thread Mikhailo Seledtsov
On Tue, 17 Aug 2021 22:13:54 GMT, Mikhailo Seledtsov wrote: >> Please review this change that updates the buildJdkDockerImage() test >> library API. >> >> This work originated while working on "8195809: [TESTBUG] jps and jcmd -l >> support for containers is not tested". >> The initial intent

Re: RFR: 8272398: Update DockerTestUtils.buildJdkDockerImage() [v3]

2021-08-17 Thread Mikhailo Seledtsov
> Please review this change that updates the buildJdkDockerImage() test library > API. > > This work originated while working on "8195809: [TESTBUG] jps and jcmd -l > support for containers is not tested". > The initial intent was to extend the buildJdkDockerImage() API of > DockerTestUtils to

Re: RFR: 8272398: Update DockerTestUtils.buildJdkDockerImage() [v2]

2021-08-17 Thread Mikhailo Seledtsov
On Tue, 17 Aug 2021 20:30:04 GMT, Harold Seigel wrote: >> Mikhailo Seledtsov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Addressing review feedback > > test/lib/jdk/test/lib/containers/docker/DockerTestUtils.java line 175: > >> 173:

Re: RFR: 8272398: Update DockerTestUtils.buildJdkDockerImage() [v2]

2021-08-17 Thread Harold Seigel
On Tue, 17 Aug 2021 14:58:48 GMT, Mikhailo Seledtsov wrote: >> Please review this change that updates the buildJdkDockerImage() test >> library API. >> >> This work originated while working on "8195809: [TESTBUG] jps and jcmd -l >> support for containers is not tested". >> The initial intent

Re: RFR: 8272124: Cgroup v1 initialization causes NullPointerException when path contains colon [v2]

2021-08-17 Thread Severin Gehwolf
On Tue, 17 Aug 2021 17:39:49 GMT, Harold Seigel wrote: >> Please review this small fix for JDK-8272124. The fix puts a limit of 3 >> when splitting self cgroup lines by ':' so that Cgroup paths won't get >> truncated if they contain embedded ':'s. For example, an entry of >> "11:memory:/user

Re: RFR: 8272124: Cgroup v1 initialization causes NullPointerException when path contains colon [v2]

2021-08-17 Thread Harold Seigel
> Please review this small fix for JDK-8272124. The fix puts a limit of 3 when > splitting self cgroup lines by ':' so that Cgroup paths won't get truncated > if they contain embedded ':'s. For example, an entry of > "11:memory:/user.sli:ce" in a /proc/self/cgroup file will now result in a >

Re: RFR: 8272124: Cgroup v1 initialization causes NullPointerException when path contains colon

2021-08-17 Thread Harold Seigel
On Mon, 16 Aug 2021 17:25:57 GMT, Harold Seigel wrote: > Please review this small fix for JDK-8272124. The fix puts a limit of 3 when > splitting self cgroup lines by ':' so that Cgroup paths won't get truncated > if they contain embedded ':'s. For example, an entry of > "11:memory:/user.sli

Re: RFR: 8272398: Update DockerTestUtils.buildJdkDockerImage() [v2]

2021-08-17 Thread Igor Ignatyev
On Tue, 17 Aug 2021 14:58:48 GMT, Mikhailo Seledtsov wrote: >> Please review this change that updates the buildJdkDockerImage() test >> library API. >> >> This work originated while working on "8195809: [TESTBUG] jps and jcmd -l >> support for containers is not tested". >> The initial intent

Re: RFR: 8272124: Cgroup v1 initialization causes NullPointerException when path contains colon

2021-08-17 Thread Severin Gehwolf
On Tue, 17 Aug 2021 09:07:17 GMT, Severin Gehwolf wrote: >> Please review this small fix for JDK-8272124. The fix puts a limit of 3 >> when splitting self cgroup lines by ':' so that Cgroup paths won't get >> truncated if they contain embedded ':'s. For example, an entry of >> "11:memory:/us

Re: RFR: 8272398: Update DockerTestUtils.buildJdkDockerImage() [v2]

2021-08-17 Thread Mikhailo Seledtsov
> Please review this change that updates the buildJdkDockerImage() test library > API. > > This work originated while working on "8195809: [TESTBUG] jps and jcmd -l > support for containers is not tested". > The initial intent was to extend the buildJdkDockerImage() API of > DockerTestUtils to

Re: RFR: 8272124: Cgroup v1 initialization causes NullPointerException when path contains colon

2021-08-17 Thread Severin Gehwolf
On Mon, 16 Aug 2021 17:25:57 GMT, Harold Seigel wrote: > Please review this small fix for JDK-8272124. The fix puts a limit of 3 when > splitting self cgroup lines by ':' so that Cgroup paths won't get truncated > if they contain embedded ':'s. For example, an entry of > "11:memory:/user.sli

Re: RFR: 8178287: AsyncGetCallTrace fails to traverse valid Java stacks [v3]

2021-08-17 Thread Marcus Hirt
On Wed, 30 Jun 2021 09:17:42 GMT, Serguei Spitsyn wrote: >> Ludovic Henry has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix comments > > Hi Ludovic, > You need two reviews including one (R)eviewer before integration of your fix. > Than