Re: RFR: 8269537: memset() is called after operator new [v2]

2021-09-25 Thread Kim Barrett
On Fri, 24 Sep 2021 08:50:18 GMT, Leo Korinth wrote: >> I hit the new assert when not on Linux, I guess it has to do with the >> initialization of the thread local variable. > > Thanks Ioi for making me adding the assert!!! The sequencing of the > allocation function and the arguments to the co

Re: RFR: 8269685: Optimize HeapHprofBinWriter implementation [v11]

2021-09-25 Thread Lin Zang
> This PR rewrite the implementation of the HeapHprofBinWriter, which could > simplify the logic of current implementation. > please see detail description at > https://bugs.openjdk.java.net/browse/JDK-8269685. Lin Zang has updated the pull request incrementally with one additional commit since

Re: RFR: 8266936: Add a finalization JFR event [v14]

2021-09-25 Thread Markus Grönlund
> Greetings, > > Object.finalize() was deprecated in JDK9. There is an ongoing effort to > replace and mitigate Object.finalize() uses in the JDK libraries; please see > https://bugs.openjdk.java.net/browse/JDK-8253568 for more information. > > We also like to assist users in replacing and mit

Re: RFR: 8266936: Add a finalization JFR event [v12]

2021-09-25 Thread Markus Grönlund
On Fri, 24 Sep 2021 22:31:18 GMT, Mandy Chung wrote: > > > Hi Markus, > > It's a little surprised to see Finalizer.c to depend JMM interface which is > used by `java.management` and `jdk.management` modules only. It's more > appropriate for it to be a JVM_* entry point for Finalizer to repor

Integrated: 8274312: ProblemList 2 serviceability/dcmd/gc tests with ZGC on macos-all

2021-09-25 Thread Daniel D . Daugherty
On Sat, 25 Sep 2021 03:54:19 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList 2 serviceability/dcmd/gc tests with ZGC on > macOS-all. This pull request has now been integrated. Changeset: ab28db14 Author:Daniel D. Daugherty URL: https://git.openjdk.java.net/jdk/commi

Re: RFR: 8274312: ProblemList 2 serviceability/dcmd/gc tests with ZGC on macos-all [v2]

2021-09-25 Thread Daniel D . Daugherty
On Sat, 25 Sep 2021 11:17:23 GMT, David Holmes wrote: >> Daniel D. Daugherty has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8274313: ProblemList sun/tools/jmap/BasicJMapTest.java subtests > > test/jdk/ProblemList.txt line 824: > >> 822

Re: RFR: 8274312: ProblemList 2 serviceability/dcmd/gc tests with ZGC on macos-all [v2]

2021-09-25 Thread Daniel D . Daugherty
On Sat, 25 Sep 2021 05:24:07 GMT, Thomas Stuefe wrote: >> Daniel D. Daugherty has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8274313: ProblemList sun/tools/jmap/BasicJMapTest.java subtests > > Looks good and trivial. @tstuefe, @sspitsy

Re: RFR: 8266936: Add a finalization JFR event [v13]

2021-09-25 Thread Markus Grönlund
> Greetings, > > Object.finalize() was deprecated in JDK9. There is an ongoing effort to > replace and mitigate Object.finalize() uses in the JDK libraries; please see > https://bugs.openjdk.java.net/browse/JDK-8253568 for more information. > > We also like to assist users in replacing and mit

Re: RFR: 8272992: Replace usages of Collections.sort with List.sort call in jdk.* modules [v4]

2021-09-25 Thread Andrey Turbanov
> Collections.sort is just a wrapper, so it is better to use an instance method > directly. Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision: 8272992: Replace usages of Collections.sort with List.sort call in jdk.* modules extrac

Re: RFR: 8272992: Replace usages of Collections.sort with List.sort call in jdk.* modules [v3]

2021-09-25 Thread Andrey Turbanov
On Sat, 25 Sep 2021 11:15:20 GMT, Andrey Turbanov wrote: >> Collections.sort is just a wrapper, so it is better to use an instance >> method directly. > > Andrey Turbanov has updated the pull request incrementally with one > additional commit since the last revision: > >8272992: Replace u

Re: RFR: 8274312: ProblemList 2 serviceability/dcmd/gc tests with ZGC on macos-all [v2]

2021-09-25 Thread David Holmes
On Sat, 25 Sep 2021 05:19:24 GMT, Daniel D. Daugherty wrote: >> A trivial fix to ProblemList 2 serviceability/dcmd/gc tests with ZGC on >> macOS-all. > > Daniel D. Daugherty has updated the pull request incrementally with one > additional commit since the last revision: > > 8274313: Problem

Re: RFR: 8272992: Replace usages of Collections.sort with List.sort call in jdk.* modules [v2]

2021-09-25 Thread Andrey Turbanov
On Tue, 14 Sep 2021 07:46:12 GMT, Andrey Turbanov wrote: >> Collections.sort is just a wrapper, so it is better to use an instance >> method directly. > > Andrey Turbanov has updated the pull request incrementally with one > additional commit since the last revision: > > 8272992: Replace us

Re: RFR: 8272992: Replace usages of Collections.sort with List.sort call in jdk.* modules [v3]

2021-09-25 Thread Andrey Turbanov
> Collections.sort is just a wrapper, so it is better to use an instance method > directly. Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision: 8272992: Replace usages of Collections.sort with List.sort call in jdk.* modules extr

RFR: 8274318: Replace 'for' cycles with iterator with enhanced-for in java.management

2021-09-25 Thread Andrey Turbanov
There are a few places in code, where manual `for` loop is used with Iterator to iterate over Collection. Instead of manual `for` cycles, it's preferred to use enhanced-for cycle instead: it's less verbose, makes code easier to read and it's less error-prone. It doesn't have any performance impac