> A fix to reduce ThreadsListHandle overhead in relation to handshakes and
> we add sanity checks for ThreadsListHandles higher in the call stack.
>
> This fix was tested with Mach5 Tier[1-8]; Tier8 is still running.
Daniel D. Daugherty has updated the pull request incrementally with one
additio
On Fri, 15 Oct 2021 18:27:43 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/runtime/thread.cpp line 1771:
>>
>>> 1769: guarantee(Thread::is_JavaThread_protected_by_my_ThreadsList(this),
>>> 1770: "missing ThreadsListHandle in calling context.");
>>> 1771: if (is_exiting()) {
On Fri, 15 Oct 2021 18:20:12 GMT, Coleen Phillimore wrote:
>> Daniel D. Daugherty has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8249004.cr1.patch
>
> src/hotspot/share/runtime/handshake.cpp line 358:
>
>> 356: bool target_is_dead =
On Fri, 15 Oct 2021 06:34:42 GMT, David Holmes wrote:
>> Daniel D. Daugherty has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8249004.cr1.patch
>
> src/hotspot/share/prims/jvmtiEventController.cpp line 623:
>
>> 621: // If we have a
On Fri, 15 Oct 2021 06:45:02 GMT, David Holmes wrote:
>> Daniel D. Daugherty has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8249004.cr1.patch
>
> src/hotspot/share/runtime/thread.cpp line 1771:
>
>> 1769: guarantee(Thread::is_JavaThr
On Thu, 14 Oct 2021 16:03:28 GMT, Daniel D. Daugherty
wrote:
>> A fix to reduce ThreadsListHandle overhead in relation to handshakes and
>> we add sanity checks for ThreadsListHandles higher in the call stack.
>>
>> This fix was tested with Mach5 Tier[1-8]; Tier8 is still running.
>
> Daniel D.
On Fri, 15 Oct 2021 09:27:54 GMT, Markus Grönlund wrote:
>> Greetings,
>>
>> Object.finalize() was deprecated in JDK9. There is an ongoing effort to
>> replace and mitigate Object.finalize() uses in the JDK libraries; please see
>> https://bugs.openjdk.java.net/browse/JDK-8253568 for more info
On Fri, 15 Oct 2021 06:43:13 GMT, Andrey Turbanov wrote:
> Non-static classes hold a link to their parent classes, which can be avoided.
Marked as reviewed by sspitsyn (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5962
On Fri, 15 Oct 2021 06:43:13 GMT, Andrey Turbanov wrote:
> Non-static classes hold a link to their parent classes, which can be avoided.
Marked as reviewed by mchung (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5962
On Fri, 15 Oct 2021 09:17:12 GMT, Richard Reingruber wrote:
>> Ok. So you just need to reacquire the threadLock before the `findThread()`
>> call and before exiting the while loop, and hold it until after the
>> `trackAppResume()` call. I guess it ok then. But this exiting of the
>> handlerLoc
On Fri, 15 Oct 2021 06:43:13 GMT, Andrey Turbanov wrote:
> Non-static classes hold a link to their parent classes, which can be avoided.
Marked as reviewed by dfuchs (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5962
> I proposed to extend DCmd to allow Java developers to customize their own
> diagnostic commands last week.
>
> At present, I have implemented a preliminary version.
>
> In the current implementation, I provided some simple APIs in the Java layer
> (under sun.management.cmd) for defining and r
On Thu, 14 Oct 2021 22:36:30 GMT, Markus Grönlund wrote:
>> src/hotspot/share/jfr/support/jfrSymbolTable.hpp line 68:
>>
>>> 66: template class,
>>> typename, size_t>
>>> 67: friend class HashTableHost;
>>> 68: typedef HashTableHost>> JfrSymbolTable> SymbolTable;
>>
>> Oh here it is. S
On Thu, 14 Oct 2021 21:43:27 GMT, Coleen Phillimore wrote:
>> Markus Grönlund has refreshed the contents of this pull request, and
>> previous commits have been removed. The incremental views will show
>> differences compared to the previous content of the PR.
>
> src/hotspot/share/jfr/support/
> Greetings,
>
> Object.finalize() was deprecated in JDK9. There is an ongoing effort to
> replace and mitigate Object.finalize() uses in the JDK libraries; please see
> https://bugs.openjdk.java.net/browse/JDK-8253568 for more information.
>
> We also like to assist users in replacing and mit
On Thu, 14 Oct 2021 18:33:51 GMT, Chris Plummer wrote:
>>> Ok, so you need to hold threadLock from the time `blockOnDebuggerSuspend()`
>>> is done waiting on it until after `trackAppResume()` is done, and since
>>> `trackAppResume()` needs to grab the handlerLock, and you need to grab the
>>>
> This change fixes deadlocks described in the JBS-bug by:
>
> * Releasing `handlerLock` before waiting on `threadLock` in
> `blockOnDebuggerSuspend()`
>
> * Notifying on `threadLock` in `threadControl_reset()`
>
> Also the actions in handleAppResumeBreakpoint() are moved/deferred until
> doPen
17 matches
Mail list logo
