On Mon, 1 Nov 2021 20:51:39 GMT, Evgeny Astigeevich
wrote:
> This PR changes nmethods names in `METHOD NAMES for CodeHeap` section to be
> qualified.
> Testing:
> - `make test TEST="gtest"`: Passed
> - `make run-test TEST="tier1"`: Passed
> - `make run-test TEST="tier2"`: Passed
> - `make run
By the way, Erik mentioned that the DCmd command in JFR is unlikely to use this
extension.
But there are some other VM commands I think can be easily replaced with this
extension,
such as RunFinalizationDCmd, FinalizerInfoDCmd, PrintSystemPropertiesDCmd,
JMX-related DCmds, etc.
Denghui
Hi Chris,
Thank you for the comments.
Yes, we have no good way to restrict the user registration commands to only
include diagnosis-related operations, but in my opinion, this does not seem to
be a problem that must be solved perfectly.
The following are my thoughts.
This extension is an entr
On Tue, 2 Nov 2021 01:07:30 GMT, Jakob Cornell wrote:
>> This will fix a few issues with the tests added in #5290:
>>
>> - [x] intermittent failures
>> - [x] tests should use `failure` method to report problems rather than
>> throwing `AssertionError`
>
> Jakob Cornell has updated the pull requ
On Tue, 2 Nov 2021 01:13:40 GMT, David Holmes wrote:
> That certainly does make sense, although it makes me wonder how this ever
> passed in the first place. Maybe there's a bug somewhere in the JDB output
> processing code that made the failure intermittent.
It depends a bit on how the underl
On Tue, 2 Nov 2021 01:07:30 GMT, Jakob Cornell wrote:
>> This will fix a few issues with the tests added in #5290:
>>
>> - [x] intermittent failures
>> - [x] tests should use `failure` method to report problems rather than
>> throwing `AssertionError`
>
> Jakob Cornell has updated the pull requ
On 2/11/2021 11:07 am, Jakob Cornell wrote:
On Mon, 1 Nov 2021 04:39:27 GMT, Jakob Cornell wrote:
This will fix a few issues with the tests added in #5290:
- [x] intermittent failures
- [x] tests should use `failure` method to report problems rather than throwing
`AssertionError`
That cert
> This will fix a few issues with the tests added in #5290:
>
> - [x] intermittent failures
> - [x] tests should use `failure` method to report problems rather than
> throwing `AssertionError`
Jakob Cornell has updated the pull request incrementally with one additional
commit since the last rev
On Mon, 1 Nov 2021 04:39:27 GMT, Jakob Cornell wrote:
> This will fix a few issues with the tests added in #5290:
>
> - [x] intermittent failures
> - [x] tests should use `failure` method to report problems rather than
> throwing `AssertionError`
That certainly does make sense, although it mak
On 2/11/2021 7:55 am, David Holmes wrote:
On 1/11/2021 5:19 pm, Yi Yang wrote:
On Wed, 27 Oct 2021 01:30:37 GMT, Yi Yang wrote:
Some customers want to observe which loaded classes have overridden
the finalize() method. I found that VM.metaspace can output detailed
classes. It seems feasible
On 1/11/2021 5:19 pm, Yi Yang wrote:
On Wed, 27 Oct 2021 01:30:37 GMT, Yi Yang wrote:
Some customers want to observe which loaded classes have overridden the
finalize() method. I found that VM.metaspace can output detailed classes. It
seems feasible to add 'f' flag to it. With this patch, I
This PR changes nmethods names in `METHOD NAMES for CodeHeap` section to be
qualified.
Testing:
- `make test TEST="gtest"`: Passed
- `make run-test TEST="tier1"`: Passed
- `make run-test TEST="tier2"`: Passed
- `make run-test TEST=`:
serviceability/dcmd/compiler/CodeHeapAnalyticsMethodNames.jav
On Mon, 1 Nov 2021 04:39:27 GMT, Jakob Cornell wrote:
> This will fix a few issues with the tests added in #5290:
>
> - [ ] intermittent failures
> - [x] tests should use `failure` method to report problems rather than
> throwing `AssertionError`
I'm pretty sure the problem is with how you are
On Mon, 1 Nov 2021 04:39:27 GMT, Jakob Cornell wrote:
> This will fix a few issues with the tests added in #5290:
>
> - [ ] intermittent failures
> - [x] tests should use `failure` method to report problems rather than
> throwing `AssertionError`
I did 20 runs each on linux, mac, and windows.
I have similar concerns to those others
have expressed, so I'll try to add something new to the discussion
and not just repeat.
DCMDs have historically been very VM centric. That's not to say
they aren't useful for debugging applications, but they do so
On Thu, 7 Oct 2021 21:46:47 GMT, Alex Menkov wrote:
> The fix adds "-XX:PerfMaxStringConstLength" argument running target app
> (default is 1024, 8K should be enough for any environments)
Marked as reviewed by lmesnik (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5858
On Thu, 7 Oct 2021 21:46:47 GMT, Alex Menkov wrote:
> The fix adds "-XX:PerfMaxStringConstLength" argument running target app
> (default is 1024, 8K should be enough for any environments)
Ok. You can proceed with your current fix if you'd like.
-
PR: https://git.openjdk.java.net/j
On Mon, 1 Nov 2021 04:39:27 GMT, Jakob Cornell wrote:
> This will fix a few issues with the tests added in #5290:
>
> - [ ] intermittent failures
> - [x] tests should use `failure` method to report problems rather than
> throwing `AssertionError`
Dan did reproduce the "Unexpected Output" failu
On Mon, 1 Nov 2021 04:39:27 GMT, Jakob Cornell wrote:
> This will fix a few issues with the tests added in #5290:
>
> - [ ] intermittent failures
> - [x] tests should use `failure` method to report problems rather than
> throwing `AssertionError`
This isn't ready for review; I'm just marking i
This will fix a few issues with the tests added in #5290:
- [ ] intermittent failures
- [x] tests should use `failure` method to report problems rather than throwing
`AssertionError`
-
Commit messages:
- Use `failure' method instead of `AssertionError' in new tests
Changes: https:
On Mon, 1 Nov 2021 04:39:27 GMT, Jakob Cornell wrote:
> This will fix a few issues with the tests added in #5290:
>
> - [ ] intermittent failures
> - [x] tests should use `failure` method to report problems rather than
> throwing `AssertionError`
I'm not sure whether this is expected to be a p
On Mon, 25 Oct 2021 22:21:54 GMT, Jakob Cornell wrote:
>> This has been under discussion on and off for the past month or so on
>> serviceability-dev, and I think a CSR request is required, so this may be a
>> work in progress.
>>
>> Notes on the patch:
>>
>> - The `list` command previously m
On Mon, 1 Nov 2021 04:49:31 GMT, Jakob Cornell wrote:
> The JDK build issue is resolved (thanks David Holmes). The switch to
> `failure` is now implemented in #6182, and I think we can move the discussion
> there.
#6182 is still a draft. Was that intentional? No emails will go out while it is
On Mon, 1 Nov 2021 01:55:48 GMT, David Holmes wrote:
>> U... The purpose of the new `is_exiting()` check and the baseline's
>> `ThreadsListHandle::includes()` check is to avoid making this call:
>>
>> return this->handshake_state()->suspend();
>>
>> The call we are avoiding is the one tha
On Sat, 16 Oct 2021 15:58:21 GMT, Daniel D. Daugherty
wrote:
>> The `NULL` target thread being passed in is actually handled by the baseline
>> code:
>>
>>
>> ThreadsListHandle tlh;
>> if (tlh.includes(target)) {
>>
>>
>> `tlh.includes(target)` returns `false` when `target` is `NULL/nul
On Fri, 29 Oct 2021 22:16:17 GMT, Daniel D. Daugherty
wrote:
>> While the name is somewhat ungainly - and unnecessarily detailed given
>> `is_JavaThread_protected` has a similar constraint - it should be a static
>> function as given because it must only be called on the current thread, and
>
> A fix to reduce ThreadsListHandle overhead in relation to handshakes and
> we add sanity checks for ThreadsListHandles higher in the call stack.
>
> This fix was tested with Mach5 Tier[1-8]; Tier8 is still running.
Daniel D. Daugherty has updated the pull request with a new target base due to
macOS12 has changed the dladdr() function to accept "-1" as a valid address and
we have functions that use dladdr() to convert DLL addresses into function or
library names. We also have a gtest that verifies that "-1" is not a valid
value to use
as a symbol address.
As you might imagine, existing
28 matches
Mail list logo
