Re: RFR: 8266593: vmTestbase/nsk/jvmti/PopFrame/popframe011 fails with "assert(java_thread == _state->get_thread()) failed: Must be" [v2]

2021-11-17 Thread David Holmes
On Thu, 18 Nov 2021 07:08:15 GMT, Serguei Spitsyn wrote: >> The test fails when the target JavaThread has is_exiting() status. In such a >> case the JvmtiExport::cleanup_thread(this) has already made a clean up of >> its jvmtiThreadState, so the JavaThread address returned by >>

Re: RFR: 8266593: vmTestbase/nsk/jvmti/PopFrame/popframe011 fails with "assert(java_thread == _state->get_thread()) failed: Must be" [v2]

2021-11-17 Thread Serguei Spitsyn
> The test fails when the target JavaThread has is_exiting() status. In such a > case the JvmtiExport::cleanup_thread(this) has already made a clean up of its > jvmtiThreadState, so the JavaThread address returned by _state->get_thread() > is 0xbabababababababa. > The fix is to add a check for

Re: RFR: 8266593: vmTestbase/nsk/jvmti/PopFrame/popframe011 fails with "assert(java_thread == _state->get_thread()) failed: Must be"

2021-11-17 Thread Serguei Spitsyn
On Wed, 17 Nov 2021 22:21:33 GMT, Serguei Spitsyn wrote: > The test fails when the target JavaThread has is_exiting() status. In such a > case the JvmtiExport::cleanup_thread(this) has already made a clean up of its > jvmtiThreadState, so the JavaThread address returned by _state->get_thread()

Re: RFR: 8266593: vmTestbase/nsk/jvmti/PopFrame/popframe011 fails with "assert(java_thread == _state->get_thread()) failed: Must be"

2021-11-17 Thread Serguei Spitsyn
On Wed, 17 Nov 2021 22:21:33 GMT, Serguei Spitsyn wrote: > The test fails when the target JavaThread has is_exiting() status. In such a > case the JvmtiExport::cleanup_thread(this) has already made a clean up of its > jvmtiThreadState, so the JavaThread address returned by _state->get_thread()

Re: RFR: 8266593: vmTestbase/nsk/jvmti/PopFrame/popframe011 fails with "assert(java_thread == _state->get_thread()) failed: Must be"

2021-11-17 Thread David Holmes
On Wed, 17 Nov 2021 22:21:33 GMT, Serguei Spitsyn wrote: > The test fails when the target JavaThread has is_exiting() status. In such a > case the JvmtiExport::cleanup_thread(this) has already made a clean up of its > jvmtiThreadState, so the JavaThread address returned by _state->get_thread()

Re: RFR: 8265796: vmTestbase/nsk/jdi/ObjectReference/referringObjects/referringObjects002/referringObjects002.java fails when running with the fix for JDK-6824466 [v3]

2021-11-17 Thread Leonid Mesnik
On Thu, 18 Nov 2021 04:03:06 GMT, Leonid Mesnik wrote: >> The nsk.share.jdi.TestClass1 is used via reflection. The reflective call >> creates MethodHandle and one more reference to TestClass1. So the number of >> expected references should be incremented. Thanks to @plummercj and >>

Re: RFR: 8265796: vmTestbase/nsk/jdi/ObjectReference/referringObjects/referringObjects002/referringObjects002.java fails when running with the fix for JDK-6824466 [v3]

2021-11-17 Thread Leonid Mesnik
> The nsk.share.jdi.TestClass1 is used via reflection. The reflective call > creates MethodHandle and one more reference to TestClass1. So the number of > expected references should be incremented. Thanks to @plummercj and @mlchung > for the investigation. > This fix also prints references to

Re: RFR: 8265796: vmTestbase/nsk/jdi/ObjectReference/referringObjects/referringObjects002/referringObjects002.java fails when running with the fix for JDK-6824466 [v2]

2021-11-17 Thread Mandy Chung
On Tue, 16 Nov 2021 02:45:13 GMT, Leonid Mesnik wrote: >> The nsk.share.jdi.TestClass1 is used via reflection. The reflective call >> creates MethodHandle and one more reference to TestClass1. So the number of >> expected references should be incremented. Thanks to @plummercj and >>

Re: RFR: 8265796: vmTestbase/nsk/jdi/ObjectReference/referringObjects/referringObjects002/referringObjects002.java fails when running with the fix for JDK-6824466 [v2]

2021-11-17 Thread Leonid Mesnik
On Tue, 16 Nov 2021 02:45:13 GMT, Leonid Mesnik wrote: >> The nsk.share.jdi.TestClass1 is used via reflection. The reflective call >> creates MethodHandle and one more reference to TestClass1. So the number of >> expected references should be incremented. Thanks to @plummercj and >>

Re: RFR: 8266593: vmTestbase/nsk/jvmti/PopFrame/popframe011 fails with "assert(java_thread == _state->get_thread()) failed: Must be"

2021-11-17 Thread Leonid Mesnik
On Wed, 17 Nov 2021 22:21:33 GMT, Serguei Spitsyn wrote: > The test fails when the target JavaThread has is_exiting() status. In such a > case the JvmtiExport::cleanup_thread(this) has already made a clean up of its > jvmtiThreadState, so the JavaThread address returned by _state->get_thread()

Re: RFR: 8266593: vmTestbase/nsk/jvmti/PopFrame/popframe011 fails with "assert(java_thread == _state->get_thread()) failed: Must be"

2021-11-17 Thread Martin Doerr
On Wed, 17 Nov 2021 22:21:33 GMT, Serguei Spitsyn wrote: > The test fails when the target JavaThread has is_exiting() status. In such a > case the JvmtiExport::cleanup_thread(this) has already made a clean up of its > jvmtiThreadState, so the JavaThread address returned by _state->get_thread()

RFR: 8266593: vmTestbase/nsk/jvmti/PopFrame/popframe011 fails with "assert(java_thread == _state->get_thread()) failed: Must be"

2021-11-17 Thread Serguei Spitsyn
The test fails when the target JavaThread has is_exiting() status. In such a case the JvmtiExport::cleanup_thread(this) has already made a clean up of its jvmtiThreadState, so the JavaThread address returned by _state->get_thread() is 0xbabababababababa. The fix is to add a check for

Integrated: 8277346: ProblemList 7 serviceability/sa tests on macosx-x64

2021-11-17 Thread Daniel D . Daugherty
On Wed, 17 Nov 2021 20:43:46 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList 7 serviceability/sa tests on macosx-x64. This pull request has now been integrated. Changeset: ce4471f8 Author:Daniel D. Daugherty URL:

Re: RFR: 8277346: ProblemList 7 serviceability/sa tests on macosx-x64

2021-11-17 Thread Daniel D . Daugherty
On Wed, 17 Nov 2021 21:16:18 GMT, Thomas Schatzl wrote: >> A trivial fix to ProblemList 7 serviceability/sa tests on macosx-x64. > > Lgtm and trivial @tschatzl and @bplb - Thanks for the fast review! - PR: https://git.openjdk.java.net/jdk/pull/6438

Re: RFR: 8277346: ProblemList 7 serviceability/sa tests on macosx-x64

2021-11-17 Thread Thomas Schatzl
On Wed, 17 Nov 2021 20:43:46 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList 7 serviceability/sa tests on macosx-x64. Lgtm and trivial - Marked as reviewed by tschatzl (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/6438

Re: RFR: 8277346: ProblemList 7 serviceability/sa tests on macosx-x64

2021-11-17 Thread Brian Burkhalter
On Wed, 17 Nov 2021 20:43:46 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList 7 serviceability/sa tests on macosx-x64. Marked as reviewed by bpb (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6438

RFR: 8277346: ProblemList 7 serviceability/sa tests on macosx-x64

2021-11-17 Thread Daniel D . Daugherty
A trivial fix to ProblemList 7 serviceability/sa tests on macosx-x64. - Commit messages: - 8277351: ProblemList runtime/jni/checked/TestPrimitiveArrayCriticalWithBadParam.java on macosx-x64 - 8277346: ProblemList 7 serviceability/sa tests on macosx-x64 Changes:

Re: RFR: 8265796: vmTestbase/nsk/jdi/ObjectReference/referringObjects/referringObjects002/referringObjects002.java fails when running with the fix for JDK-6824466 [v2]

2021-11-17 Thread Mandy Chung
On Tue, 16 Nov 2021 02:45:13 GMT, Leonid Mesnik wrote: >> The nsk.share.jdi.TestClass1 is used via reflection. The reflective call >> creates MethodHandle and one more reference to TestClass1. So the number of >> expected references should be incremented. Thanks to @plummercj and >>

Re: RFR: 8274903: Zero: Support AsyncGetCallTrace [v3]

2021-11-17 Thread Aleksey Shipilev
On Wed, 10 Nov 2021 18:03:00 GMT, Serguei Spitsyn wrote: >> Aleksey Shipilev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> More reviews > > Marked as reviewed by sspitsyn (Reviewer). > Thank you, @sspitsyn! Any more reviews, anyone?

Withdrawn: 8206438: com/sun/jdi/FieldWatchpoints.java timeout intermittently

2021-11-17 Thread duke
On Tue, 21 Sep 2021 07:40:01 GMT, Fairoz Matte wrote: > 8206438: com/sun/jdi/FieldWatchpoints.java timeout intermittently This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jdk/pull/5598

Integrated: 8276139: TestJpsHostName.java not reliable, better to expand HostIdentifierCreate.java test

2021-11-17 Thread Kevin Walls
On Fri, 29 Oct 2021 11:29:32 GMT, Kevin Walls wrote: > Remove a specific test which invokes jps on a fictional process, and can > timeout and fail. > Instead, add to the patterns used in > open/test/jdk/sun/jvmstat/monitor/HostIdentifier/HostIdentifierCreate.java > which will perform the same

Re: RFR: 8276139: TestJpsHostName.java not reliable, better to expand HostIdentifierCreate.java test

2021-11-17 Thread Kevin Walls
On Fri, 29 Oct 2021 11:29:32 GMT, Kevin Walls wrote: > Remove a specific test which invokes jps on a fictional process, and can > timeout and fail. > Instead, add to the patterns used in > open/test/jdk/sun/jvmstat/monitor/HostIdentifier/HostIdentifierCreate.java > which will perform the same

Re: RFR: 8276139: TestJpsHostName.java not reliable, better to expand HostIdentifierCreate.java test

2021-11-17 Thread Serguei Spitsyn
On Fri, 29 Oct 2021 11:29:32 GMT, Kevin Walls wrote: > Remove a specific test which invokes jps on a fictional process, and can > timeout and fail. > Instead, add to the patterns used in > open/test/jdk/sun/jvmstat/monitor/HostIdentifier/HostIdentifierCreate.java > which will perform the same