Re: RFR: 8279124: VM does not handle SIGQUIT during initialization [v6]

2022-01-20 Thread Xin Liu
> In early stage of initialization, HotSpot doesn't handle SIGQUIT. The default > signal preposition on Linux is to quit the process and generate coredump. > > There are 2 applications for this signal. > 1. There's a handshake protocol between sun.tools.attach and HotSpot. > VirtualMachineImpl

Re: RFR: 8272317: jstatd has dependency on Security Manager which needs to be removed [v2]

2022-01-20 Thread Kevin Walls
On Thu, 20 Jan 2022 16:54:21 GMT, Mandy Chung wrote: > If `sun.jvmstat.monitor.remote.RemoteVm` is the only proxy interface, > `com.sun.proxy.jdk.proxy*` should adequately cover the proxy classes created > for `RemoteVm`. Thanks. With that endorsement I think there are no unresolved issues

Re: Integrated: 8280413: ProblemList jdk/jfr/event/oldobject/TestLargeRootSet.java on all X64 platforms

2022-01-20 Thread Daniel D . Daugherty
On Thu, 20 Jan 2022 20:22:42 GMT, Alexander Zvegintsev wrote: >> A trivial fix to ProblemList jdk/jfr/event/oldobject/TestLargeRootSet.java >> on all X64 platforms. > > Marked as reviewed by azvegint (Reviewer). @azvegint - Thanks for the fast review! - PR:

Integrated: 8280413: ProblemList jdk/jfr/event/oldobject/TestLargeRootSet.java on all X64 platforms

2022-01-20 Thread Daniel D . Daugherty
On Thu, 20 Jan 2022 20:21:17 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList jdk/jfr/event/oldobject/TestLargeRootSet.java on > all X64 platforms. This pull request has now been integrated. Changeset: 293fb46f Author:Daniel D. Daugherty URL:

Re: Integrated: 8280413: ProblemList jdk/jfr/event/oldobject/TestLargeRootSet.java on all X64 platforms

2022-01-20 Thread Alexander Zvegintsev
On Thu, 20 Jan 2022 20:21:17 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList jdk/jfr/event/oldobject/TestLargeRootSet.java on > all X64 platforms. Marked as reviewed by azvegint (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7168

Integrated: 8280413: ProblemList jdk/jfr/event/oldobject/TestLargeRootSet.java on all X64 platforms

2022-01-20 Thread Daniel D . Daugherty
A trivial fix to ProblemList jdk/jfr/event/oldobject/TestLargeRootSet.java on all X64 platforms. - Commit messages: - 8280413: ProblemList jdk/jfr/event/oldobject/TestLargeRootSet.java on all X64 platforms Changes: https://git.openjdk.java.net/jdk/pull/7168/files Webrev:

Re: RFR: 8279124: VM does not handle SIGQUIT during initialization [v5]

2022-01-20 Thread Xin Liu
On Thu, 20 Jan 2022 07:00:23 GMT, David Holmes wrote: >> Xin Liu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove log_info from the signal handler. > > src/hotspot/os/posix/signals_posix.cpp line 600: > >> 598:

Re: RFR: 8280166: Extend java/lang/instrument/GetObjectSizeIntrinsicsTest.java test cases

2022-01-20 Thread Serguei Spitsyn
On Tue, 18 Jan 2022 18:33:29 GMT, Aleksey Shipilev wrote: > While working on JDK-8280003, I noticed that > java/lang/instrument/GetObjectSizeIntrinsicsTest.java does not test arrays > with more than 1-byte size elements, and no large arrays (past 4G limit) are > tested either. It would be

Re: RFR: 8272317: jstatd has dependency on Security Manager which needs to be removed [v2]

2022-01-20 Thread Mandy Chung
On Mon, 10 Jan 2022 11:17:12 GMT, Kevin Walls wrote: >> Remove the use of Security Manager from jstatd. >> Add use of an ObjectInputFilter to restrict RMI. >> >> Also we can undo the property-setting Launcher.gmk change from: 8279007: >> jstatd fails to start because SecurityManager is

Re: RFR: 8269542: JDWP: EnableCollection support is no longer spec compliant after JDK-8255987 [v3]

2022-01-20 Thread Chris Plummer
On Thu, 20 Jan 2022 05:44:32 GMT, Chris Plummer wrote: >> Fixes for NULL case look good. >> >> Thanks, >> David > >> Fixes for NULL case look good. >> >> Thanks, David > > Thanks for the review and noticing these issues. > @plummercj I haven't reviewed, this but the Eclipse-based reproducer

Re: RFR: 8269542: JDWP: EnableCollection support is no longer spec compliant after JDK-8255987 [v3]

2022-01-20 Thread Severin Gehwolf
On Thu, 20 Jan 2022 04:22:28 GMT, Chris Plummer wrote: >> The JDWP spec mentions nothing about `DisableCollection` and >> `EnableCollection` tracking the depth or nesting of the commands. This means >> that `EnableCollection` should enable collection no matter how many >> `DisableCollection`

Re: RFR: 8275775: Add jcmd VM.classes to print details of all classes [v5]

2022-01-20 Thread Yi Yang
> Add VM.classes to print details of all classes, output looks like: > > 1. jcmd VM.classes > > KlassAddr Size State Flags LoaderName ClassName > 0x000800c0b400 62 inited W bootstrap > java.lang.invoke.LambdaForm$MH/0x000800c0b400 > 0x000800c0b000 62 inited W bootstrap >

Re: RFR: 8272317: jstatd has dependency on Security Manager which needs to be removed [v2]

2022-01-20 Thread Kevin Walls
On Wed, 19 Jan 2022 19:56:53 GMT, Mandy Chung wrote: > Are all the proxy interfaces public? sun.jvmstat.monitor.remote.RemoteVm is "public interface RemoteVm extends Remote" and methods in there only return basic types. This is in the jdk.jstatd module, where I see the module info contains