Re: RFR: 8280554: resourcehogs/serviceability/sa/ClhsdbRegionDetailsScanOopsForG1.java can fail if GC is triggered [v2]

2022-01-27 Thread Alan Bateman
On Fri, 28 Jan 2022 07:46:01 GMT, Chris Plummer wrote: >> When using -Xcomp, the liveness of some objects the test allocates is more >> precisely known, allowing the objects to be collected before the test >> expects. This became an issue in the loom repo because it has changes that >> result

Re: RFR: 8280554: resourcehogs/serviceability/sa/ClhsdbRegionDetailsScanOopsForG1.java can fail if GC is triggered [v2]

2022-01-27 Thread Chris Plummer
> When using -Xcomp, the liveness of some objects the test allocates is more > precisely known, allowing the objects to be collected before the test > expects. This became an issue in the loom repo because it has changes that > result in a full GC when the codecache is swept. This is fixed by

Re: RFR: 8280553: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java can fail if GC occurs [v2]

2022-01-27 Thread Chris Plummer
On Fri, 28 Jan 2022 06:08:55 GMT, Alan Bateman wrote: >> Chris Plummer has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Use Reference.reachabilityFence() instead of static field. > >

Re: RFR: 8280553: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java can fail if GC occurs [v2]

2022-01-27 Thread Alan Bateman
On Fri, 28 Jan 2022 07:43:45 GMT, Chris Plummer wrote: >> This test is failing in the loom repo when using -Xcomp. The reason is >> because loom introduced doing a full GC in the codecache sweeper, which >> causes the large array that the test allocates to be GC'd before the heap >> dump is

Re: RFR: 8280553: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java can fail if GC occurs [v2]

2022-01-27 Thread Chris Plummer
> This test is failing in the loom repo when using -Xcomp. The reason is > because loom introduced doing a full GC in the codecache sweeper, which > causes the large array that the test allocates to be GC'd before the heap > dump is done. The fix is to make the large array static rather than a

RFR: 8280770: serviceability/sa/ClhsdbThreadContext.java sometimes fails with 'Thread "SteadyStateThread"' missing from stdout/stderr

2022-01-27 Thread Chris Plummer
The test does a "threadcontext -v -a", and from the following output determines the threadID of the SteadyStateThread: `Thread "SteadyStateThread" id=23 Address=0x01dc51749420` It then tries threadcontext on this id, but it fails: + threadcontext -v 23 Couldn't find thread 23 This

Re: RFR: 8280553: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java can fail if GC occurs

2022-01-27 Thread Alan Bateman
On Wed, 26 Jan 2022 20:03:21 GMT, Chris Plummer wrote: > This test is failing in the loom repo when using -Xcomp. The reason is > because loom introduced doing a full GC in the codecache sweeper, which > causes the large array that the test allocates to be GC'd before the heap > dump is done.

RFR: 8280554: resourcehogs/serviceability/sa/ClhsdbRegionDetailsScanOopsForG1.java can fail if GC is triggered

2022-01-27 Thread Chris Plummer
When using -Xcomp, the liveness of some objects the test allocates is more precisely known, allowing the objects to be collected before the test expects. This became an issue in the loom repo because it has changes that result in a full GC when the codecache is swept. This is fixed by using

RFR: 8280553: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java can fail if GC occurs

2022-01-27 Thread Chris Plummer
This test is failing in the loom repo when using -Xcomp. The reason is because loom introduced doing a full GC in the codecache sweeper, which causes the large array that the test allocates to be GC'd before the heap dump is done. The fix is to make the large array static rather than a local

Re: RFR: 8280601: ClhsdbThreadContext.java test is triggering codecache related assert in PointerFinder.find()

2022-01-27 Thread Chris Plummer
On Tue, 25 Jan 2022 22:07:37 GMT, Chris Plummer wrote: > It's possible for an address to be in the codecache but not in any CodeBlob. > Don't assert in this case. > > Also I ran into a couple of other asserts listed below. It looks like since > dumping the threadcontext can result in using

Re: RFR: 8280601: ClhsdbThreadContext.java test is triggering codecache related assert in PointerFinder.find() [v2]

2022-01-27 Thread Chris Plummer
On Wed, 26 Jan 2022 14:27:54 GMT, Kevin Walls wrote: >> Chris Plummer has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Guard against invalid CodeBlobs that may throw exceptions. > >

Re: RFR: 8280601: ClhsdbThreadContext.java test is triggering codecache related assert in PointerFinder.find() [v2]

2022-01-27 Thread Chris Plummer
> It's possible for an address to be in the codecache but not in any CodeBlob. > Don't assert in this case. > > Also I ran into a couple of other asserts listed below. It looks like since > dumping the threadcontext can result in using PointerFinder with fairly > random addresses, it is doing

RFR: 8280543: Update the "java" and "jcmd" tool specification for CDS

2022-01-27 Thread Ioi Lam
The discussion of CDS in the man pages need to be cleaned up and updated to match the latest functionalities and intended usage. For java.md: - Reorganized the flow of the doc: Overview -> How to use -> How to create -> Restrictions and notes. I think this will be easier to read. - Added

Re: RFR: 8272317: jstatd has dependency on Security Manager which needs to be removed [v2]

2022-01-27 Thread Kevin Walls
On Thu, 27 Jan 2022 17:44:39 GMT, Roger Riggs wrote: >> Kevin Walls has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Wildcard in object filter to permit proxies, in case other activity in >> this JVM changes the nameing/numbering of

Re: RFR: 8272317: jstatd has dependency on Security Manager which needs to be removed [v2]

2022-01-27 Thread Kevin Walls
On Mon, 10 Jan 2022 11:17:12 GMT, Kevin Walls wrote: >> Remove the use of Security Manager from jstatd. >> Add use of an ObjectInputFilter to restrict RMI. >> >> Also we can undo the property-setting Launcher.gmk change from: 8279007: >> jstatd fails to start because SecurityManager is

Re: RFR: 8272317: jstatd has dependency on Security Manager which needs to be removed [v3]

2022-01-27 Thread Kevin Walls
> Remove the use of Security Manager from jstatd. > Add use of an ObjectInputFilter to restrict RMI. > > Also we can undo the property-setting Launcher.gmk change from: 8279007: > jstatd fails to start because SecurityManager is disabled > ..as that is no longer needed. > > Docs/man page update

Re: RFR: 8272317: jstatd has dependency on Security Manager which needs to be removed [v2]

2022-01-27 Thread Roger Riggs
On Mon, 10 Jan 2022 11:17:12 GMT, Kevin Walls wrote: >> Remove the use of Security Manager from jstatd. >> Add use of an ObjectInputFilter to restrict RMI. >> >> Also we can undo the property-setting Launcher.gmk change from: 8279007: >> jstatd fails to start because SecurityManager is

Re: RFR: 8272317: jstatd has dependency on Security Manager which needs to be removed [v2]

2022-01-27 Thread Chris Plummer
On Mon, 10 Jan 2022 11:17:12 GMT, Kevin Walls wrote: >> Remove the use of Security Manager from jstatd. >> Add use of an ObjectInputFilter to restrict RMI. >> >> Also we can undo the property-setting Launcher.gmk change from: 8279007: >> jstatd fails to start because SecurityManager is

Re: RFR: 8240908: RetransformClass does not know about MethodParameters attribute [v4]

2022-01-27 Thread Chris Plummer
On Thu, 27 Jan 2022 11:32:18 GMT, Alex Menkov wrote: >> Changes: >> - ClassFileReconstituter is updated to restore "MethodParameters" attribute; >> - handling of the attribute in VM_RedefineClasses is moved to be consistent >> with other code (like local variable table); >> - copied

Re: RFR: 8275775: Add jcmd VM.classes to print details of all classes [v6]

2022-01-27 Thread Ioi Lam
On Thu, 27 Jan 2022 09:17:09 GMT, Yi Yang wrote: >> Add VM.classes to print details of all classes, output looks like: >> >> 1. jcmd VM.classes >> >> KlassAddr Size State Flags LoaderName ClassName >> 0x000800c0b400 62 inited W bootstrap >>

Re: RFR: 8240908: RetransformClass does not know about MethodParameters attribute [v3]

2022-01-27 Thread Alex Menkov
On Thu, 27 Jan 2022 04:23:51 GMT, Chris Plummer wrote: >> Alex Menkov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Simplified the test, added comments > > src/hotspot/share/prims/jvmtiRedefineClasses.cpp line 3692: > >> 3690:

Re: RFR: 8240908: RetransformClass does not know about MethodParameters attribute [v4]

2022-01-27 Thread Alex Menkov
> Changes: > - ClassFileReconstituter is updated to restore "MethodParameters" attribute; > - handling of the attribute in VM_RedefineClasses is moved to be consistent > with other code (like local variable table); > - copied ClassTransformer class (from test/jdk/com/sun/jdi/lib/jdb) to >

Re: RFR: 8275775: Add jcmd VM.classes to print details of all classes [v5]

2022-01-27 Thread Yi Yang
On Mon, 24 Jan 2022 04:12:22 GMT, Ioi Lam wrote: >> Yi Yang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix test > > src/hotspot/share/oops/instanceKlass.cpp line 2106: > >> 2104: // classloader name >> 2105: ClassLoaderData*

Re: RFR: 8275775: Add jcmd VM.classes to print details of all classes [v6]

2022-01-27 Thread Yi Yang
> Add VM.classes to print details of all classes, output looks like: > > 1. jcmd VM.classes > > KlassAddr Size State Flags LoaderName ClassName > 0x000800c0b400 62 inited W bootstrap > java.lang.invoke.LambdaForm$MH/0x000800c0b400 > 0x000800c0b000 62 inited W bootstrap >