Re: RFR: 8281615: Deadlock caused by jdwp agent

2022-02-14 Thread Chris Plummer
On Mon, 14 Feb 2022 23:11:34 GMT, David Holmes wrote: >> There are scenarios that JDWP agent can deadlock on `classTrackLock` >> monitor. Following is the scenario in bug report. >> >> **Java Thread** >> - loads a class and post `JVMTI_EVENT_CLASS_PREPARE` event >> - JDWP event callback hand

Re: RFR: 8281615: Deadlock caused by jdwp agent

2022-02-14 Thread Chris Plummer
On Mon, 14 Feb 2022 14:27:45 GMT, Zhengyu Gu wrote: > There are scenarios that JDWP agent can deadlock on `classTrackLock` monitor. > Following is the scenario in bug report. > > **Java Thread** > - loads a class and post `JVMTI_EVENT_CLASS_PREPARE` event > - JDWP event callback handler call

Re: RFR: 8281615: Deadlock caused by jdwp agent

2022-02-14 Thread Chris Plummer
On Mon, 14 Feb 2022 14:27:45 GMT, Zhengyu Gu wrote: > There are scenarios that JDWP agent can deadlock on `classTrackLock` monitor. > Following is the scenario in bug report. > > **Java Thread** > - loads a class and post `JVMTI_EVENT_CLASS_PREPARE` event > - JDWP event callback handler call

Re: RFR: 8281267: VM HeapDumper dumps array classes several times [v3]

2022-02-14 Thread Chris Plummer
On Mon, 14 Feb 2022 13:05:52 GMT, Alex Menkov wrote: >> ClassLoaderDataGraph::classes_do description says: >> // Walking classes through the ClassLoaderDataGraph include array classes. >> So do_load_class callback should not dump arrays for the classes and dumper >> doesn't need to call Universe

Re: RFR: 8281615: Deadlock caused by jdwp agent

2022-02-14 Thread David Holmes
On Mon, 14 Feb 2022 14:27:45 GMT, Zhengyu Gu wrote: > There are scenarios that JDWP agent can deadlock on `classTrackLock` monitor. > Following is the scenario in bug report. > > **Java Thread** > - loads a class and post `JVMTI_EVENT_CLASS_PREPARE` event > - JDWP event callback handler call

RFR: 8281615: Deadlock caused by jdwp agent

2022-02-14 Thread Zhengyu Gu
There are scenarios that JDWP agent can deadlock on `classTrackLock` monitor. Following is the scenario in bug report. **Java Thread** - loads a class and post `JVMTI_EVENT_CLASS_PREPARE` event - JDWP event callback handler calls `classTrack_processUnloads()` to handle the event. - `classTrac

Re: RFR: 8281267: VM HeapDumper dumps array classes several times [v3]

2022-02-14 Thread Alex Menkov
On Mon, 14 Feb 2022 09:18:34 GMT, Alex Menkov wrote: >> Sorry about the delay. I didn't see your response when it came in. >> >> It seems like this comment belongs with do_class_dump(). Putting it here is >> kind of confusing. Also, what is meant by "bottom class"? Do you mean the >> element t

Re: RFR: 8281267: VM HeapDumper dumps array classes several times [v3]

2022-02-14 Thread Alex Menkov
> ClassLoaderDataGraph::classes_do description says: > // Walking classes through the ClassLoaderDataGraph include array classes. > So do_load_class callback should not dump arrays for the classes and dumper > doesn't need to call Universe::basic_type_classes_do (array classes for > primitive typ

Integrated: 8281585: Remove unused imports under test/lib and jtreg/gc

2022-02-14 Thread Leo Korinth
On Thu, 10 Feb 2022 15:39:53 GMT, Leo Korinth wrote: > Remove unused imports under test/lib and jtreg/gc. They create lots of > warnings if editing using an IDE. Tests in hotspot_gc passed. This pull request has now been integrated. Changeset: 2604a88f Author:Leo Korinth URL: https

Re: RFR: 8281585: Remove unused imports under test/lib and jtreg/gc [v2]

2022-02-14 Thread Leo Korinth
On Fri, 11 Feb 2022 08:54:51 GMT, Leo Korinth wrote: >> Remove unused imports under test/lib and jtreg/gc. They create lots of >> warnings if editing using an IDE. Tests in hotspot_gc passed. > > Leo Korinth has updated the pull request incrementally with one additional > commit since the last

Re: RFR: 8281267: VM HeapDumper dumps array classes several times [v2]

2022-02-14 Thread Alex Menkov
On Mon, 14 Feb 2022 05:02:34 GMT, Chris Plummer wrote: >> HPROF_GC_CLASS_DUMP records contain references to signers and protection >> domain objects. >> But this is properties of InstanceKlass, for array classes the properties >> from their element classes are written (or NULL for arrays of pri