Re: RFR: 8283147: Include NonJavaThread stacktrace during thread dump [v3]

2022-03-16 Thread David Holmes
On Wed, 16 Mar 2022 07:48:42 GMT, Yi Yang wrote: >> Yi Yang has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. The pull request contains one >> new commit since t

Re: RFR: 8280400: JDK 19 L10n resource files update - msgdrop 10 [v4]

2022-03-16 Thread Naoto Sato
On Wed, 16 Mar 2022 18:31:55 GMT, Alisen Chung wrote: >> msg drop for jdk19, Mar 9, 2022 > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > removed incorrect translation of compiler configuration file LGTM. Thanks for the cha

Re: RFR: 8283092: JMX subclass permission check redundant with strong encapsulation

2022-03-16 Thread Kevin Walls
On Wed, 16 Mar 2022 15:14:53 GMT, Daniel Fuchs wrote: >> Removing permission checks which, in the presence of a Security Manager, >> would check for a RuntimePermission "className.subclass". This was to >> prevent subclassing these classes, but is no longer necessary with strong >> encapsulat

Re: RFR: 8280400: JDK 19 L10n resource files update - msgdrop 10 [v4]

2022-03-16 Thread Alisen Chung
> msg drop for jdk19, Mar 9, 2022 Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: removed incorrect translation of compiler configuration file - Changes: - all: https://git.openjdk.java.net/jdk/pull/7765/files - new:

Re: RFR: 8282241: Invalid generic signature for redefined classes [v2]

2022-03-16 Thread Serguei Spitsyn
On Fri, 4 Mar 2022 17:12:51 GMT, Alex Menkov wrote: >> JDK-8238048 (fixed in jdk15) moved major_version, minor_version, >> generic_signature_index and source_file_name_index from InstanceKlass to >> ConstantPool. >> We still have some incorrect code in CP merge during class redefinition. >> >>

Re: RFR: 8283092: JMX subclass permission check redundant with strong encapsulation

2022-03-16 Thread Daniel Fuchs
On Tue, 15 Mar 2022 20:22:16 GMT, Kevin Walls wrote: > Removing permission checks which, in the presence of a Security Manager, > would check for a RuntimePermission "className.subclass". This was to > prevent subclassing these classes, but is no longer necessary with strong > encapsulation f

Re: RFR: 8283147: Include NonJavaThread stacktrace during thread dump [v3]

2022-03-16 Thread Yi Yang
On Wed, 16 Mar 2022 02:57:20 GMT, Yi Yang wrote: >> When we use jcmd Thread.dump/jstack , we could dump all Java >> thread stack trace, but unfortunately we are not able to print NonJavaThread >> stack trace such as VMThread/GCWorker, etc. For these threads, we know >> nothing about what are