Re: RFR: 8284903: Fix typos in hotspot [v2]

2022-04-19 Thread David Holmes
On Tue, 19 Apr 2022 19:08:26 GMT, Magnus Ihse Bursie wrote: >> I ran `codespell` on hotspot, and accepted those changes where it indeed >> discovered real typos. >> >> You'd be surprised over the many implementions of instrinsics and other >> intructions accross all archtectures I've encounte

Re: RFR: 8284828: Use `os::ThreadCrashProtection` to protect AsyncGetCallTrace from crashing [v9]

2022-04-19 Thread David Holmes
On Thu, 14 Apr 2022 15:19:17 GMT, Johannes Bechberger wrote: >> Move the AsyncGetCallTrace method implementation into a separate method and >> wrap its call in non-assert compilation mode in `os::ThreadCrashProtection` >> like it is done in >> [JFR](https://github.com/openjdk/jdk/blob/965ea8d

Re: RFR: 8283179: SA tests fail with "ERROR: catch_mach_exception_raise: Message doesn't denote a Unix soft signal." [v2]

2022-04-19 Thread Chris Plummer
On Tue, 19 Apr 2022 04:01:16 GMT, Chris Plummer wrote: >> During the SA attach process on macOS, SA installs an exception handler and >> expects to get an EXC_SOFTWARE exception for the expected SIGSTOP signal. On >> aarch64, sometimes it instead gets an EXC_BAD_INSTRUCTION exception. I found

Integrated: 8284903: Fix typos in hotspot

2022-04-19 Thread Magnus Ihse Bursie
On Fri, 15 Apr 2022 07:40:04 GMT, Magnus Ihse Bursie wrote: > I ran `codespell` on hotspot, and accepted those changes where it indeed > discovered real typos. > > You'd be surprised over the many implementions of instrinsics and other > intructions accross all archtectures I've encounted, so

Re: RFR: 8284903: Fix typos in hotspot [v3]

2022-04-19 Thread Magnus Ihse Bursie
> I ran `codespell` on hotspot, and accepted those changes where it indeed > discovered real typos. > > You'd be surprised over the many implementions of instrinsics and other > intructions accross all archtectures I've encounted, so for the preceding > reason it's neccesery to sucessfully sea

Re: RFR: 8284903: Fix typos in hotspot [v2]

2022-04-19 Thread Magnus Ihse Bursie
> I ran `codespell` on hotspot, and accepted those changes where it indeed > discovered real typos. > > You'd be surprised over the many implementions of instrinsics and other > intructions accross all archtectures I've encounted, so for the preceding > reason it's neccesery to sucessfully sea

Re: RFR: 8284903: Fix typos in hotspot

2022-04-19 Thread Stefan Karlsson
On Fri, 15 Apr 2022 07:40:04 GMT, Magnus Ihse Bursie wrote: > I ran `codespell` on hotspot, and accepted those changes where it indeed > discovered real typos. > > You'd be surprised over the many implementions of instrinsics and other > intructions accross all archtectures I've encounted, so

Re: RFR: 8284903: Fix typos in hotspot

2022-04-19 Thread Lutz Schmidt
On Fri, 15 Apr 2022 07:40:04 GMT, Magnus Ihse Bursie wrote: > I ran `codespell` on hotspot, and accepted those changes where it indeed > discovered real typos. > > You'd be surprised over the many implementions of instrinsics and other > intructions accross all archtectures I've encounted, so

Re: RFR: 8269537: memset() is called after operator new [v5]

2022-04-19 Thread Leo Korinth
On Tue, 19 Apr 2022 16:49:12 GMT, Leo Korinth wrote: >> The basic problem is that we are relying on undefined behaviour, as >> documented in the code: >> >> // This whole business of passing information from ResourceObj::operator new >> // to the ResourceObj constructor via fields in the "objec

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v4]

2022-04-19 Thread Mandy Chung
On Tue, 19 Apr 2022 10:49:14 GMT, Alan Bateman wrote: >> src/java.base/share/classes/java/lang/ref/ReferenceQueue.java line 61: >> >>> 59: private final Condition notEmpty; >>> 60: >>> 61: void signal() { notEmpty.signalAll(); } >> >> `signal()`, `await()` and `await(long)` methods are

Re: RFR: 8269537: memset() is called after operator new [v5]

2022-04-19 Thread Leo Korinth
> The basic problem is that we are relying on undefined behaviour, as > documented in the code: > > // This whole business of passing information from ResourceObj::operator new > // to the ResourceObj constructor via fields in the "object" is technically > UB. > // But it seems to work within th

Re: RFR: 8284903: Fix typos in hotspot

2022-04-19 Thread Magnus Ihse Bursie
On Fri, 15 Apr 2022 07:40:04 GMT, Magnus Ihse Bursie wrote: > I ran `codespell` on hotspot, and accepted those changes where it indeed > discovered real typos. > > You'd be surprised over the many implementions of instrinsics and other > intructions accross all archtectures I've encounted, so

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v4]

2022-04-19 Thread Alan Bateman
On Tue, 19 Apr 2022 00:09:04 GMT, Mandy Chung wrote: >> Alan Bateman has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Refresh > > src/java.base/share/classes/java/lang/ref/ReferenceQueue.java line 61: > >> 59: private final Condition

Re: RFR: 8284903: Fix typos in hotspot

2022-04-19 Thread XenoAmess
On Tue, 19 Apr 2022 08:49:28 GMT, Doug Simon wrote: > Are there plans to add `codespell` to the make system to somehow > catch/prevent spelling regressions in future? I understand this may not be > feasible. IMO all spell checking mechanisms suffers from false positive and need human manual j

Re: RFR: 8284903: Fix typos in hotspot

2022-04-19 Thread Doug Simon
On Fri, 15 Apr 2022 07:40:04 GMT, Magnus Ihse Bursie wrote: > I ran `codespell` on hotspot, and accepted those changes where it indeed > discovered real typos. > > You'd be surprised over the many implementions of instrinsics and other > intructions accross all archtectures I've encounted, so