On Thu, 21 Apr 2022 11:35:57 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in the
On Thu, 21 Apr 2022 16:30:42 GMT, Daniel Fuchs wrote:
> > @dfuch I have only updated files in `src`, so if the incorrect spelling is
> > tested, that test will now fail. I'm unfortunately not well versed in what
> > tests cover serviceability code. Can you suggest a suitable set of tests to
>
The test is testing that EventSets for ThreadStartEvents have the proper
suspendPolicy. When there is more than one ThreadStartRequest and a thread is
started, each ThreadStartRequest results in a ThreadStartEvent being created,
and they all are grouped into the same EventSet. The suspendPolicy
On Thu, 21 Apr 2022 17:22:04 GMT, Magnus Ihse Bursie wrote:
>> src/jdk.jdwp.agent/share/native/libjdwp/invoker.h line 38:
>>
>>> 36: jboolean pending; /* Is an invoke requested? */
>>> 37: jboolean started; /* Is an invoke happening? */
>>> 38: jboolean available;/* Is
On Thu, 21 Apr 2022 16:17:20 GMT, Kevin Walls wrote:
>> I ran `codespell` on modules owned by the serviceability team
>> (`java.instrument java.management.rmi java.management jdk.attach
>> jdk.hotspot.agent jdk.internal.jvmstat jdk.jcmd jdk.jconsole jdk.jdi
>> jdk.jdwp.agent jdk.jstatd jdk.man
On Thu, 21 Apr 2022 14:03:39 GMT, Daniel Fuchs wrote:
>> I ran `codespell` on modules owned by the serviceability team
>> (`java.instrument java.management.rmi java.management jdk.attach
>> jdk.hotspot.agent jdk.internal.jvmstat jdk.jcmd jdk.jconsole jdk.jdi
>> jdk.jdwp.agent jdk.jstatd jdk.ma
On Thu, 21 Apr 2022 11:22:48 GMT, Magnus Ihse Bursie wrote:
> I ran `codespell` on modules owned by the serviceability team
> (`java.instrument java.management.rmi java.management jdk.attach
> jdk.hotspot.agent jdk.internal.jvmstat jdk.jcmd jdk.jconsole jdk.jdi
> jdk.jdwp.agent jdk.jstatd jdk.
On Thu, 21 Apr 2022 14:03:39 GMT, Daniel Fuchs wrote:
>> I ran `codespell` on modules owned by the serviceability team
>> (`java.instrument java.management.rmi java.management jdk.attach
>> jdk.hotspot.agent jdk.internal.jvmstat jdk.jcmd jdk.jconsole jdk.jdi
>> jdk.jdwp.agent jdk.jstatd jdk.ma
On Thu, 21 Apr 2022 12:19:20 GMT, Stefan Karlsson wrote:
> had hoped to fine a way to just get rid of it instead of finding a better
> name.
`vmClasses::Reference_klass()->set_reference_type(REF_SOFT);` works. In fact,
anything other than `REF_NONE` works. The correct ref-type for each subclas
On Thu, 21 Apr 2022 11:22:48 GMT, Magnus Ihse Bursie wrote:
> I ran `codespell` on modules owned by the serviceability team
> (`java.instrument java.management.rmi java.management jdk.attach
> jdk.hotspot.agent jdk.internal.jvmstat jdk.jcmd jdk.jconsole jdk.jdi
> jdk.jdwp.agent jdk.jstatd jdk.
On Thu, 21 Apr 2022 11:30:20 GMT, Albert Mingkun Yang wrote:
>> Simple rename and some comments update.
>>
>> Test: build
>
> Albert Mingkun Yang has updated the pull request incrementally with one
> additional commit since the last revision:
>
> review
That's unfortunate. The allocate_inst
On Thu, 21 Apr 2022 11:36:35 GMT, Stefan Karlsson wrote:
> Maybe the latter could be changed to REF_NONE?
`vmClasses::Reference_klass()->set_reference_type(REF_NONE);` fails in `make
images`.
The relevant code is:
ClassFileParser::post_process_parsed_stream(...) {
...
_rt = (NULL ==_supe
On Thu, 21 Apr 2022 11:30:20 GMT, Albert Mingkun Yang wrote:
>> Simple rename and some comments update.
>>
>> Test: build
>
> Albert Mingkun Yang has updated the pull request incrementally with one
> additional commit since the last revision:
>
> review
Do we even need REF_OTHER / REF_REFER
On Fri, 15 Apr 2022 21:31:09 GMT, Paul Sandoz wrote:
>> Alan Bateman has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Refresh
>
> src/java.base/share/classes/jdk/internal/vm/Continuation.java line 264:
>
>> 262: } finally {
>
On Sat, 16 Apr 2022 14:59:55 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/jdk/internal/vm/ThreadContainers.java line 184:
>>
>>> 182: * with the Thread API.
>>> 183: */
>>> 184: private static class RootContainer extends ThreadContainer {
>>
>> This implementation could
On Tue, 19 Apr 2022 01:11:56 GMT, Mandy Chung wrote:
>> Alan Bateman has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Refresh
>
> src/java.base/share/classes/java/lang/System.java line 2173:
>
>> 2171:
>> 2172: // start Finalize
> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
> JDK version to target.
>
> We will refresh this PR periodically to pick up changes and fixes from the
> loom repo.
>
> Most of the new mechanisms in the HotSpot VM are disabled by default and
> require running with
I ran `codespell` on modules owned by the serviceability team (`java.instrument
java.management.rmi java.management jdk.attach jdk.hotspot.agent
jdk.internal.jvmstat jdk.jcmd jdk.jconsole jdk.jdi jdk.jdwp.agent jdk.jstatd
jdk.management.agent jdk.management`), and accepted those changes where it
> Simple rename and some comments update.
>
> Test: build
Albert Mingkun Yang has updated the pull request incrementally with one
additional commit since the last revision:
review
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/8332/files
- new: https://git.openjdk.j
On Thu, 21 Apr 2022 10:48:06 GMT, Albert Mingkun Yang wrote:
> Simple rename and some comments update.
>
> Test: build
Changes requested by kbarrett (Reviewer).
src/hotspot/share/jfr/recorder/checkpoint/types/jfrType.cpp line 214:
> 212: }
> 213:
> 214: static const char* reference_type_to_s
Simple rename and some comments update.
Test: build
-
Commit messages:
- ref-rename
Changes: https://git.openjdk.java.net/jdk/pull/8332/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8332&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8285364
Stats: 9 li
21 matches
Mail list logo
