Re: RFR: 8285366: Fix typos in serviceability

2022-04-22 Thread David Holmes
On Thu, 21 Apr 2022 18:08:05 GMT, Kevin Walls wrote: >> But on the other hand we have `javax.script.Invocable`. :-) >> >> Codespell suggested this change, and I based my decision to keep it based on >> [Merriam-Webster](https://www.merriam-webster.com/dictionary/invocable) not >> even listing

Re: RFR: 8285149: Using HashMap.newHashMap to replace new HashMap(int) [v3]

2022-04-22 Thread Sergey Bylokhov
On Wed, 20 Apr 2022 19:24:25 GMT, XenoAmess wrote: >> These are the changes that too many to be reviewed in 8186958, thus split >> some of them out. > > XenoAmess has updated the pull request incrementally with one additional > commit since the last revision: > > add more replaces src/demo/

Re: RFR: 8285366: Fix typos in serviceability

2022-04-22 Thread Serguei Spitsyn
On Thu, 21 Apr 2022 11:22:48 GMT, Magnus Ihse Bursie wrote: > I ran `codespell` on modules owned by the serviceability team > (`java.instrument java.management.rmi java.management jdk.attach > jdk.hotspot.agent jdk.internal.jvmstat jdk.jcmd jdk.jconsole jdk.jdi > jdk.jdwp.agent jdk.jstatd jdk.

Re: RFR: 8285364: Remove REF_ enum for java.lang.ref.Reference [v2]

2022-04-22 Thread Stefan Karlsson
On Fri, 22 Apr 2022 09:04:37 GMT, Kim Barrett wrote: > > > Using REF_SOFT seems too hacky. > > > > > > Just to put all alternatives on the table. The use of `REF_SOFT` is > > ephemeral. > > [...] > > I have no particular preference. What does everyone think? > > I also think using REF_SOFT li

Re: RFR: 8285364: Remove REF_ enum for java.lang.ref.Reference [v2]

2022-04-22 Thread Albert Mingkun Yang
On Thu, 21 Apr 2022 11:30:20 GMT, Albert Mingkun Yang wrote: >> Simple rename and some comments update. >> >> Test: build > > Albert Mingkun Yang has updated the pull request incrementally with one > additional commit since the last revision: > > review I have taken the commit from Stefan a

Re: RFR: 8285364: Use more precise name for ReferenceType::REF_OTHER [v3]

2022-04-22 Thread Albert Mingkun Yang
> Simple rename and some comments update. > > Test: build Albert Mingkun Yang has updated the pull request incrementally with one additional commit since the last revision: Remove REF_ enum for java.lang.ref.Reference Signed-off-by: Albert Yang - Changes: - all: https://

Re: RFR: 8285364: Use more precise name for ReferenceType::REF_OTHER [v2]

2022-04-22 Thread Kim Barrett
On Thu, 21 Apr 2022 11:30:20 GMT, Albert Mingkun Yang wrote: >> Simple rename and some comments update. >> >> Test: build > > Albert Mingkun Yang has updated the pull request incrementally with one > additional commit since the last revision: > > review > > Using REF_SOFT seems too hacky. >

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v3]

2022-04-22 Thread Ron Pressler
On Sun, 17 Apr 2022 04:57:34 GMT, Jaikiran Pai wrote: >> Alan Bateman has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> commits

Re: RFR: 8285364: Use more precise name for ReferenceType::REF_OTHER [v2]

2022-04-22 Thread Albert Mingkun Yang
On Fri, 22 Apr 2022 08:03:42 GMT, Stefan Karlsson wrote: > Using REF_SOFT seems too hacky. Just to put all alternatives on the table. The use of `REF_SOFT` is ephemeral. // in vmClasses::resolve_all vmClasses::Reference_klass()->set_reference_type(REF_SOFT); // setting ref-type of Sof

Re: RFR: 8285364: Use more precise name for ReferenceType::REF_OTHER [v2]

2022-04-22 Thread Stefan Karlsson
On Thu, 21 Apr 2022 11:30:20 GMT, Albert Mingkun Yang wrote: >> Simple rename and some comments update. >> >> Test: build > > Albert Mingkun Yang has updated the pull request incrementally with one > additional commit since the last revision: > > review Using REF_SOFT seems too hacky. If we