On Mon, 13 Jun 2022 18:14:56 GMT, Aleksey Shipilev wrote:
> SonarCloud reports a few uninitialized fields in new VM_Virtual* ops. Those
> fields are used, and therefore this is a serious bug. These ops seem to be
> used only from a few corner cases, which is probably why this was never
> actua
On Mon, 13 Jun 2022 11:42:43 GMT, David Holmes wrote:
> Maybe we actually need to backtrack and restore an invariant that there is
> always a TLH even for the current thread and fix the JVMTI code that did
> things differently?
This will make JVMTI code unnecessarily ugly in a couple of spots.
On Sat, 11 Jun 2022 08:11:34 GMT, Alan Bateman wrote:
> This test connects to http://openjdk.java.net/ so it's not reliable if the
> host name can't be resolved or a HTTP connection cannot be established. I've
> changed the test to use a local HTTP server so the original test works as
> before
JNI is updated in Java 19 so we need to define JNI_VERSION_19 and change
GetVersion to return this version.
test/hotspot/jtreg/native_sanity/JniVersion.java is updated to check that
JNI_VERSION_19 is returned. The native library in the JMX agent, and several
tests, define JNI_OnLoad that return
On Mon, 13 Jun 2022 07:45:41 GMT, Robbin Ehn wrote:
>> Johan Sjölén has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Move assert up and remove other assert, remove unused var
>
> The only way to become an active handshaker is to handshake
On Wed, 8 Jun 2022 12:09:27 GMT, Severin Gehwolf wrote:
>> Please review this cleanup change in the cgroup subsystem which used to use
>> hard-coded stack allocated
>> buffers for concatenating strings in memory. We can use `stringStream`
>> instead which doesn't have the issue
>> of hard-codin
On Tue, 7 Jun 2022 12:42:05 GMT, Johan Sjölén wrote:
>> Please review this PR for fixing JDK-8287281.
>>
>> If a thread is handshake safe we immediately execute the closure, instead of
>> going through the regular Handshake process.
>>
>> Finally: Should `VirtualThreadGetThreadClosure` and i
