Dear All,
I want to get your suggestion about adding a new internal command
to solve the argument passing problem of jmap alike tools.
We recently encounter a problem when adding the 4th option
(“parallel”) to jmap -dump, it failed because there is limitation of max numb
5 times run)
> Before: 685ms
> After(4threads): 356ms
>
>BRs,
>Lin
>
>> On Sep 1, 2020, at 12:45 PM, David Holmes
> wrote:
> >
>> Hi Lin,
>>
>>> On 1/09/2020 12:28 pm, linzang(臧琳) wrote:
>>
e already discussed this in the CSR for parallel
> flag and decided it should not be accepted without a value.
>
> Thanks,
> Serguei
>
>
>> On 9/1/20 16:51, David Holmes wrote:
>> Hi Lin,
>>
>>> On 1/09/2020 7:06 pm, linzang(臧琳) wrote:
>>> H
ted behavior as you mentioned. so I made the webrev and
expect to get some comments.
If it is not an issue, may be I can just close the issue.
BRs,
Lin
On 2020/9/2, 7:52 AM, "David Holmes" wrote:
Hi Lin,
On 1/09/2020 7:06 pm, linzang(臧琳) wrote:
> Hi
Hi All,
Please help review this small change about jmap -histo:parallel
Bug: https://bugs.openjdk.java.net/browse/JDK-8252629
webrev: http://cr.openjdk.java.net/~lzang/8252629/webrev.00/
The problem is that "jmap -histo:parallel" command prompt error message "
Fail: invalid
t; On 1/09/2020 12:28 pm, linzang(臧琳) wrote:
>> Dear All,
>> May I ask your help to review this change of adding parallel
>> heap inspection for PSS Heap?
>> bug: https://bugs.openjdk.java.net/browse/JDK-8252103
>> webrev:
>> http://cr.
Dear All,
May I ask your help to review this change of adding parallel
heap inspection for PSS Heap?
bug: https://bugs.openjdk.java.net/browse/JDK-8252103
webrev:
http://cr.openjdk.java.net/~lzang/jmap-8214535/8252103/webrev.00/
My preliminary measurement sho
gt; Serguei
>
>
> On 8/21/20 14:01, Daniel D. Daugherty wrote:
>> On 8/20/20 7:42 PM, linzang(臧琳) wrote:
>>> After discuss with paul, it is not a good idea to combine two fix
>>> together in one webrev. I will handle them separately
>>> Please help revi
Dear Paul,
Thanks a lot! may I ask your help to push it if there is no need for
more review?
Cheers,
Lin
On 22/08/2020 04:33, Hohensee, Paul wrote:
Lgtm.
Paul
From: "linzang(臧琳)" <mailto:linz...@tencent.com>
Date: Thursday, August 20, 2020 at 5:03 PM
To:
&qu
Dear All,
Please help review the patch of 8251848, Thanks!
Webrev: http://cr.openjdk.java.net/~lzang/8251848/webrev.00/
Bug: https://bugs.openjdk.java.net/browse/JDK-8251848
BRs,
Lin
-8252102
Bug: https://bugs.openjdk.java.net/browse/JDK-8252101
BRs,
Lin
On 2020/8/21, 12:17 AM, "linzang(臧琳)" wrote:
Dear All,
May I ask your help to review this change:
Webrev: http://cr.openjdk.java.net/~lzang/8252101/webrev.00/
s,
Lin
On 2020/8/20, 8:18 PM, "linzang(臧琳)" wrote:
Thanks Paul!
I have filed CSR and Bug:
CSR: https://bugs.openjdk.java.net/browse/JDK-8252102
Bug: https://bugs.openjdk.java.net/browse/JDK-8252101
Patch is under testing, will create RFR thread wh
:
> I prioritize compatibility, so would go with option 2.
>
> Thanks,
> Paul
>
> On 8/18/20, 11:17 PM, "serviceability-dev on behalf of linzang(臧琳)"
>
> wrote:
>
> Dear All,
> May I get some suggestions? so that I can work out a patch
Dear All,
May I get some suggestions? so that I can work out a patch
base on that.
Or may be it should not be treated as an issue?
BRs,
Lin
On 17/08/2020 17:17, linzang(臧琳) wrote:
> Dear all,
> we found the jmap’s histo/dump command could accept "live&q
Dear all,
we found the jmap’s histo/dump command could accept "live" and "all"
options together, and the specification does not describe what is the expected
behavior of it.
I have tried that when these two options used together, the "live"
takes effect, no matter what sequ
Dear All,
Sorry for making incomplete patch. And thanks for help fixing it.
BRs,
Lin
> On Aug 15, 2020, at 6:04 AM, "serguei.spit...@oracle.com"
> wrote:
>
> Hi Stefan and Paul,
>
> Thank you for taking care and fixing this regression!
>
> It seems, the fix from Paul is more comple
self?
>>>>
>>>> https://hg.openjdk.java.net/jdk/jdk/rev/5036ca733469
>>>>
>>>> Thanks,
>>>> Paul
>>>>
>>>> On 8/13/20, 9:48 AM, "serviceability-dev on behalf of H
6:21 PM, "serguei.spit...@oracle.com"
> wrote:
>
>Hi Lin.
>
>Thank you for the update.
>It looks good.
>
>Thanks,
>Serguei
>
>
>>On 8/12/20 17:08, linzang(臧琳) wrote:
>> Hi Paul and Serguei,
>> Thanks fo
ne comment.
+ System.err.println("Fail: invalid option: '" + subopt
+"'");
+ System.exit(1);
Exit needs to be replaced wit usage for consistency.
Thanks,
Serguei
On 8/10/20 19:57, linzang(臧琳) wrote:
> Here is the webrev: http://
1:06 AM
To: "linzang(臧琳)"
Cc: "Hohensee, Paul" , Stefan Karlsson
, David Holmes ,
serviceability-dev ,
"hotspot-gc-...@openjdk.java.net"
Subject: Re: RFR(L): 8215624: add parallel heap inspection support for jmap
histo(G1)(Internet mail)
Hi Lin,
Thanks you for
| latest
| usage printed |
BRs,
Lin
From: "serguei.spit...@oracle.com"
Date: Wednesday, August 12, 2020 at 4:23 AM
To: "linzang(臧琳)"
Cc: "Hohensee, Paul" , Stefan Karlsson
, David Holmes ,
ser
not change things without a real
need.
Thanks,
Serguei
On 8/10/20 20:23, linzang(臧琳) wrote:
> Hi Serguei
> I got your point, just thought usage may be a little verbosity, it
prints almost my whole screen which could flush the error message. And I
checked
ough.
>
> Thanks,
> Serguei
>
>
>> On 8/10/20 19:25, linzang(臧琳) wrote:
>> Hi Serguei,
>> >> First, the CSR does not include any update for 'live' and 'all'
>> options, does it?
>>>> If so, then I'm co
Here is the webrev: http://cr.openjdk.java.net/~lzang/8251374/webrev01/
BRs,
Lin
On 2020/8/11, 10:52 AM, "linzang(臧琳)" wrote:
Hi All,
May I ask your help to review this tiny patch? It fix an issue that
jmap -dump could wrongly accept invalid optioins.
B
Hi All,
May I ask your help to review this tiny patch? It fix an issue that jmap
-dump could wrongly accept invalid optioins.
Bugs: https://bugs.openjdk.java.net/browse/JDK-8251374
Patch: (Can not connect to webrev ftp currently, will try it later,
following are all code changes)
BTW, during refining this changeset I also found an issue that jmap -dump
could accept undefined options, will setup a new issue in JBS and fix it
separately soon.
BRs,
Lin
From: "serguei.spit...@oracle.com"
Date: Tuesday, August 11, 2020 at 8:40 AM
To: "linzang(
And Here is the latest refined changeset
Webrev: http://cr.openjdk.java.net/~lzang/jmap-8214535/8215624/webrev_12/
Delta: http://cr.openjdk.java.net/~lzang/jmap-8214535/8215624/webrev_12_delta/
BRs,
Lin
On 2020/8/11, 7:23 AM, "linzang(臧琳)" wrote:
Dear Serguei,
at same time,
> use “live”, rather than print error message. (not sure which one is better :P)
My last point is to retrive the behavior for compatibility. And do you think
make a separate enhancement about spec is reasonable ?
Thanks!
BRs,
Lin
From: "serguei.spit...@oracl
log_info().
In heapInspection.hpp, you can delete two of the three blank lines before
#endif // SHARE_MEMORY_HEAPINSPECTION_HPP
Thanks,
Paul
On 8/5/20, 6:46 AM, "linzang(臧琳)" wrote:
Hi Paul, Stefan and Serguei,
Here I uploaded a new changeset, would
. I am in process of building it on windows environment for a double
check. May update result later. Thanks!
BRs,
Lin
On 2020/8/5, 8:56 PM, "Hohensee, Paul" wrote:
uintx is fine with me.
Thanks,
Paul
On 8/5/20, 1:14 AM, "linzang(臧琳)" wrote
8-05 07:22, linzang(臧琳) wrote:
> Hi Serguei,
>
> No problem, Thanks for your reviewing :)
>
> I wll upload a new webrev later, so may I ask your help to review it
> again?
>
> Hi Stefan,
>
> As Paul mentioned, the _/mis
o run with this succeeded, so afaic you're good to go. Stefan,
you reviewed the GC part before, it'd be great if you could ok the final
version.
Thanks,
Paul
On 7/29/20, 5:02 AM, "linzang(臧琳)" wrote:
Upload a new change at
http://cr.openjdk.java.n
) NOT_SERVICES_RETURN_(0);
+ uint populate_table(KlassInfoTable* cit, BoolObjectClosure* filter = NULL,
uint parallel_thread_num = 1) NOT_SERVICES_RETURN_(0);
BRs,
Lin
On 2020/7/27, 11:26 AM, "linzang(臧琳)" wrote:
I update a new change at
http://cr.openjdk.java.
);
+ uint parallel_thread_num = MAX2(1,
(uint)os::initial_active_processor_count() * 3 / 8);
BRs,
Lin
On 2020/7/23, 11:56 AM, "linzang(臧琳)" wrote:
Hi Paul,
Thanks for your help, that all looks good to me.
Just 2 min
##
Here is the webrev
http://cr.openjdk.java.net/~lzang/jmap-8214535/8215624/webrev_08/
BRs,
Lin
-
From: "Hohensee, Paul"
Date: Thursday, July 23, 2020 at 6:48 AM
To: "linzang(臧琳)" , Stefan Karlsson
, "serguei
r("Invalid argument to inspectheap operation: %s", arg0);
return JNI_ERR;
}
###
Thanks.
BRs,
Lin
On 2020/7/9, 3:22 PM, "linzang(臧琳)" wrote:
Hi Paul,
Thanks for reviewing!
>>
>>
c, worker_id);
+ missed_count = ric.missed_count();
+ {
+MutexLocker x(&_mutex);
+merge_success = _shared_cit->merge(&cit);
+ }
+ if (merge_success) {
+Atomic::add(&_missed_count, missed_count);
+ else {
+Atomic::store(&_succes
2020/5/9, 3:47 PM, "linzang(臧琳)" wrote:
Dear All,
May I ask your help again for review the latest change? Thanks!
BRs,
Lin
On 2020/4/28, 1:54 PM, "linzang(臧琳)" wrote:
Hi Stefan,
>> - Adding Atomic::load/store.
Dear All,
May I ask your help again for review the latest change? Thanks!
BRs,
Lin
On 2020/4/28, 1:54 PM, "linzang(臧琳)" wrote:
Hi Stefan,
>> - Adding Atomic::load/store.
>> - Removing the time measurement in the run_task. I renamed G1
InspectTask, and delete unnecessary
comments.
BRs,
Lin
On 2020/4/27, 4:34 PM, "Stefan Karlsson" wrote:
Hi Lin,
On 2020-04-26 05:10, linzang(臧琳) wrote:
> Hi Stefan and Paul，
> I have made a new patch based on your comments and Stefan's Poc code:
>
/z/zHeap.cpp.
There maybe other better ways to sovle the above problems, welcome for
any comments, Thanks!
BRs,
Lin
On 2020/4/23, 11:08 AM, "linzang(臧琳)" wrote:
Thanks Paul! I agree with using "parallel", will make the update in next
patch, Thanks for help update
l
the other options are lower case, and it's a lot easier to type "parallel". I
took the liberty of updating the CSR. If you're ok with it, you might want to
change variable names and such, plus of course JMap.usage.
Thanks,
Paul
On 4/22/20, 2:29 AM, "servi
e GCs.
Thanks,
StefanK
On 2020-04-22 02:21, linzang(臧琳) wrote:
> Dear all,
> May I ask you help to review? This RFR has been there for quite a
while.
> Thanks!
>
> BRs,
> Lin
>
> > On 2020/3/16, 5:18 PM, "li
Dear all,
May I ask you help to review? This RFR has been there for quite a while.
Thanks!
BRs,
Lin
> On 2020/3/16, 5:18 PM, "linzang(臧琳)" wrote:>
> Just update a new path, my preliminary measure show about 3.5x speedup of
> jmap histo on a nearly fu
-8215624
CSR: https://bugs.openjdk.java.net/browse/JDK-8239290
BRs,
Lin
> On 2020/3/2, 9:56 PM, "linzang(臧琳)" wrote:
>
>Dear all,
> Let me try to ease the reviewing work by some explanation :P
> The patch's target is to speed up jmap -histo
object_iterate_parallel().
5. Add related test.
6. it may be easy to extend this patch for other kinds of heap by creating
subclass of ParHeapInspectTask and implement the do_object_iterate_parallel().
Hope these info could help on code review and initate the discussion :-)
Thanks!
BRs,
v.
>>
>> Chris
>>
>> On 2/25/20 2:21 AM, linzang(臧琳) wrote:
>>> Hi,
>>> Please review the following change:
>>> Bugs: https://bugs.openjdk.java.net/browse/JDK-8239916
>>> webrev: http://cr.openjdk.java.net/~lzang/8239916/webrev/
>>>
>>> Thanks,
>>> Lin
>>
>
>
Hi,
Please review the following change:
Bugs: https://bugs.openjdk.java.net/browse/JDK-8239916
webrev: http://cr.openjdk.java.net/~lzang/8239916/webrev/
Thanks,
Lin
/browse/JDK-8239290
--
Lin
>Hi Lin,
>
>Could you, please, re-post your RFR with the right enhancement number in
>the message subject?
>It will be more trackable this way.
>
>Thanks,
>Serguei
>
>
>On 2/17/20 10:29 PM, linzang(臧琳) wrote:
>> Dear David,
gt;>It will be more trackable this way.
>>
>>Thanks,
>>Serguei
>>
>>
>>On 2/17/20 10:29 PM, linzang(臧琳) wrote:
>>> Dear David,
>>> Thanks a lot!
>>> I have updated the refined code to
>>> http://cr.openjdk
Could you, please, re-post your RFR with the right enhancement number in
>the message subject?
>It will be more trackable this way.
>
>Thanks,
>Serguei
>
>
>On 2/17/20 10:29 PM, linzang(臧琳) wrote:
>> Dear David,
>> Thanks a lot!
>> I have updated
spect_task(KlassInfoTable* cit,
>+ BoolObjectClosure* filter,
>+ size_t* missed_count,
>+ size_t thread_num) {
>+ return NULL;
>
>s/NULL/false/
>
>Cheers,
>David
>
>On 18/02/2020 2
Dear All,
May I ask your help to review the follow changes:
webrev: http://cr.openjdk.java.net/~lzang/jmap-8214535/8215264/webrev_00/
bug: https://bugs.openjdk.java.net/browse/JDK-8215624
related CSR: https://bugs.openjdk.java.net/browse/JDK-8239290
This patch enable parall
Dear All,
I found jhsdb jmap —heap print the value of uint_max (17592186044415 MB)
when MaxMetaspaceSize is not set by user. This number confused me a little.
And I also found the jcmd VM.metaspace prints “unimited” if
MaxMetaspaceSize is not set. Which seems more reasonable.
So D
, 2019, at 3:09 AM, Chris Plummer
mailto:chris.plum...@oracle.com>> wrote:
On 12/15/19 5:38 PM, linzang(臧琳) wrote:
Dear Chris,
>> why jmap is getting stuck or "killed by timer" as you mention below.
>> Shouldn't this be considered a bug and addressed directly.
ut?
Yes, the incremental dump information shows the number of the objects and the
totally bytes have been iterated.
Thanks!
BRs,
Lin
From: Chris Plummer
Date: Saturday, December 14, 2019 at 2:46 AM
To: "linzang(臧琳)" , "serviceability-dev@openjdk.java.net"
Subject: Re: Discuss
Dear All,
I want to re-activate the thread of discussion about the implementation of
parallel and incremental “Jmap -histo”.
The target of these changes is to solve the problems that “jmap -histo” may
“ timeout or killed by timer” when heap is large. And the result of “jmap
-histo” is “on
for large heap.
What do you think?
BRs,
Lin
From: serguei.spit...@oracle.com
Sent: Tuesday, June 4, 2019 8:55:31 AM
To: 臧琳
Cc: Hohensee, Paul; JC Beyler; serviceability-dev@openjdk.java.net
Subject: Re: [RFR]8215623: Add incremental dump for jmap histo
Dear Serguei,
Do you think it is reasonable if I implement the parallel, incremental
jmap histo together? so that the design can be discussed together.
BRs,
Lin
From: 臧琳
Sent: Monday, May 20, 2019 11:14:34 PM
To: serguei.spit...@oracle.com
Cc
agree it is better if we can get rid of
incremental-file options and using file=, but I think we need to discuss
how to make it adaptable for parallel dump. What do you think?
Thanks,
Lin
From: serguei.spit...@oracle.com
Sent: Saturday, May 18, 2019 2:42 AM
To: 臧琳
Cc: Hohensee, Paul ; JC
Dear Serguei,
在
2019年5月16日，下午1:39，serguei.spit...@oracle.com<mailto:serguei.spit...@oracle.com>
写道：
On 5/13/19 23:46, 臧琳 wrote:
Dear Serguei,
Thanks for your comments.
> > - incremental[:], enable the incremental dump of heap, dumped
> > data will be saved to
ile behave like gclog,
when maxfilesize is reached, the file is renamed with numbered suffix, and new
file is created to use. so there can be IncrementalHisto.dump.0 and
IncrementalHisto.dump.1 etc for large heap.
what do you think?
Thanks,
Lin
From: ser
Dear All,
I have updated the CSR at https://bugs.openjdk.java.net/browse/JDK-8222319
May I ask your help to review it?
When it is finalized, I will refine the webrev.
BRs,
Lin
> Dear Serguei，
> Thanks a lot for your reviewing.
>
>
>
> > System.err.println(" inc
Dear Serguei，
Thanks a lot for your reviewing.
System.err.println(" incremental dump support:");
+System.err.println("chunkcount=object number counted
(in Kilo) to trigger incremental dump");
+System.err.println("maxfilesize= size limit of
Dear All,
May I ask for more review of this webrev and CSR?
Webrev:
http://cr.openjdk.java.net/~lzang/jmap-8214535/8215623/webrev.06/
CSR: https://bugs.openjdk.java.net/browse/JDK-8222319.
Thanks!
Lin
From: 臧琳
Sent: Monday
and maxfilesize are new)
Thanks,
Jc
On Wed, Apr 10, 2019 at 11:56 PM 臧琳 mailto:zangl...@jd.com>>
wrote:
Dear All,
I have created a CSR at https://bugs.openjdk.java.net/browse/JDK-8222319.
May I ask your help to review it? Thanks!
BRs,
Lin
在 2019年4月11日，上午11:22，臧琳 mailto:zangl.
Dear All,
I have created a CSR at https://bugs.openjdk.java.net/browse/JDK-8222319.
May I ask your help to review it? Thanks!
BRs,
Lin
在 2019年4月11日，上午11:22，臧琳 mailto:zangl...@jd.com>> 写道：
Sorry, it should be CSR ticket
Thanks，
Lin
在 2019年4月11日，上午11:16，臧琳 mailto:zangl...@jd.co
Sorry, it should be CSR ticket
Thanks，
Lin
在 2019年4月11日，上午11:16，臧琳 mailto:zangl...@jd.com>> 写道：
Also realized it requires a JCP ticket, I will create it.
Cheers,
Lin
在 2019年4月11日，上午10:26，臧琳 mailto:zangl...@jd.com>> 写道：
Dear JC,
Thanks so much, I suddenly realized your wa
Also realized it requires a JCP ticket, I will create it.
Cheers,
Lin
在 2019年4月11日，上午10:26，臧琳 mailto:zangl...@jd.com>> 写道：
Dear JC,
Thanks so much, I suddenly realized your way is exactly what I want.
And here is new wehbrev.
http://cr.openjdk.java.net/~lzang/jmap-8214535/8
d, String opt) {
+ if (cmd.isEmpty()) {
+return opt;
+ }
+ return cmd + "," + opt;
+}
+
That way you only put the ',' when needed,
Jc
On Wed, Apr 10, 2019 at 5:33 AM 臧琳 mailto:zangl...@jd.com>>
wrote:
Dear Jc,
Thanks a lot for your comments,
you do it for "all", should this not be:
} else if (subopt.equals("live")) {
-liveopt = "-live";
+// Add '-' for compatibility.
+cmdline += "-live";
Thanks,
Jc
On Mon, Apr 1, 2019 at 5:18 AM 臧琳 mailto
/serviceability-dev/2019-March/027338.html
May I ask your help to review?
http://cr.openjdk.java.net/~lzang/jmap-8214535/8215623/webrev.04/
BRs,
Lin
在 2019年2月26日，上午10:50，臧琳 mailto:zangl...@jd.com>> 写道：
Dear All,
I have revised the webrev at
http://cr.openjdk.java.net/~xi
Thanks all for reviewing it. I think it could be pushed now, right?
BRs,
Lin
From: Thomas Stüfe
Sent: Thursday, March 7, 2019 3:39:05 PM
To: 臧琳
Cc: serviceability-dev@openjdk.java.net serviceability-dev@openjdk.java.net
Subject: Re: RFR:8219721: jcmd from
Hi David,
Thanks a lot for your review.
Hi All,
May I get more review about this patch, it is a trivial patch to fix
compatibility issue.
Thanks,
Lin
> -Original Message-
> From: David Holmes
> Sent: Tuesday, March 5, 2019 2:12 PM
> To: 臧琳 ; serviceability-dev@open
Thanks David,
Here is the RFR thread
https://mail.openjdk.java.net/pipermail/serviceability-dev/2019-March/027337.html
Cheers,
Lin
From: David Holmes
Sent: Monday, March 4, 2019 3:34:10 PM
To: 臧琳; Yasumasa Suenaga; Hohensee, Paul
Cc: serviceability-dev
Dear All,
May I ask your help to review the fix of compatibility issue introduced by
JDK-8215622
webrev: http://cr.openjdk.java.net/~xiaofeya/8219721/webrev.01/
Bug: https://bugs.openjdk.java.net/browse/JDK-8219721
FYI, this webrev is forked from the discussion
https://mail.openjd
From: David Holmes
Sent: Monday, March 4, 2019 3:22:34 PM
To: 臧琳; Yasumasa Suenaga; Hohensee, Paul
Cc: serviceability-dev@openjdk.java.net serviceability-dev@openjdk.java.net
Subject: Re: Protocol version of Attach API
Hi Lin,
I think this is fine to address the
-Original Message-
> From: David Holmes
> Sent: Friday, March 1, 2019 12:22 PM
> To: Yasumasa Suenaga ; 臧琳
> Cc: serviceability-dev@openjdk.java.net serviceability-dev@openjdk.java.net
>
> Subject: Re: Protocol version of Attach API
>
> On 1/03/2019 1:54 pm, Yas
ev.
Thanks.
Lin
From: David Holmes
Sent: Thursday, February 28, 2019 7:55:01 PM
To: 臧琳; Yasumasa Suenaga
Cc: serviceability-dev@openjdk.java.net serviceability-dev@openjdk.java.net
Subject: Re: Protocol version of Attach API
Hi Lin,
On 28/02/2019 7:30 pm, 臧琳 w
; for jmap histo , described in 8215623).
what do you think?
BRs,
Lin
From: Hohensee, Paul
Sent: Thursday, February 28, 2019 7:48:06 PM
To: 臧琳; David Holmes; Yasumasa Suenaga
Cc: serviceability-dev@openjdk.java.net serviceability-dev@openjdk.java.net
S
Hi David,
I am a little confused, do you think it is proper to made the patch as a
fix of https://bugs.openjdk.java.net/browse/JDK-8219721 so that we don't need
to backout and REDO?
Thanks,
LIn
From: 臧琳
Sent: Thursday, February 28, 2019 4:50:
a random name
Random rnd = new Random();
Thanks,
Lin
____
From: 臧琳
Sent: Thursday, February 28, 2019 3:24:52 PM
To: David Holmes; Yasumasa Suenaga
Cc: serviceability-dev@openjdk.java.net serviceability-dev@openjdk.java.net
Subject: RE: Protocol version of At
Hi David,
Since I don't have the access to JBS, may I ask your help to ceate
sub-task? Thanks.
BRs,
Lin
> -Original Message-
> From: David Holmes
> Sent: Thursday, February 28, 2019 3:16 PM
> To: 臧琳 ; Yasumasa Suenaga
> Cc: serviceability-dev@openjdk.java.ne
, February 28, 2019 12:59:28 PM
To: 臧琳; Yasumasa Suenaga
Cc: serviceability-dev@openjdk.java.net serviceability-dev@openjdk.java.net
Subject: Re: Protocol version of Attach API
Sorry I'm going to pick up on the rollback and re-do option here as I
just had a closer look at jmap. Given jmap
. And I will try to fix the second one for Windows, and
create a separate thread for discussing. And if possible, I can help to fix the
third one.
What’s your opinion?
BRs,
Lin
From: Yasumasa Suenaga
Sent: Thursday, February 28, 2019 8:39 AM
To: 臧琳
Cc: David Holmes ; serviceability-dev
ll. so 00 may not indicate
it reach the end.
BRs,
Lin
From: Yasumasa Suenaga
Sent: Wednesday, February 27, 2019 8:10:14 PM
To: 臧琳
Cc: David Holmes; serviceability-dev@openjdk.java.net
Subject: Re: Protocol version of Attach API
Hi Lin,
I think we need to
str_count++;
+ }
+ break;;
+ }
+}
assert(n <= left, "buffer was too small, impossible!");
buf[max_len - 1] = '\0';
if (n == -1) {
Thanks.
Lin
From: Yasumasa Suenaga
Sent: Wedne
Another solution I can figure out is try to add timeout for socket read. I will
also investigate whether is works.
Cheers,
Lin
> -Original Message-
> From: 臧琳
> Sent: Wednesday, February 27, 2019 1:52 PM
> To: 'David Holmes' ; Yasumasa Suenaga
>
age-
> From: David Holmes
> Sent: Wednesday, February 27, 2019 1:44 PM
> To: Yasumasa Suenaga ; 臧琳
> Cc: serviceability-dev@openjdk.java.net
> Subject: Re: Protocol version of Attach API
>
> Hi Yasumasa,
>
> On 27/02/2019 1:05 pm, Yasumasa Suenaga wrote:
> > Hi Lin
Dear All,
Thanks for your suggestions.
IMHO, the problem is that it seems the "AttachOperation::arg_count_max"
limits the ability to extend the jcmd/jmap tools for new arguments. and it is
hard for me to extend jmaps new functionality (WIP, tracked at JDK-8214535 )
without touching thi
Dear Yasumasa,
The fix you mentioned seems not work as expected.
I have done an experiment that use jdk1.8's "jcmd help" to attach to
latest jdk.
it seem the whole "jcmd help" buffer is not read completely at one
time. in my case it is "jcmd", "", "help", and then block at while().
easonable?
BRs,
Lin
________
From: 臧琳
Sent: Tuesday, February 26, 2019 6:19:37 PM
To: Yasumasa Suenaga; David Holmes
Cc: serviceability-dev@openjdk.java.net serviceability-dev@openjdk.java.net
Subject: Re: Protocol version of Attach API
Hi David, Yasumasa, Thomas,
Thanks for point o
Hi David, Yasumasa, Thomas,
Thanks for point out this issue. it is introduced by enlarged the
arg_count_max for 8215622.
I have reproduced it on my side, and I will handle the fix.
would you like to help create a JBS for this issue?
Cheers,
Lin
___
Dear All,
I have revised the webrev at
http://cr.openjdk.java.net/~xiaofeya/8215623/webrev.02/.
May I ask your help for reviewing? Thanks
BRs,
Lin
> -Original Message-
> From: 臧琳
> Sent: Friday, January 25, 2019 9:01 AM
> To: Hohensee, Paul ; service
From: serguei.spit...@oracle.com
Sent: Wednesday, February 13, 2019 2:57:15 PM
To: 臧琳; Hohensee, Paul; Joe Darcy; Daniel Fuchs; David Holmes; JC Beyler
Cc: serviceability-dev@openjdk.java.net
Subject: Re: [RFR]8215622: Add dump to file support for jmap histo
Hi
like to help review it? Thanks.
BRs,
Lin
From: serguei.spit...@oracle.com
Sent: Wednesday, February 13, 2019 4:00
To: Hohensee, Paul; Joe Darcy; Daniel Fuchs; 臧琳; David Holmes; JC Beyler
Cc: serviceability-dev@openjdk.java.net
Subject: Re: [RFR]8215622: Add
ot;, so I think I need to add test for that.
is this OK?
Cheers,
Lin
From: Joseph D. Darcy
Sent: Tuesday, February 12, 2019 6:22:59 AM
To: Hohensee, Paul; serguei.spit...@oracle.com; 臧琳; David Holmes; JC Beyler
Cc: serviceability-dev@openjdk.java.net
Subject: Re: [RFR]8215622: Add dump to f
x27;s comments in the CSR
https://bugs.openjdk.java.net/browse/JDK-8218131
* Added the unit test for JMap based on Serguei's comments.
* Fixed the comments format.
Thanks !
Cheers,
Lin
____
From: 臧琳
Sent: Saturday, February 9, 201
: 臧琳; David Holmes; Hohensee, Paul; JC Beyler
Cc: serviceability-dev@openjdk.java.net
Subject: Re: [RFR]8215622: Add dump to file support for jmap histo
Hi Lin,
Thank you for the fix!
It looks good in general.
Should it come with a unit test for new flags?
http://cr.openjdk.java.net/~xiaofeya
: David Holmes
Sent: Thursday, January 31, 2019 9:19:31 AM
To: Hohensee, Paul; 臧琳; JC Beyler
Cc: serviceability-dev@openjdk.java.net
Subject: Re: [RFR]8215622: Add dump to file support for jmap histo
On 31/01/2019 10:41 am, Hohensee, Paul wrote:
> Also, I suspect that this change needs a CSR, si
1 - 100 of 129 matches
Mail list logo
