Re: RFR: JDK-8276447 Deprecate finalization-related methods for removal [v4]

2021-12-06 Thread Brent Christian
JEP 421. It also updates the relevant @SuppressWarning annotations. > > The CSR has been approved. > An automated test build+test run passes cleanly (FWIW :D ). Brent Christian has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 34 commits:

Re: RFR: JDK-8276447 Deprecate finalization-related methods for removal [v3]

2021-12-01 Thread Brent Christian
JEP 421. It also updates the relevant @SuppressWarning annotations. > > The CSR has been approved. > An automated test build+test run passes cleanly (FWIW :D ). Brent Christian has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 33 commits:

Re: RFR: JDK-8276447 Deprecate finalization-related methods for removal [v2]

2021-12-01 Thread Brent Christian
JEP 421. It also updates the relevant @SuppressWarning annotations. > > The CSR has been approved. > An automated test build+test run passes cleanly (FWIW :D ). Brent Christian has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 32 commits:

Re: RFR: JDK-8276447 Deprecate finalization-related methods for removal

2021-11-19 Thread Brent Christian
On Fri, 19 Nov 2021 18:06:39 GMT, Mandy Chung wrote: >> Here are the code changes for the "Deprecate finalizers in the standard Java >> API" portion of JEP 421 ("Deprecate Finalization for Removal") for code >> review. >> >> This change makes the indicated deprecations, and updates the API spe

RFR: JDK-8276447 Deprecate finalization-related methods for removal

2021-11-18 Thread Brent Christian
Here are the code changes for the "Deprecate finalizers in the standard Java API" portion of JEP 421 ("Deprecate Finalization for Removal") for code review. This change makes the indicated deprecations, and updates the API spec for JEP 421. It also updates the relevant @SuppressWarning annotatio

Integrated: 8253497: Core Libs Terminology Refresh

2020-12-16 Thread Brent Christian
On Mon, 14 Dec 2020 19:36:48 GMT, Brent Christian wrote: > This is part of an effort in the JDK to replace archaic/non-inclusive words > with more neutral terms (see JDK-8253315 for details). > > Here are the changes covering core libraries code and tests. Terms were > cha

Re: RFR: 8253497: Core Libs Terminology Refresh [v5]

2020-12-16 Thread Brent Christian
. blacklist -> filter or reject > 3. whitelist -> allow or accept > 4. master -> coordinator > 5. slave -> worker > > Addressing similar issues in upstream 3rd party code is out of scope of this > PR. Such changes will be picked up from their upstream sources. Brent Chr

Re: RFR: 8253497: Core Libs Terminology Refresh [v4]

2020-12-16 Thread Brent Christian
On Wed, 16 Dec 2020 07:10:41 GMT, Alan Bateman wrote: >> Brent Christian has updated the pull request incrementally with one >> additional commit since the last revision: >> >> improve SERIAL_FILTER_PATTERN comment > > src/java.base/share/classes/java/util/Loc

Re: RFR: 8253497: Core Libs Terminology Refresh [v4]

2020-12-15 Thread Brent Christian
. blacklist -> filter or reject > 3. whitelist -> allow or accept > 4. master -> coordinator > 5. slave -> worker > > Addressing similar issues in upstream 3rd party code is out of scope of this > PR. Such changes will be picked up from their upstream sources. Brent Chr

Re: RFR: 8253497: Core Libs Terminology Refresh [v3]

2020-12-15 Thread Brent Christian
On Tue, 15 Dec 2020 22:13:58 GMT, Stuart Marks wrote: >> It's an adverb, since it's the act of 'defining' that is being done too >> restrictively or broadly. If you want to have an adjective you would need to >> rephrase it so it applies to the noun, like 'defining a too restrictive >> accept-

Re: RFR: 8253497: Core Libs Terminology Refresh [v3]

2020-12-15 Thread Brent Christian
. blacklist -> filter or reject > 3. whitelist -> allow or accept > 4. master -> coordinator > 5. slave -> worker > > Addressing similar issues in upstream 3rd party code is out of scope of this > PR. Such changes will be picked up from their upstream sources. Brent Chr

Re: RFR: 8253497: Core Libs Terminology Refresh [v2]

2020-12-15 Thread Brent Christian
On Tue, 15 Dec 2020 22:02:00 GMT, Lance Andersen wrote: >> test/jdk/java/lang/ClassLoader/Assert.java line 65: >> >>> 63: >>> 64: int switchSource = 0; >>> 65: if (args.length == 0) { // This is the coordinator version >> >> Perhaps s/coordinator/controller/? > > Let's change i

Re: RFR: 8253497: Core Libs Terminology Refresh [v2]

2020-12-15 Thread Brent Christian
On Tue, 15 Dec 2020 07:32:12 GMT, Alan Bateman wrote: >> Brent Christian has updated the pull request incrementally with one >> additional commit since the last revision: >> >> updates, per code review > > test/jdk/java/nio/channels/SocketChannel/CloseRegistered

Re: RFR: 8253497: Core Libs Terminology Refresh [v2]

2020-12-14 Thread Brent Christian
. blacklist -> filter or reject > 3. whitelist -> allow or accept > 4. master -> coordinator > 5. slave -> worker > > Addressing similar issues in upstream 3rd party code is out of scope of this > PR. Such changes will be picked up from their upstream sources. Brent Chr

Re: RFR: 8253497: Core Libs Terminology Refresh

2020-12-14 Thread Brent Christian
On Mon, 14 Dec 2020 21:08:35 GMT, Joe Wang wrote: >> This is part of an effort in the JDK to replace archaic/non-inclusive words >> with more neutral terms (see JDK-8253315 for details). >> >> Here are the changes covering core libraries code and tests. Terms were >> changed as follows: >> 1.

RFR: 8253497: Core Libs Terminology Refresh

2020-12-14 Thread Brent Christian
This is part of an effort in the JDK to replace archaic/non-inclusive words with more neutral terms (see JDK-8253315 for details). Here are the changes covering core libraries code and tests. Terms were changed as follows: 1. grandfathered -> legacy 2. blacklist -> filter or reject 3. whitelist

Re: RFR: 8221503: vmTestbase/nsk/jdb/eval/eval001/eval001.java failes with: com.sun.jdi.InvalidTypeException: Can't assign double[][][] to double[][][]

2019-06-21 Thread Brent Christian
Hi, Egor On 6/20/19 8:49 AM, Alan Bateman wrote: On 20/06/2019 15:49, Egor Ushakov wrote: any news on https://bugs.openjdk.java.net/browse/JDK-8212117? I do not see any activity on this :( > cc'ing Brent as he has picked up this issue. I think we want to fix this and David has a patch in one

Re: RFR 12 : 8072130 : java/lang/instrument/BootClassPath/BootClassPathTest.sh fails on Mac OSX

2018-09-18 Thread Brent Christian
Any thoughts on this change? -B On 9/11/18 3:41 PM, Brent Christian wrote: Hi, Please review this change to how the platform encoding is determined on Mac when loading agents. Webrev: http://cr.openjdk.java.net/~bchristi/8072130/webrev.01.cleanned/ Additional details in the bug report

Re: RFR(XS) : 8210779 : 8182404 and 8210732 haven't updated copyright years

2018-09-14 Thread Brent Christian
Looks like you got them all - reviewed. -Brent On 09/14/2018 04:09 PM, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8210779/webrev.00/index.html 36 lines changed: 0 ins; 0 del; 36 mod; Hi all, could you please review this small and trivial follow-up fix for 8182404 and 821073

RFR 12 : 8072130 : java/lang/instrument/BootClassPath/BootClassPathTest.sh fails on Mac OSX

2018-09-11 Thread Brent Christian
Hi, Please review this change to how the platform encoding is determined on Mac when loading agents. Webrev: http://cr.openjdk.java.net/~bchristi/8072130/webrev.01.cleanned/ Additional details in the bug report: https://bugs.openjdk.java.net/browse/JDK-8072130 Some background: Since JDK 8, i

RFR (8u40) 8064288 : sun.management.Flag should loadLibrary()

2014-11-10 Thread Brent Christian
Please review my change for: 8064288 - sun.management.Flag should loadLibrary() JBS Issue: https://bugs.openjdk.java.net/browse/JDK-8064288 Webrev: http://cr.openjdk.java.net/~bchristi/8064288/webrev.0/ Thanks, -Brent

RFR (8u40) 8044473 : Allow for extended set of platform MXBeans

2014-06-09 Thread Brent Christian
Please review my change for: 8044473 - Allow for extended set of platform MXBeans which adds an internal ExtendedPlatformComponent mechanism. There are no new public APIs or MXBeans. JBS Issue: https://bugs.openjdk.java.net/browse/JDK-8044473 Webrev: http://cr.openjdk.java.net/~bchristi/804

Re: RFR 6835233 : Fedora 9 jdk regression test failed: java/lang/instrument/ParallelTransformerLoader.sh

2014-02-28 Thread Brent Christian
On 2/28/14 9:27 AM, Stuart Marks wrote: I guess there is some risk of adding new intermittent failures, but tackling @ignore'd tests is important too. Right - the main risk is that we will see this test fail again at some point in the future. I'll be keeping an eye out for that. Thanks for

RFR 6835233 : Fedora 9 jdk regression test failed: java/lang/instrument/ParallelTransformerLoader.sh

2014-02-26 Thread Brent Christian
File under "chipping away at test stabilization issues." https://bugs.openjdk.java.net/browse/JDK-6835233 I've done some repeated runs of this test on my Linux machine. The test fails every time with 6u3. It fails intermittently on 7 (after 145 iterations for 7u45, and 62 iterations for 7u60