On Fri, 15 Oct 2021 18:31:26 GMT, Coleen Phillimore wrote:
>> Daniel D. Daugherty has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8249004.cr1.patch
>
> This has more moving pieces than the last ve
> A fix to reduce ThreadsListHandle overhead in relation to handshakes and
> we add sanity checks for ThreadsListHandles higher in the call stack.
>
> This fix was tested with Mach5 Tier[1-8]; Tier8 is still running.
Daniel D. Daugherty has updated the pull request incrementa
On Tue, 2 Nov 2021 16:34:26 GMT, Daniel D. Daugherty wrote:
> A trivial fix to ProblemList
> vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption/TestDescription.java
This pull request has now been integrated.
Changeset: 01105d69
Author:Daniel D. Daughert
On Tue, 2 Nov 2021 16:47:08 GMT, Brian Burkhalter wrote:
>> A trivial fix to ProblemList
>> vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption/TestDescription.java
>
> Marked as reviewed by bpb (Reviewer).
@bplb - Thanks for the fast review.
-
PR:
A trivial fix to ProblemList
vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption/TestDescription.java
-
Commit messages:
- 8276367: ProblemList
vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption/TestDescription.java
Changes:
On Mon, 1 Nov 2021 01:55:48 GMT, David Holmes wrote:
>> U... The purpose of the new `is_exiting()` check and the baseline's
>> `ThreadsListHandle::includes()` check is to avoid making this call:
>>
>> return this->handshake_state()->suspend();
>>
>> The call we are avoiding is the one
On Sat, 16 Oct 2021 15:58:21 GMT, Daniel D. Daugherty
wrote:
>> The `NULL` target thread being passed in is actually handled by the baseline
>> code:
>>
>>
>> ThreadsListHandle tlh;
>> if (tlh.includes(target)) {
>>
>>
>> `tlh.in
On Fri, 29 Oct 2021 22:16:17 GMT, Daniel D. Daugherty
wrote:
>> While the name is somewhat ungainly - and unnecessarily detailed given
>> `is_JavaThread_protected` has a similar constraint - it should be a static
>> function as given because it must only be called on
> A fix to reduce ThreadsListHandle overhead in relation to handshakes and
> we add sanity checks for ThreadsListHandles higher in the call stack.
>
> This fix was tested with Mach5 Tier[1-8]; Tier8 is still running.
Daniel D. Daugherty has updated the pull request with a new tar
macOS12 has changed the dladdr() function to accept "-1" as a valid address and
we have functions that use dladdr() to convert DLL addresses into function or
library names. We also have a gtest that verifies that "-1" is not a valid
value to use
as a symbol address.
As you might imagine,
On Sun, 17 Oct 2021 12:52:15 GMT, David Holmes wrote:
>> On rereading all of these comments and the current baseline code, I have
>> to clarify one thing:
>>
>> There is a minor change in behavior caused by switching from a
>> `ThreadsListHandle::includes()` check to a
On Sun, 17 Oct 2021 12:45:59 GMT, David Holmes wrote:
>> I modeled the new check after the existing:
>>
>>
>> bool Thread::is_JavaThread_protected(const JavaThread* p) {
>>
>>
>> which is also a static function.
>
> While the name is somewhat ungainly - and unnecessarily detailed given
>
On Mon, 18 Oct 2021 17:58:25 GMT, Daniel D. Daugherty
wrote:
> This reverts commit 31500692d1503cb73249e0425e693049258a.
This pull request has now been integrated.
Changeset: a03119ce
Author: Daniel D. Daugherty
URL:
https://git.openjdk.java.net/jdk/com
On Mon, 18 Oct 2021 18:14:16 GMT, Markus Grönlund wrote:
>> This reverts commit 31500692d1503cb73249e0425e693049258a.
>
> Thanks for creating the backout Dan, looks good.
@mgronlun - Thanks for the fast review!
-
PR: https://git.openjdk.java.net/jdk/pull/5994
This reverts commit 31500692d1503cb73249e0425e693049258a.
-
Commit messages:
- JDK-8275436 [BACKOUT] JDK-8271949 dumppath in -XX:FlightRecorderOptions does
not affect
Changes: https://git.openjdk.java.net/jdk/pull/5994/files
Webrev:
On Fri, 15 Oct 2021 22:19:15 GMT, Daniel D. Daugherty
wrote:
>> So suspend_thread and resume thread's caller already takes a
>> ThreadsListHandle so this is unnecessary and never happens.
>
>> This seems an unrelated change in behaviour ??
>
> Actually this is eq
On Fri, 15 Oct 2021 21:58:38 GMT, Daniel D. Daugherty
wrote:
>> src/hotspot/share/runtime/handshake.cpp line 358:
>>
>>> 356: bool target_is_dead = false;
>>> 357: if (target == nullptr) {
>>> 358: target_is_dead = true;
>>
>> W
> A fix to reduce ThreadsListHandle overhead in relation to handshakes and
> we add sanity checks for ThreadsListHandles higher in the call stack.
>
> This fix was tested with Mach5 Tier[1-8]; Tier8 is still running.
Daniel D. Daugherty has updated the pull request incrementa
On Fri, 15 Oct 2021 06:54:10 GMT, David Holmes wrote:
> This looks promising but I'm unclear on some of the details. I can't quite
> work out
> the criteria for deciding when to pass the TLH through to Handshake::execute.
> If
> it is passed through then the target is checked for being alive
> A fix to reduce ThreadsListHandle overhead in relation to handshakes and
> we add sanity checks for ThreadsListHandles higher in the call stack.
>
> This fix was tested with Mach5 Tier[1-8]; Tier8 is still running.
Daniel D. Daugherty has updated the pull request incrementa
On Fri, 15 Oct 2021 18:27:43 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/runtime/thread.cpp line 1771:
>>
>>> 1769: guarantee(Thread::is_JavaThread_protected_by_my_ThreadsList(this),
>>> 1770: "missing ThreadsListHandle in calling context.");
>>> 1771: if (is_exiting()) {
On Fri, 15 Oct 2021 18:20:12 GMT, Coleen Phillimore wrote:
>> Daniel D. Daugherty has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8249004.cr1.patch
>
> src/hotspot/share/runtime/handshake.cpp line 358:
&g
On Fri, 15 Oct 2021 06:34:42 GMT, David Holmes wrote:
>> Daniel D. Daugherty has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8249004.cr1.patch
>
> src/hotspot/share/prims/jvmtiEventController.cpp line 623
On Sun, 4 Jul 2021 23:39:00 GMT, David Holmes wrote:
>> A fix to reduce ThreadsListHandle overhead in relation to handshakes and
>> we add sanity checks for ThreadsListHandles higher in the call stack.
>>
>> This fix was tested with Mach5 Tier[1-8]; Tier8 is still running.
>
> Hi Dan,
>
> I
> A fix to reduce ThreadsListHandle overhead in relation to handshakes and
> we add sanity checks for ThreadsListHandles higher in the call stack.
>
> This fix was tested with Mach5 Tier[1-8]; Tier8 is still running.
Daniel D. Daugherty has updated the pull request incrementa
On Fri, 30 Jul 2021 20:20:48 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to support JFR use of new ThreadsList::Iterator.
>
> This fix was tested with Mach5 Tier[1-3].
This pull request has now been integrated.
Changeset: 8657f776
Author: Daniel D. Daugherty
URL:
On Wed, 4 Aug 2021 22:57:40 GMT, Serguei Spitsyn wrote:
>> Daniel D. Daugherty has updated the pull request with a new target base due
>> to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull requ
On Wed, 22 Sep 2021 03:57:21 GMT, Daniel D. Daugherty
wrote:
>> A trivial fix to reduce ThreadListHandle overhead in relation to handshakes.
>>
>> This refactoring was tested with Mach5 Tier[1-3].
>
> Daniel D. Daugherty has updated the pull request with a new targe
> A trivial fix to reduce ThreadListHandle overhead in relation to handshakes.
>
> This refactoring was tested with Mach5 Tier[1-3].
Daniel D. Daugherty has updated the pull request with a new target base due to
a merge or a rebase. The incremental webrev excludes the unrelated changes
> A trivial fix to support JFR use of new ThreadsList::Iterator.
>
> This fix was tested with Mach5 Tier[1-3].
Daniel D. Daugherty has updated the pull request with a new target base due to
a merge or a rebase. The pull request now contains 14 commits:
- Merge branch 'master' into JD
On Wed, 22 Sep 2021 03:56:25 GMT, Daniel D. Daugherty
wrote:
>> A trivial fix to support JFR use of new ThreadsList::Iterator.
>>
>> This fix was tested with Mach5 Tier[1-3].
>
> Daniel D. Daugherty has updated the pull request with a new target base due
> to a
On Mon, 11 Oct 2021 12:40:31 GMT, Lin Zang wrote:
>> The root cause for the fail is that there must be a flush for
>> `BufferedOutputStream` before getting the `pos` of the file, otherwise the
>> data length is wrongly calculated.
>
> Lin Zang has updated the pull request incrementally with
On Mon, 11 Oct 2021 12:40:31 GMT, Lin Zang wrote:
>> The root cause for the fail is that there must be a flush for
>> `BufferedOutputStream` before getting the `pos` of the file, otherwise the
>> data length is wrongly calculated.
>
> Lin Zang has updated the pull request incrementally with
On Wed, 6 Oct 2021 23:27:17 GMT, Coleen Phillimore wrote:
> Also fixes: 8273956: Add checking for rank values
>
> This change does 3 things. I could separate them but this has all been
> tested together and most of the change is mechanical. The first is a simple
> rename of nonleaf =>
On Wed, 6 Oct 2021 23:27:17 GMT, Coleen Phillimore wrote:
> 8273956: Add checking for rank values
>
> This change does 3 things. I could separate them but this has all been
> tested together and most of the change is mechanical. The first is a simple
> rename of nonleaf => safepoint. The
On Tue, 5 Oct 2021 21:39:52 GMT, Daniel D. Daugherty wrote:
> A trivial fix to ProblemList
> resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java
> on macosx-x64.
This pull request has now been integrated.
Changeset: d4e8712c
Author: Daniel D. Daugherty
URL:
On Tue, 5 Oct 2021 21:44:40 GMT, Joe Darcy wrote:
>> A trivial fix to ProblemList
>> resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java
>> on macosx-x64.
>
> Marked as reviewed by darcy (Reviewer).
@jddarcy - Thanks for the fast review!
-
PR:
A trivial fix to ProblemList
resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java
on macosx-x64.
-
Commit messages:
- 8274797: ProblemList
resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java on macosx-x64
Changes:
On Sat, 25 Sep 2021 03:54:19 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList 2 serviceability/dcmd/gc tests with ZGC on
> macOS-all.
This pull request has now been integrated.
Changeset: ab28db14
Author:Daniel D. Daugherty
URL:
https://git.openjdk.java.n
On Sat, 25 Sep 2021 11:17:23 GMT, David Holmes wrote:
>> Daniel D. Daugherty has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8274313: ProblemList sun/tools/jmap/BasicJMapTest.java subtests
>
> tes
On Sat, 25 Sep 2021 05:24:07 GMT, Thomas Stuefe wrote:
>> Daniel D. Daugherty has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8274313: ProblemList sun/tools/jmap/BasicJMapTest.java subtests
>
> Loo
> A trivial fix to ProblemList 2 serviceability/dcmd/gc tests with ZGC on
> macOS-all.
Daniel D. Daugherty has updated the pull request incrementally with one
additional commit since the last revision:
8274313: ProblemList sun/tools/jmap/BasicJMapTest.java subtests
-
C
A trivial fix to ProblemList 2 serviceability/dcmd/gc tests with ZGC on
macOS-all.
-
Commit messages:
- 8274312: ProblemList 2 serviceability/dcmd/gc tests with ZGC on macos-all
Changes: https://git.openjdk.java.net/jdk/pull/5691/files
Webrev:
On Fri, 24 Sep 2021 15:37:13 GMT, Roger Riggs wrote:
>> A trivial fix to ProblemList sun/tools/jmap/BasicJMapTest.java.
>
> Marked as reviewed by rriggs (Reviewer).
@RogerRiggs - Thanks for the fast review!
-
PR: https://git.openjdk.java.net/jdk/pull/5685
A trivial fix to ProblemList sun/tools/jmap/BasicJMapTest.java.
-
Commit messages:
- 8274294: ProblemList sun/tools/jmap/BasicJMapTest.java
Changes: https://git.openjdk.java.net/jdk/pull/5685/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=5685=00
Issue:
On Fri, 24 Sep 2021 15:34:18 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList sun/tools/jmap/BasicJMapTest.java.
This pull request has now been integrated.
Changeset: 0c050be6
Author: Daniel D. Daugherty
URL:
https://git.openjdk.java.net/jdk/com
On Fri, 24 Sep 2021 13:13:39 GMT, Lin Zang wrote:
> The root cause for crash in ZGC is that the JNIHandles are processed before
> object iteration. And ZGC would update the JNIHandles at object iteration
> with read barrier. So the crash is cause by accessing the invalid address
> which can
On Thu, 23 Sep 2021 16:45:30 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList 2 serviceability/dcmd/gc tests with ZGC on
> linux-all and windows-all.
This pull request has now been integrated.
Changeset: 0aa63fec
Author:Daniel D. Daugherty
URL:
On Thu, 23 Sep 2021 17:01:14 GMT, Thomas Schatzl wrote:
>> A trivial fix to ProblemList 2 serviceability/dcmd/gc tests with ZGC on
>> linux-all and windows-all.
>
> Marked as reviewed by tschatzl (Reviewer).
@tschatzl - Thanks for the fast review!
-
PR:
On Thu, 23 Sep 2021 16:58:58 GMT, Joe Darcy wrote:
>> A trivial fix to ProblemList 2 serviceability/dcmd/gc tests with ZGC on
>> linux-all and windows-all.
>
> Marked as reviewed by darcy (Reviewer).
@jddarcy - Thanks for the fast review!
-
PR:
A trivial fix to ProblemList 2 serviceability/dcmd/gc tests with ZGC on
linux-all and windows-all.
-
Commit messages:
- 8274216: ProblemList 2 serviceability/dcmd/gc tests with ZGC on linux-all
and windows-all
Changes: https://git.openjdk.java.net/jdk/pull/5657/files
Webrev:
On Wed, 22 Sep 2021 18:21:51 GMT, Coleen Phillimore wrote:
>> Daniel D. Daugherty has updated the pull request with a new target base due
>> to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull req
> A trivial fix to reduce ThreadListHandle overhead in relation to handshakes.
>
> This refactoring was tested with Mach5 Tier[1-3].
Daniel D. Daugherty has updated the pull request with a new target base due to
a merge or a rebase. The incremental webrev excludes the unrelated changes
> A trivial fix to support JFR use of new ThreadsList::Iterator.
>
> This fix was tested with Mach5 Tier[1-3].
Daniel D. Daugherty has updated the pull request with a new target base due to
a merge or a rebase. The pull request now contains 13 commits:
- Merge branch 'master' into JD
On Wed, 22 Sep 2021 02:33:41 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList serviceability/sa/TestJhsdbJstackMixed.java on
> linux-aarch64 in -Xcomp mode.
This pull request has now been integrated.
Changeset: eeaf43b2
Author:Daniel D. Daugherty
URL:
On Wed, 22 Sep 2021 02:47:47 GMT, Chris Plummer wrote:
>> A trivial fix to ProblemList serviceability/sa/TestJhsdbJstackMixed.java on
>> linux-aarch64 in -Xcomp mode.
>
> Approved and trivial.
@plummercj - Thanks for the fast review!
-
PR:
A trivial fix to ProblemList serviceability/sa/TestJhsdbJstackMixed.java on
linux-aarch64 in -Xcomp mode.
-
Commit messages:
- 8274114: ProblemList serviceability/sa/TestJhsdbJstackMixed.java on
linux-aarch64 in -Xcomp mode
Changes:
On Thu, 19 Aug 2021 21:18:53 GMT, Leonid Mesnik wrote:
> monitors_iterate make several checks which often are true before filter
> monitor by a thread. It might take a lot of time when there are a lot of
> threads. So it makes sense to first check thread and only then other
> conditions.
On Fri, 3 Sep 2021 01:26:01 GMT, Daniel D. Daugherty wrote:
>> monitors_iterate make several checks which often are true before filter
>> monitor by a thread. It might take a lot of time when there are a lot of
>> threads. So it makes sense to first check thread a
On Wed, 8 Sep 2021 02:07:47 GMT, David Holmes wrote:
>> A trivial fix to bump the timeout value for the second sub-test in
>> jfr/api/consumer/TestRecordedFrame.java. See the bug report
>> for the gory details.
>
> LGTM!
>
> Thanks,
> David
@dholmes-ora - Thanks for the lightning fast review!
On Wed, 8 Sep 2021 02:04:50 GMT, Daniel D. Daugherty wrote:
> A trivial fix to bump the timeout value for the second sub-test in
> jfr/api/consumer/TestRecordedFrame.java. See the bug report
> for the gory details.
This pull request has now been integrated.
Changeset: ea4907
A trivial fix to bump the timeout value for the second sub-test in
jfr/api/consumer/TestRecordedFrame.java. See the bug report
for the gory details.
-
Commit messages:
- 8273047: test jfr/api/consumer/TestRecordedFrame.java timing out
Changes:
On Thu, 19 Aug 2021 21:18:53 GMT, Leonid Mesnik wrote:
> monitors_iterate make several checks which often are true before filter
> monitor by a thread. It might take a lot of time when there are a lot of
> threads. So it makes sense to first check thread and only then other
> conditions.
On Wed, 1 Sep 2021 17:35:12 GMT, Naoto Sato wrote:
>> A trivial fix to ProblemList
>> java/lang/instrument/BootClassPath/BootClassPathTest.sh on all configs.
>
> Marked as reviewed by naoto (Reviewer).
@naotoj - Thanks for the review!
-
PR:
On Wed, 1 Sep 2021 17:33:13 GMT, Daniel D. Daugherty wrote:
> A trivial fix to ProblemList
> java/lang/instrument/BootClassPath/BootClassPathTest.sh on all configs.
This pull request has now been integrated.
Changeset: 4ee0dace
Author:Daniel D. Daugherty
URL:
On Tue, 31 Aug 2021 20:02:37 GMT, Naoto Sato wrote:
>> Trivial fixes to reduce the noise in the JDK18 CI:
>> JDK-8273197 ProblemList 2 jtools tests due to JDK-8273187
>> JDK-8273198 ProblemList
>> java/lang/instrument/BootClassPath/BootClassPathTest.sh due to JDK-8273188
>>
>> These failures
A trivial fix to ProblemList
java/lang/instrument/BootClassPath/BootClassPathTest.sh on all configs.
-
Commit messages:
- 8273248: ProblemList java/lang/instrument/BootClassPath/BootClassPathTest.sh
on all configs
Changes: https://git.openjdk.java.net/jdk/pull/5337/files
Webrev:
On Tue, 31 Aug 2021 19:44:08 GMT, Daniel D. Daugherty
wrote:
> Trivial fixes to reduce the noise in the JDK18 CI:
> JDK-8273197 ProblemList 2 jtools tests due to JDK-8273187
> JDK-8273198 ProblemList
> java/lang/instrument/BootClassPath/BootClassPathTest.sh due to
Trivial fixes to reduce the noise in the JDK18 CI:
JDK-8273197 ProblemList 2 jtools tests due to JDK-8273187
JDK-8273198 ProblemList java/lang/instrument/BootClassPath/BootClassPathTest.sh
due to JDK-8273188
These failures happen in Tier5 so I'm ProblemListing them now to give @naotoj
time to
> A trivial fix to reduce ThreadListHandle overhead in relation to handshakes.
>
> This refactoring was tested with Mach5 Tier[1-3].
Daniel D. Daugherty has updated the pull request with a new target base due to
a merge or a rebase. The incremental webrev excludes the unrelated changes
> A trivial fix to support JFR use of new ThreadsList::Iterator.
>
> This fix was tested with Mach5 Tier[1-3].
Daniel D. Daugherty has updated the pull request with a new target base due to
a merge or a rebase. The pull request now contains 12 commits:
- Merge branch 'master' into JD
On Wed, 4 Aug 2021 13:57:25 GMT, Yasumasa Suenaga wrote:
> We saw some failures of TestJmapCore.java, and we need more time to fix it.
> So we should add it to ProblemList-zgc.
Thumbs up. This is a trivial fix.
-
Marked as reviewed by dcubed (Reviewer).
PR:
> A trivial fix to support JFR use of new ThreadsList::Iterator.
>
> This fix was tested with Mach5 Tier[1-3].
Daniel D. Daugherty has updated the pull request with a new target base due to
a merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by
A trivial fix to support JFR use of new ThreadsList::Iterator.
This fix was tested with Mach5 Tier[1-3].
-
Depends on: https://git.openjdk.java.net/jdk/pull/4948
Commit messages:
- Merge branch 'pull/4948' into JDK-8271514
- 8271514: support JFR use of new ThreadsList::Iterator
On Thu, 29 Jul 2021 19:40:35 GMT, Chris Plummer wrote:
> These tests recently started failing frequently with ZGC
Also, this is a trivial fix.
-
PR: https://git.openjdk.java.net/jdk17/pull/294
On Thu, 29 Jul 2021 20:11:54 GMT, Chris Plummer wrote:
>> [JDK-8267666](https://bugs.openjdk.java.net/browse/JDK-8267666) added a 2nd
>> test case, which doubles the run time of this test. As a result it
>> occasionally times out. This change double the timeout to 240 seconds.
>
> Chris
On Thu, 29 Jul 2021 20:03:28 GMT, Chris Plummer wrote:
> This test currently doesn't fail because it is skipped, but JDK-8270199 is
> fixed (which causes SA tests to be erroneously skipped skipped), we will
> start to see failures due to JDK-8270326, so DebugdConnectTest.java needs to
> be
On Thu, 29 Jul 2021 20:11:54 GMT, Chris Plummer wrote:
>> [JDK-8267666](https://bugs.openjdk.java.net/browse/JDK-8267666) added a 2nd
>> test case, which doubles the run time of this test. As a result it
>> occasionally times out. This change double the timeout to 240 seconds.
>
> Chris
On Thu, 29 Jul 2021 20:04:40 GMT, Chris Plummer wrote:
>> test/hotspot/jtreg/ProblemList-zgc.txt line 46:
>>
>>> 44: serviceability/sa/TestJhsdbJstackMixed.java 8248912
>>> generic-all
>>> 45: serviceability/sa/ClhsdbPstack.java#id0 8248912
>>>
On Thu, 29 Jul 2021 19:40:35 GMT, Chris Plummer wrote:
> These tests recently started failing frequently with ZGC
Marked as reviewed by dcubed (Reviewer).
-
PR: https://git.openjdk.java.net/jdk17/pull/294
On Thu, 29 Jul 2021 19:50:20 GMT, Chris Plummer wrote:
> [JDK-8267666](https://bugs.openjdk.java.net/browse/JDK-8267666) added a 2nd
> test case, which doubles the run time of this test. As a result it
> occasionally times out. This change double the timeout to 240 seconds.
Changes requested
On Thu, 29 Jul 2021 19:40:35 GMT, Chris Plummer wrote:
> These tests recently started failing frequently with ZGC
Marked as reviewed by dcubed (Reviewer).
test/hotspot/jtreg/ProblemList-zgc.txt line 46:
> 44: serviceability/sa/TestJhsdbJstackMixed.java 8248912
>
> A trivial fix to reduce ThreadListHandle overhead in relation to handshakes.
>
> This refactoring was tested with Mach5 Tier[1-3].
Daniel D. Daugherty has updated the pull request with a new target base due to
a merge or a rebase. The incremental webrev excludes the unrelated changes
On Wed, 28 Jul 2021 08:38:04 GMT, Yi Yang wrote:
>> For hotspot changes, it would be better to have a second review & wait for
>> 24 hours before integration.
>> Thanks.
>
>> For hotspot changes, it would be better to have a second review & wait for
>> 24 hours before integration.
>> Thanks.
On Wed, 28 Jul 2021 10:03:10 GMT, David Holmes wrote:
> If a thread is attaching via JNI and has not yet created its Thread object it
> can be caught in a ThreadSnapshot during a thread dump (VM_DumpThreads) of
> all threads**, and the threadObj() will be NULL, so we can't pass it to
>
On Thu, 22 Jul 2021 23:50:56 GMT, Joe Darcy wrote:
>> Trivial fixes:
>> JDK-8271165 ProblemList serviceability/dcmd/gc/HeapDumpAllTest.java on X64
>> JDK-8271166 ProblemList applications/jcstress/copy.java on Linux-X64
>
> Marked as reviewed by darcy (Reviewer).
@jddarcy - Thanks for the fast
On Thu, 22 Jul 2021 21:51:30 GMT, Daniel D. Daugherty
wrote:
> Trivial fixes:
> JDK-8271165 ProblemList serviceability/dcmd/gc/HeapDumpAllTest.java on X64
> JDK-8271166 ProblemList applications/jcstress/copy.java on Linux-X64
This pull request has now been integrated.
Changeset:
Trivial fixes:
JDK-8271165 ProblemList serviceability/dcmd/gc/HeapDumpAllTest.java on X64
JDK-8271166 ProblemList applications/jcstress/copy.java on Linux-X64
-
Commit messages:
- 8271166: ProblemList applications/jcstress/copy.java on Linux-X64
- 8271165: ProblemList
On Thu, 8 Jul 2021 19:11:45 GMT, Serguei Spitsyn wrote:
> The fix of:
>8252657 JVMTI agent is not unloaded when Agent_OnAttach is failed
> did not update the JVM TI spec history at the end of document.
> This PR adds missed item to the JVM TI spec history.
Thumbs up. This looks like a
On Thu, 8 Jul 2021 19:21:20 GMT, Mikael Vidstedt wrote:
>> A trivial fix to ProblemList 4 SA tests on macOS-aarch64
>
> Marked as reviewed by mikael (Reviewer).
@vidmik - Thanks for the fast review!
-
PR: https://git.openjdk.java.net/jdk17/pull/234
On Thu, 8 Jul 2021 19:17:53 GMT, Daniel D. Daugherty wrote:
> A trivial fix to ProblemList 4 SA tests on macOS-aarch64
This pull request has now been integrated.
Changeset: 9acb2a69
Author: Daniel D. Daugherty
URL:
https://git.openjdk.java.net/jdk17/com
A trivial fix to ProblemList 4 SA tests on macOS-aarch64
-
Commit messages:
- 8270109: ProblemList 4 SA tests on macOS-aarch64
Changes: https://git.openjdk.java.net/jdk17/pull/234/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk17=234=00
Issue:
On Wed, 7 Jul 2021 13:58:59 GMT, Daniel D. Daugherty wrote:
> A trivial fix to ProblemList jdk/jfr/event/oldobject/TestObjectSize.java on
> macOS-x64.
This pull request has now been integrated.
Changeset: 2209e3ec
Author:Daniel D. Daugherty
URL:
https://git.openjdk.java.n
A trivial fix to ProblemList jdk/jfr/event/oldobject/TestObjectSize.java on
macOS-x64.
-
Commit messages:
- 8270027: ProblemList jdk/jfr/event/oldobject/TestObjectSize.java on macOS-x64
Changes: https://git.openjdk.java.net/jdk/pull/4709/files
Webrev:
On Wed, 7 Jul 2021 14:02:45 GMT, Markus Grönlund wrote:
>> A trivial fix to ProblemList jdk/jfr/event/oldobject/TestObjectSize.java on
>> macOS-x64.
>
> Marked as reviewed by mgronlun (Reviewer).
@mgronlun - Thanks for the fast review!
-
PR:
A trivial fix to reduce ThreadListHandle overhead in relation to handshakes.
This refactoring was tested with Mach5 Tier[1-3].
-
Commit messages:
- 8249004: Reduce ThreadListHandle overhead in relation to direct handshakes
Changes: https://git.openjdk.java.net/jdk/pull/4677/files
On Fri, 2 Jul 2021 07:03:50 GMT, David Holmes wrote:
> Please review this simple refactoring to share the common code used to create
> j.l.Thread instances for the internal VM JavaThreads. (Also fix a missing
> space from my previous change in thread.cpp.)
>
> It is all very straight-forward.
On Thu, 1 Jul 2021 04:18:28 GMT, David Holmes wrote:
>> Please see the JBS issue for more details, but basically we have 8 different
>> kinds of internal VM JavaThreads (grouping the three types of CompilerThread
>> together) that all basically duplicated the logic for initializing
>>
On Wed, 30 Jun 2021 21:21:43 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList
> vmTestbase/nsk/jvmti/scenarios/sampling/SP07/sp07t002/TestDescription.java
> on Windows-X64 with -Xcomp.
This pull request has now been integrated.
Changeset: aba6c55d
Author: Daniel D.
On Wed, 30 Jun 2021 21:21:43 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList
> vmTestbase/nsk/jvmti/scenarios/sampling/SP07/sp07t002/TestDescription.java
> on Windows-X64 with -Xcomp.
Cool. I typo'ed the "/integrate" and then edited it. The c
101 - 200 of 1650 matches
Mail list logo
