On Wed, 30 Mar 2022 15:09:08 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList containers/docker/TestJcmd.java on linux-x64.
LGTM
and is trivial.
-
Marked as reviewed by hseigel (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/8042
On Wed, 9 Feb 2022 16:20:49 GMT, Emanuel Peter wrote:
>> Deprecated ExtendedDTraceProbes.
>> Edited help messages and man pages accordingly, added the 3 flags to man
>> pages.
>> Added flag to VMDeprecatedOptions test.
>> Replaced the flag with 3 flags in SDTProbesGNULinuxTest.java.
>>
>> Check
On Fri, 28 Jan 2022 01:53:09 GMT, Ioi Lam wrote:
> The discussion of CDS in the man pages need to be cleaned up and updated to
> match the latest functionalities and intended usage.
>
> For java.md:
>
> - Reorganized the flow of the doc: Overview -> How to use -> How to create ->
> Restricti
On Thu, 16 Dec 2021 17:33:29 GMT, Harold Seigel wrote:
> Please review this fix for JDK-8225093 to set the default value of property
> jdk.boot.class.path.append to NULL instead of "". This fix was tested by
> running Mach5 tiers 1-2 on Linux, Mac OS, and Windows, and
On Mon, 20 Dec 2021 18:36:45 GMT, Harold Seigel wrote:
>> Please review this fix for JDK-8225093 to set the default value of property
>> jdk.boot.class.path.append to NULL instead of "". This fix was tested by
>> running Mach5 tiers 1-2 on Linux, Mac OS, and
On Mon, 20 Dec 2021 18:36:45 GMT, Harold Seigel wrote:
>> Please review this fix for JDK-8225093 to set the default value of property
>> jdk.boot.class.path.append to NULL instead of "". This fix was tested by
>> running Mach5 tiers 1-2 on Linux, Mac OS, and
On Mon, 20 Dec 2021 17:33:58 GMT, Alan Bateman wrote:
>> Harold Seigel has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix test
>
> test/hotspot/jtreg/runtime/BootClassAppendProp/libGetBootClassPathApp
by running the agent.c example in
> JDK-8224791.
>
> Thanks! Harold
Harold Seigel has updated the pull request incrementally with one additional
commit since the last revision:
Add error code to test failure message
-
Changes:
- all: https://git.openjdk.java.net/jdk
On Fri, 17 Dec 2021 02:18:55 GMT, David Holmes wrote:
>> Harold Seigel has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix test
>
> test/hotspot/jtreg/runtime/BootClassAppendProp/GetBootClassPathAppend
On Fri, 17 Dec 2021 03:17:23 GMT, Serguei Spitsyn wrote:
>> Harold Seigel has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix test
>
> test/hotspot/jtreg/runtime/BootClassAppendProp/GetBootClassPathAppend
On Thu, 16 Dec 2021 17:33:29 GMT, Harold Seigel wrote:
> Please review this fix for JDK-8225093 to set the default value of property
> jdk.boot.class.path.append to NULL instead of "". This fix was tested by
> running Mach5 tiers 1-2 on Linux, Mac OS, and Windows, and
by running the agent.c example in
> JDK-8224791.
>
> Thanks! Harold
Harold Seigel has updated the pull request incrementally with one additional
commit since the last revision:
fix test
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/6868/files
- new: https:
Please review this fix for JDK-8225093 to set the default value of property
jdk.boot.class.path.append to NULL instead of "". This fix was tested by
running Mach5 tiers 1-2 on Linux, Mac OS, and Windows, and Mach5 tiers 3-5 on
Linux x64. The fix was also tested by running the agent.c example i
On Tue, 14 Dec 2021 17:42:00 GMT, Coleen Phillimore wrote:
>> This change makes VM_Version_Ext part of VM_Version (the platform dependent
>> part) and moves some duplicated code. x86 had the most code in
>> VM_Version_Ext, so the most code moved there. There might be some unneeded
>> function
On Fri, 10 Dec 2021 15:01:29 GMT, Harold Seigel wrote:
> Please review this change to obsolete deprecated CDS options UseSharedSpaces,
> RequireSharedSpaces, DynamicDumpSharedSpaces, and DumpSharedSpaces. The
> change was tested by running Mach5 tiers 1-2 on Linux, Mac OS, and Windo
On Fri, 10 Dec 2021 19:49:48 GMT, Harold Seigel wrote:
>> Please review this change to obsolete deprecated CDS options
>> UseSharedSpaces, RequireSharedSpaces, DynamicDumpSharedSpaces, and
>> DumpSharedSpaces. The change was tested by running Mach5 tiers 1-2 on
>> Li
On Fri, 10 Dec 2021 19:37:31 GMT, Calvin Cheung wrote:
>> Harold Seigel has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix print_debug() message
>
> src/jdk.hotspot.agent/share/native/libsaproc/ps_cor
64.
>
> The use of UseSharedSpaces in ps_core_common.c was tested on Mac OS x64 by
> temporarily removing serviceability/sa/ClhsdbPmap.java#core from the problem
> list.
>
> Thanks! Harold
Harold Seigel has updated the pull request incrementally with one additional
commit s
Please review this change to obsolete deprecated CDS options UseSharedSpaces,
RequireSharedSpaces, DynamicDumpSharedSpaces, and DumpSharedSpaces. The change
was tested by running Mach5 tiers 1-2 on Linux, Mac OS, and Windows and Mach5
tiers 3-5 on Linux x64 and Windows x64.
The use of UseShare
On Tue, 2 Nov 2021 19:25:40 GMT, Leo Korinth wrote:
>> HeapDumper does a lot of unneeded casts. Some arguments should be const.
>> Headers are not correctly sorted. Comment about identifier size on Windows
>> and Solaris is not true.
>>
>> First I cleaned up casting in the "union casting", but
On Thu, 28 Oct 2021 13:03:56 GMT, Severin Gehwolf wrote:
> Please review this change to remove some API which no longer works as
> expected as recent OCI runtimes start to drop support for `--kernel-memory`
> switch. See the bug for references. This part of the API is not present in
> hotspot
On Mon, 16 Aug 2021 17:25:57 GMT, Harold Seigel wrote:
> Please review this small fix for JDK-8272124. The fix puts a limit of 3 when
> splitting self cgroup lines by ':' so that Cgroup paths won't get truncated
> if they contain embedded ':'s. For
On Wed, 18 Aug 2021 13:04:46 GMT, Harold Seigel wrote:
>> Please review this small fix for JDK-8272124. The fix puts a limit of 3
>> when splitting self cgroup lines by ':' so that Cgroup paths won't get
>> truncated if they contain embedded ':'
On Wed, 18 Aug 2021 12:25:45 GMT, Harold Seigel wrote:
>> Please review this small fix for JDK-8272124. The fix puts a limit of 3
>> when splitting self cgroup lines by ':' so that Cgroup paths won't get
>> truncated if they contain embedded ':'
n a /proc/self/cgroup file will now result in a
> Cgroup path of "/user.sli:ce" instead of "/user.sli".
>
> The fix was tested with Mach5 tiers 1 and 2, and Mach5 tiers 3-5 on Linux x64
> and Linux aarch64.
>
> Thanks, Harold
Harold Seigel has updated the p
On Tue, 17 Aug 2021 17:39:49 GMT, Harold Seigel wrote:
>> Please review this small fix for JDK-8272124. The fix puts a limit of 3
>> when splitting self cgroup lines by ':' so that Cgroup paths won't get
>> truncated if they contain embedded ':'
n a /proc/self/cgroup file will now result in a
> Cgroup path of "/user.sli:ce" instead of "/user.sli".
>
> The fix was tested with Mach5 tiers 1 and 2, and Mach5 tiers 3-5 on Linux x64
> and Linux aarch64.
>
> Thanks, Harold
Harold Seigel has updated the p
On Tue, 17 Aug 2021 14:58:48 GMT, Mikhailo Seledtsov
wrote:
>> Please review this change that updates the buildJdkDockerImage() test
>> library API.
>>
>> This work originated while working on "8195809: [TESTBUG] jps and jcmd -l
>> support for containers is not tested".
>> The initial intent
n a /proc/self/cgroup file will now result in a
> Cgroup path of "/user.sli:ce" instead of "/user.sli".
>
> The fix was tested with Mach5 tiers 1 and 2, and Mach5 tiers 3-5 on Linux x64
> and Linux aarch64.
>
> Thanks, Harold
Harold Seigel has updated the p
On Mon, 16 Aug 2021 17:25:57 GMT, Harold Seigel wrote:
> Please review this small fix for JDK-8272124. The fix puts a limit of 3 when
> splitting self cgroup lines by ':' so that Cgroup paths won't get truncated
> if they contain embedded ':'s. For
Please review this small fix for JDK-8272124. The fix puts a limit of 3 when
splitting self cgroup lines by ':' so that Cgroup paths won't get truncated if
they contain embedded ':'s. For example, an entry of "11:memory:/user.sli:ce"
in a /proc/self/cgroup file will now result in a Cgroup path
On Wed, 23 Jun 2021 17:27:00 GMT, Coleen Phillimore wrote:
> This is somewhat trivial change to remove
> CodeCache::mark_for_evol_deoptimization() and its calling method, and nothing
> else this time.
> Ran vmTestbase/nsk/jvmti tests.
LGTM
Thanks, Harold
-
Marked as reviewed by h
On Thu, 13 May 2021 12:31:44 GMT, Harold Seigel wrote:
>> Please review this large change to remove Unsafe::defineAnonymousClass().
>> The change removes dAC relevant code and changes a lot of tests. Many of
>> the changed tests need renaming. I hope to do this in a follow
On Tue, 11 May 2021 12:50:31 GMT, Harold Seigel wrote:
> Please review this large change to remove Unsafe::defineAnonymousClass().
> The change removes dAC relevant code and changes a lot of tests. Many of the
> changed tests need renaming. I hope to do this in a follow up RFE.
On Thu, 13 May 2021 07:19:03 GMT, David Holmes wrote:
>> Harold Seigel has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix Weak hidden comment
>
> src/hotspot/share/oops/constantPool.hpp line 493:
On Wed, 12 May 2021 22:30:30 GMT, Mandy Chung wrote:
>> Harold Seigel has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> test changes and small fixes
>
> src/hotspot/share/classfile/classLoaderData.cpp
sses, others were deleted because
> either similar hidden classes tests already exist or they tested dAC specific
> functionality, such as host classes.
>
> This change was tested with Mach5 tiers 1-2 on Linux, Mac OS, and Windows,
> and Mach5 tiers 3-7 on Linux x64.
>
>
On Tue, 11 May 2021 17:07:35 GMT, Ioi Lam wrote:
>> Harold Seigel has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix GetModuleTest.java
>
> src/hotspot/share/oops/instanceMirrorKlass.inline.hpp line 65
On Tue, 11 May 2021 20:49:46 GMT, Mandy Chung wrote:
>> Harold Seigel has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix GetModuleTest.java
>
> src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.meta/sr
sses, others were deleted because
> either similar hidden classes tests already exist or they tested dAC specific
> functionality, such as host classes.
>
> This change was tested with Mach5 tiers 1-2 on Linux, Mac OS, and Windows,
> and Mach5 tiers 3-7 on Linux x64.
>
>
On Tue, 11 May 2021 14:13:49 GMT, Harold Seigel wrote:
>> Please review this large change to remove Unsafe::defineAnonymousClass().
>> The change removes dAC relevant code and changes a lot of tests. Many of
>> the changed tests need renaming. I hope to do this in a follow
classes by comparing the name
to see if it contains a slash, especially tests, but which don’t say
“anonymous”. Did you do a search for these idioms too, which are now dead
tests?
Sent from my iPad
On May 11, 2021, at 8:59 AM, Harold Seigel wrote:
Please review this large change to remove
On Tue, 11 May 2021 13:41:53 GMT, Alan Bateman wrote:
>> test/jdk/java/lang/Class/GetModuleTest.java line 42:
>>
>>> 40: import static org.testng.Assert.*;
>>> 41:
>>> 42: public class GetModuleTest {
>>
>> testGetModuleOnVMAnonymousClass is the only test here that uses ASM so you
>> can remo
sses, others were deleted because
> either similar hidden classes tests already exist or they tested dAC specific
> functionality, such as host classes.
>
> This change was tested with Mach5 tiers 1-2 on Linux, Mac OS, and Windows,
> and Mach5 tiers 3-7 on Linux x64.
>
>
sses, others were deleted because
> either similar hidden classes tests already exist or they tested dAC specific
> functionality, such as host classes.
>
> This change was tested with Mach5 tiers 1-2 on Linux, Mac OS, and Windows,
> and Mach5 tiers 3-7 on Linux x64.
>
>
Please review this large change to remove Unsafe::defineAnonymousClass(). The
change removes dAC relevant code and changes a lot of tests. Many of the
changed tests need renaming. I hope to do this in a follow up RFE. Some of
the tests were modified to use hidden classes, others were deleted
On Mon, 5 Apr 2021 17:57:13 GMT, Harold Seigel wrote:
> Please review this additional cleanup of use of TRAPS in hotspot runtime
> code. The changes were tested with Mach5 tiers 1-2 on Linux, Mac OS, and
> Windows and Mach5 tiers 3-5 on Linux x64.
>
> Thanks, Harold
This p
On Thu, 8 Apr 2021 10:10:00 GMT, David Holmes wrote:
>> Harold Seigel has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove unneeded statement
>
> Hi Harold,
>
> Updates seem fine.
>
> Tha
On Mon, 5 Apr 2021 23:15:48 GMT, David Holmes wrote:
>> Harold Seigel has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove unneeded statement
>
> src/hotspot/share/classfile/klassF
On Mon, 5 Apr 2021 23:28:38 GMT, David Holmes wrote:
>> Harold Seigel has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Undo change to ObjectSynchronizer::jni_exit()
>
> Hi Harold,
>
> Lots of go
On Mon, 5 Apr 2021 19:08:38 GMT, Patricio Chilano Mateo
wrote:
>> Harold Seigel has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove unneeded statement
>
> src/hotspot/share/runtime/synchr
> Please review this additional cleanup of use of TRAPS in hotspot runtime
> code. The changes were tested with Mach5 tiers 1-2 on Linux, Mac OS, and
> Windows and Mach5 tiers 3-5 on Linux x64.
>
> Thanks, Harold
Harold Seigel has updated the pull request incrementally with
> Please review this additional cleanup of use of TRAPS in hotspot runtime
> code. The changes were tested with Mach5 tiers 1-2 on Linux, Mac OS, and
> Windows and Mach5 tiers 3-5 on Linux x64.
>
> Thanks, Harold
Harold Seigel has updated the pull request incrementally with
On Mon, 5 Apr 2021 19:11:49 GMT, Patricio Chilano Mateo
wrote:
>> Harold Seigel has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Undo change to ObjectSynchronizer::jni_exit()
>
> Hi Harold,
&
> Please review this additional cleanup of use of TRAPS in hotspot runtime
> code. The changes were tested with Mach5 tiers 1-2 on Linux, Mac OS, and
> Windows and Mach5 tiers 3-5 on Linux x64.
>
> Thanks, Harold
Harold Seigel has updated the pull request incrementally with
Please review this additional cleanup of use of TRAPS in hotspot runtime code.
The changes were tested with Mach5 tiers 1-2 on Linux, Mac OS, and Windows and
Mach5 tiers 3-5 on Linux x64.
Thanks, Harold
-
Commit messages:
- 8264711: More runtime TRAPS cleanups
Changes: https://g
On Thu, 1 Apr 2021 16:58:00 GMT, Coleen Phillimore wrote:
> This is a trivial change to remove the last TRAPS from redefine_single_class
> which is called by the VM thread during a safepoint.
> Tested with serviceability/jvmti/RedefineClasses, vmTestbase/nsk/jvmti,jdi
> and jdk/java/lang/instru
On Wed, 31 Mar 2021 21:41:39 GMT, Coleen Phillimore wrote:
>> This function is used to call the classfile parser for hidden or anonymous
>> classes, and for use with jvmti RedefineClasses. The latter only calls
>> KlassFactory::create_from_stream and skips the rest of the code in
>> SystemDict
On Wed, 31 Mar 2021 19:57:57 GMT, Coleen Phillimore wrote:
>> This function is used to call the classfile parser for hidden or anonymous
>> classes, and for use with jvmti RedefineClasses. The latter only calls
>> KlassFactory::create_from_stream and skips the rest of the code in
>> SystemDict
On Wed, 31 Mar 2021 19:57:57 GMT, Coleen Phillimore wrote:
>> This function is used to call the classfile parser for hidden or anonymous
>> classes, and for use with jvmti RedefineClasses. The latter only calls
>> KlassFactory::create_from_stream and skips the rest of the code in
>> SystemDict
On Mon, 29 Mar 2021 17:40:09 GMT, Harold Seigel wrote:
> Please review this change for JDK-8264193 to remove unneeded TRAPS parameters
> from modules and default methods files. Besides removing TRAPS,
> Modules::get_named_module() was changed to return an oop instead of a
> jobje
On Tue, 30 Mar 2021 01:40:02 GMT, David Holmes wrote:
>> Please review this change for JDK-8264193 to remove unneeded TRAPS
>> parameters from modules and default methods files. Besides removing TRAPS,
>> Modules::get_named_module() was changed to return an oop instead of a
>> jobject, removi
Please review this change for JDK-8264193 to remove unneeded TRAPS parameters
from modules and default methods files. Besides removing TRAPS,
Modules::get_named_module() was changed to return an oop instead of a jobject,
removing its need for a TRAPS parameter.
This change was tested with Mach
On Tue, 23 Mar 2021 15:05:59 GMT, Coleen Phillimore wrote:
>> Removed the TRAPS in function declarations in jvmtiRedefineClasses and in
>> ConstantPool merging functions.
>> Tested with vmTestbase/nsk/jvmti and tier1 (in progress).
>
> Coleen Phillimore has updated the pull request incrementally
On Tue, 23 Mar 2021 01:22:56 GMT, Coleen Phillimore wrote:
>> Removed the TRAPS in function declarations in jvmtiRedefineClasses and in
>> ConstantPool merging functions.
>> Tested with vmTestbase/nsk/jvmti and tier1 (in progress).
>
> Coleen Phillimore has updated the pull request incrementally
On Tue, 23 Mar 2021 01:22:56 GMT, Coleen Phillimore wrote:
>> Removed the TRAPS in function declarations in jvmtiRedefineClasses and in
>> ConstantPool merging functions.
>> Tested with vmTestbase/nsk/jvmti and tier1 (in progress).
>
> Coleen Phillimore has updated the pull request incrementally
On Thu, 25 Feb 2021 16:27:20 GMT, Severin Gehwolf wrote:
> Fails prior the patch of JDK-8257746, passes after. As expected.
>
> Thoughts?
The new tests looks good. Thanks for adding it.
Harold
-
Marked as reviewed by hseigel (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull
On Tue, 9 Feb 2021 13:31:25 GMT, Severin Gehwolf wrote:
>> This is an enhancement which solves two issues:
>>
>> 1. Multiple reads of relevant cgroup interface files. Now interface files
>> are only read once per file (just like Hotspot).
>> 2. Proxies creation of the impl specific subsystem vi
On Mon, 8 Feb 2021 19:54:03 GMT, Harold Seigel wrote:
> Please review this small fix for JDK-8261340 to clean up deprecation
> warnings, such as the following, in the vmTestbase/nsk tests.
>
> warning: [dep-ann] deprecated item is not annotated with @Deprecated
>
> The
On Tue, 9 Feb 2021 04:36:29 GMT, Serguei Spitsyn wrote:
>> Please review this small fix for JDK-8261340 to clean up deprecation
>> warnings, such as the following, in the vmTestbase/nsk tests.
>>
>> warning: [dep-ann] deprecated item is not annotated with @Deprecated
>>
>> The change was t
Please review this small fix for JDK-8261340 to clean up deprecation warnings,
such as the following, in the vmTestbase/nsk tests.
warning: [dep-ann] deprecated item is not annotated with @Deprecated
The change was tested by running the tests locally and checking for the
warnings. It was r
On Fri, 5 Feb 2021 16:53:00 GMT, Coleen Phillimore wrote:
>> Please review this change to clean up warnings, such as the following, in
>> the vmTestbase tests.
>>
>> warning: [synchronization] attempt to synchronize on an instance of a
>> value-based class
>> warning: [removal] Integer(int)
On Fri, 5 Feb 2021 14:48:25 GMT, Harold Seigel wrote:
> Please review this change to clean up warnings, such as the following, in the
> vmTestbase tests.
>
> warning: [synchronization] attempt to synchronize on an instance of a
> value-based class
> warning: [remova
Please review this change to clean up warnings, such as the following, in the
vmTestbase tests.
warning: [synchronization] attempt to synchronize on an instance of a
value-based class
warning: [removal] Integer(int) in Integer has been deprecated and marked for
removal
This change cleans up
On Fri, 8 Jan 2021 19:32:36 GMT, Coleen Phillimore wrote:
> Remove the _nh versions. Tested with tier1 and vmTestbase/nsk/jdi,jvmti
> tests.
The changes look good!
Thanks, Harold
-
Marked as reviewed by hseigel (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/2008
On Mon, 7 Dec 2020 17:48:01 GMT, Severin Gehwolf wrote:
> This has been implemented for cgroups v1 with
> [JDK-8250984](https://bugs.openjdk.java.net/browse/JDK-8250984) but was
> lacking some tooling support for cgroups v2. With podman 2.2.0 release this
> could now be implemented (and tested
On Wed, 9 Dec 2020 16:33:22 GMT, Coleen Phillimore wrote:
> This change handles redefinition during method resolution, by returning the
> new method. It's not needed to reresolve the invocation. See the bug for
> more information.
>
> Tested with tier1-3 and tier8 on linux-x64-debug and macos
On Sat, 5 Dec 2020 01:46:31 GMT, Dan Smith wrote:
> Integration of [JEP 390](https://bugs.openjdk.java.net/browse/JDK-8249100).
>
> Development has been broken into 5 tasks, each with its own JBS issue:
> - Deprecate wrapper class constructors for removal (rriggs)
> - Revise "value-based class"
On Mon, 30 Nov 2020 21:13:05 GMT, Harold Seigel wrote:
> Please review this change to obsolete the deprecated and aliased Trace flags.
> The now empty aliased_logging_flags support was left in arguments.cpp for
> use by trace flags that get deprecated and aliased in the future.
>
On Wed, 2 Dec 2020 23:00:03 GMT, David Holmes wrote:
>> Harold Seigel has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8256718: Obsolete the long term deprecated and aliased Trace flags
>
> Looks good!
>
On Wed, 2 Dec 2020 02:42:18 GMT, David Holmes wrote:
>> Harold Seigel has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8256718: Obsolete the long term deprecated and aliased Trace flags
>
> I'm still
On Tue, 1 Dec 2020 12:02:57 GMT, Coleen Phillimore wrote:
>> Harold Seigel has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8256718: Obsolete the long term deprecated and aliased Trace flags
>
> src/hotsp
aths; support was removed in 16.0.
> Please use -Xlog:class+path=off instead.
>
> The change was tested with tiers1and 2 on Linux, Windows, and MacOS, and
> tiers 3-5 on Linux x64 and with JCK lang and vm tests.
>
> Thanks, Harold
Harold Seigel has updated the pull request incre
On Tue, 1 Dec 2020 12:10:59 GMT, Coleen Phillimore wrote:
>> Harold Seigel has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8256718: Obsolete the long term deprecated and aliased Trace flags
>
> I agree wit
aths; support was removed in 16.0.
> Please use -Xlog:class+path=off instead.
>
> The change was tested with tiers1and 2 on Linux, Windows, and MacOS, and
> tiers 3-5 on Linux x64 and with JCK lang and vm tests.
>
> Thanks, Harold
Harold Seigel has updated the pull request incre
Please review this change to obsolete the deprecated and aliased Trace flags.
The now empty aliased_logging_flags support was left in arguments.cpp for use
by trace flags that get deprecated and aliased in the future.
With this change, users will get the following example messages when using
t
On Wed, 11 Nov 2020 00:27:59 GMT, Serguei Spitsyn wrote:
>> Please review this small change to add a cgroups keyword to tests that use
>> cgroups. The fix was tested by running Mach5 container tests.
>
> Hi Harold,
>
> The fix looks good.
>
> Thanks,
> Serguei
Thanks Serguei!
Harold
---
On Tue, 10 Nov 2020 21:24:25 GMT, Harold Seigel wrote:
> Please review this small change to add a cgroups keyword to tests that use
> cgroups. The fix was tested by running Mach5 container tests.
This pull request has now been integrated.
Changeset: 4df8abc2
Author:Harold Seige
Please review this small change to add a cgroups keyword to tests that use
cgroups. The fix was tested by running Mach5 container tests.
-
Commit messages:
- 8255787: Tag container tests that use cGroups with cgroups keyword
Changes: https://git.openjdk.java.net/jdk/pull/1148/file
On Mon, 9 Nov 2020 23:46:04 GMT, Coleen Phillimore wrote:
> This option has been removed in favor of always verifying the bytecodes in
> debug mode. Tested with tier1-3.
Looks good!
Thanks, Harold
-
Marked as reviewed by hseigel (Reviewer).
PR: https://git.openjdk.java.net/jdk/p
On Mon, 9 Nov 2020 20:05:09 GMT, Frederic Parain wrote:
>> Please review this small cleanup code, removing the now unused allocation
>> type from the fieldInfo structure.
>>
>> Tested with Mach5, tiers 1 to 3 and locally by running
>> test/hotspot/jtreg/serviceability/sa tests.
>>
>> Thank yo
On Mon, 9 Nov 2020 19:54:58 GMT, Frederic Parain wrote:
>> Please review this small cleanup code, removing the now unused allocation
>> type from the fieldInfo structure.
>>
>> Tested with Mach5, tiers 1 to 3 and locally by running
>> test/hotspot/jtreg/serviceability/sa tests.
>>
>> Thank yo
On Tue, 22 Sep 2020 15:52:43 GMT, Harold Seigel wrote:
> Please review this small change to remove "--memory 200m" option from
> TestUseContainerSupport.java. This can cause
> test failures on systems where swap accounting is disabled.
This pull request has now been int
Please review this small change to remove "--memory 200m" option from
TestUseContainerSupport.java. This can cause
test failures on systems where swap accounting is disabled.
-
Commit messages:
- 8253476: TestUseContainerSupport.java fails on some Linux kernels w/o swap
limit capa
oonam/8243290/webrev.01/
Thanks,
Poonam
On 6/9/20 8:38 AM, Harold Seigel wrote:
Hi Poonam,
Thanks for making this change.
In verifier.cpp, if ex_msg is NULL, will the call to st->print_cr()
at line 142 - 143, fail?
Thanks, Harold
On 6/9/2020 10:46 AM, Poonam Parhar wrote:
Hello,
Pleas
Hi Serguei,
The change looks good. Could you add a comment to
check_attribute_arrays() saying that its caller should have a ResourceMark?
Also, I think that the log_trace arguments at line 724 are in the wrong
order. attr_name should be after the_class->external_name().
I don't need to se
Hi David,
Thanks for reviewing the latest changes.
I'll create the follow on RFE's once the sealed classes code is in mainline.
Harold
On 5/31/2020 9:34 PM, David Holmes wrote:
Hi Harold,
On 1/06/2020 8:57 am, Harold Seigel wrote:
Thanks for the comments.
Here's version 3
sealed classes API's in Class.java.
Thanks, Harold
On 5/28/2020 8:30 PM, David Holmes wrote:
Hi Harold,
Sorry Mandy's comment raised a couple of issues ...
On 29/05/2020 7:12 am, Mandy Chung wrote:
Hi Harold,
On 5/27/20 1:35 PM, Harold Seigel wrote:
Incremental webrev:
Hi Mandy,
The entries in the PermittedSubclasses attribute are constant pool
ConstantClass_info entries. These names get validated by the VM in this
code in ClassFileParser::parse_constant_pool():
for (index = 1; index < length; index++) {
const jbyte tag = cp->tag_at(index).va
. And added appropriate testing.
* Method Class.permittedSubtypes() was changed.
See also inline comments.
On 5/24/2020 10:28 PM, David Holmes wrote:
Hi Harold,
On 22/05/2020 4:33 am, Harold Seigel wrote:
Hi David,
Thanks for looking at this! Please review this new webrev:
http
1 - 100 of 199 matches
Mail list logo
