On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> It's the last issue in the series, and it still touches different areas of
> the code.
Marked as reviewed by iris (Reviewer).
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> Also, I fixed a couple of spelling mistakes.
Marked as reviewed by iris (Reviewer).
-
PR:
On Mon, 11 Apr 2022 16:20:02 GMT, Daniel D. Daugherty
wrote:
> A trivial copyright fix to solve validate-source failure after JDK-8283710.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8181
On Wed, 6 Apr 2022 17:45:13 GMT, Naoto Sato wrote:
> This is a follow-on task after deprecating the Locale constructors
> (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are
> simple replacements to Locale constructors with `Locale.of()` or Locale
> constants, such as
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
Nice tidy of the code.
Is there anything that can be done to prevent re-introduction of this trivial
problem? Perhaps a new
On Tue, 1 Feb 2022 16:19:01 GMT, Pavel Rappo wrote:
> While looking into guts of javadoc comment inheritance, I noticed that a
> number of places in JDK seem to confuse JLS 8.4.6.** with JLS 8.4.8.**.
>
> Granted, "8.4.6 Method Throws" tangentially addresses overriding. However, I
> believe
On Sat, 22 Jan 2022 21:09:03 GMT, Joe Darcy wrote:
> Use presumed syntax that will be introduced by JDK-8280488.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7189
On Fri, 10 Dec 2021 01:46:03 GMT, Jonathan Gibbons wrote:
> Please review this semi-automatic update for the nroff man pages for JDK 18.
> The changes update the version number, copyright year, and incorporate the
> changes from the latest upstream files.
Marked as reviewed by iris
On Tue, 7 Dec 2021 00:27:45 GMT, Serguei Spitsyn wrote:
> This fix adds escaping of invalid characters '[]' for 3 URLs defined in the
> jvmti.xml.
> This file is a base to generate the jvmti.html.
Marked as reviewed by iris (Reviewer).
-
PR:
On Sun, 5 Dec 2021 23:45:32 GMT, Joe Darcy wrote:
> Exploratory builds indicate it is not currently necessary to exclude the
> doclint accessibility checks; this patch enables them.
>
> (Enabling the reference checks is left for future work.)
Marked as reviewed by iris (Reviewer).
On Thu, 16 Sep 2021 01:08:45 GMT, Naoto Sato wrote:
> Fixing failing regression tests caused by the JEP 400: UTF-8 by Default.
>
> `JcmdOutputEncodingTest` test case uses `file.encoding=UTF-8` in `C` locale.
> The output from the agent library is in `UTF-8` so it succeeded before the
> JEP
On Thu, 5 Aug 2021 19:20:50 GMT, Jonathan Gibbons wrote:
> Please review a semi-automatic update of the nroff man pages from the
> upstream files.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk17/pull/303
On Wed, 3 Feb 2021 19:12:25 GMT, Emmanuel Bourg
wrote:
> This PR fixes the following spelling errors:
>
> choosen -> chosen
> commad -> command
> hiearchy -> hierarchy
> leagacy -> legacy
> minium -> minimum
> subsytem -> subsystem
> unamed -> unnamed
Marked as reviewed by iris
On Wed, 28 Jul 2021 17:12:04 GMT, Emmanuel Bourg
wrote:
>> This PR fixes the following spelling errors:
>>
>> choosen -> chosen
>> commad -> command
>> hiearchy -> hierarchy
>> leagacy -> legacy
>> minium -> minimum
>> subsytem -> subsystem
>> unamed -> unnamed
>
> Emmanuel
On Tue, 8 Jun 2021 02:02:38 GMT, Serguei Spitsyn wrote:
>> The JVM TI Heap functions 1.0 were superseded by newer functions in JVM TI
>> 1.2 (Java 6) and should be deprecated so they can be removed in a future
>> release.
>>
>> We need to replace this sentence:
>> "These functions and data
On Thu, 22 Oct 2020 17:16:23 GMT, Jonathan Gibbons wrote:
> The change is (just) to remove legacy usages of a JDK-private custom tag.
Nice clean-up.
-
Marked as reviewed by iris (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/814
Hi, Erik.
> New webrev: http://cr.openjdk.java.net/~erikj/8223319/webrev.02/
The revised webrev looks good.
Thank you!
Iris
Hi, Erik.
I'm happy to see this change go in. It looks good.
Just one comment. When removing the footer in jvmit.html, I suspect that you
also need to make changes to jvmti.xsl, which was also modified when the
copyright footer was inserted in this changeset:
Hi, Mandy, David, and Serguei.
Thank you for taking the time to Review. I've pushed the changeset.
iris
-Original Message-
From: Serguei Spitsyn
Sent: Monday, September 17, 2018 12:57 AM
To: David Holmes ; Iris Clark ;
serviceability-dev
Subject: Re: RFR (S) 8210775: JVM TI Spec
Hi.
Please review the following changes to add a copyright line to the end
of the generated jvmti.html file:
8210775: JVM TI Spec missing copyright
bug: https://bugs.openjdk.java.net/browse/JDK-8210775
webrev: http://cr.openjdk.java.net/~iris/8210775/webrev/
The year ranges are
Hi, Stuart.
http://cr.openjdk.java.net/~smarks/reviews/8204243/webrev.2/
The simple update to remove references to the removed methods looks good.
Thanks,
iris
From: Stuart Marks
Sent: Wednesday, June 6, 2018 2:58 PM
To: Serguei Spitsyn ; David Holmes
; Alan Bateman ; Iris Clark
Hi, Stuart.
I think you need to make changes to this file too:
http://hg.openjdk.java.net/jdk/jdk/file/tip/src/java.base/share/classes/java/lang/doc-files/threadPrimitiveDeprecation.html
Thanks,
iris
-Original Message-
From: Alan Bateman
Sent: Wednesday, June 6, 2018 3:40 AM
To:
Hi, Mandy.
Thanks for the super-fast review!
iris
From: mandy chung
Sent: Monday, May 21, 2018 4:15 PM
To: Iris Clark <iris.cl...@oracle.com>
Cc: compiler-...@openjdk.java.net; core-libs-...@openjdk.java.net;
serviceability-dev@openjdk.java.net
Subject: Re: RFR (S): 820350
Hi, Jon.
Thanks for the speedy review!
iris
From: Jonathan Gibbons
Sent: Monday, May 21, 2018 4:00 PM
To: compiler-...@openjdk.java.net
Subject: Re: RFR (S): 8203500: Fix broken links to Specification in "specs"
directory
Looks good to me.
-- Jon
On 5/21/18 3:5
Hi, Lance.
Thanks for the speedy review!
iris
From: Lance Andersen
Sent: Monday, May 21, 2018 3:58 PM
To: Iris Clark <iris.cl...@oracle.com>
Cc: compiler-...@openjdk.java.net; core-libs-...@openjdk.java.net;
serviceability-dev@openjdk.java.net
Subject: Re: RFR (S): 820350
Hi.
Please review this small change to fix a few broken links to
Specification in the "specs" directory from the JavaDoc API.
The incorrect references either not include "{@docRoot}" or
include the non-existent "{@docRootParent}". They should all
begin with "{@docRoot}/../specs/".
Hi, Chris.
I think that change is fine.
I've added a note to JDK-8144062 (module for jdk.Version), indicating that this
code may need to be changed depending on how that issue is resolved.
Thanks,
iris
-Original Message-
From: Chris Hegarty
Sent: Thursday, February 18, 2016 5:42 AM
Hi, Alan.
> JEP 223 isn't in JDK 9 yet. I've no doubt there will be a s/1.9/9/g when it
> goes in, it will probably need to be done a few times to ensure changes in
> progress at the time of the switch are caught.
Correct. For reference, here's the bug:
8136494: Update "@since 1.9" to
: Update javax/management regression test for
Verona (versioning)
Looks fine. Not likely this test will ever be run on pre JDK 1.5.
-JB-
On 21.7.2015 07:30, Iris Clark wrote:
Hi.
Please review changes to resolve the following bug:
8132003: Update javax/management regression test for Verona
Hi, Jaroslav, Shanliang, and Daniel.
I pushed the changeset this morning to verona/stage. Expect the changeset to
get to jdk9/* when we Verona is complete, later this summer.
Thanks again for all your help.
iris
-Original Message-
From: verona-dev
Hi.
Please review changes to resolve the following bug:
8132003: Update javax/management regression test for Verona (versioning)
Bug: https://bugs.openjdk.java.net/browse/JDK-8132003
The regression test
javax/management/remote/mandatory/notif/NotSerializableNotifTest.java fails in
Verona
Hi, Staffan.
bug: https://bugs.openjdk.java.net/browse/JDK-8075056
webrev: http://cr.openjdk.java.net/~sla/8075056/webrev.00/
http://cr.openjdk.java.net/~sla/8075056/webrev.00/
Looks good. I'm always happy to see changes where complexity is reduced.
Thanks,
iris
So overall it looks good to me and should be pushed to the staging forest
once you hear from others that commented previously.
I think that means Chris Hegarty, Michael McMahon, and Sergey Bylokhov. Alan,
please correct me if I'm wrong.
Thanks,
iris
-Original Message-
From: Alan
Hi.
http://cr.openjdk.java.net/~simonis/webrevs/8024854.v3/
+ src/solaris/classes/java/lang/UNIXProcess.java.aix
2 * Copyright (c) 1995, 2013, Oracle and/or its affiliates. All rights
reserved.
3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
Oracle copyright in
Hi, Volker.
Just wanted to say that in addition to preparing for JavaOne (next week!),
we're also busy fixing bugs in anticipation of JDK 8 ZBB milestone on 24 Oct
[1].
Thanks,
iris
[1]: http://openjdk.java.net/projects/jdk8/milestones
-Original Message-
From: Phil Race
Sent:
The webrev with the proposed changes is here:
http://cr.openjdk.java.net/~alanb/7173494/webrev/
Looks like a good clean-up.
iris
Hi, Dan.
Just FYI: I haven't seen Éamonn's posting come in. Just replies to his
posting. This may mean that other comments are stuck in the ether
somewhere...
I suspect that the OpenJDK list server is again having issues...
I just checked the core-libs-dev admin interface to see if
37 matches
Mail list logo
