Re: review request for JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release

2013-05-23 Thread Joseph Provino
David, thanks for finding that! joe On 05/22/2013 08:09 PM, David Holmes wrote: Joe, On 23/05/2013 5:27 AM, Joseph Provino wrote: Is there a consensus what is in the webrev is okay? Yes I am now okay with it. I found this in 4889433: "AsyncGetCallTrace() requires the CLASS_LOAD eve

Re: review request for JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release

2013-05-22 Thread Joseph Provino
https://jbs.oracle.com/bugs/browse/JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release joe On 05/21/2013 04:52 PM, JOSEPH PROVINO wrote: On 5/21/2013 4:00 PM, Oleg Mazurov wrote: Though formally not part of

Re: review request for JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release

2013-05-21 Thread JOSEPH PROVINO
r the quick reply. joe -- Oleg On 5/21/2013 12:19 PM, JOSEPH PROVINO wrote: On 5/21/2013 3:16 PM, serguei.spit...@oracle.com wrote: On 5/21/13 11:26 AM, JOSEPH PROVINO wrote: On 5/21/2013 2:23 PM, Staffan Larsen wrote: On 21 maj 2013, at 17:35, JOSEPH PROVINO wrote: On 5/21/2013 3:

Re: review request for JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release

2013-05-21 Thread JOSEPH PROVINO
On 5/21/2013 3:16 PM, serguei.spit...@oracle.com wrote: On 5/21/13 11:26 AM, JOSEPH PROVINO wrote: On 5/21/2013 2:23 PM, Staffan Larsen wrote: On 21 maj 2013, at 17:35, JOSEPH PROVINO wrote: On 5/21/2013 3:06 AM, David Holmes wrote: Hi Staffan, On 21/05/2013 4:49 PM, Staffan Larsen

Re: review request for JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release

2013-05-21 Thread JOSEPH PROVINO
On 5/21/2013 2:23 PM, Staffan Larsen wrote: On 21 maj 2013, at 17:35, JOSEPH PROVINO wrote: On 5/21/2013 3:06 AM, David Holmes wrote: Hi Staffan, On 21/05/2013 4:49 PM, Staffan Larsen wrote: On 21 maj 2013, at 04:34, David Holmes wrote: Hi Joe, As I have previously stated you copied

Re: review request for JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release

2013-05-21 Thread JOSEPH PROVINO
David On 21/05/2013 5:10 AM, JOSEPH PROVINO wrote: The change is to include forte.cpp in the minimal jvm but to conditionalize the code so that only AsyncGetCallTrace() is defined with the minimal jvm. Webrev is here: http://cr.openjdk.java.net/~jprovino/8013461/webrev.00/ * JDK-8013461 <

Re: review request for JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release

2013-05-21 Thread JOSEPH PROVINO
o either of you feel strongly about how this should be fixed -- return an error or remove the symbol? joe Thanks, David /Staffan Thanks, David On 21/05/2013 5:10 AM, JOSEPH PROVINO wrote: The change is to include forte.cpp in the minimal jvm but to conditionalize the code so that only As

Re: review request for JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release

2013-05-21 Thread JOSEPH PROVINO
ticks_no_class_load is deemed appropriate in this situation. Who will be consuming this value? Thanks, David On 21/05/2013 5:10 AM, JOSEPH PROVINO wrote: The change is to include forte.cpp in the minimal jvm but to conditionalize the code so that only AsyncGetCallTrace() is defined with the minimal