Re: RFR: JDK-8151674: STW phases at Concurrent GC should count in PerfCounter

2016-03-19 Thread Jon Masamitsu
On 03/10/2016 07:59 PM, Yasumasa Suenaga wrote: Hi all, This review request continues from: http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2016-March/016774.html http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2016-March/016896.html I wonder that STW phases (Remark and Clea

Re: RFR: JDK-8151674: STW phases at Concurrent GC should count in PerfCounter

2016-03-19 Thread Jon Masamitsu
tml On 2016/03/17 8:23, Yasumasa Suenaga wrote: Hi Jon, 2016/03/17 3:25 "Jon Masamitsu" <mailto:jon.masami...@oracle.com>>: > > > > On 03/10/2016 07:59 PM, Yasumasa Suenaga wrote: >> >> Hi all, >> >> This review request continues

Re: JDK-6291341: jstat: FGC counter confusing when CMS GC is used

2016-03-08 Thread Jon Masamitsu
Yasumasa, We're discussing this. What would the result be if the GC team made the JVM changes that you want to contribute. Meaning, without the jdk changes, will jstat continue to work as it currently does? Would the changes in the JVM be useful to you without the jstat changes? By the JVM ch

Re: PerfData counter: sun.gc.policy.generations in JDK 8

2015-06-02 Thread Jon Masamitsu
Ramki, Changes look good. I'm guessing you tested by generating the perfdata by hand and verifying the contents of the perfdata. Do you think a test can be written to verify the change? If you look at test/gc/metaspace/TestMetaspacePerfCounters.java in your repository I think that is an exa

Re: request for review - 8004172: Remove display of permanent generation counters from jstat options

2013-01-09 Thread Jon Masamitsu
I still need a review from an official "reviewer" please. Jon On 1/4/2013 2:41 PM, Jon Masamitsu wrote: 8004172: Remove display of permanent generation counters from jstat options This change removes from the jstat options the display of permanent generation counters. It al

request for review - 8004172: Remove display of permanent generation counters from jstat options

2013-01-04 Thread Jon Masamitsu
8004172: Remove display of permanent generation counters from jstat options This change removes from the jstat options the display of permanent generation counters. It also removes entirely the gcpermcapacity option. http://cr.openjdk.java.net/~jmasa/8004172/webrev.00/ The permanent generatio