You are going backwards. You need to have a CSR approved first.
Kumar
Ping. Could I please have reviews for below webrev.
Thanks
Harsha
On Wednesday 14 February 2018 09:59 PM, Harsha Wardhana B wrote:
Hi,
Below is the updated webrev.
http://cr.openjdk.java.net/~hb/8187498/webrev.03/
On
Hi Harsha,
Changes look reasonable to me, couple of things that must be addressed:
1. Since this is a main-stream launcher change with a documented and
supported
option, a CSR is required, you have to add and document the option in
the help page
.
-Original Message-
From: Kumar Srinivasan [mailto:kumar.x.sriniva...@oracle.com]
Sent: Montag, 27. November 2017 17:43
To: Lindenmaier, Goetz <goetz.lindenma...@sap.com>
Cc: core-libs-...@openjdk.java.net; 'compiler-...@openjdk.java.net'
<compiler-...@openjdk.java.net>; servic
Hi,
I looked at some of the components I maintain, and they look good.
Wrt. the test:
1. The local variables/fields don't comply with the coding conventions,
we have been
following in the JDK.
2. Hmm, someone parked a .ini file in bin directory, later removed,
perhaps on windows
Hello,
Ping!. Lets wrap this up soon, as we have to move to
the next steps in the docs related work.
Thanks
Kumar
Hi All,
Please review fixes to make the API doc comments HTML5 clean,
there are no changes to the verbiage, and mostly fixes for the table
styles defined here:
Hi All,
Please review fixes to make the API doc comments HTML5 clean,
there are no changes to the verbiage, and mostly fixes for the table
styles defined here:
http://hg.openjdk.java.net/jdk9/dev/langtools/rev/ee84b7d44339
For tables with many entries I have used "striped", there are few
Hello,
Please review changes to make jdk.jdi HTML5 friendly,
table cell padding has not been addressed and will be fixed
separately, this takes care of others.
Note: Some of the errors were due to incorrect@throws but
in all cases there is the correct one further down, please use
sdiffs in
Hello,
Please review changes for java.management and java.management.rmi to
be HTML5 ready, there are outliers like cellpadding, cellspacing that needs
to be done separately, note this was *not* done mechanically by a script.
http://cr.openjdk.java.net/~ksrini/8179415/
Hi Chris,
Approved with some minor nits, typos which needs correction.
yes java.c follows the JDK indenting as Alan pointed out.
TooSmallStackSize.java
Copyright should be 2014,
1.
37 * stack size for the platform (as provided by the JVM error message when
a very
38 * small is used),
On 12/3/2014 11:26 AM, Chris Plummer wrote:
Hi Kumar,
On 12/3/14 10:58 AM, Kumar Srinivasan wrote:
Hi Chris,
Approved with some minor nits, typos which needs correction.
yes java.c follows the JDK indenting as Alan pointed out.
TooSmallStackSize.java
Copyright should be 2014,
Copy/paste
be:
198 if (home.length() 0) {
201 exePath = home + File.separator + bin + File.separator
+ exe;
203 } else {
204 exePath = exe;
205 }
Thanks,
/Staffan
On 9 sep 2013, at 18:12, Kumar Srinivasan kumar.x.sriniva
/solaris-amd64/libLauncher.so
I know this already exist but I thought binaries were disallowed in
the open repo?
Alan, are the nio changes acceptable? Let me know if you need more time
to go over all
the changes.
Kumar
Davud
On 9/09/2013 1:09 PM, Kumar Srinivasan wrote:
Hi David, Staffan
/HatRun.java
It isn't clear to me why you need to retain the d64 variable at all.
---
test/tools/launcher/ExecutionEnvironment.java
typo: appopriate
Thanks,
David
On 7/09/2013 2:47 AM, Kumar Srinivasan wrote:
Hello,
Please review the changes to remove Solaris 32-bit binaries from JDK8
distros
On 9/6/2013 12:21 PM, Alan Bateman wrote:
On 06/09/2013 17:47, Kumar Srinivasan wrote:
Hello,
Please review the changes to remove Solaris 32-bit binaries from JDK8
distros,
at this time the dual mode support in the launcher is being disabled.
Message regarding this:
http
IMHO this looks like a valid use case that should be solved in some upcoming
release, on all relevant target platforms (Windows/non-Windows, 32/64-bit).
Is there a bug created yet?
We need a bug/CR on this, I will look into fixing this for the next
available
update release.
Kumar
We can
Changeset: de45eac5670e
Author:ksrini
Date: 2009-11-20 11:01 -0800
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/de45eac5670e
6367077: Purge LD_LIBRARY_PATH usage from the launcher
6899834: (launcher) remove the solaris libjvm.so symlink
Summary: Fixes other related issues as
Changeset: 2c65a59dd48d
Author:ksrini
Date: 2008-08-26 10:21 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2c65a59dd48d
6685121: (launcher) make ReportErrorMessages accessible by other launcher
subsystems
Summary: provided error reporting interfaces to other java
Changeset: 058bdd3ca02e
Author:ksrini
Date: 2008-03-20 08:44 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/058bdd3ca02e
6618930: (javac) fix test after whitespace normalization
Summary: whitespace normalization left the test unusable, back to service
Reviewed-by: jjg
18 matches
Mail list logo
