You are going backwards. You need to have a CSR approved first.
Kumar
Ping. Could I please have reviews for below webrev.
Thanks
Harsha
On Wednesday 14 February 2018 09:59 PM, Harsha Wardhana B wrote:
Hi,
Below is the updated webrev.
http://cr.openjdk.java.net/~hb/8187498/webrev.03/
On
Hi Harsha,
Changes look reasonable to me, couple of things that must be addressed:
1. Since this is a main-stream launcher change with a documented and
supported
option, a CSR is required, you have to add and document the option in
the help page
http://hg.openjdk.java.net/jdk/jdk/file/8cc6
.
-Original Message-
From: Kumar Srinivasan [mailto:kumar.x.sriniva...@oracle.com]
Sent: Montag, 27. November 2017 17:43
To: Lindenmaier, Goetz
Cc: core-libs-...@openjdk.java.net; 'compiler-...@openjdk.java.net'
; serviceability-dev (serviceability-
d...@openjdk.java.net)
Subjec
Hi,
I looked at some of the components I maintain, and they look good.
Wrt. the test:
1. The local variables/fields don't comply with the coding conventions,
we have been
following in the JDK.
2. Hmm, someone parked a .ini file in bin directory, later removed,
perhaps on windows s
Hello,
Ping!. Lets wrap this up soon, as we have to move to
the next steps in the docs related work.
Thanks
Kumar
Hi All,
Please review fixes to make the API doc comments HTML5 clean,
there are no changes to the verbiage, and mostly fixes for the table
styles defined here:
http://hg.openjdk
Hi All,
Please review fixes to make the API doc comments HTML5 clean,
there are no changes to the verbiage, and mostly fixes for the table
styles defined here:
http://hg.openjdk.java.net/jdk9/dev/langtools/rev/ee84b7d44339
For tables with many entries I have used "striped", there are few
tables
Hello,
Please review changes to make jdk.jdi HTML5 friendly,
table cell padding has not been addressed and will be fixed
separately, this takes care of others.
Note: Some of the errors were due to incorrect@throws but
in all cases there is the correct one further down, please use
sdiffs in these
Hello,
Please review changes for java.management and java.management.rmi to
be HTML5 ready, there are outliers like cellpadding, cellspacing that needs
to be done separately, note this was *not* done mechanically by a script.
http://cr.openjdk.java.net/~ksrini/8179415/
https://bugs.openjdk.java.
On 12/3/2014 11:26 AM, Chris Plummer wrote:
Hi Kumar,
On 12/3/14 10:58 AM, Kumar Srinivasan wrote:
Hi Chris,
Approved with some minor nits, typos which needs correction.
yes java.c follows the JDK indenting as Alan pointed out.
TooSmallStackSize.java
Copyright should be 2014,
Copy/paste
Hi Chris,
Approved with some minor nits, typos which needs correction.
yes java.c follows the JDK indenting as Alan pointed out.
TooSmallStackSize.java
Copyright should be 2014,
1.
37 * stack size for the platform (as provided by the JVM error message when
a very
38 * small is used),
th = exe;
205 }
I think this should be:
198 if (home.length() > 0) {
201 exePath = home + File.separator + "bin" + File.separator
+ exe;
203 } else {
204 exePath = exe;
205 }
Thanks,
/St
hannel/lib/solaris-amd64/libLauncher.so
I know this already exist but I thought binaries were disallowed in
the open repo?
Alan, are the nio changes acceptable? Let me know if you need more time
to go over all
the changes.
Kumar
Davud
On 9/09/2013 1:09 PM, Kumar Srinivasan wrote:
Hi Davi
/sun/tools/jhat/HatRun.java
It isn't clear to me why you need to retain the d64 variable at all.
---
test/tools/launcher/ExecutionEnvironment.java
typo: appopriate
Thanks,
David
On 7/09/2013 2:47 AM, Kumar Srinivasan wrote:
Hello,
Please review the changes to remove Solaris 32-bi
On 9/6/2013 12:21 PM, Alan Bateman wrote:
On 06/09/2013 17:47, Kumar Srinivasan wrote:
Hello,
Please review the changes to remove Solaris 32-bit binaries from JDK8
distros,
at this time the dual mode support in the launcher is being disabled.
Message regarding this:
http
On 4/12/2012 2:03 PM, Daniel D. Daugherty wrote:
The wonderful T&L nightly testing caught an error in my changes
The change looks good to me.
Thanks
Kumar
that were reviewed on this thread. On Linux and Solaris, I installed
the .debuginfo files for programs in $JAVA_HOME/bin. I made a
mista
> IMHO this looks like a valid use case that should be solved in some upcoming
> release, on all relevant target platforms (Windows/non-Windows, 32/64-bit).
>
> Is there a bug created yet?
We need a bug/CR on this, I will look into fixing this for the next
available
update release.
Kumar
> We
Changeset: de45eac5670e
Author:ksrini
Date: 2009-11-20 11:01 -0800
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/de45eac5670e
6367077: Purge LD_LIBRARY_PATH usage from the launcher
6899834: (launcher) remove the solaris libjvm.so symlink
Summary: Fixes other related issues as well
Changeset: e7f373751c6b
Author:ksrini
Date: 2008-10-05 18:53 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e7f373751c6b
6755847: (launcher) will trigger assertions in debug build
Summary: Adds a temporary counter measure to to prevent assertions CR: 6755845
Reviewed-by: darc
Changeset: 906b5be0eca5
Author:ksrini
Date: 2008-10-01 09:04 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/906b5be0eca5
4459600: java -jar fails to run Main-Class if classname followed by whitespace.
Summary: Fixed whitespace trimming in the manifest as well as post review
Changeset: e2c416af20bd
Author:ksrini
Date: 2008-09-24 15:07 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e2c416af20bd
6742159: (launcher) improve the java launching mechanism
Summary: improves launching, also addresses 6694671 and 6749732
Reviewed-by: darcy, dholmes
! src
Changeset: 2c65a59dd48d
Author:ksrini
Date: 2008-08-26 10:21 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2c65a59dd48d
6685121: (launcher) make ReportErrorMessages accessible by other launcher
subsystems
Summary: provided error reporting interfaces to other java subsystems
Changeset: c2019d1360ef
Author:ksrini
Date: 2008-04-10 09:02 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c2019d1360ef
6684582: Launcher needs improved error reporting
Summary: indicate the missing main class in the error message
Reviewed-by: darcy, kbr
! src/share/bin/eme
Changeset: ddd77d1c1b49
Author:ksrini
Date: 2008-04-03 18:01 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/ddd77d1c1b49
6570242: Regression test failures with Javac on win32.
Summary: takes this test out of service until the reall bug is fixed
Reviewed-by: jjg
! test/
Changeset: 058bdd3ca02e
Author:ksrini
Date: 2008-03-20 08:44 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/058bdd3ca02e
6618930: (javac) fix test after whitespace normalization
Summary: whitespace normalization left the test unusable, back to service
Reviewed-by: jjg
Changeset: 5aaa9902102b
Author:ksrini
Date: 2008-03-06 07:51 -0800
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5aaa9902102b
6596475: (launcher) javaw should call InitCommonControls
Summary: javaw does not show error window after manifest changes.
Reviewed-by: darcy
! make/java/
25 matches
Mail list logo
