On Tue, 24 May 2022 09:52:29 GMT, Alexey Ivanov wrote:
>> Replaces usages of articles that follow each other in all combinations:
>> a/the, an?/an?, the/the…
>>
>> It's the last issue in the series, and it still touches different areas of
>> the code.
>
> Alexey Ivanov has updated the pull req
On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> It's the last issue in the series, and it still touches different areas of
> the code.
Marked as reviewed by lancea (Reviewer).
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> Also, I fixed a couple of spelling mistakes.
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.net
On Tue, 26 Apr 2022 17:27:35 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in the
On Thu, 21 Apr 2022 11:35:57 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in the
On Mon, 25 Apr 2022 13:19:49 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in the
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
What problem are you having editing the PR header? You should be able to do
so as the author of the PR
-
PR: ht
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
The changes look OK. The copyright year probably should be updated as part of
this PR
-
Marked as reviewed by la
On Sat, 22 Jan 2022 21:09:03 GMT, Joe Darcy wrote:
> Use presumed syntax that will be introduced by JDK-8280488.
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7189
On Thu, 13 Jan 2022 14:01:04 GMT, Pavel Rappo wrote:
>> - Most of the typos are of a trivial kind: missing whitespace.
>> - If any of the typos should be fixed in the upstream projects instead,
>> please say so; I will drop those typos from the patch.
>> - As I understand it, ` ` in ImageInputSt
On Thu, 13 Jan 2022 13:48:02 GMT, Pavel Rappo wrote:
> > Yes an "or" is probably worthwhile to add.
>
> I would prefer to leave it for the follow-up cleanup if only because adding
> "or" here would make it inconsistent with other `@throws SQLException`
> descriptions in that file and perhaps e
On Thu, 13 Jan 2022 12:37:46 GMT, Pavel Rappo wrote:
> > The above is a bit confusing as it reads(same in ImageInputStream.java). I
> > think that that can be looked at later.
>
> Just to clarify: you are okay with removing the ` ` entity, right? As for
> ImageInputStream, some doc comments sh
On Thu, 13 Jan 2022 11:29:35 GMT, Pavel Rappo wrote:
>> src/java.sql/share/classes/java/sql/Statement.java line 784:
>>
>>> 782: * statement returns a {@code ResultSet} object, the second
>>> argument
>>> 783: * supplied to this method is not an
>>> 784: * {@code int} array whose
On Thu, 13 Jan 2022 11:28:34 GMT, Kevin Walls wrote:
>> I thought about it too, but then noticed how the position of `[]` mimics
>> that of the respective method signatures in code.
>
> OK, so lines 264, 295, 329, 364, 431 are arguably wrong as well? Separating
> the [] completely looks quite
On Thu, 13 Jan 2022 10:30:07 GMT, Pavel Rappo wrote:
> - Most of the typos are of a trivial kind: missing whitespace.
> - If any of the typos should be fixed in the upstream projects instead,
> please say so; I will drop those typos from the patch.
> - As I understand it, ` ` in ImageInputStream
On Sat, 20 Nov 2021 04:09:51 GMT, Tim Prinzing wrote:
> JDK-8276681: Malformed Javadoc inline tags in JDK source
> jdk/internal/net/http/ResponseSubscribers.java
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/6486
On Thu, 18 Nov 2021 21:51:30 GMT, Brent Christian wrote:
> Here are the code changes for the "Deprecate finalizers in the standard Java
> API" portion of JEP 421 ("Deprecate Finalization for Removal") for code
> review.
>
> This change makes the indicated deprecations, and updates the API spec
On Mon, 28 Jun 2021 18:03:56 GMT, Weijun Wang wrote:
> More refactoring to limit the scope of `@SuppressWarnings` annotations.
>
> Sometimes I introduce new methods. Please feel free to suggest method names
> you like to use.
>
> Note: this is copied from https://github.com/openjdk/jdk17/pull/
On Fri, 25 Jun 2021 23:40:27 GMT, Weijun Wang wrote:
>> More refactoring to limit the scope of `@SuppressWarnings` annotations.
>>
>> Sometimes I introduce new methods. Please feel free to suggest method names
>> you like to use.
>
> Weijun Wang has updated the pull request incrementally with o
On Fri, 25 Jun 2021 20:04:37 GMT, Weijun Wang wrote:
> More refactoring to limit the scope of `@SuppressWarnings` annotations.
>
> Sometimes I introduce new methods. Please feel free to suggest method names
> you like to use.
Changes look good Max
-
Marked as reviewed by lancea (
On Mon, 31 May 2021 15:02:57 GMT, Weijun Wang wrote:
>> Please review this implementation of [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> The code change is divided into 3 commits. Please review them one by one.
>>
>> 1.
>> https://github.com/openjdk/jdk/commit/576161d15423f58281e38
On Fri, 5 Mar 2021 19:36:13 GMT, Jonathan Gibbons wrote:
> Please review some simple cleanup for empty `` tags.
>
> Two of the tags are completely redundant, and simply deleted.
>
> The other three, in _package.html_ files are generally undesirable. Although
> the presumed intent of the `id` d
On Tue, 15 Dec 2020 21:57:17 GMT, Brian Burkhalter wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> updates, per code review
>
> test/jdk/java/lang/ClassLoader/Assert.java line 65:
>
>> 63:
>> 64: int s
On Thu, 22 Oct 2020 17:16:23 GMT, Jonathan Gibbons wrote:
> The change is (just) to remove legacy usages of a JDK-private custom tag.
looks fine
-
Marked as reviewed by lancea (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/814
On Sun, 27 Sep 2020 12:46:21 GMT, Vipin Sharma wrote:
>> Updated @exception with @throws for core-libs, it fixes all open sub-tasks
>> of JDK-8252536.
>>
>> Open Subtasks part of this fix are:
>> 1. JDK-8252537
>> 2. JDK-8252539
>> 3. JDK-8252540
>> 4. JDK-8252541
>>
>> Previous conversation o
On Thu, 24 Sep 2020 18:20:15 GMT, Vipin Sharma wrote:
> > Overall the changes look OK. in the java.sql set of classes, please updated
> > the modified statements to also use {@code}
>
> Hi @LanceAndersen, it was suggested by @RogerRiggs also. I have created a
> separate bug JDK-8253612 to fix
On Sat, 19 Sep 2020 20:24:14 GMT, Vipin Sharma wrote:
>> Updated @exception with @throws for core-libs, it fixes all open sub-tasks
>> of JDK-8252536.
>>
>> Open Subtasks part of this fix are:
>> 1. JDK-8252537
>> 2. JDK-8252539
>> 3. JDK-8252540
>> 4. JDK-8252541
>>
>> Previous conversation o
Signatures
>
> JDI Type Signatures
> @@ -74,6 +73,5 @@
> has the following type signature:
> (ILjava/lang/String;[I)J
>
> -
>
>
>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif&
6 @@
>
> /**
> * Defines the API for JDK Flight Recorder.
> - *
> *
> * @moduleGraph
> * @since 9
>
>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
+1
--
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
Sent from my iPhone
> On Jun 3, 2019, at 6:33 PM, Jonathan Gibbons
> wrote:
>
> Please review a tiny delete-one-li
ex.html
>
>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>La
gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
/xml/ws/clientjar/TestWsImport.java 8170370
> generic-all
> +javax/xml/ws/clientjar/TestWsImport.java 8173317
> generic-all
>
>
>
>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/desi
# jdk_management
> @@ -320,6 +323,9 @@
> # 8031482
> sun/tools/jcmd/TestJcmdSanity.javawindows-all
>
> +# 8072131
> +sun/tools/jmap/heapconfig/JMapHeapConfigTest.java macosx-all
> +
> # 8027668
> sun/tools/jstatd/TestJstatdDefaults.javageneric-all
> su
ist filters and List[] requestLists is hard to fix.
> // Remove SuppressWarning when we fix the warnings from List filters
> // and List[] requestLists. The generic array is not supported.
> -@SuppressWarnings("unchecked")
> +@SuppressWarnings({"unchecked", "rawtypes"})
&g
iple classes in the jdk9-dev repo (except client
> packages).
>
> webrev: http://cr.openjdk.java.net/~rriggs/webrev-8044461-cleanup/
> Issue: https://bugs.openjdk.java.net/browse/JDK-8044461
>
> Thanks, Roger
>
Lance Andersen| Principal Member of Technical Staff | +1.781
Changeset: bcf5fa5e9509
Author:lancea
Date: 2013-12-02 16:06 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bcf5fa5e9509
8029417: JDBC 4.2 javadoc updates
Reviewed-by: darcy
! src/share/classes/java/sql/CallableStatement.java
! src/share/classes/java/sql/DriverManager.java
!
Changeset: 59ff7957c26f
Author:lancea
Date: 2013-11-11 14:22 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/59ff7957c26f
8028149: Clean-up javac -Xlint warnings in com.sun.rowset and
com.sun.rowset.internal
Reviewed-by: darcy
! src/share/classes/com/sun/rowset/CachedRowSetI
Changeset: 64c0ac7cd936
Author:lancea
Date: 2013-10-17 15:14 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/64c0ac7cd936
8026812: doclint clean up for java.sql and javax.sql
Reviewed-by: mduigou
! src/share/classes/java/sql/CallableStatement.java
! src/share/classes/java/sql
Changeset: 657482758408
Author:lancea
Date: 2013-09-17 07:56 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/657482758408
7097386: Correct error in Predicate javadoc example
Reviewed-by: alanb, shade
! src/share/classes/javax/sql/rowset/Predicate.java
Changeset: 5c7690923663
Author:lancea
Date: 2013-09-13 19:10 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5c7690923663
8014967: EBehavior of DriverManager.registerDriver(dr) is unspecified if driver
is null
Reviewed-by: alanb
! src/share/classes/java/sql/DriverManager.jav
Changeset: 60d6f60416ca
Author:lancea
Date: 2013-09-12 13:20 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/60d6f60416ca
8015340: remove erroneous @since tag
Reviewed-by: darcy
! src/share/classes/java/sql/PreparedStatement.java
Changeset: cc64a05836a7
Author:lancea
Date: 2013-08-12 16:09 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cc64a05836a7
8022753: SQLXML javadoc example typo
Reviewed-by: alanb, mchung
! src/share/classes/java/sql/SQLXML.java
Changeset: a4eb59bffb60
Author:lancea
Date: 2013-06-29 06:12 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a4eb59bffb60
8019286: Fix javadoc typo in ResultSet.next
Reviewed-by: darcy, mchung
! src/share/classes/java/sql/ResultSet.java
Changeset: b9ba04dc210f
Author:lancea
Date: 2013-06-27 15:07 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b9ba04dc210f
8017471: Fix JDBC -Xdoclint public errors
Reviewed-by: darcy
! src/share/classes/java/sql/Blob.java
! src/share/classes/java/sql/CallableStatement.java
!
Changeset: e2333bd8514a
Author:lancea
Date: 2013-06-07 14:13 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e2333bd8514a
8016101: Fix typo in SerialRef and missing @param in SerialStruct
Reviewed-by: darcy
! src/share/classes/javax/sql/rowset/serial/SerialRef.java
! src/shar
Changeset: ac3e189c9099
Author:lancea
Date: 2013-04-30 14:44 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ac3e189c9099
8010416: Add a way for java.sql.Driver to be notified when it is deregistered
Reviewed-by: alanb, ulfzibis
! src/share/classes/java/sql/Driver.java
+ src/
Changeset: b456f25c2075
Author:lancea
Date: 2013-04-23 11:17 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b456f25c2075
8011620: adding free form netbeans project for jdbc to jdk/make/netbeans
Reviewed-by: chegar
! make/netbeans/common/shared.xml
+ make/netbeans/jdbc/README
ProblemList.txt
> +++ b/test/ProblemList.txt
> @@ -144,6 +144,9 @@
>
> # jdk_management
>
> +# 8010897
> +sun/management/HotspotRuntimeMBean/GetSafepointSyncTime.java macosx-all
> +
> ####
>
> # jd
Changeset: 04617e462512
Author:lancea
Date: 2013-04-08 15:29 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/04617e462512
8006036: (process) cleanup code in java/lang/Runtime/exec/WinCommand.java
Reviewed-by: lancea
Contributed-by: Jim Gish
! test/java/lang/Runtime/exec/WinC
Changeset: 9f9dac5a9e74
Author:lancea
Date: 2013-02-22 09:29 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9f9dac5a9e74
8008716: address typo in CallableStatement javadocs
Reviewed-by: chegar
! src/share/classes/java/sql/CallableStatement.java
Changeset: 8d8a35ac7d40
Autho
arcy might have suggestions on that.
>
> Otherwise this is mostly mechanical and the patch file is easier to review
> that the webrev.
>
> -Alan
>
> [1] http://hg.openjdk.java.net/jdk8/tl/langtools/rev/55cca2f38ee6
<>
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
Changeset: 1574fa3df1c0
Author:lancea
Date: 2013-02-06 14:15 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1574fa3df1c0
8006505: additional changes for JSR 310 support
Reviewed-by: naoto, ulfzibis
! src/share/classes/java/sql/JDBCType.java
! src/share/classes/java/sql/SQLIn
Changeset: de30e46250c5
Author:lancea
Date: 2013-01-21 14:08 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/de30e46250c5
8006642: Fix javadoc warnings due to Integer.MAX_VALUE
Reviewed-by: alanb
! src/share/classes/java/sql/BatchUpdateException.java
! src/share/classes/java/
Changeset: d3da0d29d7cd
Author:lancea
Date: 2013-01-19 10:53 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d3da0d29d7cd
8005080: JDBC 4.2 Core changes
Reviewed-by: naoto
! src/share/classes/java/sql/BatchUpdateException.java
! src/share/classes/java/sql/CallableStatement.ja
Changeset: 78514544980d
Author:lancea
Date: 2013-01-19 10:11 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/78514544980d
8006139: add missing methods to javax.sql.rowset.serial.SQLInputImpl,
SQLOutputImpl
Reviewed-by: naoto, ulfzibis, alanb
! src/share/classes/javax/sql/row
+1
--
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
Sent from my iPhone
On Dec 13, 2012, at 6:30 PM, David Holmes wrote:
> Trivial update of max classfile version to 52.
>
Changeset: 7a8978a5bb6e
Author:lancea
Date: 2012-12-12 20:57 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7a8978a5bb6e
8004357: Implement various methods in SerialBlob/Clob/Array and specify Thread
Safety
Reviewed-by: naoto
! src/share/classes/javax/sql/rowset/serial/Seri
Changeset: 41a1b110f34d
Author:lancea
Date: 2012-12-06 15:51 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/41a1b110f34d
8004374: CachedRowSetSwriter.writeData reports wrong number of conflicts in
SyncProviderException
Reviewed-by: naoto
! src/share/classes/com/sun/rowset/i
Changeset: 8748331f63cf
Author:lancea
Date: 2012-11-01 17:35 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8748331f63cf
8001536: Added readObject,writeObject,clone, equals, hashcode to SerialXLob
Reviewed-by: alanb, forax
! src/share/classes/javax/sql/rowset/serial/SerialBl
Changeset: 734ca9f4719c
Author:lancea
Date: 2012-10-10 17:34 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/734ca9f4719c
8000712: Remove unused fields in SyncFactory
Reviewed-by: mchung
! src/share/classes/javax/sql/rowset/spi/SyncFactory.java
Changeset: 3c4be36de073
Author:lancea
Date: 2012-10-10 11:15 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3c4be36de073
8000687: Correct javadoc typo for getLogWriter and setLogWriter
Reviewed-by: alanb
! src/share/classes/java/sql/DriverManager.java
Changeset: 036c55976cef
Author:lancea
Date: 2012-10-09 08:58 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/036c55976cef
7197395: Add @Deprecated to all deprecated methods to eliminate compiler
warnings in JDBC
Reviewed-by: alanb, smarks
! src/share/classes/com/sun/rowset/C
Changeset: 8c6895afe204
Author:lancea
Date: 2012-09-06 13:16 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8c6895afe204
7192302: Remove JDBCRowSetImpl dependency on java.beans
Reviewed-by: alanb, mchung
! src/share/classes/com/sun/rowset/JdbcRowSetImpl.java
Changeset: 11bfec75d333
Author:lancea
Date: 2012-08-30 13:38 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/11bfec75d333
7193683: DriverManager Iterator Warning cleanup
Reviewed-by: lancea
Contributed-by: Dan Xu
! src/share/classes/java/sql/DriverManager.java
Changeset: 28588ace1fb9
Author:lancea
Date: 2012-06-14 15:05 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/28588ace1fb9
7145913: CachedRowSetSwriter.insertNewRow() throws SQLException
Reviewed-by: joehw, naoto, psandoz, forax
! src/share/classes/com/sun/rowset/internal/Cach
Changeset: 6b6a73e8c036
Author:lancea
Date: 2012-06-12 17:32 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6b6a73e8c036
7171918: XmlReaderContentHandler.endElement does not handle a Delete Tag
properly
Reviewed-by: joehw
! src/share/classes/com/sun/rowset/internal/XmlReade
Changeset: 46ff1b63b0c3
Author:lancea
Date: 2012-06-11 07:10 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/46ff1b63b0c3
7171917: CachedRowSetImpl.populate does not handle map properly
Reviewed-by: joehw
! src/share/classes/com/sun/rowset/CachedRowSetImpl.java
Changeset: 8305ddc88a5a
Author:lancea
Date: 2012-06-07 20:11 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8305ddc88a5a
7172551: Remove Native calls from DriverManager for jigsaw
Reviewed-by: alanb, chegar, darcy, mchung
! make/java/java/FILES_c.gmk
! make/java/java/mapfile
Changeset: 4580652d9828
Author:lancea
Date: 2012-05-04 16:00 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4580652d9828
7166598: FilteredRowSetImpl can result in Invalid Cursor Position
Reviewed-by: lancea
Contributed-by: Knut Anders Hatlen
! src/share/classes/com/sun/rows
Changeset: b518b160607f
Author:lancea
Date: 2012-01-26 19:41 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b518b160607f
7133815: address the findbug errors in CachedRowSetImpl, SerialStruct,
BaseRow, SerialInputImpl, SerialOutputImpl
Reviewed-by: forax
! src/share/classes
Changeset: 303b67074666
Author:lancea
Date: 2012-01-24 15:13 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/303b67074666
7132879: address Findbugs issue in WebRowSetXmlWriter
Reviewed-by: forax
! src/share/classes/com/sun/rowset/internal/WebRowSetXmlWriter.java
Changeset: 3c524deb8431
Author:lancea
Date: 2011-12-02 19:33 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3c524deb8431
7116445: Miscellaneous warnings in the JDBC/RowSet classes
Reviewed-by: smarks, chegar
! src/share/classes/com/sun/rowset/CachedRowSetImpl.java
! src/shar
I've run all the tests for all these areas with the changes.http://cr.openjdk.java.net/~alanb/7117357/webrev/Thanks,Alan.
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037Oracle Java Engineering 1 Network Drive Burlington, MA 01803lance.ander...@oracle.com
Changeset: 830d2e46023a
Author:lancea
Date: 2011-11-10 11:41 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/830d2e46023a
7110111: Minor Java SE javadoc & Constructor clean up
Reviewed-by: alanb, darcy
Contributed-by: Martin Desruisseaux
! src/share/classes/java/io/Writer.j
Changeset: 7676670d1e97
Author:lancea
Date: 2011-08-10 16:23 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7676670d1e97
7077451: SerialLob, SerialClob have the wrong checks for setStream methods
Reviewed-by: alanb
Contributed-by: Patrick Reinhart
! src/share/classes/javax/
Changeset: a00f48c96345
Author:lancea
Date: 2011-06-02 12:02 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a00f48c96345
7049107: Cannot call initCause() on BatchUpdateException
Reviewed-by: darcy
! src/share/classes/java/sql/BatchUpdateException.java
Changeset: 6a3a41e0af88
Author:lancea
Date: 2011-05-10 14:41 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6a3a41e0af88
7043443: address missed reason initialization in BatchUpdateException
Reviewed-by: alanb
! src/share/classes/java/sql/BatchUpdateException.java
Changeset: 0b1354ecf5a3
Author:lancea
Date: 2011-04-29 09:04 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0b1354ecf5a3
7040150: Indexing Error in CachedRowSetImpl.removeCurrentRow
Reviewed-by: smarks
! src/share/classes/com/sun/rowset/CachedRowSetImpl.java
Changeset: 28caa191884a
Author:lancea
Date: 2011-04-28 09:46 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/28caa191884a
7038565: address Findbugs issue in BatchUpdateException
Reviewed-by: alanb, forax
! src/share/classes/java/sql/BatchUpdateException.java
Changeset: 9b3e6baad033
Author:lancea
Date: 2011-04-18 12:07 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9b3e6baad033
7037085: Add hashCode() to Timestamp to address Findbugs warning
Reviewed-by: darcy, alanb, emcmanus
! src/share/classes/java/sql/Timestamp.java
Changeset: d9248245a88c
Author:lancea
Date: 2011-04-13 11:21 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d9248245a88c
7036251: Correct SQLPermission constructor javadocs for permission target names
Reviewed-by: alanb
! src/share/classes/java/sql/SQLPermission.java
Changeset: 0bae251b548b
Author:lancea
Date: 2011-04-12 14:32 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0bae251b548b
7007772: Address typos in javadoc for ResultSet
Reviewed-by: ohair, smarks
! src/share/classes/java/sql/ResultSet.java
Changeset: 1bb95f6ac753
Author:lancea
Date: 2011-04-12 12:25 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1bb95f6ac753
7035615: Address lint warnings for javax.sql.rowset & com.sun.rowset
Reviewed-by: alanb, darcy
! src/share/classes/com/sun/rowset/CachedRowSetImpl.java
!
Changeset: 5137806a3e34
Author:lancea
Date: 2011-04-07 11:25 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5137806a3e34
7034656: Address lint warnings for DriverManager
Reviewed-by: alanb, forax, ohair
! src/share/classes/java/sql/DriverManager.java
Changeset: d5bc10b1aa2c
Author:lancea
Date: 2011-04-06 17:37 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d5bc10b1aa2c
7034471: Wrap registeredDrivers in DriverManager
Reviewed-by: alanb, briangoetz
! src/share/classes/java/sql/DriverManager.java
Changeset: df9991dc1f0d
Author:lancea
Date: 2011-03-17 11:37 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/df9991dc1f0d
7026898: DriverManager to now use CopyOnWriteArrayList
Reviewed-by: alanb, briangoetz
! src/share/classes/java/sql/DriverManager.java
Changeset: 9599534b1727
Author:lancea
Date: 2011-02-04 09:07 -0500
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9599534b1727
7014095: Broken link in java.sql package specification
Reviewed-by: alanb
! src/share/classes/java/sql/package.html
Changeset: befe813e24d2
Author:lancea
Date: 2011-01-11 12:36 -0500
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/befe813e24d2
7000693: java.sql.Timestamp compareTo() issues using low values
Reviewed-by: okutsu
! src/share/classes/java/sql/Timestamp.java
Changeset: f4d755bbdabe
Author:lancea
Date: 2011-01-10 14:43 -0500
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f4d755bbdabe
6544224: Remove the need of sun.reflect.misc
Reviewed-by: alanb
! src/share/classes/javax/sql/rowset/serial/SerialJavaObject.java
Changeset: a72e7147816f
Author:lancea
Date: 2010-12-14 16:08 -0500
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a72e7147816f
7006454: Typo in javadocs typo for Statement.executeBatch @since
Reviewed-by: alanb
! src/share/classes/java/sql/Statement.java
Changeset: 1bf378034d39
Author:lancea
Date: 2010-12-09 13:01 -0500
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1bf378034d39
6659234: Incorrect check in SerialBlob.getBytes
Reviewed-by: darcy
! src/share/classes/javax/sql/rowset/serial/SerialBlob.java
Changeset: ff619988afac
Author:lancea
Date: 2010-11-19 17:15 -0500
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ff619988afac
7000752: Duplicate entry in RowSetResourceBundles.properties
Reviewed-by: alanb
! src/share/classes/com/sun/rowset/RowSetResourceBundle.properties
! src/s
Changeset: c4a38022fdc1
Author:lancea
Date: 2010-11-12 08:41 -0500
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c4a38022fdc1
6999086: Clarify that SyncFactory.setLogger can throw an NullPointerException
Reviewed-by: alanb
! src/share/classes/javax/sql/rowset/spi/SyncFactory.java
Changeset: af2de4de1076
Author:lancea
Date: 2010-11-12 07:15 -0500
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/af2de4de1076
6982530: javadoc update to SyncFactory & JdbcResource bundle for
synchronization issues
Reviewed-by: alanb
! src/share/classes/com/sun/rowset/JdbcRowSet
Changeset: 0f23a139e819
Author:lancea
Date: 2010-10-06 10:09 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0f23a139e819
6988310: SyncFactory.setLogger(Logger,Level) requires unspecified security
permission
Reviewed-by: darcy
! src/share/classes/javax/sql/rowset/spi/SyncFac
Changeset: ffaf6a35b895
Author:lancea
Date: 2010-10-04 13:04 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ffaf6a35b895
6989139: Address JDBC Findbugs where Number type Constructor are used
Reviewed-by: ohair
! src/share/classes/com/sun/rowset/CachedRowSetImpl.java
! src/sh
Changeset: 9a8022905f6a
Author:lancea
Date: 2010-10-01 14:36 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9a8022905f6a
6988993: Address Findbugs warnings for the use of String Constructor
Reviewed-by: ohair
! src/share/classes/com/sun/rowset/CachedRowSetImpl.java
! src/sha
Changeset: 7b2b0131fa61
Author:lancea
Date: 2010-09-27 18:05 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7b2b0131fa61
6987638: javadoc update to RowSetProvider and Statement
Reviewed-by: darcy, alanb
! src/share/classes/java/sql/Statement.java
! src/share/classes/javax/sq
1 - 100 of 111 matches
Mail list logo
