Re: RFR: 8288214: serviceability/jvmti/vthread/VThreadNotifyFramePopTest/VThreadNotifyFramePopTest.java test failed

2022-06-12 Thread Leonid Mesnik
On Sat, 11 Jun 2022 08:11:34 GMT, Alan Bateman wrote: > This test connects to http://openjdk.java.net/ so it's not reliable if the > host name can't be resolved or a HTTP connection cannot be established. I've > changed the test to use a local HTTP server so the original test works as >

Integrated: 8287877: Exclude vmTestbase/nsk/jvmti/AttachOnDemand/attach022/TestDescription.java until JDK-8277573 is fixed

2022-06-07 Thread Leonid Mesnik
On Tue, 7 Jun 2022 00:49:29 GMT, Leonid Mesnik wrote: > Please review following fix which exclude failing test. This pull request has now been integrated. Changeset: 8e10c2bf Author: Leonid Mesnik URL: https://git.openjdk.java.net/jdk/commit/8e10c2bfc73a25d93187b62f5aa8e6210d6fe

Re: RFR: 8287877: Exclude vmTestbase/nsk/jvmti/AttachOnDemand/attach022/TestDescription.java until JDK-8277573 is fixed [v3]

2022-06-07 Thread Leonid Mesnik
> Please review following fix which exclude failing test. Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision: fixed merge - Changes: - all: https://git.openjdk.java.net/jdk/pull/9050/files - new: ht

Re: RFR: 8287877: Exclude vmTestbase/nsk/jvmti/AttachOnDemand/attach022/TestDescription.java until JDK-8277573 is fixed [v2]

2022-06-07 Thread Leonid Mesnik
> Please review following fix which exclude failing test. Leonid Mesnik has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits: - Merge branch 'master' of https://github.com/openjdk/jdk into 8287877 - Merge branch 'mas

Re: RFR: 8279358: vmTestbase/nsk/jvmti/scenarios/jni_interception/JI03/ji03t003/TestDescription.java fails with usage tracker

2022-06-06 Thread Leonid Mesnik
On Mon, 9 May 2022 21:26:50 GMT, Alex Menkov wrote: > isThreadExpected function checks only some known JFR/Graal threads. > This approach requires to keep this function up to date (add other internal > threads like usage tracker, loom, etc). > > To avoid this updated all tests which use it,

RFR: 8287877: Exclude vmTestbase/nsk/jvmti/AttachOnDemand/attach022/TestDescription.java until JDK-8277573 is fixed

2022-06-06 Thread Leonid Mesnik
Please review following fix which exclude failing test. - Commit messages: - 8287877: Exclude vmTestbase/nsk/jvmti/AttachOnDemand/attach022/TestDescription.java until JDK-8277573 is fixed Changes: https://git.openjdk.java.net/jdk/pull/9050/files Webrev:

Re: RFR: 8287726: Fix JVMTI tests with "requires vm.continuations" after JDK-8287496

2022-06-02 Thread Leonid Mesnik
On Thu, 2 Jun 2022 09:54:31 GMT, Aleksey Shipilev wrote: > [JDK-8287496](https://bugs.openjdk.java.net/browse/JDK-8287496) brought the > alternative Loom implementation that can be used by ports as the fallback. > That fallback does not support JVMTI entirely, so lots of tests fail. Some >

Integrated: 8287200: Test java/lang/management/ThreadMXBean/VirtualThreadDeadlocks.java timed out after JDK-8287103

2022-05-26 Thread Leonid Mesnik
On Tue, 24 May 2022 19:52:57 GMT, Leonid Mesnik wrote: > Need to use proper synchronization. > > The CyclicBarriers might move the thread to WAITING state but not BLOCKED. So > it should not confuse existing checks. This pull request has now been integrated. Changeset: 176

Re: RFR: 8287200: Test java/lang/management/ThreadMXBean/VirtualThreadDeadlocks.java timed out after JDK-8287103 [v2]

2022-05-26 Thread Leonid Mesnik
> Need to use proper synchronization. > > The CyclicBarriers might move the thread to WAITING state but not BLOCKED. So > it should not confuse existing checks. Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revi

Re: RFR: 8287200: Test java/lang/management/ThreadMXBean/VirtualThreadDeadlocks.java timed out after JDK-8287103

2022-05-25 Thread Leonid Mesnik
On Wed, 25 May 2022 21:18:24 GMT, master-code-java wrote: >> Need to use proper synchronization. >> >> The CyclicBarriers might move the thread to WAITING state but not BLOCKED. >> So it should not confuse existing checks. > >

Re: RFR: 8286490: JvmtiEventControllerPrivate::set_event_callbacks CLEARING_MASK computation is incorrect

2022-05-24 Thread Leonid Mesnik
On Tue, 24 May 2022 05:45:17 GMT, Serguei Spitsyn wrote: > It was a typo when the original CLEARING_MASK was initially introduced: > > > // Mask to clear normal event bits. > const jlong CLEARING_MASK = (1L >> (TOTAL_MIN_EVENT_TYPE_VAL - > TOTAL_MIN_EVENT_TYPE_VAL)) - 1L; > // Avoid

RFR: 8287200: Test java/lang/management/ThreadMXBean/VirtualThreadDeadlocks.java timed out after JDK-8287103

2022-05-24 Thread Leonid Mesnik
Need to use proper synchronization. The CyclicBarriers might move the thread to WAITING state but not BLOCKED. So it should not confuse existing checks. - Commit messages: - 8287200 Changes: https://git.openjdk.java.net/jdk/pull/8874/files Webrev:

Integrated: 8285739: disable EscapeBarrier deopt for virtual threads

2022-05-23 Thread Leonid Mesnik
On Mon, 9 May 2022 01:36:39 GMT, Leonid Mesnik wrote: > The fix disables EscapeBarrier and EscapeAnalysis when certain JVMTI > capabilities are enabled and --enable-preview. > > It restores the same behavior as it was before > https://bugs.openjdk.java.net/browse/JDK-8227745

Integrated: 8287103: java/lang/management/ThreadMXBean/VirtualThreadDeadlocks.java fails with Xcomp

2022-05-23 Thread Leonid Mesnik
On Fri, 20 May 2022 22:27:29 GMT, Leonid Mesnik wrote: > Sync improved in test This pull request has now been integrated. Changeset: 110d9064 Author: Leonid Mesnik URL: https://git.openjdk.java.net/jdk/commit/110d906432761482acd2899be1314e075bc21bec Stats: 7 lines in 1 f

Re: RFR: 8285739: disable EscapeBarrier deopt for virtual threads [v2]

2022-05-23 Thread Leonid Mesnik
On Mon, 23 May 2022 10:20:39 GMT, Richard Reingruber wrote: > Could it be that you mean > [JDK-8264699](https://bugs.openjdk.java.net/browse/JDK-8264699)? > Yes, you are right. > I'm ok with this version of your fix. I'd suggest to change title/synopsis of > the bug report to better match it

Re: RFR: 8287103: java/lang/management/ThreadMXBean/VirtualThreadDeadlocks.java fails with Xcomp [v2]

2022-05-21 Thread Leonid Mesnik
> Sync improved in test Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision: fix - Changes: - all: https://git.openjdk.java.net/jdk/pull/8821/files - new: https://git.openjdk.java.net/jdk/pull/8821/files/b3f87

Re: RFR: 8285739: disable EA when both JVMTI and Preview are enabled [v2]

2022-05-21 Thread Leonid Mesnik
On Sat, 21 May 2022 12:14:11 GMT, Richard Reingruber wrote: > Hi Leonid, if EscapeAnalysis is not disabled, then local objects cannot be > read per JVMTI if they are scalarized in compiled frames on the heap, right? > This would be a problem I'd think. Thanks, Richard. Yes, the fix restores

Re: RFR: 8285739: disable EA when both JVMTI and Preview are enabled [v2]

2022-05-20 Thread Leonid Mesnik
On Fri, 20 May 2022 20:09:59 GMT, Leonid Mesnik wrote: >> The fix disables EscapeBarrier and EscapeAnalysis when certain JVMTI >> capabilities are enabled and --enable-preview. >> >> It restores the same behavior as it was before >> https://bugs.openjdk.java.

Re: RFR: 8285739: disable EA when both JVMTI and Preview are enabled [v2]

2022-05-20 Thread Leonid Mesnik
On Fri, 20 May 2022 20:09:59 GMT, Leonid Mesnik wrote: >> The fix disables EscapeBarrier and EscapeAnalysis when certain JVMTI >> capabilities are enabled and --enable-preview. >> >> It restores the same behavior as it was before >> https://bugs.openjdk.java.

RFR: 8287103: java/lang/management/ThreadMXBean/VirtualThreadDeadlocks.java fails with Xcomp

2022-05-20 Thread Leonid Mesnik
Sync improved in test - Commit messages: - 8287103: java/lang/management/ThreadMXBean/VirtualThreadDeadlocks.java fails with Xcomp Changes: https://git.openjdk.java.net/jdk/pull/8821/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=8821=00 Issue:

Re: RFR: 8285739: disable EA when both JVMTI and Preview are enabled [v2]

2022-05-20 Thread Leonid Mesnik
On Fri, 20 May 2022 20:09:59 GMT, Leonid Mesnik wrote: >> The fix disables EscapeBarrier and EscapeAnalysis when certain JVMTI >> capabilities are enabled and --enable-preview. >> >> It restores the same behavior as it was before >> https://bugs.openjdk.java.

Re: RFR: 8285739: disable EA when both JVMTI and Preview are enabled [v2]

2022-05-20 Thread Leonid Mesnik
ormance in the Presence of JVMTI Agents" is implemented when > Continuations are enabled. Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision: 2nd v - Changes: - all: https://git.openjdk.java.net/jdk/pull/8589/files - ne

Re: RFR: 8286983: Add mention of "Preview Feature" for new loom related jdb and debug agent options

2022-05-18 Thread Leonid Mesnik
On Thu, 19 May 2022 00:10:15 GMT, Chris Plummer wrote: > As part of the loom integration, jdb added -trackvthreads and the debug agent > added "enumeratevthreads". The help text for these options should call out > that they are Preview Features. Marked as reviewed by lmesnik (Reviewer).

Integrated: 8283001: windows-x86-cmp-baseline fails in some jvmti native libs

2022-05-11 Thread Leonid Mesnik
On Tue, 10 May 2022 20:23:01 GMT, Leonid Mesnik wrote: > 8283001: windows-x86-cmp-baseline fails in some jvmti native libs This pull request has now been integrated. Changeset: 82d25700 Author: Leonid Mesnik URL: https://git.openjdk.java.net/jdk/com

Integrated: 8278123: serviceability/dcmd/vm/ClassLoaderStatsTest.java failing with java.lang.AssertionError: Should have a hidden class

2022-05-10 Thread Leonid Mesnik
On Wed, 27 Apr 2022 23:49:56 GMT, Leonid Mesnik wrote: > The test failed if GC happens somewhere between > Class c = Class.forName("TestClass", true, dummyloader); > and > OutputAnalyzer output = executor.execute("VM.classloader_stats"); > > The fix

RFR: 8283001: windows-x86-cmp-baseline fails in some jvmti native libs

2022-05-10 Thread Leonid Mesnik
8283001: windows-x86-cmp-baseline fails in some jvmti native libs - Commit messages: - 8283001 Changes: https://git.openjdk.java.net/jdk/pull/8641/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=8641=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8283001 Stats: 85

Re: RFR: 8278123: serviceability/dcmd/vm/ClassLoaderStatsTest.java failing with java.lang.AssertionError: Should have a hidden class [v3]

2022-05-10 Thread Leonid Mesnik
> To verfiy fix I add System.gc() before > executor.execute("VM.classloader_stats"); Leonid Mesnik has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains se

Re: RFR: 8278123: serviceability/dcmd/vm/ClassLoaderStatsTest.java failing with java.lang.AssertionError: Should have a hidden class [v2]

2022-05-10 Thread Leonid Mesnik
On Tue, 10 May 2022 05:14:19 GMT, Alan Bateman wrote: > I assume you'll remove this test from the-Xcomp exclude list > (test/hotspot/jtreg/ProblemList-Xcomp.txt) as part of this change, Sure. The PR reminded me about this. But I need to push problemlist cleanup first and than merge chnges.

Integrated: 8286438: Add jhsdb jstack processing without --mixed in efh

2022-05-10 Thread Leonid Mesnik
On Mon, 9 May 2022 20:35:57 GMT, Leonid Mesnik wrote: > The default is required only to set the same depth level in the tree on HTML > page for default and mixed mode. This pull request has now been integrated. Changeset: d347fc12 Author:Leonid Mesnik URL:

Re: RFR: 8283651: nsk/jvmti/SuspendThread/suspendthrd003 may leak native memory

2022-05-09 Thread Leonid Mesnik
On Mon, 9 May 2022 20:15:21 GMT, Daniel D. Daugherty wrote: > A trivial fix to nsk_jvmti_threadByName() to solve a native memory leak. > > This fix has been stress tested with my > StressWrapper60M_NMT_detail_suspendthrd003.java > test and I did NMT detailed monitoring for the whole 60M run.

Re: RFR: 8285739: disable EA when both JVMTI and Preview are enabled

2022-05-09 Thread Leonid Mesnik
On Mon, 9 May 2022 21:31:12 GMT, Richard Reingruber wrote: > Hi Leonid, > > have you done some testing? > [JDK-8227745](https://bugs.openjdk.java.net/browse/JDK-8227745) came with a > bunch of tests. I wonder how they behave with your change. > > Thanks, Richard. Thank you for looking on

Re: RFR: 8285739: disable EA when both JVMTI and Preview are enabled

2022-05-09 Thread Leonid Mesnik
On Mon, 9 May 2022 01:36:39 GMT, Leonid Mesnik wrote: > The fix disables EscapeBarrier and EscapeAnalysis when certain JVMTI > capabilities are enabled and --enable-preview. > > It restores the same behavior as it was before > https://bugs.openjdk.java.net/browse/JDK-8227745

Withdrawn: 8285739: disable EA when both JVMTI and Preview are enabled

2022-05-09 Thread Leonid Mesnik
On Mon, 9 May 2022 01:36:39 GMT, Leonid Mesnik wrote: > The fix disables EscapeBarrier and EscapeAnalysis when certain JVMTI > capabilities are enabled and --enable-preview. > > It restores the same behavior as it was before > https://bugs.openjdk.java.net/browse/JDK-8227745

RFR: 8285739: disable EA when both JVMTI and Preview are enabled

2022-05-09 Thread Leonid Mesnik
The fix disables EscapeBarrier and EscapeAnalysis when certain JVMTI capabilities are enabled and --enable-preview. It restores the same behavior as it was before https://bugs.openjdk.java.net/browse/JDK-8227745 "Enable Escape Analysis for Better Performance in the Presence of JVMTI Agents" is

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v8]

2022-05-02 Thread Leonid Mesnik
On Fri, 29 Apr 2022 06:33:42 GMT, Serguei Spitsyn wrote: >> Alan Bateman has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Refresh 7965cc6b168e567ac2596f2fbc3b00a7d99b7e1e > >

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v8]

2022-05-02 Thread Leonid Mesnik
On Fri, 29 Apr 2022 06:43:02 GMT, Serguei Spitsyn wrote: >> Alan Bateman has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Refresh 7965cc6b168e567ac2596f2fbc3b00a7d99b7e1e > >

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v8]

2022-05-02 Thread Leonid Mesnik
On Fri, 29 Apr 2022 06:09:35 GMT, Serguei Spitsyn wrote: >> Alan Bateman has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Refresh 7965cc6b168e567ac2596f2fbc3b00a7d99b7e1e > >

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v8]

2022-05-02 Thread Leonid Mesnik
On Fri, 29 Apr 2022 05:48:19 GMT, Serguei Spitsyn wrote: >> Alan Bateman has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Refresh 7965cc6b168e567ac2596f2fbc3b00a7d99b7e1e > >

Re: RFR: 8278123: serviceability/dcmd/vm/ClassLoaderStatsTest.java failing with java.lang.AssertionError: Should have a hidden class [v2]

2022-04-28 Thread Leonid Mesnik
> To verfiy fix I add System.gc() before > executor.execute("VM.classloader_stats"); Leonid Mesnik has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three

Re: RFR: 8278123: serviceability/dcmd/vm/ClassLoaderStatsTest.java failing with java.lang.AssertionError: Should have a hidden class

2022-04-27 Thread Leonid Mesnik
On Thu, 28 Apr 2022 00:44:18 GMT, Chris Plummer wrote: >> The test failed if GC happens somewhere between >> Class c = Class.forName("TestClass", true, dummyloader); >> and >> OutputAnalyzer output = executor.execute("VM.classloader_stats"); >> >> The fix is to make hc static as Chris proposed.

RFR: 8278123: serviceability/dcmd/vm/ClassLoaderStatsTest.java failing with java.lang.AssertionError: Should have a hidden class

2022-04-27 Thread Leonid Mesnik
The test failed if GC happens somewhere between Class c = Class.forName("TestClass", true, dummyloader); and OutputAnalyzer output = executor.execute("VM.classloader_stats"); The fix is to make hc static as Chris proposed. To verfiy fix I add System.gc() before

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v8]

2022-04-27 Thread Leonid Mesnik
On Wed, 27 Apr 2022 14:24:20 GMT, Alan Bateman wrote: >> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which >> JDK version to target. >> >> We will refresh this PR periodically to pick up changes and fixes from the >> loom repo. >> >> Most of the new mechanisms in

Withdrawn: 8284616: Implement workaround for CODETOOLS-7901986 in serviceability/jvmti/RedefineClasses

2022-04-11 Thread Leonid Mesnik
On Fri, 8 Apr 2022 22:15:21 GMT, Leonid Mesnik wrote: > The tests serviceability/jvmti/RedefineClasses start failing in loom-repo > with CNFE like "java.lang.NoClassDefFoundError: > jdk/test/lib/compiler/InMemoryJavaCompiler" > > It is not a loom specific bug, it mig

Re: RFR: 8284616: Implement workaround for CODETOOLS-7901986 in serviceability/jvmti/RedefineClasses

2022-04-11 Thread Leonid Mesnik
On Sat, 9 Apr 2022 00:39:46 GMT, Alex Menkov wrote: >> The tests serviceability/jvmti/RedefineClasses start failing in loom-repo >> with CNFE like "java.lang.NoClassDefFoundError: >> jdk/test/lib/compiler/InMemoryJavaCompiler" >> >> It is not a loom specific bug, it might happen in jdk/jdk

RFR: 8284616: Implement workaround for CODETOOLS-7901986 in serviceability/jvmti/RedefineClasses

2022-04-08 Thread Leonid Mesnik
The tests serviceability/jvmti/RedefineClasses start failing in loom-repo with CNFE like "java.lang.NoClassDefFoundError: jdk/test/lib/compiler/InMemoryJavaCompiler" It is not a loom specific bug, it might happen in jdk/jdk also. The workaround is to build some classes explicitly. The fix was

Integrated: 8284556: Ensure reachability of classes in runtime/whitebox/TestHiddenClassIsAlive.java and serviceability/dcmd/vm/ClassLoaderHierarchyTest.java

2022-04-08 Thread Leonid Mesnik
On Thu, 7 Apr 2022 23:29:41 GMT, Leonid Mesnik wrote: > Tests are updated to ensure that classes are alive while test checks them. > Actually, fixed by @AlanBateman in repo-loom. This pull request has now been integrated. Changeset: a8c87526 Author:Leonid Mesnik URL:

RFR: 8284556: Ensure reachability of classes in runtime/whitebox/TestHiddenClassIsAlive.java and serviceability/dcmd/vm/ClassLoaderHierarchyTest.java

2022-04-07 Thread Leonid Mesnik
Tests are updated to ensure that classes are alive while test checks them. Actually, fixed by @AlanBateman in repo-loom. - Commit messages: - 8284556: Ensure reachability of classes in runtime/whitebox/TestHiddenClassIsAlive.java and

Re: RFR: 8284458: CodeHeapState::aggregate() leaks blob_name [v3]

2022-04-07 Thread Leonid Mesnik
On Thu, 7 Apr 2022 02:57:29 GMT, Zhengyu Gu wrote: >> Please review this small patch to fix a possible memory leak. >> >> Test: >> - [x] hotspot_serviceability > > Zhengyu Gu has updated the pull request incrementally with one additional > commit since the last revision: > > Fix Marked as

Re: RFR: 8284495: [testbug] Adapt nsk tests to the RISC-V platform

2022-04-07 Thread Leonid Mesnik
On Thu, 7 Apr 2022 05:47:56 GMT, Feilong Jiang wrote: > Add riscv which doesn't have shared memory connector. > Following tests passed with this patch and > [CODETOOLS-7903138](https://github.com/openjdk/jtreg/pull/66): > > - vmTestbase/nsk/jdb/options/connect/connect003/connect003.java > -

Re: RFR: 8283717: vmTestbase/nsk/jdi/ThreadStartEvent/thread/thread001 failed due to SocketTimeoutException

2022-03-28 Thread Leonid Mesnik
On Mon, 28 Mar 2022 19:58:59 GMT, Chris Plummer wrote: > In this test the debuggee creates a couple of threads, and the debugger > checks to make sure it gets a ThreadStartEvent for each of these threads, > plus one for the main debuggee thread. Once it has done this, it disables the >

Re: RFR: 8283800: Simplify String.indexOf/lastIndexOf calls

2022-03-28 Thread Leonid Mesnik
On Sun, 20 Mar 2022 12:45:34 GMT, Andrey Turbanov wrote: > In a few places String.indexOf/lastIndexOf methods are called with default > parameter for index: `0` for `indexOf`, length() for `lastIndexOf`. > I propose to cleanup such calls. It makes code a bit easier to read. In case > of

Re: RFR: 8283799: Collapse identical catch branches in jdk.hotspot.agent

2022-03-28 Thread Leonid Mesnik
On Sat, 26 Mar 2022 20:50:34 GMT, Andrey Turbanov wrote: > Let's take advantage of Java 7 languate feature - "Catching Multiple > Exception Types". > It simplifies code. Reduce duplication. > Found by IntelliJ IDEA inspection `Identical 'catch' branches in 'try' > statement` Marked as

Re: RFR: 8283587: [BACKOUT] Invalid generic signature for redefined classes

2022-03-23 Thread Leonid Mesnik
On Thu, 24 Mar 2022 01:31:42 GMT, Alex Menkov wrote: > The change reverts the fix for JDK-8282241 which causes regression Although I think it is a test problem, backout is fine. - Marked as reviewed by lmesnik (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/7934

Re: RFR: 8282314: nsk/jvmti/SuspendThread/suspendthrd003 may leak memory

2022-03-10 Thread Leonid Mesnik
On Wed, 9 Mar 2022 20:41:37 GMT, Daniel D. Daugherty wrote: > A trivial fix to solve a memory leak/memory pinning for long runs of > suspendthrd003. > > See the bug report for the gory analysis details. > > This fix was included in my jdk-19+12 stress runs so the updated test was > executed

Re: RFR: 8282170: JVMTI SetBreakpoint metaspace allocation test [v5]

2022-03-10 Thread Leonid Mesnik
On Wed, 9 Mar 2022 10:11:41 GMT, Aleksey Shipilev wrote: >> There are few bugs in SetBreakpoint when it reaches for metaspace >> allocation, notably >> [JDK-8214992](https://bugs.openjdk.java.net/browse/JDK-8214992) and >> [JDK-8264149](https://bugs.openjdk.java.net/browse/JDK-8264149). This

Re: RFR: 8282852: Debug agent asserts in classTrack_addPreparedClass() [v2]

2022-03-09 Thread Leonid Mesnik
On Wed, 9 Mar 2022 07:52:37 GMT, Chris Plummer wrote: >> Fix incorrect assert that assumed the debug agent should never see a >> ClassPrepare event for a class that it already saw when calling >> GetLoadedClasses. Details can be found in the bug description. > > Chris Plummer has updated the

Re: RFR: 8282170: JVMTI SetBreakpoint metaspace allocation test [v4]

2022-03-08 Thread Leonid Mesnik
On Tue, 8 Mar 2022 18:37:45 GMT, Aleksey Shipilev wrote: >> There are few bugs in SetBreakpoint when it reaches for metaspace >> allocation, notably >> [JDK-8214992](https://bugs.openjdk.java.net/browse/JDK-8214992) and >> [JDK-8264149](https://bugs.openjdk.java.net/browse/JDK-8264149). This

Re: RFR: 8282170: JVMTI SetBreakpoint metaspace allocation test [v3]

2022-03-07 Thread Leonid Mesnik
On Mon, 28 Feb 2022 18:49:05 GMT, Aleksey Shipilev wrote: >> There are few bugs in SetBreakpoint when it reaches for metaspace >> allocation, notably >> [JDK-8214992](https://bugs.openjdk.java.net/browse/JDK-8214992) and >> [JDK-8264149](https://bugs.openjdk.java.net/browse/JDK-8264149). This

Re: RFR: 8282076: Merge some debug agent changes from the loom repo

2022-02-23 Thread Leonid Mesnik
On Thu, 17 Feb 2022 21:32:14 GMT, Chris Plummer wrote: > There are some minor debug agent changes in the loom repo that are not > virtual thread specific, and I would like to merge them into the jdk repo. > This will make the future real merge of loom into jdk a bit cleaner. > > The biggest

Re: RFR: 8281243: Test java/lang/instrument/RetransformWithMethodParametersTest.java is failing

2022-02-04 Thread Leonid Mesnik
On Fri, 4 Feb 2022 11:18:39 GMT, Alex Menkov wrote: > The test expects ClassFileReconstituter restores exactly the same bytes as > original classbytes. > This can be wrong if the class has more than 1 method (due to method sorting > in the VM). > MethodParametersTarget class had only 1 method

Re: RFR: 8280554: resourcehogs/serviceability/sa/ClhsdbRegionDetailsScanOopsForG1.java can fail if GC is triggered [v2]

2022-02-01 Thread Leonid Mesnik
On Fri, 28 Jan 2022 07:49:42 GMT, Chris Plummer wrote: >> When using -Xcomp, the liveness of some objects the test allocates is more >> precisely known, allowing the objects to be collected before the test >> expects. This became an issue in the loom repo because it has changes that >> result

Re: RFR: 8280555: serviceability/sa/TestObjectMonitorIterate.java is failing due to ObjectMonitor referencing a null Object

2022-01-26 Thread Leonid Mesnik
On Wed, 26 Jan 2022 20:15:59 GMT, Chris Plummer wrote: > This test is failing in the loom repo when using -Xcomp. The reason is > because loom introduced doing a full GC in the codecache sweeper, which > causes some of the Objects referenced by ObjectMonitors to be GC'd. The fix > is to check

Re: RFR: 8280166: Extend java/lang/instrument/GetObjectSizeIntrinsicsTest.java test cases [v2]

2022-01-21 Thread Leonid Mesnik
On Fri, 21 Jan 2022 11:04:26 GMT, Aleksey Shipilev wrote: >> While working on JDK-8280003, I noticed that >> java/lang/instrument/GetObjectSizeIntrinsicsTest.java does not test arrays >> with more than 1-byte size elements, and no large arrays (past 4G limit) are >> tested either. It would be

Re: RFR: 8274982: Add a test for 8269574. [v2]

2021-12-16 Thread Leonid Mesnik
On Thu, 16 Dec 2021 20:20:41 GMT, Evgeny Nikitin wrote: >> This PR contains a relatively simple test which verifies that JVMTI-agents >> are correctly informed about exceptions caught in C2-compiled code. The >> 8269574 introduces pre-allocated exceptions in some paths, so the test tries >>

Re: RFR: 8274982: Add a test for 8269574. [v2]

2021-12-16 Thread Leonid Mesnik
On Thu, 16 Dec 2021 20:16:39 GMT, Evgeny Nikitin wrote: >> test/hotspot/jtreg/compiler/jvmti/TriggerBuiltinExceptionsTest.java line 28: >> >>> 26: * @bug 8269574 >>> 27: * @summary Verifies that exceptions are reported correctly to JVMTI in >>> the compiled code >>> 28: * @requires vm.jvmti

Re: RFR: 8278643: CoreUtils.getCoreFileLocation() should print out the size of the core file found

2021-12-13 Thread Leonid Mesnik
On Tue, 14 Dec 2021 01:14:45 GMT, Chris Plummer wrote: > Include the size of the core file when printing a message that it was found. Marked as reviewed by lmesnik (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6822

Re: RFR: 8258512: serviceability/sa/TestJmapCore.java timed out on macOS 10.13.6

2021-12-02 Thread Leonid Mesnik
On Thu, 2 Dec 2021 17:36:43 GMT, Chris Plummer wrote: > Increase the test timeout to 480 just to make sure we don't see this timeout > anymore. This same change was already made to TestJmapCoreMetaspace.java a > long time ago. Marked as reviewed by lmesnik (Reviewer). - PR:

Integrated: 8264605: vmTestbase/nsk/jvmti/SuspendThread/suspendthrd003/TestDescription.java failed with "agent_tools.cpp, 471: (foundThread = (jthread) jni_env->NewGlobalRef(foundThread)) != NULL"

2021-11-24 Thread Leonid Mesnik
On Tue, 23 Nov 2021 06:49:47 GMT, Leonid Mesnik wrote: > The agentThread variable might have been set by the new agentThread iteration > and then deleted in the wrapper from the previous iteration. > > The deletion of agentThread variable should be synced with the termination of

Re: RFR: 8264605: vmTestbase/nsk/jvmti/SuspendThread/suspendthrd003/TestDescription.java failed with "agent_tools.cpp, 471: (foundThread = (jthread) jni_env->NewGlobalRef(foundThread)) != NULL"

2021-11-24 Thread Leonid Mesnik
On Wed, 24 Nov 2021 02:16:29 GMT, David Holmes wrote: >> The new thread is started in nsk_jvmti_runAgentThread which is executed >> under monitors also as well as nsk_jvmti_resetAgentData. >> Could you please point exact location which is not protected? Seems all >> thread_state changes and

Integrated: 8265796: vmTestbase/nsk/jdi/ObjectReference/referringObjects/referringObjects002/referringObjects002.java fails when running with JEP 416

2021-11-23 Thread Leonid Mesnik
On Tue, 16 Nov 2021 02:03:46 GMT, Leonid Mesnik wrote: > The nsk.share.jdi.TestClass1 is used via reflection. The reflective call > creates MethodHandle and one more reference to TestClass1. So the number of > expected references should be incremented. Thanks to @plummercj and

Re: RFR: 8265796: vmTestbase/nsk/jdi/ObjectReference/referringObjects/referringObjects002/referringObjects002.java fails when running with JEP 416 [v4]

2021-11-23 Thread Leonid Mesnik
ints references to inspected class. Leonid Mesnik has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits: - Merge branch 'master' into 8265796 - force GC to clean weak references - updated - fix -

Re: RFR: 8264605: vmTestbase/nsk/jvmti/SuspendThread/suspendthrd003/TestDescription.java failed with "agent_tools.cpp, 471: (foundThread = (jthread) jni_env->NewGlobalRef(foundThread)) != NULL"

2021-11-23 Thread Leonid Mesnik
On Tue, 23 Nov 2021 06:49:47 GMT, Leonid Mesnik wrote: > The agentThread variable might have been set by the new agentThread iteration > and then deleted in the wrapper from the previous iteration. > > The deletion of agentThread variable should be synced with the termination of

RFR: 8264605: vmTestbase/nsk/jvmti/SuspendThread/suspendthrd003/TestDescription.java failed with "agent_tools.cpp, 471: (foundThread = (jthread) jni_env->NewGlobalRef(foundThread)) != NULL"

2021-11-22 Thread Leonid Mesnik
The agentThread variable might have been set by the new agentThread iteration and then deleted in the wrapper from the previous iteration. The deletion of agentThread variable should be synced with the termination of the agent thread. - Commit messages: - merge - fix Changes:

Integrated: 8265795: vmTestbase/nsk/jvmti/AttachOnDemand/attach022/TestDescription.java fails when running with JEP 416

2021-11-22 Thread Leonid Mesnik
On Fri, 19 Nov 2021 15:32:24 GMT, Leonid Mesnik wrote: > The VMObjectAlloc jvmti event was not generated for objects created using > MethodHanldle. The fix adds posting of the event into Unsafe_AllocateInstance. > > While fixing this bug I noticed that event is not posted in th

Re: RFR: 8265795: vmTestbase/nsk/jvmti/AttachOnDemand/attach022/TestDescription.java fails when running with JEP 416 [v2]

2021-11-21 Thread Leonid Mesnik
On Mon, 22 Nov 2021 01:38:47 GMT, David Holmes wrote: >> Leonid Mesnik has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed > > test/hotspot/jtreg/serviceability/jvmti/VMObjectAlloc/VMObjectAlloc

Re: RFR: 8265795: vmTestbase/nsk/jvmti/AttachOnDemand/attach022/TestDescription.java fails when running with JEP 416 [v2]

2021-11-21 Thread Leonid Mesnik
ment some common way to handle this and cover it > in another issue. Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision: fixed - Changes: - all: https://git.openjdk.java.net/jdk/pull/6478/files - new: https://git.openjdk.java

Re: RFR: 8274898: Cleanup usages of StringBuffer in jdk tools modules

2021-11-20 Thread Leonid Mesnik
On Thu, 9 Sep 2021 06:53:13 GMT, Andrey Turbanov wrote: > StringBuffer is a legacy synchronized class. StringBuilder is a direct > replacement to StringBuffer which generally have better performance Marked as reviewed by lmesnik (Reviewer). - PR:

Re: RFR: 8277413: Remove unused local variables in jdk.hotspot.agent

2021-11-20 Thread Leonid Mesnik
On Wed, 10 Nov 2021 09:33:23 GMT, Andrey Turbanov wrote: > 8277413: Remove unused local variables in jdk.hotspot.agent Marked as reviewed by lmesnik (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6329

Re: RFR: 8266593: vmTestbase/nsk/jvmti/PopFrame/popframe011 fails with "assert(java_thread == _state->get_thread()) failed: Must be" [v3]

2021-11-20 Thread Leonid Mesnik
On Thu, 18 Nov 2021 09:34:13 GMT, Serguei Spitsyn wrote: >> The test fails when the target JavaThread has is_exiting() status. In such a >> case the JvmtiExport::cleanup_thread(this) has already made a clean up of >> its jvmtiThreadState, so the JavaThread address returned by >>

RFR: 8265795: vmTestbase/nsk/jvmti/AttachOnDemand/attach022/TestDescription.java fails when running with JEP 416

2021-11-19 Thread Leonid Mesnik
The VMObjectAlloc jvmti event was not generated for objects created using MethodHanldle. The fix adds posting of the event into Unsafe_AllocateInstance. While fixing this bug I noticed that event is not posted in the intrinsics version for many functions where it is used. Including but not

Re: RFR: 8265796: vmTestbase/nsk/jdi/ObjectReference/referringObjects/referringObjects002/referringObjects002.java fails when running with the fix for JDK-6824466 [v3]

2021-11-17 Thread Leonid Mesnik
On Thu, 18 Nov 2021 04:03:06 GMT, Leonid Mesnik wrote: >> The nsk.share.jdi.TestClass1 is used via reflection. The reflective call >> creates MethodHandle and one more reference to TestClass1. So the number of >> expected references should be incremented. Th

Re: RFR: 8265796: vmTestbase/nsk/jdi/ObjectReference/referringObjects/referringObjects002/referringObjects002.java fails when running with the fix for JDK-6824466 [v3]

2021-11-17 Thread Leonid Mesnik
ints references to inspected class. Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision: force GC to clean weak references - Changes: - all: https://git.openjdk.java.net/jdk/pull/6402/files - new: https://git.openjdk.java.ne

Re: RFR: 8265796: vmTestbase/nsk/jdi/ObjectReference/referringObjects/referringObjects002/referringObjects002.java fails when running with the fix for JDK-6824466 [v2]

2021-11-17 Thread Leonid Mesnik
On Tue, 16 Nov 2021 02:45:13 GMT, Leonid Mesnik wrote: >> The nsk.share.jdi.TestClass1 is used via reflection. The reflective call >> creates MethodHandle and one more reference to TestClass1. So the number of >> expected references should be incremented. Th

Re: RFR: 8266593: vmTestbase/nsk/jvmti/PopFrame/popframe011 fails with "assert(java_thread == _state->get_thread()) failed: Must be"

2021-11-17 Thread Leonid Mesnik
On Wed, 17 Nov 2021 22:21:33 GMT, Serguei Spitsyn wrote: > The test fails when the target JavaThread has is_exiting() status. In such a > case the JvmtiExport::cleanup_thread(this) has already made a clean up of its > jvmtiThreadState, so the JavaThread address returned by _state->get_thread()

Re: RFR: 8265796: vmTestbase/nsk/jdi/ObjectReference/referringObjects/referringObjects002/referringObjects002.java fails when running with the fix for JDK-6824466 [v2]

2021-11-16 Thread Leonid Mesnik
On Tue, 16 Nov 2021 02:45:13 GMT, Leonid Mesnik wrote: >> The nsk.share.jdi.TestClass1 is used via reflection. The reflective call >> creates MethodHandle and one more reference to TestClass1. So the number of >> expected references should be incremented. Th

Re: RFR: 8265796: vmTestbase/nsk/jdi/ObjectReference/referringObjects/referringObjects002/referringObjects002.java fails when running with the fix for JDK-6824466 [v2]

2021-11-15 Thread Leonid Mesnik
ints references to inspected class. Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision: updated - Changes: - all: https://git.openjdk.java.net/jdk/pull/6402/files - new: https://git.openjdk.java.net/jdk/pull/6402/files/f48

RFR: 8265796: vmTestbase/nsk/jdi/ObjectReference/referringObjects/referringObjects002/referringObjects002.java fails when running with the fix for JDK-6824466

2021-11-15 Thread Leonid Mesnik
The nsk.share.jdi.TestClass1 is used via reflection. The reflective call creates MethodHandle and one more reference to TestClass1. So the number of expected references should be incremented. Thanks to @plummercj and @mlchung for the investigation. This fix also prints references to inspected

Re: RFR: 8276628: Use blessed modifier order in serviceability code

2021-11-04 Thread Leonid Mesnik
On Thu, 4 Nov 2021 10:44:41 GMT, Magnus Ihse Bursie wrote: > I ran bin/blessed-modifier-order.sh on source owned by serviceability. This > scripts verifies that modifiers are in the "blessed" order, and fixes it > otherwise. I have manually checked the changes made by the script to make >

Re: RFR: JDK-8274930: sun/tools/jps/TestJps.java can fail with long VM arguments string

2021-11-01 Thread Leonid Mesnik
On Thu, 7 Oct 2021 21:46:47 GMT, Alex Menkov wrote: > The fix adds "-XX:PerfMaxStringConstLength" argument running target app > (default is 1024, 8K should be enough for any environments) Marked as reviewed by lmesnik (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5858

Re: RFR: 8274621: NullPointerException because listenAddress[0] is null

2021-10-27 Thread Leonid Mesnik
On Tue, 5 Oct 2021 22:34:38 GMT, Alex Menkov wrote: > The change fixes ProcessTools.startProcess "warmup predicate" synchronization > issue. > Initially the predicate was called only for STDOUT; > From jdk8 it's called for STDERR too (but ProcessTools javadoc was not > updated). > The fix

Re: RFR: 8275666: serviceability/jvmti/GetObjectSizeClass.java shouldn't have vm.flagless

2021-10-20 Thread Leonid Mesnik
On Wed, 20 Oct 2021 18:34:36 GMT, Igor Ignatyev wrote: > Hi all, > > could you please review this tiny patch? > > from JBS: >> serviceability/jvmti/GetObjectSizeClass.java doesn't ignore external flags >> (where it matters) and hence should not have been marked w/ vm.flagless > > Thanks, >

Integrated: 8273921: Refactor NSK/JDI tests to create thread using factory

2021-09-21 Thread Leonid Mesnik
On Wed, 15 Sep 2021 00:34:08 GMT, Leonid Mesnik wrote: > 8273921: Refactor NSK/JDI tests to create thread using factory This pull request has now been integrated. Changeset: a72c8aa6 Author: Leonid Mesnik URL: https://git.openjdk.java.net/jdk/com

Re: RFR: 8273921: Refactor NSK/JDI tests to create thread using factory [v6]

2021-09-21 Thread Leonid Mesnik
On Mon, 20 Sep 2021 22:08:19 GMT, Chris Plummer wrote: >> I've gotten through about 1/3 of the test plus the new files, so thought I'd >> pass along my comments so far. Overall it looks good though. > >> I've gotten through about 1/3 of the test plus the new files, so thought I'd >> pass along

Re: RFR: 8206438: com/sun/jdi/FieldWatchpoints.java timeout intermittently

2021-09-21 Thread Leonid Mesnik
On Tue, 21 Sep 2021 07:40:01 GMT, Fairoz Matte wrote: > 8206438: com/sun/jdi/FieldWatchpoints.java timeout intermittently I haven't found any analysis for these failures in the bug. Why does increasing of timeout fix the issue? - PR: https://git.openjdk.java.net/jdk/pull/5598

Re: RFR: 8273921: Refactor NSK/JDI tests to create thread using factory [v6]

2021-09-20 Thread Leonid Mesnik
> 8273921: Refactor NSK/JDI tests to create thread using factory Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision: fixed line numbers after Idea autoimport. - Changes: - all: https://git.openjdk.java.net/jdk/pull/5

Re: RFR: 8273921: Refactor NSK/JDI tests to create thread using factory [v5]

2021-09-20 Thread Leonid Mesnik
> 8273921: Refactor NSK/JDI tests to create thread using factory Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision: space fixed - Changes: - all: https://git.openjdk.java.net/jdk/pull/5515/files - new: ht

Re: RFR: 8273921: Refactor NSK/JDI tests to create thread using factory [v4]

2021-09-20 Thread Leonid Mesnik
On Fri, 17 Sep 2021 20:56:14 GMT, Chris Plummer wrote: >> Leonid Mesnik has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Renamed JDITask to NamedTask. > > test/hotspot/jtreg/vmTestbase/nsk/jdi/Break

Re: RFR: 8273921: Refactor NSK/JDI tests to create thread using factory [v4]

2021-09-20 Thread Leonid Mesnik
On Tue, 21 Sep 2021 03:13:15 GMT, Leonid Mesnik wrote: >> 8273921: Refactor NSK/JDI tests to create thread using factory > > Leonid Mesnik has updated the pull request incrementally with one additional > commit since the last revision: > > Renamed JDITask to NamedTask.

Re: RFR: 8273921: Refactor NSK/JDI tests to create thread using factory [v4]

2021-09-20 Thread Leonid Mesnik
> 8273921: Refactor NSK/JDI tests to create thread using factory Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision: Renamed JDITask to NamedTask. - Changes: - all: https://git.openjdk.java.net/jdk/pull/5515/fi

Re: RFR: 8273921: Refactor NSK/JDI tests to create thread using factory [v3]

2021-09-20 Thread Leonid Mesnik
> 8273921: Refactor NSK/JDI tests to create thread using factory Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision: More tests fixed. - Changes: - all: https://git.openjdk.java.net/jdk/pull/5515/files - new: ht

  1   2   3   4   >