On Wed, 23 Jun 2021 12:06:41 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my changes for the removal of the legacy
> `PlainSocketImpl` and `PlainDatagramSocketImpl` implementations?
>
> In JDK 13, JEP 353 provided a drop in replacem
e mechanisms they use to enable them to
> mitigate compatibility issues) have been deemed no longer necessary, they now
> represent a maintenance burden. This patch looks at removing them from the
> JDK.
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with
On Fri, 25 Jun 2021 11:37:50 GMT, Daniel Fuchs wrote:
>> src/java.base/share/classes/java/net/DatagramSocket.java line 1398:
>>
>>> 1396: DatagramSocketImpl impl =
>>> factory.createDatagramSocketImpl();
>>> 1397: Objects.requireNonNull(impl,
>>> 1398:
e mechanisms they use to enable them to
> mitigate compatibility issues) have been deemed no longer necessary, they now
> represent a maintenance burden. This patch looks at removing them from the
> JDK.
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request incremen
On Thu, 24 Jun 2021 15:06:49 GMT, Daniel Fuchs wrote:
>>> I've created an issue to track this:
>>> https://bugs.openjdk.java.net/browse/JDK-8269288
>>
>> Thanks. So are you keeping the Objects.requireNonNull here? If so then it
>> should probably be the 2-arg version so that the message is cle
e mechanisms they use to enable them to
> mitigate compatibility issues) have been deemed no longer necessary, they now
> represent a maintenance burden. This patch looks at removing them from the
> JDK.
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with
e mechanisms they use to enable them to
> mitigate compatibility issues) have been deemed no longer necessary, they now
> represent a maintenance burden. This patch looks at removing them from the
> JDK.
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request incremen
On Wed, 23 Jun 2021 15:09:28 GMT, Alan Bateman wrote:
>> @AlanBateman
>>
>> `protected DatagramSocket(DatagramSocketImpl impl)` throws NPE if `impl` is
>> `null`.
>> (this is covered by the blanket statement for NPE)
>>
>> Do we really need to specify anything else since the global
>> `setD
On Wed, 23 Jun 2021 13:09:53 GMT, Alan Bateman wrote:
> I assume DatagramSocket L1043-L1049 (declaration/init of
> USE_PLAINDATAGRAMSOCKET) can be removed too.
USE_PLAINDATAGRAMSOCKET removed as requested. See 49125e7
> src/java.base/share/classes/sun/nio/ch/NioSocketImpl.java line 69:
>
>> 6
e mechanisms they use to enable them to
> mitigate compatibility issues) have been deemed no longer necessary, they now
> represent a maintenance burden. This patch looks at removing them from the
> JDK.
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with
Hi,
Could someone please review my changes for the removal of the legacy
`PlainSocketImpl` and `PlainDatagramSocketImpl` implementations?
In JDK 13, JEP 353 provided a drop in replacement for the legacy
`PlainSocketImpl` implementation. Since JDK 13, the `PlainSocketImpl`
implementation was no
11 matches
Mail list logo
