Re: RFR: 8283092: JMX subclass permission check redundant with strong encapsulation

2022-03-17 Thread Sean Mullan
On Tue, 15 Mar 2022 20:22:16 GMT, Kevin Walls wrote: > Removing permission checks which, in the presence of a Security Manager, > would check for a RuntimePermission "className.subclass". This was to > prevent subclassing these classes, but is no longer necessary with strong > encapsulation

Re: RFR: 8279918: Fix various doc typos

2022-01-13 Thread Sean Mullan
On Thu, 13 Jan 2022 10:30:07 GMT, Pavel Rappo wrote: > - Most of the typos are of a trivial kind: missing whitespace. > - If any of the typos should be fixed in the upstream projects instead, > please say so; I will drop those typos from the patch. > - As I understand it, ` ` in

Re: [jdk18] RFR: 8279007: jstatd fails to start because SecurityManager is disabled [v2]

2021-12-21 Thread Sean Mullan
On Tue, 21 Dec 2021 20:28:52 GMT, Kevin Walls wrote: >> jstatd now in jdk18 fails to start unless we specifically allow or set a >> SecurityManager. >> This update to the launcher makefile adds JAVA_ARGS to permit a >> SecurityManager. > > Kevin Walls has updated the pull request incrementally

Re: [jdk18] RFR: 8279007: jstatd fails to start because SecurityManager is disabled

2021-12-21 Thread Sean Mullan
On Tue, 21 Dec 2021 13:00:26 GMT, Kevin Walls wrote: > jstatd now in jdk18 fails to start unless we specifically allow or set a > SecurityManager. > This update to the launcher makefile adds JAVA_ARGS to permit a > SecurityManager. You should also remove `-Djava.security.manager=allow` from

Re: RFR: 8269130: Replace usages of Collection.toArray() with Collection.toArray(T[]) to avoid redundant array copying

2021-07-26 Thread Sean Mullan
On Mon, 14 Jun 2021 17:00:29 GMT, Andrey Turbanov wrote: > I found few places, where code initially perform `Object[] > Colleciton.toArray()` call and then manually copy array into another array > with required type. > This PR cleanups such places to more shorter call `T[] >

Re: RFR: 8267543: Post JEP 411 refactoring: security [v2]

2021-05-25 Thread Sean Mullan
On Tue, 25 May 2021 16:20:35 GMT, Weijun Wang wrote: >> For all modified files in #4073 having "security", "crypto", or "ssl" in >> their names. Codes are refactored to bring a `@SuppressWarning` annotation >> nearer to the deprecated API usage and also shrink the size of its target. >> >>

Re: RFR: 8267543: Post JEP 411 refactoring: security [v2]

2021-05-25 Thread Sean Mullan
On Tue, 25 May 2021 16:20:35 GMT, Weijun Wang wrote: >> For all modified files in #4073 having "security", "crypto", or "ssl" in >> their names. Codes are refactored to bring a `@SuppressWarning` annotation >> nearer to the deprecated API usage and also shrink the size of its target. >> >>

Re: RFR: 8267543: Post JEP 411 refactoring: security

2021-05-25 Thread Sean Mullan
On Mon, 24 May 2021 20:23:27 GMT, Weijun Wang wrote: > For all modified files in #4073 having "security", "crypto", or "ssl" in > their names. Codes are refactored to bring a `@SuppressWarning` annotation > nearer to the deprecated API usage and also shrink the size of its target.

Re: RFR: 8266459: Implement JEP 411: Deprecate the Security Manager for Removal [v3]

2021-05-23 Thread Sean Mullan
On Fri, 21 May 2021 15:27:39 GMT, Daniel Fuchs wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixing awt/datatransfer/DataFlavor/DataFlavorRemoteTest.java > >

Re: RFR: 8267184: JEP 411: Add -Djava.security.manager=allow to tests calling System.setSecurityManager [v2]

2021-05-19 Thread Sean Mullan
On Tue, 18 May 2021 21:44:43 GMT, Weijun Wang wrote: >> Please review the test changes for [JEP >> 411](https://openjdk.java.net/jeps/411). >> >> With JEP 411 and the default value of `-Djava.security.manager` becoming >> `disallow`, tests calling `System.setSecurityManager()` need >>

Re: RFR: 8266459: Implement JEP 411: Deprecate the Security Manager for Removal

2021-05-18 Thread Sean Mullan
On Tue, 18 May 2021 15:19:21 GMT, Alan Bateman wrote: >> It includes both: >> ![Screen Shot 2021-05-18 at 8 41 11 >> AM](https://user-images.githubusercontent.com/35072269/118652730-dfb35400-b7b4-11eb-83ee-92be9136fea2.jpg) > > Thanks for checking, I assumed that was the case so wondering if it

Re: RFR: 8266459: Implement JEP 411: Deprecate the Security Manager for Removal

2021-05-18 Thread Sean Mullan
On Tue, 18 May 2021 06:31:06 GMT, Alan Bateman wrote: >> Please review this implementation of [JEP >> 411](https://openjdk.java.net/jeps/411). >> >> The code change is divided into 3 commits. Please review them one by one. >> >> 1. >>

Re: RFR: 8080272 Refactor I/O stream copying to use InputStream.transferTo/readAllBytes and Files.copy [v11]

2021-02-19 Thread Sean Mullan
On Fri, 19 Feb 2021 08:05:06 GMT, Andrey Turbanov wrote: >> src/java.base/share/classes/sun/security/provider/certpath/X509CertPath.java >> line 228: >> >>> 226: try { >>> 227: if (is.markSupported() == false) { >>> 228: // Copy the entire input stream into

Re: RFR: 8080272 Refactor I/O stream copying to use InputStream.transferTo/readAllBytes and Files.copy [v11]

2021-02-18 Thread Sean Mullan
On Mon, 15 Feb 2021 19:47:00 GMT, Andrey Turbanov wrote: >> 8080272 Refactor I/O stream copying to use >> InputStream.transferTo/readAllBytes and Files.copy > > Andrey Turbanov has updated the pull request incrementally with one > additional commit since the last revision: > > 8080272:

Re: RFR 8072932: Test fails with java.security.AccessControlException: access denied (java.security.SecurityPermission getDomainCombiner)

2015-02-12 Thread Sean Mullan
Looks fine to me. Can you add a noreg-trivial label to the bug? --Sean On 02/11/2015 11:10 AM, Jaroslav Bachorik wrote: Please, review the following simple change. Issue : https://bugs.openjdk.java.net/browse/JDK-8072932 Webrev: http://cr.openjdk.java.net/~jbachorik/8072932/webrev.00 This

Re: 8034856/8034857: More gcc warnings

2014-02-13 Thread Sean Mullan
Looks fine to me. --Sean On 02/13/2014 08:18 AM, Alan Bateman wrote: The number of native code warnings in the build is annoying so this is another drive-by fix that eliminates a few of them in the serviceability and security areas. The webrev with the changes is here:

hg: jdk8/tl/jdk: 8031825: OCSP client can't find responder cert if it uses a different subject key id algorithm than responderID

2014-01-22 Thread sean . mullan
Changeset: 57c26829deb6 Author:mullan Date: 2014-01-22 19:06 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/57c26829deb6 8031825: OCSP client can't find responder cert if it uses a different subject key id algorithm than responderID Reviewed-by: vinnie, xuelei !

hg: jdk8/tl/jdk: 2 new changesets

2013-12-23 Thread sean . mullan
Changeset: aef6c726810e Author:mullan Date: 2013-12-23 14:03 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/aef6c726810e 8030813: Signed applet fails to load when CRLs are stored in an LDAP directory Summary: Skip JNDI application resource lookup to avoid recursive JAR

Re: RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX

2013-11-25 Thread Sean Mullan
comments (20 Sept [4]) - Steffan Larsen (svc): APPROVED (20 Sept [5]) - Phil Race (2d): Initial comments (18 Sept [6]); Additional comments (15 Oct [7]) - Sean Mullan (sec): Initial comments (26 Sept [8]) [2]: http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001045.html [3

hg: jdk8/tl/jdk: 3 new changesets

2013-10-22 Thread sean . mullan
Changeset: 5f4aecd73caa Author:mullan Date: 2013-10-22 08:03 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5f4aecd73caa 8021191: Add isAuthorized check to limited doPrivileged methods Reviewed-by: weijun, xuelei ! src/share/classes/java/security/AccessControlContext.java !

hg: jdk8/tl/jdk: 2 new changesets

2013-10-22 Thread sean . mullan
Changeset: fc7a6fa3589a Author:ascarpino Date: 2013-10-22 19:37 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fc7a6fa3589a 8025763: Provider does not override new Hashtable methods Reviewed-by: mullan ! src/share/classes/java/security/Provider.java Changeset: b065de1700d3

hg: jdk8/tl/jdk: 3 new changesets

2013-10-17 Thread sean . mullan
Changeset: 5d866df64ae3 Author:mullan Date: 2013-10-17 10:18 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5d866df64ae3 8026346: test/java/lang/SecurityManager/CheckPackageAccess.java failing Reviewed-by: vinnie ! src/share/lib/security/java.security-macosx !

hg: jdk8/tl/jdk: 2 new changesets

2013-10-11 Thread sean . mullan
Changeset: 4ad76262bac8 Author:mullan Date: 2013-10-11 08:43 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4ad76262bac8 8007292: Add JavaFX internal packages to package.access Summary: build hooks to allow closed restricted packages to be added to java.security file

Re: 8008662: Add @jdk.Exported to JDK-specific/exported APIs

2013-10-07 Thread Sean Mullan
7 classes in com.sun.security.auth have been deprecated for several major releases now. Should they still have this annotation? --Sean On 10/06/2013 04:03 PM, Alan Bateman wrote: As a follow-up to Joe Darcy's rename of jdk.Supported to jdk.Exported, I'd like to have another attempt at adding

Re: 8008662: Add @jdk.Exported to JDK-specific/exported APIs

2013-10-07 Thread Sean Mullan
On 10/07/2013 08:28 AM, Alan Bateman wrote: On 07/10/2013 13:26, Sean Mullan wrote: 7 classes in com.sun.security.auth have been deprecated for several major releases now. Should they still have this annotation? --Sean I know but aren't they still exported and supported? They have all had

Re: 8008662: Add @jdk.Exported to JDK-specific/exported APIs

2013-10-07 Thread Sean Mullan
On 10/07/2013 08:58 AM, Alan Bateman wrote: On 07/10/2013 13:36, Sean Mullan wrote: We have only started removing some deprecated things in JDK, so it just was never thought about until now. Marking these as supported going forward strikes me as a bit strange, since we don't really want anyone

Re: RFR(L): 8024854: Basic changes and files to build the class library on AIX

2013-09-26 Thread Sean Mullan
On 09/16/2013 12:30 PM, Volker Simonis wrote: src/share/lib/security/java.security-aix - Provide default java.security-aix for AIX. The login.configuration.provider property should be set to: sun.security.provider.ConfigFile See 8016848 for more info. After you make this change,

hg: jdk8/tl/jdk: 2 new changesets

2013-09-06 Thread sean . mullan
Changeset: 0aba8b6232af Author:mullan Date: 2013-09-06 12:04 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0aba8b6232af 8023362: Don't allow soft-fail behavior if OCSP responder returns unauthorized Reviewed-by: vinnie, xuelei !

hg: jdk8/tl/jdk: 8023769: JDK-8016850 broke the old build

2013-08-27 Thread sean . mullan
Changeset: 134283a88499 Author:mullan Date: 2013-08-27 10:46 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/134283a88499 8023769: JDK-8016850 broke the old build Summary: remove files that were moved/removed from com/sun/security/auth/FILES_java.gmk Reviewed-by: chegar,

hg: jdk8/tl/jdk: 2 new changesets

2013-08-27 Thread sean . mullan
Changeset: 6a1bfcde4d4d Author:mullan Date: 2013-08-27 12:04 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6a1bfcde4d4d 8019830: Add com.sun.media.sound to the list of restricted package Reviewed-by: vinnie ! src/share/lib/security/java.security-linux !

hg: jdk8/tl/jdk: 2 new changesets

2013-08-19 Thread sean . mullan
Changeset: bce5205dbe84 Author:ascarpino Date: 2013-08-14 10:50 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bce5205dbe84 8022669: OAEPParameterSpec does not work if MGF1ParameterSpec is set to SHA2 algorithms Reviewed-by: mullan !

hg: jdk8/tl/jdk: 8016850: JCK javax.security.auth.Policy tests fail when run in Profiles mode

2013-08-19 Thread sean . mullan
Changeset: f120e2c4b4b1 Author:mullan Date: 2013-08-19 17:17 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f120e2c4b4b1 8016850: JCK javax.security.auth.Policy tests fail when run in Profiles mode Summary: Move default javax.security.auth.Policy implementation to compact1

hg: jdk8/tl/jdk: 2 new changesets

2013-08-13 Thread sean . mullan
Changeset: 412b2f0950a9 Author:mullan Date: 2013-08-13 10:06 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/412b2f0950a9 8022897: Add test/com/sun/crypto/provider/Cipher/RSA/TestOAEPPadding.java to ProblemList Reviewed-by: vinnie, chegar ! test/ProblemList.txt Changeset:

hg: jdk8/tl/jdk: 2 new changesets

2013-08-12 Thread sean . mullan
Changeset: ffacf3e7a130 Author:mullan Date: 2013-08-12 09:03 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ffacf3e7a130 8016848: javax_security/auth/login tests fail in compact 1 and 2 profiles Summary: Change the default value of the login.configuration.provider security

hg: jdk8/tl/jdk: 2 new changesets

2013-08-06 Thread sean . mullan
Changeset: 1f4af3e0447e Author:mullan Date: 2013-08-06 08:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1f4af3e0447e 8022120: JCK test api/javax_xml/crypto/dsig/TransformService/index_ParamMethods fails Summary: TransformService.init and marshalParams must throw

hg: jdk8/tl/jdk: 3 new changesets

2013-08-02 Thread sean . mullan
Changeset: 42b786f2fb99 Author:mullan Date: 2013-08-02 08:30 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/42b786f2fb99 8001319: Add SecurityPermission insertProvider target name Reviewed-by: vinnie ! src/share/classes/java/security/Security.java !

hg: jdk8/tl/jdk: 2 new changesets

2013-07-25 Thread sean . mullan
Changeset: a834ab2c1354 Author:mullan Date: 2013-07-25 10:58 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a834ab2c1354 8010748: Add PKIXRevocationChecker NO_FALLBACK option and improve SOFT_FAIL option Reviewed-by: vinnie !

hg: jdk8/tl/jdk: 2 new changesets

2013-07-25 Thread sean . mullan
Changeset: 1744a32d3db3 Author:mullan Date: 2013-07-25 20:12 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1744a32d3db3 8012288: XML DSig API allows wrong tag names and extra elements in SignedInfo Reviewed-by: xuelei !

hg: jdk8/tl/jdk: 2 new changesets

2013-07-05 Thread sean . mullan
Changeset: 028ef97797c1 Author:mullan Date: 2013-07-05 15:54 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/028ef97797c1 8011547: Update XML Signature implementation to Apache Santuario 1.5.4 Reviewed-by: xuelei !

hg: jdk8/tl/jdk: 8014307: Memory leak ... security/jgss/wrapper/GSSLibStub.c

2013-06-14 Thread sean . mullan
Changeset: f695f447f6b7 Author:jzavgren Date: 2013-06-14 09:13 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f695f447f6b7 8014307: Memory leak ... security/jgss/wrapper/GSSLibStub.c Summary: I modified the native procedure:

hg: jdk8/tl/jdk: 2 new changesets

2013-03-01 Thread sean . mullan
Changeset: 1652ac7b4bfd Author:mullan Date: 2013-03-01 16:12 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1652ac7b4bfd 8008908: Access denied when invoking Subject.doAsPrivileged() Summary: wildcard principal names are not processed correctly Reviewed-by: xuelei !

hg: jdk8/tl/jdk: 8005389: Backout fix for JDK-6500133

2013-01-16 Thread sean . mullan
Changeset: c7d54f93d3e5 Author:juh Date: 2013-01-16 09:51 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c7d54f93d3e5 8005389: Backout fix for JDK-6500133 Reviewed-by: mullan ! src/share/classes/sun/security/x509/URIName.java ! test/sun/security/x509/URIName/Parse.java

hg: jdk8/tl/jdk: 8005939: sun/security/x509/{X509CRLImplX509CertImpl}/Verify.java fail in confusing way when some providers not present

2013-01-16 Thread sean . mullan
Changeset: f7f77bdf248b Author:juh Date: 2013-01-16 13:35 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f7f77bdf248b 8005939: sun/security/x509/{X509CRLImplX509CertImpl}/Verify.java fail in confusing way when some providers not present Reviewed-by: mullan, weijun !

hg: jdk8/tl/jdk: 3 new changesets

2013-01-09 Thread sean . mullan
Changeset: 86828e84654f Author:mullan Date: 2013-01-08 19:00 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/86828e84654f 7019834: Eliminate dependency from PolicyFile to com.sun.security.auth.PrincipalComparator Summary: Add new java.security.Principal.implies method

hg: jdk8/tl/jdk: 2 new changesets

2012-12-26 Thread sean . mullan
Changeset: 4d28776d7007 Author:mullan Date: 2012-12-26 10:07 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4d28776d7007 8005117: Eliminate dependency from ConfigSpiFile to com.sun.security.auth.login.ConfigFile Reviewed-by: alanb, mchung, weijun !

hg: jdk8/tl/jdk: 2 new changesets

2012-12-13 Thread sean . mullan
Changeset: c97618a3c8c2 Author:juh Date: 2012-12-13 09:35 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c97618a3c8c2 7193792: sun/security/pkcs11/ec/TestECDSA.java failing intermittently Reviewed-by: vinnie, wetmore ! test/ProblemList.txt !

hg: jdk8/tl/jdk: 8004188: Rename src/share/lib/security/java.security to java.security-linux

2012-12-04 Thread sean . mullan
Changeset: 44ae777564eb Author:mullan Date: 2012-12-04 17:40 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/44ae777564eb 8004188: Rename src/share/lib/security/java.security to java.security-linux Reviewed-by: mullan, mchung Contributed-by: jason...@oracle.com !

hg: jdk8/tl/jdk: 7199143: RFE: OCSP revocation checker should provide possibility to specify connection timeout

2012-12-03 Thread sean . mullan
Changeset: ee9846f351d7 Author:mullan Date: 2012-12-03 11:07 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ee9846f351d7 7199143: RFE: OCSP revocation checker should provide possibility to specify connection timeout Summary: Added com.sun.security.ocsp.timeout system

hg: jdk8/tl/jdk: 7198416: CertificateIssuerName and CertificateSubjectName are redundant

2012-11-08 Thread sean . mullan
Changeset: 1e7dd9e05ce2 Author:mullan Date: 2012-11-08 12:51 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1e7dd9e05ce2 7198416: CertificateIssuerName and CertificateSubjectName are redundant Reviewed-by: mullan Contributed-by: jason...@oracle.com !

hg: jdk8/tl/jdk: 7195409: CertPath/CertPathValidatorTest/KeyParamsInheritanceTest fails with NullPointerException

2012-09-16 Thread sean . mullan
Changeset: 17881ebf811c Author:mullan Date: 2012-09-16 13:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/17881ebf811c 7195409: CertPath/CertPathValidatorTest/KeyParamsInheritanceTest fails with NullPointerException Reviewed-by: xuelei !

hg: jdk8/tl/jdk: 2 new changesets

2012-09-12 Thread sean . mullan
Changeset: 7a16cd3bd2d9 Author:mullan Date: 2012-09-12 15:20 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7a16cd3bd2d9 7196593: java.security.debug=help doesn't list certpath option Reviewed-by: mullan, wetmore, valeriep Contributed-by: jason...@oracle.com !

hg: jdk8/tl/jdk: 3 new changesets

2012-09-10 Thread sean . mullan
Changeset: a51f86e2dce9 Author:mullan Date: 2012-09-10 08:57 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a51f86e2dce9 7195301: XML Signature DOM implementation should not use instanceof to determine type of Node Reviewed-by: xuelei !

hg: jdk8/tl/jdk: 4647343: IDENT variable in sun.security.x509 classes not used

2012-09-07 Thread sean . mullan
Changeset: 7f081e14364e Author:mullan Date: 2012-09-07 12:49 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7f081e14364e 4647343: IDENT variable in sun.security.x509 classes not used Reviewed-by: mullan Contributed-by: jason...@oracle.com -

hg: jdk8/tl/jdk: 2 new changesets

2012-08-30 Thread sean . mullan
Changeset: 0a2565113920 Author:mullan Date: 2012-08-30 14:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0a2565113920 6995421: Eliminate the static dependency to sun.security.ec.ECKeyFactory Reviewed-by: mullan, vinnie Contributed-by: stephen.flo...@oracle.com !

hg: jdk8/tl/jdk: 2 new changesets

2012-08-28 Thread sean . mullan
Changeset: 8b90182f2b33 Author:mullan Date: 2012-08-28 08:43 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8b90182f2b33 7192896: Reason of CertPathValidatorException should be UNDETERMINED_REVOCATION_STATUS if OCSP request failed Reviewed-by: xuelei !

hg: jdk8/tl/jdk: 6500133: REGRESSION: CertificateParsingException for CRL Distribution Point with blank

2012-08-17 Thread sean . mullan
Changeset: 6b2ebf3c4964 Author:mullan Date: 2012-08-17 14:32 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6b2ebf3c4964 6500133: REGRESSION: CertificateParsingException for CRL Distribution Point with blank Reviewed-by: mullan Contributed-by: jason...@oracle.com !

hg: jdk8/tl/jdk: 2 new changesets

2012-08-10 Thread sean . mullan
Changeset: 57b5025548d6 Author:mullan Date: 2012-08-10 09:12 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/57b5025548d6 7187962: sun.security.pkcs11.P11DSAKeyFactory.implTranslatePublicKey doesn't check if params is null Reviewed-by: valeriep !

hg: jdk8/tl/jdk: 2 new changesets

2012-08-02 Thread sean . mullan
Changeset: b0bfa441d70f Author:mullan Date: 2012-08-02 10:40 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b0bfa441d70f 7026347: Certificate and X509CRL should have verify(PublicKey key, Provider sigProvider) Reviewed-by: mullan, xuelei, weijun Contributed-by:

hg: jdk8/tl/jdk: 2 new changesets

2012-08-01 Thread sean . mullan
Changeset: 21c590fdc8cb Author:mullan Date: 2012-08-01 11:06 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/21c590fdc8cb 7179715: OCSP revocation checking fails if the signer certificate is identified using the key ID Reviewed-by: vinnie !

hg: jdk8/tl/jdk: 3 new changesets

2012-06-15 Thread sean . mullan
Changeset: 8deec0d1fc6f Author:mullan Date: 2012-06-15 08:43 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8deec0d1fc6f 7176326: CertPath/CertPathBuilderTest failures after webrev 6854712_6637288_7126011 Reviewed-by: xuelei !

hg: jdk8/tl/jdk: 3 new changesets

2012-05-31 Thread sean . mullan
Changeset: 0c6830e7241f Author:mullan Date: 2012-05-30 17:19 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0c6830e7241f 6854712: Revocation checking enhancements (JEP-124) 6637288: Add OCSP support to PKIX CertPathBuilder implementation 7126011:

hg: jdk8/tl/jdk: 2 new changesets

2012-04-13 Thread sean . mullan
Changeset: fa26ac92b29e Author:mullan Date: 2012-04-13 09:46 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fa26ac92b29e 7152564: Improve CodeSource.matchLocation(CodeSource) performance 7155693: CodeSource.matchLocation getPort test can be improved Reviewed-by: chegar !

hg: jdk8/tl/jdk: 2 new changesets

2012-02-27 Thread sean . mullan
Changeset: 805fc337bbe8 Author:mullan Date: 2012-02-27 11:44 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/805fc337bbe8 7147830: NullPointerException in java.security.Policy.implies() when the ProtectionDomain has a null code sou Reviewed-by: vinnie !

hg: jdk8/tl/jdk: 2 new changesets

2012-02-15 Thread sean . mullan
Changeset: 0720542d6c1e Author:mullan Date: 2012-02-15 07:45 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0720542d6c1e 7024604: OID.1 causes IAE in X500Principal constructor Reviewed-by: vinnie ! src/share/classes/javax/security/auth/x500/X500Principal.java !

hg: jdk8/tl/jdk: 2 new changesets

2012-01-23 Thread sean . mullan
Changeset: 3df0bd3ed880 Author:mullan Date: 2012-01-23 12:17 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3df0bd3ed880 7131084: XMLDSig XPathFilter2Transform regression involving intersect filter Reviewed-by: xuelei !

hg: jdk8/tl/jdk: 3 new changesets

2011-11-22 Thread sean . mullan
Changeset: 1945abeb82a0 Author:mullan Date: 2011-11-22 08:58 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1945abeb82a0 7093090: Reduce synchronization in java.security.Policy.getPolicyNoCheck Reviewed-by: valeriep ! src/share/classes/java/security/Policy.java Changeset:

hg: jdk8/tl/jdk: 2 new changesets

2011-10-27 Thread sean . mullan
Changeset: 56cc907fc8dc Author:mullan Date: 2011-10-27 10:57 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/56cc907fc8dc 7094155: JSR105 code throws javax.xml.crypto.URIReferenceException when running into Java 7 VM Reviewed-by: xuelei !

hg: jdk8/tl/jdk: 2 new changesets

2011-10-19 Thread sean . mullan
Changeset: 57eb9136b73b Author:mullan Date: 2011-10-19 10:15 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/57eb9136b73b 7102686: Restructure timestamp code so that jars and modules can more easily share the same code Reviewed-by: mchung !

hg: jdk8/tl/jdk: 2 new changesets

2011-10-18 Thread sean . mullan
Changeset: 9bf526cc4046 Author:mullan Date: 2011-10-18 10:12 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9bf526cc4046 7092897: sun.security.util.Cache should be generified Reviewed-by: xuelei ! src/share/classes/sun/security/pkcs11/KeyCache.java !

hg: jdk8/tl/jdk: 2 new changesets

2011-10-13 Thread sean . mullan
Changeset: 01615d3e74ed Author:mullan Date: 2011-10-13 13:50 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/01615d3e74ed 6953295: Move few sun.security.{util, x509, pkcs} classes used by keytool/jarsigner to another package Reviewed-by: mchung !

hg: jdk8/tl/jdk: 7054969: Null-check-in-finally pattern in java/security documentation

2011-07-06 Thread sean . mullan
Changeset: f68d30c0a2e3 Author:mullan Date: 2011-07-06 11:08 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f68d30c0a2e3 7054969: Null-check-in-finally pattern in java/security documentation Reviewed-by: vinnie ! src/share/classes/java/security/KeyStore.java !

hg: jdk7/tl/jdk: 2 new changesets

2011-05-24 Thread sean . mullan
Changeset: 0a80650409e1 Author:mullan Date: 2011-05-24 14:15 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0a80650409e1 703: Permissions resolved incorrectly for jar protocol (Patch from bugs.openjdk.java.net) Reviewed-by: alanb, chegar Contributed-by:

hg: jdk7/tl/jdk: 2 new changesets

2011-03-29 Thread sean . mullan
Changeset: b8259e08543b Author:mullan Date: 2011-03-29 10:39 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b8259e08543b 7019937: Translatability bug - Remove Unused String - String ID , read end of file 7019938: Translatability bug - Remove Unused String - String ID can

hg: jdk7/tl/jdk: 2 new changesets

2011-03-07 Thread sean . mullan
Changeset: bc0c58d65e97 Author:mullan Date: 2011-03-07 13:20 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bc0c58d65e97 7022467: SecretKeyFactory doesn't support algorithm AES on Windows and Linux Reviewed-by: wetmore, valeriep !

hg: jdk7/tl/jdk: 4 new changesets

2011-01-25 Thread sean . mullan
Changeset: ae38d1374e31 Author:mullan Date: 2011-01-24 14:56 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ae38d1374e31 5001004: Required Security Algorithms need to be defined Reviewed-by: wetmore ! src/share/classes/java/security/AlgorithmParameterGenerator.java !

hg: jdk7/tl/jdk: 6998860: Signed jar file verification is currently creating many extra new Sun providers.

2010-12-08 Thread sean . mullan
Changeset: 291128e77395 Author:mullan Date: 2010-12-08 10:21 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/291128e77395 6998860: Signed jar file verification is currently creating many extra new Sun providers. Reviewed-by: mchung !

hg: jdk7/tl/jdk: 6994717: expired certificate in test ValidateCertPath

2010-11-08 Thread sean . mullan
Changeset: 34faa22a8ce8 Author:mullan Date: 2010-11-08 11:33 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/34faa22a8ce8 6994717: expired certificate in test ValidateCertPath Reviewed-by: vinnie !

hg: jdk7/tl/jdk: 2 new changesets

2010-10-18 Thread sean . mullan
Changeset: 0f5bab573e01 Author:mullan Date: 2010-10-18 09:00 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0f5bab573e01 6988599: CertificateRevokedException specifies name of authority but interacts with authority instance Reviewed-by: vinnie !

hg: jdk7/tl/jdk: 2 new changesets

2010-08-03 Thread sean . mullan
Changeset: a21c46dac6cf Author:mullan Date: 2010-08-03 09:39 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a21c46dac6cf 6653372: Error in java.security.KeyStore example code Reviewed-by: weijun ! src/share/classes/java/security/KeyStore.java Changeset: 2feeefb45a44

hg: jdk7/tl/jdk: 6870553: X509Certificate.getSigAlgName method description uses non-standard algorithm name as example

2010-07-20 Thread sean . mullan
Changeset: 9d1994d53a67 Author:mullan Date: 2010-07-20 10:41 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9d1994d53a67 6870553: X509Certificate.getSigAlgName method description uses non-standard algorithm name as example Reviewed-by: xuelei !

hg: jdk7/tl/jdk: 2 new changesets

2010-07-01 Thread sean . mullan
Changeset: 9bffc32b645d Author:mullan Date: 2010-07-01 15:20 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9bffc32b645d 6782979: Add JNLPAppletLauncher (6618105) to blacklist Reviewed-by: ohair ! make/java/security/Makefile Changeset: c0d2a097eb99 Author:mullan Date:

hg: jdk7/tl/jdk: 2 new changesets

2010-01-15 Thread sean . mullan
Changeset: 51d62db10c93 Author:mullan Date: 2010-01-15 09:48 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/51d62db10c93 6915939: Exception should be thrown if OCSP SingleResponses contain unresolved critical extensions Reviewed-by: xuelei !

hg: jdk7/tl/jdk: 2 new changesets

2009-12-10 Thread sean . mullan
Changeset: 7c9be6c9385a Author:mullan Date: 2009-12-10 11:31 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7c9be6c9385a 6867348: Digest Value of References inside Manifest - calculation order problem Reviewed-by: xuelei !

hg: jdk7/tl/jdk: 2 new changesets

2009-11-23 Thread sean . mullan
Changeset: 5d2e63dad298 Author:mullan Date: 2009-11-23 12:36 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5d2e63dad298 6899503: Security code issue using Verisign root certificate Summary: Add support for reordering out-of-order certificate chains Reviewed-by: vinnie,

hg: jdk7/tl/jdk: 6894461: OCSP Checker should not wrap all Exception as Unable to send OCSP request.(introduced by #6885667)

2009-11-18 Thread sean . mullan
Changeset: 6fac6e5fdf0c Author:mullan Date: 2009-11-18 12:34 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6fac6e5fdf0c 6894461: OCSP Checker should not wrap all Exception as Unable to send OCSP request.(introduced by #6885667) Reviewed-by: vinnie, xuelei !

hg: jdk7/tl/jdk: 2 new changesets

2009-10-14 Thread sean . mullan
Changeset: 5f326176855d Author:mullan Date: 2009-10-14 09:36 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5f326176855d 6885667: CertPath/CertPathValidatorTest/bugs/bug6383078 fails on jdk6u18/b02, jdk7/pit/b73 and passes on b72. Summary: Wrap all OCSP exceptions in

hg: jdk7/tl/jdk: 6787645: CRL validation code should permit some clock skew when checking validity of CRLs

2009-07-20 Thread sean . mullan
Changeset: 1203425b5742 Author:mullan Date: 2009-07-20 17:16 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1203425b5742 6787645: CRL validation code should permit some clock skew when checking validity of CRLs Reviewed-by: vinnie !

hg: jdk7/tl/jdk: 2 new changesets

2009-06-18 Thread sean . mullan
Changeset: e387bb1367a7 Author:mullan Date: 2009-06-18 09:04 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e387bb1367a7 6833839: RFE: improve ManifestDigester by instantiating StringBuilder constructor w/ initial value Reviewed-by: weijun !

hg: jdk7/tl/jdk: 2 new changesets

2008-11-06 Thread sean . mullan
Changeset: 5102df668164 Author:mullan Date: 2008-11-05 15:55 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5102df668164 6744888: OCSP validation code should permit some clock skew when checking validity of OCSP responses Summary: Allow for up to 10 minutes of clock skew

hg: jdk7/tl/jdk: 6765046: CertPathValidatorException(Throwable).getMessage() always returns null since b37

2008-11-06 Thread sean . mullan
Changeset: 3a3e02a55de8 Author:mullan Date: 2008-11-06 12:12 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3a3e02a55de8 6765046: CertPathValidatorException(Throwable).getMessage() always returns null since b37 Reviewed-by: vinnie !