Re: Review Request JDK-8212795: ThreadInfoCompositeData.toCompositeData fails to map ThreadInfo to CompositeData

2018-10-25 Thread Sven Reimers
Hi Mandy, will this be backported to 11? Sven On Thu, Oct 25, 2018 at 10:10 AM Mandy Chung wrote: > Thanks for verifying the fix, Sven. > > Mandy > > On 10/25/18 10:09 AM, Sven Reimers wrote: > > Hi, > > jus tested the suggested fix against jdk12 head with NetBean

Re: Review Request JDK-8212795: ThreadInfoCompositeData.toCompositeData fails to map ThreadInfo to CompositeData

2018-10-25 Thread Sven Reimers
http://cr.openjdk.java.net/~mchung/jdk12/webrevs/8212795/webrev.00/ > > Thanks > Mandy > [1] > http://mail.openjdk.java.net/pipermail/serviceability-dev/2018-October/025512.html > [2] https://issues.apache.org/jira/browse/NETBEANS-1478 > > > >

Re: Probable bug within sun.management.StackTraceElementCompositeData

2018-10-25 Thread Sven Reimers
ean > server. I think we should first look into the performance > of MBeanServer::invoke and it can be improved. > > Mandy > > > On 10/20/18 6:40 AM, Sven Reimers wrote: > > Hi Mandy, > > I think the main problem here is that there is no simple was to do >

Re: OpenDataException thrown when constructing CompositeData for ThreadInfo

2018-10-22 Thread Sven Reimers
far as I can tell. NB > profiling is using this internal API > `sun.management.ThreadInfoCompositeData::toCompositeData` which may be > unused since JMX supports MXBean. > > Mandy > > On 10/21/18 5:38 PM, Sven Reimers wrote: > > Hi, > > one more problem to g

OpenDataException thrown when constructing CompositeData for ThreadInfo

2018-10-21 Thread Sven Reimers
(), threadInfo.getPriority(), }; With both of this fixes in place I can finally get the self sampling in NetBeans to work on JDK 12.. (and 11) Thanks for looking into this -Sven -- Sven Reimers * Senior Expert Software Architect * Java Champion * JUG Leader JUG Bodensee

Re: ThreadInfoCompositeData.compositeType() broken in 11 and later

2018-10-21 Thread Sven Reimers
Probable fix use Runtime.version().feature() instead of 0: public static CompositeType compositeType() { return ThreadInfoCompositeTypes.compositeTypes.get(Runtime.version().feature()); } Sven On Sun, Oct 21, 2018 at 10:50 AM Sven Reimers wrote: > Hi, > > seems

ThreadInfoCompositeData.compositeType() broken in 11 and later

2018-10-21 Thread Sven Reimers
Hi, seems with the change for 8198253: ThreadInfo.from(CompositeData) incorrectly accepts CompositeData with missing JDK 6 attributes ThreadInfoCompositeData.compositeType() was broken. It just returns public static CompositeType compositeType() { return ThreadInfoCompositeTypes.co

Re: Probable bug within sun.management.StackTraceElementCompositeData

2018-10-20 Thread Sven Reimers
t 11:48 AM Sven Reimers wrote: > Hi Mandy, > > Thanks for the pointer. I have not yet investigated the usage, but will > check if we can use the official API instead. > > Thanks again for the quick response. > > -Sven > > Mandy Chung schrieb am Mi., 17. Okt. 2018,

Re: Probable bug within sun.management.StackTraceElementCompositeData

2018-10-17 Thread Sven Reimers
wrote: > > Hi Sven, > > Moving to serviceability-dev mailing list. Please don't reply to jdk-dev. > > Thanks, > David > > On 15/10/2018 5:42 AM, Sven Reimers wrote: > > Hi all, > > I hope this is the correct e-mailing list. During out testing of Apach

Re: Probable bug within sun.management.StackTraceElementCompositeData

2018-10-16 Thread Sven Reimers
njdk.java.net/browse/JDK-8212197 for this issue. > > Mandy > > On 10/14/18 3:52 PM, David Holmes wrote: > > Hi Sven, > > Moving to serviceability-dev mailing list. Please don't reply to jdk-dev. > > Thanks, > David > > On 15/10/2018 5:42 AM, Sven Reimers

Re: RFR JDK-8212197: OpenDataException thrown when constructing CompositeData for StackTraceElement

2018-10-15 Thread Sven Reimers
ositeData > for StackTraceElement is mismatched. I keep names/values > in the order of the attributes defined from old to new > version. > > Mandy > [1] > http://mail.openjdk.java.net/pipermail/serviceability-dev/2018-October/025512.html > -- Sven Reimers * Senior Ex