Re: RFR(XS): 8062938: sun/jvmstat/monitor/MonitoredVm/CR6672135.java: java.lang.IllegalArgumentException: Could not map vmid to user name

Jaroslav, thanks for the review! // Katja On 07/24/2015 05:02 PM, Jaroslav Bachorik wrote: Thumbs up! -JB- On 24.7.2015 16:06, Yekaterina Kantserova wrote: Hi, Could I please have a review of this fix. bug: https://bugs.openjdk.java.net/browse/JDK-8062938 webrev: http

RFR(XS): 8062938: sun/jvmstat/monitor/MonitoredVm/CR6672135.java: java.lang.IllegalArgumentException: Could not map vmid to user name

Hi, Could I please have a review of this fix. bug: https://bugs.openjdk.java.net/browse/JDK-8062938 webrev: http://cr.openjdk.java.net/~ykantser/8062938/webrev.00 As David pointed out [1] the test is trying to monitor the first best VM from localHost.activeVms() which can result in various

Re: RFR(XS): 8132094: Mark intermittently failuring core-svc tests

Hi, In order to test the fix I ran the svc_tools, jdk_management, jdk_jmx and jdk_jdi tests on all of the core platforms. // Katja On 07/23/2015 03:35 PM, Daniel D. Daugherty wrote: What testing of these changes was done? Dan On 7/22/15 7:50 AM, Yekaterina Kantserova wrote: Hi, Could

Re: RFR(XS): 8132094: Mark intermittently failuring core-svc tests

Jaroslav, Serguei, thanks for the review! // Katja On 07/23/2015 12:09 PM, serguei.spit...@oracle.com wrote: Looks good. Thanks, Serguei On 7/22/15 6:50 AM, Yekaterina Kantserova wrote: Hi, Could I please have a review of this fix. bug: https://bugs.openjdk.java.net/browse/JDK-8132094

RFR(XS): 8132094: Mark intermittently failuring core-svc tests

Hi, Could I please have a review of this fix. bug: https://bugs.openjdk.java.net/browse/JDK-8132094 webrev: http://cr.openjdk.java.net/~ykantser/8132094/webrev.00 Thanks, Katja

RFR(XXS): 8037957: [TEST_BUG] javax/management/mxbean/LeakTest.java misses MerlinMXBean TigerMXBean in @run build tag

Hi, Could I please have a review of this small fix. bug: https://bugs.openjdk.java.net/browse/JDK-8037957 webrev: http://cr.openjdk.java.net/~ykantser/8037957/webrev.00 Thanks, Katja

RFR(XS): 8075658: Mark intermittently failuring core-svc tests

Hi, Could I please have a review of this fix. bug: https://bugs.openjdk.java.net/browse/JDK-8075658 webrev: http://cr.openjdk.java.net/~ykantser/8075658/webrev.00 Thanks, Katja

Re: RFR(XXS): 8037957: [TEST_BUG] javax/management/mxbean/LeakTest.java misses MerlinMXBean TigerMXBean in @run build tag

Thanks Jaroslav! // Katja On 07/17/2015 02:01 PM, Jaroslav Bachorik wrote: Looks good! -JB- On 17.7.2015 13:59, Yekaterina Kantserova wrote: Hi, Could I please have a review of this small fix. bug: https://bugs.openjdk.java.net/browse/JDK-8037957 webrev: http://cr.openjdk.java.net

Re: RFR: JDK-8114828: wrong class file error when compiling tests

Looks good! (Not a reviewer) I've switched the issue to be open. // Katja On 07/15/2015 06:57 PM, Alexander Kulyakhtin wrote: Hi, Could you, please, review these simple test-only changes: CR: https://bugs.openjdk.java.net/browse/JDK-8114828 wrong class file error when compiling tests

Re: RFR(S): JDK-8129971 TestStackTrace.java: ArrayIndexOutOfBoundsException thrown by AARCH64ThreadContext.setRegister

Looks good! Thanks! // Katja On 07/15/2015 04:25 PM, Dmitry Samersoff wrote: Katja, done. Webrev updated in-place (press shift-reload) -Dmitry On 2015-07-15 15:16, Yekaterina Kantserova wrote: Dmitry, could you please remove @ignore tag in TestStackTrace.java as well? // Katja On 07/15

Re: RFR(XS): 8076471: Remove hprof agent tests in JDK

David, thanks for the review! Yes, I will. // Katja On 07/15/2015 11:31 AM, David Holmes wrote: Hi Katja, On 15/07/2015 7:22 PM, Yekaterina Kantserova wrote: Hi, I've forgotten to remove serviceability/hprof/cpu002.java test in hotspot repo. Could I please have a review for this change

Re: RFR(XS): 8076471: Remove hprof agent tests in JDK

Hi, I've forgotten to remove serviceability/hprof/cpu002.java test in hotspot repo. Could I please have a review for this change? webrev: http://cr.openjdk.java.net/~ykantser/8076471.hotspot/webrev.00 Thanks, Katja On 07/10/2015 02:55 PM, Yekaterina Kantserova wrote: Hi, Could I please

Re: RFR(XS): 8076471: Remove hprof agent tests in JDK

Hi Serguei, Thanks a lot for looking at it! Yes, I unintentionally removed test/demo/jvmti instead of test/demo/jvmti/hprof :( Will restore the tests asap. // Katja On 07/15/2015 11:58 AM, serguei.spit...@oracle.com wrote: Hi Katya, On 7/15/15 2:22 AM, Yekaterina Kantserova wrote: Hi

Re: RFR(S): JDK-8129971 TestStackTrace.java: ArrayIndexOutOfBoundsException thrown by AARCH64ThreadContext.setRegister

Dmitry, could you please remove @ignore tag in TestStackTrace.java as well? // Katja On 07/15/2015 01:52 PM, Dmitry Samersoff wrote: Everybody, Please, review the fix: http://cr.openjdk.java.net/~dsamersoff/JDK-8129971/webrev.01/ Added one more register counted in frame context. -Dmitry

RFR(XS): 8131328: Restore demo/jvmti tests

Hi, Could I please have a review of this fix. demo/jvmti tests were unintentionally removed by https://bugs.openjdk.java.net/browse/JDK-8076471. This fix will restore the tests unrelated to hprof. bug: https://bugs.openjdk.java.net/browse/JDK-8131328 webrev:

Re: RFR(XXS): 8131035: [TESTBUG] sun/management/HotspotRuntimeMBean/GetTotalSafepointTime.java needs to enable UsePerfData

Thanks David! // Katja On 07/14/2015 06:19 AM, David Holmes wrote: Ship it! :) Thanks, David On 13/07/2015 11:40 PM, Yekaterina Kantserova wrote: Hi, Could I please have a review of this very small fix. bug: https://bugs.openjdk.java.net/browse/JDK-8131035 webrev: http

Re: RFR(XXS): 8130057: serviceability/sa/TestStackTrace.java should be quarantined

Thanks for the review! // Katja On 07/14/2015 12:13 PM, Erik Gahlin wrote: Looks good Erik Yekaterina Kantserova skrev den 14/07/15 11:44: Hi, Could I please have a review of this very small fix. bug: https://bugs.openjdk.java.net/browse/JDK-8130057 webrev: http://cr.openjdk.java.net

Re: RFR(XXS): 8131035: [TESTBUG] sun/management/HotspotRuntimeMBean/GetTotalSafepointTime.java needs to enable UsePerfData

, Yekaterina Kantserova wrote: Hi, Could I please have a review of this very small fix. bug: https://bugs.openjdk.java.net/browse/JDK-8131035 webrev: http://cr.openjdk.java.net/~ykantser/8131035/webrev.00 Thanks, Katja

RFR(XXS): 8131035: [TESTBUG] sun/management/HotspotRuntimeMBean/GetTotalSafepointTime.java needs to enable UsePerfData

Hi, Could I please have a review of this very small fix. bug: https://bugs.openjdk.java.net/browse/JDK-8131035 webrev: http://cr.openjdk.java.net/~ykantser/8131035/webrev.00 Thanks, Katja

RFR(XS): 8076471: Remove hprof agent tests in JDK

Hi, Could I please have a review of this fix. bug: https://bugs.openjdk.java.net/browse/JDK-8076471 webrev: http://cr.openjdk.java.net/~ykantser/8076471/webrev.00 More details can be found in JEP 240: Remove the JVM TI hprof Agent (https://bugs.openjdk.java.net/browse/JDK-8046661). Thanks,

RFR(XSS): 8032763: Remove use of sun.misc.Ref from hprof parser in testlibrary

Hi, Could I please have a review of this very small fix. bug: https://bugs.openjdk.java.net/browse/JDK-8032763 webrev: http://cr.openjdk.java.net/~ykantser/8032763/webrev.00 Thanks, Katja

Re: RFR(XSS): 8032763: Remove use of sun.misc.Ref from hprof parser in testlibrary

Jaroslav, Alan, thanks for your reviews! // Katja On 07/09/2015 12:41 PM, Jaroslav Bachorik wrote: Looks good! -JB- On 9.7.2015 12:39, Yekaterina Kantserova wrote: Hi, Could I please have a review of this very small fix. bug: https://bugs.openjdk.java.net/browse/JDK-8032763 webrev: http

Re: RFR(S): 8085813: The targeted processes in sun/tools tests should be launched with -XX:+UsePerfData flag in order to work on embedded platforms

Serguei, Thank you for the review! // Katja On 06/08/2015 10:05 PM, serguei.spit...@oracle.com wrote: It looks good. Thanks, Serguei On 6/8/15 4:21 AM, Yekaterina Kantserova wrote: Hi, Could I please have a review of this small fix. bug: https://bugs.openjdk.java.net/browse/JDK-8085813

RFR(S): 8085813: The targeted processes in sun/tools tests should be launched with -XX:+UsePerfData flag in order to work on embedded platforms

Hi, Could I please have a review of this small fix. bug: https://bugs.openjdk.java.net/browse/JDK-8085813 webrev hotspot: http://cr.openjdk.java.net/~ykantser/8085813.hotspot/webrev.00/ webrev jdk: http://cr.openjdk.java.net/~ykantser/8085813.jdk/webrev.00/ Thanks, Katja

RFR(XS): 8085973: The targeted processes in javax/management tests should be launched with -XX:+UsePerfData flag in order to work on embedded platforms

Hi, Could I please have a review of this small fix. bug: https://bugs.openjdk.java.net/browse/JDK-8085973 webrev: http://cr.openjdk.java.net/~ykantser/8085973/webrev.00/ Thanks, Katja

Re: RFR(S): 8081037: serviceability/sa/ tests time out on Windows

to test/lib/Makefile. webrev root: http://cr.openjdk.java.net/~ykantser/8081037/webrev.01 Thanks, Katja On 05/27/2015 03:02 PM, Yekaterina Kantserova wrote: Hi, Could I please have a review of this fix. bug: https://bugs.openjdk.java.net/browse/JDK-8081037 webrev root: http

Re: RFR(XS): 8080828: Create sanity test for JDK-8080155

Staffan, thanks for the review! On 05/21/2015 01:04 PM, Staffan Larsen wrote: Looks good! Thanks, /Staffan On 21 maj 2015, at 12:55, Yekaterina Kantserova yekaterina.kantser...@oracle.com wrote: The new webrev can be found here: http://cr.openjdk.java.net/~ykantser/8080828/webrev.01

8080855: Create sanity test for JDK-8080692

Hi, Could I please have a review of this new test. bug: https://bugs.openjdk.java.net/browse/JDK-8080855 webrev: http://cr.openjdk.java.net/~ykantser/8080855/webrev.00/ This test will trigger the exception reported in https://bugs.openjdk.java.net/browse/JDK-8080692 if running with -Xcomp.

RFR(XS): 8080828: Create sanity test for JDK-8080155

Hi, Could I please have a review of this new test. bug: https://bugs.openjdk.java.net/browse/JDK-8080828 webrev: http://cr.openjdk.java.net/~ykantser/8080828/webrev.00 This test will trigger the exception reported in https://bugs.openjdk.java.net/browse/JDK-8080155 if running with -Xcomp.

Re: RFR(XS): 8080828: Create sanity test for JDK-8080155

think we ran. On 21 maj 2015, at 09:33, Yekaterina Kantserova yekaterina.kantser...@oracle.com wrote: Hi, Could I please have a review of this new test. bug: https://bugs.openjdk.java.net/browse/JDK-8080828 webrev: http://cr.openjdk.java.net/~ykantser/8080828/webrev.00 This test will trigger

Re: RFR(XS): 8080828: Create sanity test for JDK-8080155

actually ran what we think we ran. On 21 maj 2015, at 09:33, Yekaterina Kantserova yekaterina.kantser...@oracle.com wrote: Hi, Could I please have a review of this new test. bug: https://bugs.openjdk.java.net/browse/JDK-8080828 webrev: http://cr.openjdk.java.net/~ykantser/8080828/webrev.00

Re: RFR(S): 6755586: Test com/sun/jdi/NoLaunchOptionTest.java may erroneously fail

Staffan, Dmitry, thank you for the reviews! // Katja On 05/07/2015 10:40 PM, Dmitry Samersoff wrote: Looks good for me! -Dmitry On 2015-05-07 18:04, Yekaterina Kantserova wrote: Hi, Could I please have a review of this small fix. bug: https://bugs.openjdk.java.net/browse/JDK-6755586

8079200: Fix heapdump tests to validate heapdump after jhat is removed

Hi, Could I please have a review of this fix. bug: https://bugs.openjdk.java.net/browse/JDK-8079200 webrev: http://cr.openjdk.java.net/~ykantser/8079200/webrev.00 The fix makes sure the HprofParser is available for all types of test frameworks, not only JTreg. It will be a part of

Re: RFR(XS): 8076998: BadHandshakeTest.java fails due to warnings in output

Thanks Serguei! On 05/06/2015 12:48 AM, serguei.spit...@oracle.com wrote: Looks good. Thanks, Serguei On 5/5/15 6:24 AM, Yekaterina Kantserova wrote: Hi, Could I please have a review of this fix. bug: https://bugs.openjdk.java.net/browse/JDK-8076998 webrev: http://cr.openjdk.java.net

Re: RFR(M): 8078896: Add @modules as needed to the jdk_svc tests

Mandy, Thanks fro your review! Please see my comment inlined. On 05/05/2015 11:00 PM, Mandy Chung wrote: com.sun.management has been moved to jdk.management module. The patch for JDK-8042901 is just integrated in jdk9/dev today. Most, if not all, test/com/sun/management tests need updates

RFR(XS): 8076998: BadHandshakeTest.java fails due to warnings in output

Hi, Could I please have a review of this fix. bug: https://bugs.openjdk.java.net/browse/JDK-8076998 webrev: http://cr.openjdk.java.net/~ykantser/8076998/webrev.00/ The test has been checking the first line of output for either 'Listening for transport dt_socket at address:' or 'Address

Re: RFR(M): 8078896: Add @modules as needed to the jdk_svc tests

Alan, Thanks for the review! And for the catch - I'll fix it. // Katja On 05/05/2015 03:30 PM, Alan Bateman wrote: Thanks Katja, this looks good. One thing that we should as part of this is rev the requiredVersion in jdk/test/TEST.ROOT in case people are using older versions of jtreg. I

Re: RFR(XS): 8076998: BadHandshakeTest.java fails due to warnings in output

Thanks! // Katja On 05/05/2015 03:30 PM, Staffan Larsen wrote: Looks good! Thanks, /Staffan On 5 maj 2015, at 15:24, Yekaterina Kantserova yekaterina.kantser...@oracle.com wrote: Hi, Could I please have a review of this fix. bug: https://bugs.openjdk.java.net/browse/JDK-8076998 webrev

RFR(M): 8078896: Add @modules as needed to the jdk_svc tests

Hi, Could I please have a review of this fix. bug: https://bugs.openjdk.java.net/browse/JDK-8078896 webrev: http://cr.openjdk.java.net/~ykantser/8078896 The push will be pushed to jdk9/dev. Thanks, Katja Alan's clarification from same change in hotspot (RFR: JDK-8075586: add @modules as

RFR(XXS): 8079120: serviceability/dcmd/gc/HeapDumpAllTest.java: compilation failed

Hi, Could I please have a review of this very small fix. bug: https://bugs.openjdk.java.net/browse/JDK-8079120 webrev: http://cr.openjdk.java.net/~ykantser/8079120/webrev.00/ Thanks, Katja

Re: RFR(M): 8059047: Extract parser/validator from jhat for use in tests

Staffan, Thanks for the review! // Katja On 04/28/2015 02:05 PM, Staffan Larsen wrote: Looks good! Thanks, /Staffan On 24 apr 2015, at 16:17, Yekaterina Kantserova yekaterina.kantser...@oracle.com mailto:yekaterina.kantser...@oracle.com wrote: All suggestions have been implemented

Re: RFR(M): 8059047: Extract parser/validator from jhat for use in tests

Hi, Here comes the updated version. bug: https://bugs.openjdk.java.net/browse/JDK-8059047 webrev root: http://cr.openjdk.java.net/~ykantser/8059047/webrev.01/ webrev jdk: http://cr.openjdk.java.net/~ykantser/8059047.jdk/webrev.01/ webrev hotspot:

Re: RFR(M): 8059047: Extract parser/validator from jhat for use in tests

// Katja On 04/24/2015 12:10 PM, Staffan Larsen wrote: On 24 apr 2015, at 11:34, Yekaterina Kantserova yekaterina.kantser...@oracle.com mailto:yekaterina.kantser...@oracle.com wrote: Hi, Here comes the updated version. bug: https://bugs.openjdk.java.net/browse/JDK-8059047 webrev root: http

Re: RFR(M): 8059047: Extract parser/validator from jhat for use in tests

On 22 apr 2015, at 14:25, Yekaterina Kantserova yekaterina.kantser...@oracle.com wrote: Staffan, thank you for the review! This issue needs a change in jdk as well. http://cr.openjdk.java.net/~ykantser/8059047.jdk/webrev.00 - BasicJMapTest.java will use HprofParser to verify hprof dumps

RFR(S): 8076524: Remove jhat tests and help library from JDK

Hi, Could I please have a review of this fix. bug: https://bugs.openjdk.java.net/browse/JDK-8076524 webrev: http://cr.openjdk.java.net/~ykantser/8076524/webrev.00 This fix is a part of JEP 241: Remove the jhat Tool (https://bugs.openjdk.java.net/browse/JDK-8059039). Thanks, Katja

Re: RFR(S): 8076524: Remove jhat tests and help library from JDK

take a look at it as well. // Katja On 04/22/2015 01:09 PM, Alan Bateman wrote: On 22/04/2015 11:56, Yekaterina Kantserova wrote: Hi, Could I please have a review of this fix. bug: https://bugs.openjdk.java.net/browse/JDK-8076524 webrev: http://cr.openjdk.java.net/~ykantser/8076524/webrev

RFR(M): 8059047: Extract parser/validator from jhat for use in tests

Hi, Could I please have a review of this fix. bug: https://bugs.openjdk.java.net/browse/JDK-8059047 webrev: http://cr.openjdk.java.net/~ykantser/8059047/webrev.00/ This fix is a part of JEP 241: Remove the jhat Tool (https://bugs.openjdk.java.net/browse/JDK-8059039). I suggest to put

Re: RFR(M): 8059047: Extract parser/validator from jhat for use in tests

! Thanks, /Staffan On 22 apr 2015, at 11:17, Yekaterina Kantserova yekaterina.kantser...@oracle.com wrote: Hi, Could I please have a review of this fix. bug: https://bugs.openjdk.java.net/browse/JDK-8059047 webrev: http://cr.openjdk.java.net/~ykantser/8059047/webrev.00/ This fix is a part

Re: JDK 9 RFR of JDK-8077952: sun/management/jmxremote/bootstrap/RmiSslBootstrapTest.sh should be quarantined

Hi Joe, I would also suggest to put the test on the ProblemList, which is the current practice for jdk repo. Best regards, Katja - Original Message - From: alan.bate...@oracle.com To: joe.da...@oracle.com, serviceability-dev@openjdk.java.net Sent: Monday, April 20, 2015 7:44:30 PM

RFR(XS): 8077423: jstatd is not terminated even though it cannot contact or bind to RMI Registry

Hi, Could I please have a review of this fix. bug: https://bugs.openjdk.java.net/browse/JDK-8077423 webrev: http://cr.openjdk.java.net/~ykantser/8077423/webrev.00/ A couple of comments about changes in sun/tools/jstatd/JstatdTest.java. If the suggested fix will be accepted there will be no

Re: RFR(XXS): 8077611: com/sun/jdi/ConnectedVMs.java should be unquarantined

Staffan, thanks! On 04/15/2015 01:03 PM, Staffan Larsen wrote: Looks good! Thanks, /Staffan On 14 apr 2015, at 11:44, Yekaterina Kantserova yekaterina.kantser...@oracle.com wrote: Hi, Could I please have a review of this very small fix. bug: https://bugs.openjdk.java.net/browse/JDK

RFR(XXS): 8077611: com/sun/jdi/ConnectedVMs.java should be unquarantined

Hi, Could I please have a review of this very small fix. bug: https://bugs.openjdk.java.net/browse/JDK-8077611 webrev: http://cr.openjdk.java.net/~ykantser/8077611/webrev.00 Thanks, Katja

Re: RFR(XS): 8027668: sun/tools/jstatd/TestJstatdPort.java: java.net.ConnectException: Connection refused: connect

Hi, The updated webrev can be found here: http://cr.openjdk.java.net/~ykantser/8027668/webrev.01/ Thanks, Katja On 04/02/2015 02:44 PM, Jaroslav Bachorik wrote: Hi Katja, On 2.4.2015 14:16, Yekaterina Kantserova wrote: Hi, Could I please have a review of this fix. bug: https

Re: RFR(XS): 8027668: sun/tools/jstatd/TestJstatdPort.java: java.net.ConnectException: Connection refused: connect

with the changes anyway. -JB- On 7.4.2015 14:52, Yekaterina Kantserova wrote: Hi, The updated webrev can be found here: http://cr.openjdk.java.net/~ykantser/8027668/webrev.01/ Thanks, Katja On 04/02/2015 02:44 PM, Jaroslav Bachorik wrote: Hi Katja, On 2.4.2015 14:16, Yekaterina Kantserova wrote: Hi

Re: RFR(XS): 8027668: sun/tools/jstatd/TestJstatdPort.java: java.net.ConnectException: Connection refused: connect

Jaroslav, thanks, will do! // Katja On 04/02/2015 02:44 PM, Jaroslav Bachorik wrote: Hi Katja, On 2.4.2015 14:16, Yekaterina Kantserova wrote: Hi, Could I please have a review of this fix. bug: https://bugs.openjdk.java.net/browse/JDK-8027668 webrev: http://cr.openjdk.java.net/~ykantser

RFR(XS): 8027668: sun/tools/jstatd/TestJstatdPort.java: java.net.ConnectException: Connection refused: connect

Hi, Could I please have a review of this fix. bug: https://bugs.openjdk.java.net/browse/JDK-8027668 webrev: http://cr.openjdk.java.net/~ykantser/8027668/webrev.00/ The tests can still contain a race. There is a possibility the jstad is not really started though there is a pid for the process.

Re: RFR(XS): 8027668: sun/tools/jstatd/TestJstatdPort.java: java.net.ConnectException: Connection refused: connect

on …”? On 2 apr 2015, at 14:56, Yekaterina Kantserova yekaterina.kantser...@oracle.com wrote: Jaroslav, thanks, will do! // Katja On 04/02/2015 02:44 PM, Jaroslav Bachorik wrote: Hi Katja, On 2.4.2015 14:16, Yekaterina Kantserova wrote: Hi, Could I please have a review of this fix. bug: https

Re: RFR 8054890: Serviceability: New diagnostic commands 'VM.set_flag' and 'JVMTI.data_dump'

The tests looks good! Thank you very much for fixing. // Katja On 03/23/2015 12:41 PM, Staffan Larsen wrote: Looks good! Thanks, /Staffan On 23 mar 2015, at 11:55, Jaroslav Bachorik jaroslav.bacho...@oracle.com wrote: On 23.3.2015 08:50, Staffan Larsen wrote: diagnosticCommand.cpp: -

Re: RFR: JDK-8075586: add @modules as needed to the open hotspot tests

, Lois On 3/24/2015 8:09 AM, Yekaterina Kantserova wrote: Notifying hotspot-dev as well. // Katja On 03/24/2015 11:48 AM, Alexander Kulyakhtin wrote: Could the reviewers, please, have a look at the proposed changes below? In addition, we are going to make a change to the TEST.ROOT file

RFR(XXS): 8075818: serviceability/threads/TestFalseDeadLock.java should be unquarantined

Hi, Could I please have a review of these 2 very small fixes. bug: https://bugs.openjdk.java.net/browse/JDK-8075818 webrev: http://cr.openjdk.java.net/~ykantser/8075818/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8075820 webrev:

Re: RFR(XXS): 8075818: serviceability/threads/TestFalseDeadLock.java should be unquarantined

: serviceability/threads/TestFalseDeadLock.java should be unquarantined Hi Katja, this looks good. Just update the copyright years before pushing. No need to re-review. -JB- On 25.3.2015 11:05, Yekaterina Kantserova wrote: Hi, Could I please have a review of these 2 very small fixes. bug: https

Re: RFR(XXS): 8075818: serviceability/threads/TestFalseDeadLock.java should be unquarantined

: Re: RFR(XXS): 8075818: serviceability/threads/TestFalseDeadLock.java should be unquarantined Hi Katya, It looks good. Thanks, Serguei On 3/25/15 3:05 AM, Yekaterina Kantserova wrote: Hi, Could I please have a review of these 2 very small fixes. bug: https://bugs.openjdk.java.net/browse/JDK

Re: RFR: JDK-8075586: add @modules as needed to the open hotspot tests

Notifying hotspot-dev as well. // Katja On 03/24/2015 11:48 AM, Alexander Kulyakhtin wrote: Could the reviewers, please, have a look at the proposed changes below? In addition, we are going to make a change to the TEST.ROOT file as indicated by Staffan in the mail below. Do you think the

Re: RFR(XXS): 8064923: [TESTBUG] jps doesn't display anything on embedded platforms and it causes some tests to fail

Erik, Jaroslav, thanks for your reviews! // Katja On 03/18/2015 06:25 PM, Erik Gahlin wrote: Looks good. Erik Yekaterina Kantserova skrev den 18/03/15 17:37: Hi, Could I please have a review of this very small fix. bug: https://bugs.openjdk.java.net/browse/JDK-8064923 webrev: http

RFR(XXS): 8064923: [TESTBUG] jps doesn't display anything on embedded platforms and it causes some tests to fail

Hi, Could I please have a review of this very small fix. bug: https://bugs.openjdk.java.net/browse/JDK-8064923 webrev: http://cr.openjdk.java.net/~ykantser/8064923/webrev.00/ Thanks, Katja

Re: RFR(S): 8073794: jdk/test/com/sun/jdi/BadHandshakeTest.java should retry if tcp port is taken

Thanks Jaroslav! // Katja On 03/13/2015 07:00 PM, Jaroslav Bachorik wrote: Hi Katja, Thumbs up! -JB- On 13.3.2015 15:23, Yekaterina Kantserova wrote: Hi, Could I please have a review of this fix. bug: https://bugs.openjdk.java.net/browse/JDK-8073794 webrev: http://cr.openjdk.java.net

RFR(S): 8073794: jdk/test/com/sun/jdi/BadHandshakeTest.java should retry if tcp port is taken

Hi, Could I please have a review of this fix. bug: https://bugs.openjdk.java.net/browse/JDK-8073794 webrev: http://cr.openjdk.java.net/~ykantser/8073794/webrev.00/ Thanks, Katja

Re: [ping] Re: RFR 8074041: sun/management/jmxremote/startstop/JMXStartStopTest.java fails with InvocationTargetException

Hi Jaroslav, That's exactly the functionality I've been looking for! Not only it will solveJDK-8074041 the ProcessImpl will help me to solve https://bugs.openjdk.java.net/browse/JDK-8073794 since I'll be able to analyse out and err streams outside startProcess() function. Best regards,

Re: 8072856: Eliminate ProcessTools.getProcessId dependency on sun.management.VMManagement

, Daniel Fuchs wrote: Looks good to me too. JEP 102 Process Updates will provide an easier way to get the current process PID but we don't have that yet :-) best regards, -- daniel On 11/02/15 17:42, Yekaterina Kantserova wrote: Hi, Could I please have a review of this small fix. bug

8072856: Eliminate ProcessTools.getProcessId dependency on sun.management.VMManagement

Hi, Could I please have a review of this small fix. bug: https://bugs.openjdk.java.net/browse/JDK-8072856 webrev: http://cr.openjdk.java.net/~ykantser/8072856/webrev.00/ Thanks, Katja

RFR(XXS): 8071784: serviceability/attach/AttachWithStalePidFile.java should be quarantined

Hi, Could I please have a review of this very small fix. bug: https://bugs.openjdk.java.net/browse/JDK-8071784 webrev: http://cr.openjdk.java.net/~ykantser/8071784/webrev.00/ Thanks, Katja

Re: RFR: JDK-8071464: Clear up SVC jdk/test/* JRE layout dependencies other than those on tools.jar

Alex, I'll push. // Katja On 01/29/2015 01:21 PM, Alexander Kulyakhtin wrote: Hi Katja, Stafan I've corrected the alignment issue, per Stafan's review, and attached the patch. Could it be possible to push the patch? Thank you very much for your help. Best regards, Alex - Original

Re: RFR(XXS): 8071545: Tests are still excluded while the appropriate bug has been fixed

Thanks, Serguei! On 01/27/2015 09:33 AM, serguei.spit...@oracle.com wrote: Hi Katya, It looks good. Thanks, Serguei On 1/27/15 12:28 AM, Yekaterina Kantserova wrote: Hi, Could I please have a review of this very small fix. bug: https://bugs.openjdk.java.net/browse/JDK-8071545 webrev: http

RFR(XXS): 8071582: com/sun/jdi/GetLocalVariables4Test.sh should be quarantined

Hi, Could I please have a review of this very small fix. bug: https://bugs.openjdk.java.net/browse/JDK-8071582 webrev: http://cr.openjdk.java.net/~ykantser/8071582/webrev.00/ Thanks, Katja

RFR(XXS): 8071545: Tests are still excluded while the appropriate bug has been fixed

Hi, Could I please have a review of this very small fix. bug: https://bugs.openjdk.java.net/browse/JDK-8071545 webrev: http://cr.openjdk.java.net/~ykantser/8071545/webrev.00/ Thanks, Katja

RFR(XXS): 8071324: com/sun/jdi/ConnectedVMs.java should be quarantined

Hi, Could I please have a review of this very small fix. bug: https://bugs.openjdk.java.net/browse/JDK-8071324 webrev: http://cr.openjdk.java.net/~ykantser/8071324/webrev.00/ Thanks, Katja

Re: RFR(S): 8044419: TEST_BUG: com/sun/jdi/JdbReadTwiceTest.sh fails when run under root

Hi, New webrev can be found here http://cr.openjdk.java.net/~ykantser/8044419/webrev.03/ The fix has been tested on all platforms except embedded. Thanks, Katja On 01/21/2015 12:56 PM, Dmitry Samersoff wrote: Mattias, 1. mkFiles at ll. 215 above is reluctant 2. if you wish to store id

Re: RFR(S): 8044419: TEST_BUG: com/sun/jdi/JdbReadTwiceTest.sh fails when run under root

Dmitry, Staffan, thanks for your reviews! // Katja On 01/23/2015 04:43 PM, Staffan Larsen wrote: Looks good! Thanks, /Staffan On 23 jan 2015, at 09:51, Yekaterina Kantserova yekaterina.kantser...@oracle.com wrote: Hi, New webrev can be found here http://cr.openjdk.java.net/~ykantser

Re: RFR: JDK-8067945: SVC jdk/test/* should be cleaned from JRE layout dependency (corrected per the review findings)

Hi Alex, Comments bellow should be removed. You don't need to make a webrev for it, only the changes are included in the final patch. test/com/sun/jdi/connect/spi/JdiLoadedByCustomLoader.java 39 // create files from given arguments and tools.jar

Re: RFR: JDK-8067945: SVC jdk/test/* should be cleaned from JRE layout dependency (corrected per the review findings)

Looks god to me (not a reviewer). // Katja On 01/21/2015 11:23 AM, Alexander Kulyakhtin wrote: Hi Katia, Please, find attached the jdk.patch containing the changes per your findings. The patch has been made by running the webrev tool. Best regards, Alex - Original Message - From:

RFR(XXS): 8069296: java/lang/management/MemoryMXBean/LowMemoryTest.java should be quarantined

Hi, Could I please have a review of this very small fix. bug: https://bugs.openjdk.java.net/browse/JDK-8069296 webrev: http://cr.openjdk.java.net/~ykantser/8069296/webrev.00/ Thanks, Katja

Re: RFR(XXS): 8069296: java/lang/management/MemoryMXBean/LowMemoryTest.java should be quarantined

Thanks, Staffan! On 01/21/2015 03:04 PM, Staffan Larsen wrote: Looks good! Thanks, /Staffan On 21 jan 2015, at 13:25, Yekaterina Kantserova yekaterina.kantser...@oracle.com wrote: Hi, Could I please have a review of this very small fix. bug: https://bugs.openjdk.java.net/browse/JDK

Re: RFR(S): 6977426: sun/tools tests can intermittently fail to find app's Java pid

. Could they be made to return a constant instead? Cheers, -JB- On 12/16/2014 04:57 PM, Yekaterina Kantserova wrote: Hi, Could I please have a review of this fix. bug: https://bugs.openjdk.java.net/browse/JDK-6977426 webrev: http://cr.openjdk.java.net/~ykantser/6977426/webrev.00/ java/util

Re: RFR(S): 6977426: sun/tools tests can intermittently fail to find app's Java pid

Adding Erik. On 12/17/2014 10:10 AM, Yekaterina Kantserova wrote: Hi, Thanks for all reviews! The new webrev can be found here: http://cr.openjdk.java.net/~ykantser/6977426/webrev.01/ // Katja On 12/16/2014 05:41 PM, Jaroslav Bachorik wrote: Hi Katja, This request should probably go

Re: RFR(S): 6977426: sun/tools tests can intermittently fail to find app's Java pid

fails: On 17/12/14 10:10, Yekaterina Kantserova wrote: Hi, Thanks for all reviews! The new webrev can be found here: http://cr.openjdk.java.net/~ykantser/6977426/webrev.01/ Not that I believe it's very likely to happen, but I wonder if the condition to exit the while loop: 79 while (now

Re: RFR(S): 6977426: sun/tools tests can intermittently fail to find app's Java pid

can be found here: http://cr.openjdk.java.net/~ykantser/6977426/webrev.02/ // Katja On 12/17/2014 12:33 PM, Daniel Fuchs wrote: On 17/12/14 12:05, Yekaterina Kantserova wrote: Daniel, It's really funny to get such a feedback! (1) The output from test right now looks like

RFR(S): 6977426: sun/tools tests can intermittently fail to find app's Java pid

Hi, Could I please have a review of this fix. bug: https://bugs.openjdk.java.net/browse/JDK-6977426 webrev: http://cr.openjdk.java.net/~ykantser/6977426/webrev.00/ java/util/logging/LoggerWeakRefLeak.sh and java/util/logging/AnonLoggerWeakRefLeak.sh are merged and rewritten in java.

Re: RFR(S): 6977426: sun/tools tests can intermittently fail to find app's Java pid

() at some point before taking the histogram? If not what guarantee do we have that the various weak references will be purged? best regards, -- daniel On 16/12/14 16:57, Yekaterina Kantserova wrote: Hi, Could I please have a review of this fix. bug: https://bugs.openjdk.java.net/browse/JDK-6977426

Re: RFR(XS): 8044591: [TESTBUG] com/sun/management/GarbageCollectorMXBean/GarbageCollectionNotificationp[Content]Test.java fail when -XX:+ExplicitGCInvokesConcurrent

The new webrev can be found here: http://cr.openjdk.java.net/~ykantser/8044591/webrev.02/ // Katja On 12/02/2014 09:12 PM, Yekaterina Kantserova wrote: Right! Thank you for the catch! // Katja - Original Message - From: staffan.lar...@oracle.com To: yekaterina.kantser...@oracle.com

Re: RFR(XS): 8044591: [TESTBUG] com/sun/management/GarbageCollectorMXBean/GarbageCollectionNotificationp[Content]Test.java fail when -XX:+ExplicitGCInvokesConcurrent

Staffan, Fredric, thanks for your reviews! // Katja On 12/03/2014 11:04 AM, Frederic Parain wrote: Looks good to me, Thank you for fixing it. Fred On 12/02/2014 08:22 PM, Yekaterina Kantserova wrote: Hi, Could I please have a review of this small fix. bug: https://bugs.openjdk.java.net

RFR(XS): 8044591: [TESTBUG] com/sun/management/GarbageCollectorMXBean/GarbageCollectionNotificationp[Content]Test.java fail when -XX:+ExplicitGCInvokesConcurrent

Hi, Could I please have a review of this small fix. bug: https://bugs.openjdk.java.net/browse/JDK-8044591 webrev: http://cr.openjdk.java.net/~ykantser/8044591/webrev.00/ Thanks, Katja

Re: RFR(XS): 8044591: [TESTBUG] com/sun/management/GarbageCollectorMXBean/GarbageCollectionNotificationp[Content]Test.java fail when -XX:+ExplicitGCInvokesConcurrent

: Re: RFR(XS): 8044591: [TESTBUG] com/sun/management/GarbageCollectorMXBean/GarbageCollectionNotificationp[Content]Test.java fail when -XX:+ExplicitGCInvokesConcurrent Looks good, but the test also needs to be removed from ProblemList.txt. /Staffan On 2 dec 2014, at 20:22, Yekaterina Kantserova

RFR(XS): 8066106: sun/tools/jps/TestJpsClass.java failed to remove stale attach pid file

Hi, Could I please have a review of this fix. Since VM warnings go to stderr the suggested fix is to check only stdout for expected output and ignore warnings in stderr. bug: https://bugs.openjdk.java.net/browse/JDK-8066106 webrev: http://cr.openjdk.java.net/~ykantser/8066106/webrev.00/ The

Re: RFR(XS): 8066106: sun/tools/jps/TestJpsClass.java failed to remove stale attach pid file

mentioned in the issue description is actually caused by JpsBase failing because of the stale pid file error message in the jps stderr, right? -JB- On 11/28/2014 10:47 AM, Yekaterina Kantserova wrote: Hi, Could I please have a review of this fix. Since VM warnings go to stderr the suggested fix

Re: RFR(XS): 8066106: sun/tools/jps/TestJpsClass.java failed to remove stale attach pid file

Thanks! On 11/28/2014 04:04 PM, Jaroslav Bachorik wrote: On 11/28/2014 03:51 PM, Yekaterina Kantserova wrote: Hi Jaroslav, 1. Thank you for the catch! 2. Right, the test inspects jps output buffer (stdout and stderr) and expects the only jps related output appears there. But stderr may

RFR(S): 6542634: TEST BUG: MISC_REGRESSION tests need to have minimum timeouts examined

Hi, Could I please have a review of this fix. In this fix I take an opportunity to refactor sun/tools/jinfo/Basic.sh and to add more tests for jinfo utility. sun/tools/jinfo/Basic.sh is a last unstable test among tests listed inhttps://bugs.openjdk.java.net/browse/JDK-6542634 that's why

Re: RFR(S): 6542634: TEST BUG: MISC_REGRESSION tests need to have minimum timeouts examined

- processBuilder.command(...) could be moved to L67 and do new ProcessBuilder(launcher.getCommand()) - it communicates the purpose better Cheers, -JB- On 11/18/2014 12:07 PM, Yekaterina Kantserova wrote: Hi, Could I please have a review of this fix. In this fix I take an opportunity to refactor sun

Re: RFR(S): 6542634: TEST BUG: MISC_REGRESSION tests need to have minimum timeouts examined

Jaroslav, Erik, thanks! The new webrev can be found here http://cr.openjdk.java.net/~ykantser/6542634/webrev.01/ // Katja On 11/18/2014 03:36 PM, Jaroslav Bachorik wrote: On 11/18/2014 02:05 PM, Yekaterina Kantserova wrote: Hi Jaroslav, Thanks for the quick review! test/sun/tools/jinfo

Re: RFR: 8062536: [TESTBUG] Conflicting GC combinations in jdk tests

Hi Evgeniya, As David has pointed out these jps tests are not testing gc. The -XX:+UseParallelGC is just an arbitrary chosen test flag. There should not be any conflicts either since these tests are running in driver mode: ... * @run driver TestJpsJar ... which means no flags from above

Re: RFR: 8062536: [TESTBUG] Conflicting GC combinations in jdk tests

these tests are GC neutral. // Katja On 11/06/2014 11:27 AM, Yekaterina Kantserova wrote: Hi Evgeniya, As David has pointed out these jps tests are not testing gc. The -XX:+UseParallelGC is just an arbitrary chosen test flag. There should not be any conflicts either since these tests are running

  1   2   >