.net/browse/JDK-7037081
> [4] http://hg.openjdk.java.net/jdk9/hs-rt/hotspot/rev/018d5b58dd4f
>
--
[image: twitter-icon-large.png]
Keith McGuigan
@kamggg
kmcgui...@twitter.com
irst under a different bug id (provided that the review goes
> well)).
> >>
> >> The newly added test starts two VM with all possible combinations of
> setting and not setting java.io.tmpdir to verify that the mechanism is
> indeed not looking at that variable. I also removed an if-statement in
> BasicTests.java which would have found this issue a long time ago had it
> not been there.
> >>
> >> Thanks,
> >> /Staffan
> >
>
>
--
[image: twitter-icon-large.png]
Keith McGuigan
@kamggg
kmcgui...@twitter.com
Looks good, but why are you not using a newer version of webrev with "next"
links??
--
- Keith
On Fri, Apr 11, 2014 at 10:48 AM, Coleen Phillimore <
coleen.phillim...@oracle.com> wrote:
> Summary: Dtrace monitoring uses size before mirror size is set.
>
> The refactoring I did for bug https://b
Hi Staffan,
It looks ok to me. LInux has a 'dtrace' command now?
--
- Keith
On Tue, Jan 28, 2014 at 3:52 AM, Staffan Larsen
wrote:
> Still looking for reviewers for this change.
>
> Thanks,
> /Staffan
>
> On 23 jan 2014, at 08:36, Staffan Larsen
> wrote:
>
> > The only usage today of the DTr
Changeset: 4735d2c84362
Author:kamg
Date: 2012-10-11 12:25 -0400
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/4735d2c84362
7200776: Implement default methods in interfaces
Summary: Add generic type analysis and default method selection algorithms
Reviewed-by: coleenp,
Changeset: 48a75d2640a5
Author:kamg
Date: 2012-10-11 14:27 -0400
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/48a75d2640a5
7054345: Support version 52.0 class file in HotSpot
Summary: Accept classfiles with major version 52
Reviewed-by: coleenp, acorn
! src/share/vm/c
Changeset: 4ee06e614636
Author:kamg
Date: 2012-08-06 15:54 -0400
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/4ee06e614636
7116786: RFE: Detailed information on VerifyErrors
Summary: Provide additional detail in VerifyError messages
Reviewed-by: sspitsyn, acorn
! src/
Changeset: 4d399f013e5a
Author:kamg
Date: 2012-06-11 13:10 -0400
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/4d399f013e5a
7175914: Usage of gcc with precompiled headers produces wrong build dependencies
Summary: Add -fpch-deps flag to gcc builds
Reviewed-by: kamg, col
Changeset: e17b61ba7bb3
Author:kamg
Date: 2012-06-04 10:22 -0400
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e17b61ba7bb3
7166498: JVM crash in ClassVerifier
Summary: Fixed raw pointer being used after potential safepoint/GC
Reviewed-by: acorn, fparain, dholmes
! src
u have any?)
Thanks,
Serguei
On 5/23/12 9:27 AM, Keith McGuigan wrote:
Hi Mark -
I'd prefer that it's done the "right" way (based on *my* definition of
"right", of course :) ), but I won't put up a fuss if whomever
shepherds this through agrees with you and wan
ill be Serguei, or someone else from the serviceability
team? (Serguei?)
--
- Keith
On 5/23/2012 12:19 PM, Mark Wielaard wrote:
On Wed, 2012-05-23 at 10:23 -0400, Keith McGuigan wrote:
On 5/23/2012 9:56 AM, Mark Wielaard wrote:
It's (of course) just a style thing, but traditionally in hotspot
On 5/23/2012 9:56 AM, Mark Wielaard wrote:
It's (of course) just a style thing, but traditionally in hotspot
we've wanted the os or arch specific code in os or arch specific
directories, instead of littering the code with #ifdefs. I know the OSX
stuff started violated this some, but I hope
On 5/23/2012 9:26 AM, Mark Wielaard wrote:
On Wed, 2012-05-23 at 09:14 -0400, Keith McGuigan wrote:
Just a couple of quick comments/questions on the code:
Why did we get rid of a couple of the declarations in jni.cpp? Why
aren't they needed?
Could you say which ones you think we go
serguei.spit...@oracle.com wrote:
Mark,
I've created new RFE:
7170638: enable support for dtrace compatible sdt probes on GNU/Linux
The patches look good.
But I think, it is better to be reviewed by Keith McGuigan, who
originally added DTrace probes to HotSpot.
Also, let's check if
Hi Dan,
I think it looks good. The new form of the 'find' commands in Release.gmk could
use a comment, though. It took me a few minutes to realize that EXE_SUFFIX was
empty for linux/solaris -- it looks like there's a redundancy in the logic (both
NOT name *.debuginfo AND name *.exe). I s
Sure. Looks good!
--
- Keith
On 3/20/2012 6:37 AM, Staffan Larsen wrote:
I'd love to get another review of this by a Reviewer. Someone, please?
Thanks,
/Staffan
On 16 mar 2012, at 09:25, Rickard Bäckman wrote:
Staffan,
nice fixes, looks good to me.
/R
On Mar 16, 2012, at 9:10 AM, Staff
Looks good!
--
- Keith
On 3/19/2012 9:03 AM, Staffan Larsen wrote:
Please review the following fix:
Webrev: http://cr.openjdk.java.net/~sla/7152800/webrev.00/
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7152800
We sometimes get an error say "well-known file is not secure" when
ru
Making String.intern() more scalable has been on our list of
things-to-do for a long, long time. But, it's not trivial. Simply
increasing the size of the hashtable is no good because we'd be upping
our footprint unconditionally, so really we want a growing hashtable
which is a bit more effo
On 2/15/2012 2:34 AM, David Holmes wrote:
On 15/02/2012 7:20 AM, keith mcguigan wrote:
Well, ok, I guess it's not the smallest code change -- I think I've
matched this before -- but I guarantee you won't see one smaller than
this!
It's a one-liner (a one-character-
Changeset: b8a4e1d372a0
Author:kamg
Date: 2012-02-14 20:02 -0500
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b8a4e1d372a0
7145589: First JSDT provider creation fails
Summary: 0 is a successful return from an ioctl() call
Reviewed-by: dcubed, phh, dsamersoff
! src/sha
Changeset: a9831b955a0a
Author:kamg
Date: 2012-02-13 14:03 -0500
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a9831b955a0a
7069991: Setup make/jprt.properties files for jdk8
Summary: Change default release value to jdk8 (but overrideable)
Reviewed-by: phh, jcoomes, dho
Well, ok, I guess it's not the smallest code change -- I think I've matched this
before -- but I guarantee you won't see one smaller than this!
It's a one-liner (a one-character-er) to accept 0 as a successful return from an
ioctl() call, for registering dtrace providers.
http://cr.openjdk.
Looks good to me.
--
- Keith
Frederic Parain wrote:
Here's the new webrev:
http://cr.openjdk.java.net/~fparain/7143760/webrev.02/
The changes are:
- fix typo in comments
- roll-back wrong THREAD->CHECK modifications
- add a wrapper catching exceptions around the method
sending notificat
Looks good.
On Jan 27, 2012, at 8:12 AM, Stefan Karlsson wrote:
Here's a fix for a simple copy-n-past bug in the handling of
annotations, affecting only class redefinition.
http://cr.openjdk.java.net/~stefank/7022100/webrev.00/
7022100: Method annotations are incorrectly set when redefinin
Looks great, thanks!
--
- Keith
On 1/26/2012 8:17 AM, Rickard Bäckman wrote:
Hi,
can I have some reviews for this change?
I decided to go with unused typedefs (thanks Keith) for the usages in
the class definition and a do { } while (0) in the method definition.
The webrev:
http://cr.openjdk.
Changeset: eaa9557116a2
Author:bdelsart
Date: 2012-01-18 16:18 +0100
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/eaa9557116a2
7120448: Fix FP values for compiled frames in frame::describe
Summary: fix for debug method frame::describe
Reviewed-by: never, kvn
! src/cpu
Changeset: 8f8b94305aff
Author:dcubed
Date: 2012-01-11 19:54 -0800
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/8f8b94305aff
7129240: backout fix for 7102776 until 7128770 is resolved
Reviewed-by: phh, bobv, coleenp, dcubed
Contributed-by: Jiangli Zhou
! agent/src/sh
Changeset: 3b2b58fb1425
Author:tonyp
Date: 2011-12-20 12:59 -0500
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/3b2b58fb1425
7123165: G1: output during parallel verification can get messed up
Summary: Serialize the worker threads that are generating output during
paral
Didn't Dan Dougherty review this too? Is he a "reviewer" for this
project? If it helps you can put me down as a reviewer (kamg).
On Nov 2, 2011, at 2:54 PM, Neil Richards wrote:
On Wed, 2011-11-02 at 14:07 -0400, Zhengyu Gu wrote:
Hi Neil,
My understanding is that you need to have at le
Changeset: ca1f1753c866
Author:andrew
Date: 2011-07-28 14:10 -0400
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/ca1f1753c866
7072341: enable hotspot builds on Linux 3.0
Summary: Add "3" to list of allowable versions
Reviewed-by: kamg, chrisphi
! make/linux/Makefile
Forwarding to serviceability-dev (and Bcc'ing hotspot-runtime-dev off).
I personally don't see anything obviously wrong in the code you sent
but it looks like you've only sent a small fragment of the code and
the problem could well be somewhere else. What is the output, and
what do you ex
Changeset: fc2b798ab316
Author:ysr
Date: 2011-05-10 00:33 -0700
URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/fc2b798ab316
6883834: ParNew: assert(!_g->to()->is_in_reserved(obj),"Scanning field twice?")
with LargeObjects tests
Summary: Fixed process_chunk_boundaries()
Changeset: 78542e2b5e35
Author:fparain
Date: 2011-05-12 10:30 -0700
URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/78542e2b5e35
7036199: Adding a notification to the implementation of GarbageCollectorMXBeans
Summary: Add a notification to the GarbageCollectorMXBeans
Rev
Changeset: d498e50ae62d
Author:kamg
Date: 2011-05-12 08:17 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d498e50ae62d
7044203: Missing @test tag in test/javax/management/timer/StartTest.java
Summary: Add tag
Reviewed-by: alanb
! test/javax/management/timer/StartTest.java
Changeset: 831017d8fbcf
Author:kamg
Date: 2011-05-11 20:18 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/831017d8fbcf
6659215: javax.management.timer.Timer frequently fails to start
Summary: Copy array to avoid ConcurrentModificationException
Reviewed-by: dcubed, alanb
! sr
Changeset: da0fffdcc453
Author:johnc
Date: 2011-04-28 15:29 -0700
URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/da0fffdcc453
7040410: -Xloggc: incorrectly enables TraceClassUnloading causing tracing
on tty
Summary: Don't enable TraceClassUnloading whne -Xloggc is spec
Thanks, Dan. I integrated your changes and while I was at it I
spruced up some of the spacing too.
New version: http://cr.openjdk.java.net/~kamg/6659215/webrev.02/
On May 11, 2011, at 1:44 PM, Daniel D. Daugherty wrote:
On 5/11/2011 10:57 AM, Keith McGuigan wrote:
Hello,
This is a
Hello,
This is a forward port of the jdk6 bugfix for 6659215:
webrev: http://cr.openjdk.java.net/~kamg/6659215/webrev.00/
Thanks for any review!
--
- Keith
Changeset: 1d80a2429f59
Author:kamg
Date: 2011-05-05 12:50 -0400
URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/1d80a2429f59
7033669: JVM TI spec has to be changed to not contain URLS to the VM Spec
Summary: Update JVMTI source files to remove hyperlinks and add full le
On May 5, 2011, at 11:47 AM, Jim Holmlund wrote:
On 5/5/2011 6:21 AM, Keith McGuigan wrote:
It's the ™ character. (trademark, if that doesn't come through for
some reason on your mail client).
Keith, Joe Darcy said that the current way to represent tm in HTML
is to use ™
On May 5, 2011, at 9:37 AM, Daniel D. Daugherty wrote:
On 5/4/2011 7:10 PM, Keith McGuigan wrote:
Hello,
There has been a request for us to not link directly to the JVMS
from the JVMTI spec (especially using the old location in the
java.sun.com domain, which will likely go away someday
This one seems to refer to the wrong Chapter/Section - Constant pool
should be 4.4
Actually hold on a sec: The original URL:
http://java.sun.com/docs/books/vmspec/2nd-edition/html/ConstantPool.doc.html#79383
Does refer to chapter 5.3.1. Do you think the original URL is wrong?
I don't
line 1044 - what is #8482 for?
thanks for doing this,
Karen
On May 5, 2011, at 8:42 AM, Keith McGuigan wrote:
On May 4, 2011, at 11:18 PM, David Holmes wrote:
Hi Keith,
Keith McGuigan said the following on 05/05/11 11:10:
There has been a request for us to not link directly to the JVMS
from
On May 4, 2011, at 11:18 PM, David Holmes wrote:
Hi Keith,
Keith McGuigan said the following on 05/05/11 11:10:
There has been a request for us to not link directly to the JVMS
from the JVMTI spec (especially using the old location in the
java.sun.com domain, which will likely go away
Hello,
There has been a request for us to not link directly to the JVMS from
the JVMTI spec (especially using the old location in the java.sun.com
domain, which will likely go away someday). This change removes the
hyperlinks to the JVMS from the JVMTI Specification and replaces it
with
Changeset: 2705303a05c4
Author:schien
Date: 2011-04-14 15:21 -0700
URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/2705303a05c4
Added tag jdk7-b138 for changeset 0930dc920c18
! .hgtags
Changeset: d6d9b537f2c6
Author:trims
Date: 2011-04-14 17:53 -0700
URL:
Hi Dan,
Sorry, I was on vacation last week. Either version of your webrev
looks fine to me if you want my review. I agree with the other D's
though, that any tool that flags passing NULL to free() is a hunk of
junk :)
--
- Keith
On Apr 27, 2011, at 3:46 PM, Daniel D. Daugherty wrote:
Changeset: 7144a1d6e0a9
Author:kamg
Date: 2011-03-31 08:08 -0400
URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/7144a1d6e0a9
7030388: JCK test failed to reject invalid class check01304m10n.
Summary: Restrict fix for 7020118 to only when checking exception handlers
Revie
Changeset: 7cd61feb3ec6
Author:kamg
Date: 2011-04-15 10:17 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7cd61feb3ec6
6519228: JDWP Spec: need references at capability canRequestMonitorEvents for
JDWP 1.6 Monitor* events
Summary: Add descriptions in event type table
Reviewe
Hello,
Please review a clarification to the JDWP spec for JDK7 which makes
explicit which monitor events are available when the
canRequestMonitorEvents capability is present:
webrev: http://cr.openjdk.java.net/~kamg/6519228/webrev/
Thanks!
--
- Keith
Actually this is news to me. I thought that they were identical when
I checked it into the jdk repo. Might be that the someone (likely me)
changed the jvmti.xml file in the hotspot repo sometime afterward and
forgot to re-sync with the jdk. Can we just re-copy it over with the
next put
Changeset: dbad0519a1c4
Author:kamg
Date: 2011-03-04 14:40 -0500
URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/dbad0519a1c4
6845426: non-static method with no args is called during the class
initialization process
Summary: Only call with ACC_STATIC for classfiles wi
Changeset: 4a9604cd7c5f
Author:kamg
Date: 2011-03-02 08:18 -0500
URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/4a9604cd7c5f
6878713: Verifier heap corruption, relating to backward jsrs
Summary: Added overflow detection in arena Amalloc methods
Reviewed-by: coleenp, phh
Changeset: c1a6154012c8
Author:kamg
Date: 2011-02-28 16:01 -0500
URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/c1a6154012c8
7020118: Alter frame assignability to allow for exception handler coverage of
invokespecial
Summary: Add special rule to allow assignment of fr
Changeset: f91db74a6810
Author:kamg
Date: 2011-02-26 13:33 -0500
URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/f91db74a6810
7017640: Fix for 6766644 deadlocks on some NSK tests when running with -Xcomp
Summary: Dynamic-code generated events should be deferred and proce
Changeset: d8a72fbc4be7
Author:kamg
Date: 2011-02-08 17:20 -0500
URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/d8a72fbc4be7
7003401: Implement VM error-reporting functionality on erroneous termination
Summary: Add support for distribution-specific error reporting
Revie
Changeset: bf8517f4e4d0
Author:kamg
Date: 2011-02-02 14:38 -0500
URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/bf8517f4e4d0
6766644: Redefinition of compiled method fails with assertion "Can not load
classes with the Compiler thread"
Summary: Defer posting events from
Just did now.
On Feb 2, 2011, at 3:22 PM, Dmytro Sheyko wrote:
Keith,
Have you tried to re-open the bug? I can't see changes in its status.
Thanks,
Dmytro
CC: david.hol...@sun.com; serviceability-dev@openjdk.java.net
From: keith.mcgui...@oracle.com
To: dmytro_she...@hotmail.com
Subject: Re:
On Feb 1, 2011, at 6:38 PM, David Holmes wrote:
The point is to avoid the need to dynamically allocate the
QueueNodes. If the elements to be queued are self-linking then you
don't need the extra wrapper objects. Take a look at VM_Operations
as an example of self-linking objects.
It also m
On Jan 31, 2011, at 9:20 PM, David Holmes wrote:
Where we have:
961 void JvmtiDeferredEventQueue::enqueue(const
JvmtiDeferredEvent& event) {
...
967 QueueNode* node = new QueueNode(event);
and
1007 void JvmtiDeferredEventQueue::add_pending_event(
1008 const JvmtiDeferredEvent& eve
ent = JvmtiDeferredEventQueue::dequeue();
104 }
It may be fine but it seems a little strange.
---
There's no thread.hpp in the webrev but presumably you can now
delete the LowMemoryDetectorThread class.
---
Cheers,
David
Keith McGuigan said the following on 01/29/11 03:27:
Ok, here&
You'll have to excuse me while I struggle to remember the details of
this one, but I believe that the deadlock detection code in the VM
only detects the existence of a deadlock when it happens, but it
doesn't know which threads are a part of it. Any thread that is
currently blocked is a
Hi David,
On Jan 30, 2011, at 6:58 PM, David Holmes wrote:
This is a pretty major change in the event architecture and I have a
few comments and concerns - the main concern being "deadlock" as
it's not obvious exactly what locks can be held when the
service_lock will be acquired, nor is
Hi Dmytro -
This bug was marked 'closed' because the behavior noted is intentional
and we do not believe it should be changed. When an error situation
such as a deadlock occurs we want the developer to have as much
information as possible to help resolve the issue.
--
- Keith
On Jan 31
Ok, here's my next attempt: http://cr.openjdk.java.net/~kamg/6766644/webrev.02
This enqueues the compiled-method-unloaded events so that they the
posting of load/unload will be in order. Other changes include
locking the nmethod until after the compiled-method-load event is
posted, and a
Hello,
This code modifies the way that JVMTI compiled-method-load events are
posted. Previously, they were posted directly from the compiler
thread, which could cause issues if the JVMTI event handling code made
calls to RedefineClasses, since the compiler thread is unable to load
class
Changeset: f5c0b3cbee2f
Author:kamg
Date: 2011-01-12 11:47 -0500
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f5c0b3cbee2f
6436034: Instance filter doesn't filter event if it occurs in native method
Summary: Use 'GetLocalInstance' JVMTI extension if it exists
Reviewed-by: coleenp
Changeset: db2b0f8c1cef
Author:kamg
Date: 2011-01-11 10:06 -0500
URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/db2b0f8c1cef
6814943: getcpool001 catches more than one JvmtiThreadState problem
Summary: Mark field volatile, use membars, and change access order to close r
Changeset: 7246a374a9f2
Author:kamg
Date: 2011-01-10 17:14 -0500
URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/7246a374a9f2
6458402: 3 jvmti tests fail with CMS and +ExplicitGCInvokesConcurrent
Summary: Make JvmtiGCMark safe to run non-safepoint and instrument CMS
Revi
On Jan 10, 2011, at 7:07 PM, David Holmes wrote:
Hi Keith,
Keith McGuigan said the following on 01/11/11 03:36:
This closes a race condition hole between
JvmtiThreadState::state_for_while_locked() and ~JavaThread().
Without this, the state_for_while_locked() could see a value of
false
This closes a race condition hole between
JvmtiThreadState::state_for_while_locked() and ~JavaThread(). Without
this, the state_for_while_locked() could see a value of false for
thread->is_exiting(), then the entirety of ~JavaThread() could run,
the state_for_while_locked() could then fi
On Jan 6, 2011, at 9:01 AM, Alan Bateman wrote:
Keith McGuigan wrote:
:
I'll find and fix those comments. Can you expand upon what you
mean by "re-hash to the same slot"? I don't understand how that
would work.
Sorry for the delay getting back to you on this. I
On Jan 4, 2011, at 11:11 AM, Alan Bateman wrote:
Daniel D. Daugherty wrote:
:
This fix adds the missing JVMTI GC callbacks for CMS:
Webrev: http://cr.openjdk.java.net/~kamg/6458402/webrev.03/
Very nicely done. You should ping Alan B. to see if he has
time to sanity check the JVM/TI tap
Hello again,
My last request for a code review this year, I promise!
This fix adds the missing JVMTI GC callbacks for CMS:
Webrev: http://cr.openjdk.java.net/~kamg/6458402/webrev.03/
Details:
Existing mechanism used a stack-allocated JvmtiGCMarker to bracket the
GC operation. The destructo
On Dec 17, 2010, at 1:43 PM, Daniel D. Daugherty wrote:
- don't forget to update the copyright years in the various files
- block comment style is different than existing code. Should be:
/*
* ...
*/
Fixed and fixed.
src/share/back/debugInit.c
Yes, keep the JVM/TI version 0.x compatib
On Dec 16, 2010, at 7:18 PM, Mandy Chung wrote:
It's more of the maintainence cost and readability (supporting the
latest version vs all existing versions 1.1 and up) that I'd like to
give my feedback so that you (new owner) can make the right
judgement call :)
I don't claim to own any
On Dec 16, 2010, at 5:12 PM, Mandy Chung wrote:
On 12/15/10 20:37, Keith McGuigan wrote:
Checking the JVMTI version would help when you bump the minor number
in the JVMTI version from 1.1.x to 1.2. If a new JVMTI function is
added in JDK 7 in the future, it will bump the micro number but
On Dec 16, 2010, at 4:11 PM, Alan Bateman wrote:
Keith McGuigan wrote:
:
Ok, here's a new webrev: http://cr.openjdk.java.net/~kamg/6436034/webrev.01/
I added a regression test and modified the code in debugInit.cpp to
explicitly allow running with JVMTI 1.1 if that's wh
On Dec 15, 2010, at 4:44 AM, Alan Bateman wrote:
Keith McGuigan wrote:
:
Yeah I missed that check too. I'm very much in favor of being able
to use an older (or newer) JVM in the JDK7 image. Triage is one
important reason but another is the non-synchronous putback
schedules of th
On Dec 15, 2010, at 4:44 AM, Alan Bateman wrote:
Keith McGuigan wrote:
:
Yeah I missed that check too. I'm very much in favor of being able
to use an older (or newer) JVM in the JDK7 image. Triage is one
important reason but another is the non-synchronous putback
schedules of th
On Dec 14, 2010, at 9:38 AM, Daniel D. Daugherty wrote:
On 12/14/2010 3:23 AM, Alan Bateman wrote:
Keith McGuigan wrote:
Hello,
This is the JDK-side of the fix for instance filters that uses the
new GetLocalInstance JVMTI function.
http://cr.openjdk.java.net/~kamg/6436034/webrev.00
Changeset: 09b4dd4f152b
Author:kamg
Date: 2010-12-09 15:04 -0500
URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/09b4dd4f152b
7004582: Add GetThisObject() function to JVMTI 1.2
Summary: Add 'GetThisObject' function
Reviewed-by: never, coleenp
! src/share/vm/code/nmethod
See subject. Does anybody know? The only thing it appears to do is
cause a recaching of the JvmtiBreakpoint cache after minor
collections, which is unnecessary as a minor collection will not
change any bytecode pointers. It's a "product" flag, defaulting to
false. Can it be removed o
Hello,
This is the JDK-side of the fix for instance filters that uses the new
GetLocalInstance JVMTI function.
http://cr.openjdk.java.net/~kamg/6436034/webrev.00/
Reviews appreciated, thanks!
--
- Keith
Hello,
Would appreciate a review for adding this new JVMTI function which
will be used to enhance JDI event instance filtering. See the JVMTI
spec (included in the webrev) for the details.
http://cr.openjdk.java.net/~kamg/7004582/webrev.00/
Thanks!
--
- Keith
Changeset: 684faacebf20
Author:kamg
Date: 2010-12-06 20:21 -0500
URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/684faacebf20
7003782: Update JVMTI version to 1.2 for jdk7
Summary: Update minor version to 1.2 for jdk7
Reviewed-by: phh, dcubed
! src/share/vm/prims/jvmti.
http://cr.openjdk.java.net/~kamg/7003782/webrev.03/
Comme ça?
--
- Keith
On Dec 6, 2010, at 11:29 AM, Daniel D. Daugherty wrote:
On 12/6/2010 8:22 AM, Keith McGuigan wrote:
This change updates the JVMTI revision number from 1.1 to 1.2, when
Hotspot is placed in a jdk >= 7.
h
On Dec 6, 2010, at 11:29 AM, Daniel D. Daugherty wrote:
src/share/vm/prims/jvmtiEnv.cpp
Since JVM/TI version 1.0, 1.1 and (presumably) 1.2 are compatible
with each other, you don't need to do this check. The relevant
part of the JVM/TI spec is:
http://download.oracle.com/javase/6/docs/
This change updates the JVMTI revision number from 1.1 to 1.2, when
Hotspot is placed in a jdk >= 7.
http://cr.openjdk.java.net/~kamg/7003782/webrev.00/
Thanks for any review.
--
- Keith
/10 2:29 PM, Keith McGuigan wrote:
This fix adds JVMTI callbacks for CMS full GCs:
http://cr.openjdk.java.net/~kamg/6458402/webrev.00/
--
- Keith
On Dec 3, 2010, at 3:30 AM, Igor Veresov wrote:
You're calling notify_gc_end() while holding the FullGCCount_lock.
Is that ok? Would it be more prudent to divert control to the user
without holding it?
The notify_gc_end() call does not divert control to the user -- it
contains only the c
This fix adds JVMTI callbacks for CMS full GCs:
http://cr.openjdk.java.net/~kamg/6458402/webrev.00/
--
- Keith
Hello,
I'd like to propose a new revision of the JVMTI spec, 1.2.1 to be
implemented by Hotspot in JDK 7, with the addition of a new method,
GetThisObject() (defined below). This new function would be part of
the 'Local Variable" set of functions. The motivation for this
addition is bet
Changeset: 35f885165c69
Author:kamg
Date: 2010-11-05 09:32 -0400
URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/35f885165c69
6981737: The java.vm.specification.version property is 1.0, seems like it
should be 2.0
Summary: Change property value to 1. for major_version >
Changeset: 613f1b310cdb
Author:kamg
Date: 2010-10-26 18:41 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/613f1b310cdb
6541462: outdated specification for CCC 6339875
Summary: Add documentation to java.lang.ClassLoader.defineClass()
Reviewed-by: dcubed, darcy
! src/share/cla
Changeset: 1070423b51f3
Author:kamg
Date: 2010-10-27 12:53 -0400
URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/1070423b51f3
6865028: Illegal instructions passing verification prior to 'invokespecial
Object.'
Summary: Update verifier to conform to spec re: reference vs
Changeset: 6412b3805cd6
Author:kamg
Date: 2010-10-26 14:08 -0400
URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/6412b3805cd6
6891959: HotSpot should not throw ClassFormatError if a class has a field with
'>' and/or '<' in its name
Summary: Class file parser needs to lo
Changeset: a4c7fe54bf3f
Author:kamg
Date: 2010-10-21 10:10 -0400
URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/a4c7fe54bf3f
6991315: RedefineClasses fails with java.lang.VerifyError
Summary: Repair stackmap table attribute when relocating bytecode
Reviewed-by: acorn, n
Changeset: c77b5c592eab
Author:kamg
Date: 2010-10-12 10:57 -0400
URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/c77b5c592eab
6392697: Additional flag needed to supress Hotspot warning messages
Summary: Apply PrintJvmWarnings flag to all warnings
Reviewed-by: coleenp, ph
Changeset: f353275af40e
Author:never
Date: 2010-09-02 11:40 -0700
URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/f353275af40e
6981773: incorrect fill value with OptimizeFill
Reviewed-by: kvn, twisti
! src/cpu/sparc/vm/stubGenerator_sparc.cpp
Changeset: d5d065957597
Au
1 - 100 of 131 matches
Mail list logo
