Re: Review request for 7195249: Some jtreg tests use hard coded ports

2014-02-27 Thread taras ledkov
Staffan, Excuse me. I didn't know about that. I looked at the http://openjdk.java.net/census#serviceability. Now I'm in need of the second review. On 26.02.2014 18:36, Staffan Larsen wrote: On 26 feb 2014, at 15:24, taras ledkov taras.led...@oracle.com wrote: Hi, Alan, Mandy could you

Re: Review request for 7195249: Some jtreg tests use hard coded ports

2014-02-26 Thread taras ledkov
/ Webrev for hs part: http://cr.openjdk.java.net/~anazarov/7195249/hs/webrev.03/ On 25.02.2014 17:52, Jaroslav Bachorik wrote: Thumbs up. (not a reviewer, though) -JB- On 19.2.2014 12:05, taras ledkov wrote: Hi, Imports are fixed: http://cr.openjdk.java.net/~anazarov/7195249/jdk/webrev.04

Re: Review request for 7195249: Some jtreg tests use hard coded ports

2014-02-19 Thread taras ledkov
/bootstrap/SSLConfigFilePermissionTest.java. It does not use any of those classes as its base class AbstractFilePermissionTest does all the heavy lifting. Cheers, -JB- On 5.2.2014 13:42, taras ledkov wrote: Hi, So please take a look at the review against JDK9. The reviewed patch had not been

Re: Review request for 7195249: Some jtreg tests use hard coded ports

2014-02-05 Thread taras ledkov
/ Webrev for hs part: http://cr.openjdk.java.net/~anazarov/7195249/hs/webrev.03/ On 21.01.2014 13:45, Jaroslav Bachorik wrote: Hi Taras, On 21.1.2014 10:30, taras ledkov wrote: Hi Jaroslav, Could you please review the last changes? Are you OK? Yes, the change looks ok. But I think we

Re: Review request for 7195249: Some jtreg tests use hard coded ports

2014-01-21 Thread taras ledkov
Hi Jaroslav, Could you please review the last changes? Are you OK? On 20.01.2014 19:21, Staffan Larsen wrote: Sorry for not replying earlier. Yes, I’m ok with these changes. Thanks, /Staffan On 20 jan 2014, at 16:07, taras ledkov taras.led...@oracle.com wrote: Hi Staffan, I fixed

Re: Review request for 7195249: Some jtreg tests use hard coded ports

2014-01-20 Thread taras ledkov
Hi Staffan, I fixed the tests according with your comments. Are you OK? On 15.01.2014 19:15, taras ledkov wrote: Hi, Please take a look at the new review. Webrev for jdk part: http://cr.openjdk.java.net/~anazarov/7195249/jdk/webrev.02/ Webrev for hs part: http://cr.openjdk.java.net

Re: Review request for 7195249: Some jtreg tests use hard coded ports

2014-01-15 Thread taras ledkov
the AbstractFilePermissionTest (see the doTest method, AbstractFilePermissionTest : 162). Thanks, /Staffan On 26 dec 2013, at 14:09, taras ledkov taras.led...@oracle.com wrote: Hi, Please take a look at the review with fixed issues about trying to launch test that needs free port several times. Webrev

Re: Fwd: Re: Review request for 7195249: Some jtreg tests use hard coded ports

2013-12-26 Thread taras ledkov
to retry. Thanks, Katja On 12/02/2013 01:39 PM, taras ledkov wrote: Hi Everyone, Whatever logic is to be chosen to select a free port, it is the library responsibility to implements it, would not you agree? Hence what I am suggesting is to integrate the tests as is. Should we decide to replace

Re: Review request for 7195249: Some jtreg tests use hard coded ports

2013-12-02 Thread taras ledkov
:54, taras ledkov wrote: Hi Everyone, I am working on bug https://bugs.openjdk.java.net/browse/JDK-7195249. There are two webrevs: Webrev for jdk part: http://cr.openjdk.java.net/~anazarov/7195249/jdk/webrev.00/ Webrev for hs part: http://cr.openjdk.java.net/~anazarov/7195249/hs/webrev.00/ Please

Re: RFR 8028141 intermittent test failure of LocalManagementTest

2013-11-19 Thread taras ledkov
://cr.openjdk.java.net/~rriggs/webrev-localmanagement-8028141/ Thanks, Roger -- With best regards, Taras Ledkov Mail-To: taras.led...@oracle.com skype: taras_ledkov Phone: 7(812)3346-157

Re: RFR for JDK-7195249 Some jtreg tests use hard coded ports

2013-11-11 Thread taras ledkov
if you see anything wrong with this fix. Taras -- With best regards, Taras Ledkov Mail-To: taras.led...@oracle.com skype: taras_ledkov Phone: 7(812)3346-157

RFR for JDK-7195249 Some jtreg tests use hard coded ports

2013-11-06 Thread taras ledkov
comments or suggestions. Thank you -- With best regards, Taras Ledkov Mail-To: taras.led...@oracle.com skype: taras_ledkov Phone: 7(812)3346-157