Re: 8218812: vmTestbase/nsk/jvmti/GetAllThreads/allthr001/TestDescription.java failed

2019-03-15 Thread Daniel D. Daugherty
hancement: https://bugs.openjdk.java.net/browse/JDK-8220468 > > Thanks, > Daniil > > From: > Organization: Oracle Corporation > Date: Thursday, March 7, 2019 at 12:19 PM > To: Daniil Titov , OpenJDK Serviceability > Subject: Re: RFR: 821

Re: 8218812: vmTestbase/nsk/jvmti/GetAllThreads/allthr001/TestDescription.java failed

2019-03-13 Thread serguei.spit...@oracle.com
iceability-dev@openjdk.java.net> Subject: Re: RFR: 8218812: vmTestbase/nsk/jvmti/GetAllThreads/allthr001/TestDescription.java failed There are other places where is_hidden_from_external_view() is used.  Should is_hidden_from_external_view() also check

Re: 8218812: vmTestbase/nsk/jvmti/GetAllThreads/allthr001/TestDescription.java failed

2019-03-12 Thread Daniil Titov
Organization: Oracle Corporation > Date: Thursday, March 7, 2019 at 12:19 PM > To: Daniil Titov , OpenJDK Serviceability > Subject: Re: RFR: 8218812: vmTestbase/nsk/jvmti/GetAllThreads/allthr001/TestDescription.java failed > > There are other places where is_hi

Re: 8218812: vmTestbase/nsk/jvmti/GetAllThreads/allthr001/TestDescription.java failed

2019-03-11 Thread dean . long
Bug: https://bugs.openjdk.java.net/browse/JDK-8218812 [3] Enhancement: https://bugs.openjdk.java.net/browse/JDK-8220468 Thanks, Daniil From: Organization: Oracle Corporation Date: Thursday, March 7, 2019 at 12:19 PM To: Daniil Titov , OpenJDK Serviceability Subject: Re: RFR: 8218812: vmTestbase/nsk/jvmti/Get

Re: 8218812: vmTestbase/nsk/jvmti/GetAllThreads/allthr001/TestDescription.java failed

2019-03-11 Thread Jean Christophe Beyler
iil Titov , OpenJDK Serviceability < > serviceability-dev@openjdk.java.net> > Subject: Re: RFR: 8218812: > vmTestbase/nsk/jvmti/GetAllThreads/allthr001/TestDescription.java failed > > There are other places where is_hidden_from_external_view() is used. > Should is_hidden_f

Re: 8218812: vmTestbase/nsk/jvmti/GetAllThreads/allthr001/TestDescription.java failed

2019-03-11 Thread Daniil Titov
ganization: Oracle Corporation Date: Thursday, March 7, 2019 at 12:19 PM To: Daniil Titov , OpenJDK Serviceability Subject: Re: RFR: 8218812: vmTestbase/nsk/jvmti/GetAllThreads/allthr001/TestDescription.java failed There are other places where is_hidden_from_external_view() is use

Re: RFR: 8218812: vmTestbase/nsk/jvmti/GetAllThreads/allthr001/TestDescription.java failed

2019-03-07 Thread dean . long
This part seems to change the value for the include_jni_attaching_threads arg from true to false: - ThreadsListEnumerator tle(Thread::current(), true); + ThreadsListEnumerator tle(Thread::current(), true, false, JvmtiExport::should_show_compiler_threads()); dl

Re: RFR: 8218812: vmTestbase/nsk/jvmti/GetAllThreads/allthr001/TestDescription.java failed

2019-03-07 Thread dean . long
There are other places where is_hidden_from_external_view() is used.  Should is_hidden_from_external_view() also check the new capability?  If so, then you can simplify your changes.  I'm not sure the new capability is the best choice, however.  There is still no way to control whether compiler

Re: RFR: 8218812: vmTestbase/nsk/jvmti/GetAllThreads/allthr001/TestDescription.java failed

2019-03-07 Thread Daniel D. Daugherty
On 3/7/19 12:54 PM, Daniil Titov wrote: Please review a change that fixes this test. The problem here is that the test checks the number of threads and with Graal on additional threads the test doesn't expect are started and cause the test fail. The fix introduces a new capability " can_sho

RFR: 8218812: vmTestbase/nsk/jvmti/GetAllThreads/allthr001/TestDescription.java failed

2019-03-07 Thread Daniil Titov
Please review a change that fixes this test. The problem here is that the test checks the number of threads and with Graal on additional threads the test doesn't expect are started and cause the test fail. The fix introduces a new capability " can_show_compiler_threads" that affects wh

Re: 8218812: vmTestbase/nsk/jvmti/GetAllThreads/allthr001/TestDescription.java failed

2019-03-07 Thread Daniil Titov
Please disregard this email, somehow it got a wrong body.. Will resend the request later after dealing with my mail client. Best regards, Danill On 3/7/19, 9:46 AM, "serviceability-dev on behalf of Daniil Titov" wrote: Resending review request with corrected subject... Please r

RFR: 8218812: vmTestbase/nsk/jvmti/GetAllThreads/allthr001/TestDescription.java failed

2019-03-07 Thread Daniil Titov
Resending review request with corrected subject... Please review a fix for this test that intermittently fails with Graal on. The problem here is that the test does two consequent calls to VirtualMachine.allThreads() and checks that the number of threads returned by these calls is the same. W

8218812: vmTestbase/nsk/jvmti/GetAllThreads/allthr001/TestDescription.java failed

2019-03-07 Thread Daniil Titov
Please review a change that fixes this test. The problem here is that the test checks the number of threads and with Graal on additional threads the test doesn't expect are started and cause the test fail. The fix introduces a new capability " can_show_compiler_threads" that affects whether Ja