Hi David!
Thank you very much for the review!
On 19.11.2014 5:47, David Holmes wrote:
In case you are still waiting this all looks fine to me.
Thanks,
David
On 13/11/2014 2:49 AM, Evgeniya Stepanova wrote:
Forgotten copyrights were changed
In case you are still waiting this all looks fine to me.
Thanks,
David
On 13/11/2014 2:49 AM, Evgeniya Stepanova wrote:
Forgotten copyrights were changed
http://cr.openjdk.java.net/~eistepan/8062536/webrev.04/
On 12.11.2014 20:07, Evgeniya Stepanova wrote:
Hi Bengt,
Please see comments
Hi Evgeniya,
On 2014-11-12 17:07, Evgeniya Stepanova wrote:
Hi Bengt,
Please see comments inline
On 12.11.2014 19:43, Bengt Rutisson wrote:
On 2014-11-12 16:21, Evgeniya Stepanova wrote:
Hi everyone!
Since the decision was made to change only tests which fail because
of conflict for now
Hi Bengt!
Ok, I'll remove this string.
Thank you for reviewing it one more time :)
Evgeniya Stepanova
On 13.11.2014 13:44, Bengt Rutisson wrote:
Hi Evgeniya,
On 2014-11-12 17:07, Evgeniya Stepanova wrote:
Hi Bengt,
Please see comments inline
On 12.11.2014 19:43, Bengt Rutisson wrote:
On
Hi everyone!
Since the decision was made to change only tests which fail because of
conflict for now (skip selfish tests), I post new webrev for jdk part
of the JDK-8019361 https://bugs.openjdk.java.net/browse/JDK-8019361:
http://cr.openjdk.java.net/~avstepan/eistepan/8062536/webrev.03/
On 2014-11-12 16:21, Evgeniya Stepanova wrote:
Hi everyone!
Since the decision was made to change only tests which fail because of
conflict for now (skip selfish tests), I post new webrev for jdk
part of the JDK-8019361
https://bugs.openjdk.java.net/browse/JDK-8019361:
On 2014-11-12 16:43, Bengt Rutisson wrote:
On 2014-11-12 16:21, Evgeniya Stepanova wrote:
Hi everyone!
Since the decision was made to change only tests which fail because
of conflict for now (skip selfish tests), I post new webrev for jdk
part of the JDK-8019361
Hi Bengt,
Please see comments inline
On 12.11.2014 19:43, Bengt Rutisson wrote:
On 2014-11-12 16:21, Evgeniya Stepanova wrote:
Hi everyone!
Since the decision was made to change only tests which fail because
of conflict for now (skip selfish tests), I post new webrev for jdk
part of the
Forgotten copyrights were changed
http://cr.openjdk.java.net/~eistepan/8062536/webrev.04/
On 12.11.2014 20:07, Evgeniya Stepanova wrote:
Hi Bengt,
Please see comments inline
On 12.11.2014 19:43, Bengt Rutisson wrote:
On 2014-11-12 16:21, Evgeniya Stepanova wrote:
Hi everyone!
Since the
On 2014-11-08 09:11, Dmitry Fazunenko wrote:
Hi Mandy,
On 08.11.2014 02:41, Mandy Chung wrote:
On 11/7/14 3:34 AM, Evgeniya Stepanova wrote:
http://cr.openjdk.java.net/~eistepan/8062536/webrev.02/
What are the valid values ofvm.gc? It's a bit awk for null as a
valid value and I would
On 10.11.2014 20:28, Bengt Rutisson wrote:
On 2014-11-08 09:11, Dmitry Fazunenko wrote:
Hi Mandy,
On 08.11.2014 02:41, Mandy Chung wrote:
On 11/7/14 3:34 AM, Evgeniya Stepanova wrote:
http://cr.openjdk.java.net/~eistepan/8062536/webrev.02/
What are the valid values ofvm.gc? It's a bit
Hi Filipp,
Ok, then I'll just remove option :)
Thanks
On 06.11.2014 18:02, Filipp Zhinkin wrote:
Hi Evgeniya,
it seems like there is no need to use Serial GC in
java/lang/ref/EnqueuePollRace.java [1],
so it does make sense to remove that option instead of adding the
@requires tag.
David, Filipp, Katja
Diff have been updated one more time:
java/lang/management/RuntimeMXBean/TestInputArgument.sh and
test/java/lang/ref/EnqueuePollRace.java have been changed
http://cr.openjdk.java.net/~eistepan/8062536/webrev.02/
Thanks
On 07.11.2014 9:37, David Holmes wrote:
On
Thank you for taking care of it,
the fix looks good to me (not a R-reviewer).
Thanks,
Filipp.
On 11/07/2014 03:34 PM, Evgeniya Stepanova wrote:
David, Filipp, Katja
Diff have been updated one more time:
java/lang/management/RuntimeMXBean/TestInputArgument.sh and
On 11/7/14 3:34 AM, Evgeniya Stepanova wrote:
http://cr.openjdk.java.net/~eistepan/8062536/webrev.02/
What are the valid values ofvm.gc? It's a bit awk for null as a valid
value and I would imagine * wildcard may be a better value?
Since you are touching test/java/lang/management/**
Hi Katja,
You are right, there will be no conflict, because test ignores any
external VM flags.
So, adding @requires seems unnecessary here, but...
Ignoring external options is bad thing, such selfish tests are not
applicable for other areas, like GC, compiler, RT.
@requires will allow to
Thanks a lot!
On 11/06/2014 02:05 PM, Evgeniya Stepanova wrote:
Hi Katja,
Ok, this seems to be a perfect solution. Thank you. I'll change the
diff accordingly.
Thanks,
Evgeniya Stepanova
On 06.11.2014 16:56, Yekaterina Kantserova wrote:
Hi Dima,
On 11/06/2014 11:22 AM, Dmitry Fazunenko
New webrev:
http://cr.openjdk.java.net/~eistepan/8062536/webrev.01/
Thanks,
Evgeniya Stepanova
On 06.11.2014 17:35, Yekaterina Kantserova wrote:
Thanks a lot!
On 11/06/2014 02:05 PM, Evgeniya Stepanova wrote:
Hi Katja,
Ok, this seems to be a perfect solution. Thank you. I'll change the
diff
Hi Evgeniya,
it seems like there is no need to use Serial GC in
java/lang/ref/EnqueuePollRace.java [1],
so it does make sense to remove that option instead of adding the @requires tag.
Thanks,
Filipp.
[1] https://bugs.openjdk.java.net/browse/JDK-8051723
On 11/06/2014 06:36 PM, Evgeniya
On 7/11/2014 12:36 AM, Evgeniya Stepanova wrote:
New webrev:
http://cr.openjdk.java.net/~eistepan/8062536/webrev.01/
In:
test/java/lang/management/RuntimeMXBean/TestInputArgument.sh
the use of the gc options seems incidental - it's just picking two
innocuous options to use - similar to the
Hi David!
Ok, I'll change the diff.
Thank you
On 07.11.2014 9:37, David Holmes wrote:
On 7/11/2014 12:36 AM, Evgeniya Stepanova wrote:
New webrev:
http://cr.openjdk.java.net/~eistepan/8062536/webrev.01/
In:
test/java/lang/management/RuntimeMXBean/TestInputArgument.sh
the use of the gc
21 matches
Mail list logo
