On May 12, 2014, at 1:00 PM, Ivan Gerasimov ivan.gerasi...@oracle.com wrote:
src/share/classes/sun/misc/UUDecoder.java
126 StringBuilder x = new StringBuilder();
Is only filled, but doesn't seem to be used anyhow.
Maybe just delete it?
Thanks, i will take a look at this and your
On May 12, 2014, at 4:07 PM, Daniel Fuchs daniel.fu...@oracle.com wrote:
Hi Paul,
I looked at -management and the changes there look good.
There is just some two spaces vs four space formatting in
On 12/05/2014 11:55, Paul Sandoz wrote:
On May 12, 2014, at 12:42 PM, Alan Bateman alan.bate...@oracle.com wrote:
On 12/05/2014 11:03, Paul Sandoz wrote:
It covers many areas and i have grouped the patches into such areas to aid
reviewing. When commenting please including core-libs.
The
Hi,
This is a request for review of Otavio's patch replacing StringBuffer with
StringBuilder within OpenJDK. (I also need to review it.)
It covers many areas and i have grouped the patches into such areas to aid
reviewing. When commenting please including core-libs.
Jtreg tests showed no
Wouldn't it be a little bit more efficient to replace a string
concatenation with yet another StringBuilder operation?
src/share/classes/com/sun/java/util/jar/pack/BandStructure.java
631 StringBuilder sb = new StringBuilder();
...
636 Utils.log.fine(
On 12/05/2014 11:03, Paul Sandoz wrote:
It covers many areas and i have grouped the patches into such areas to
aid reviewing. When commenting please including core-libs.
The groupings are a bit odd but I looked through the -core, -io,
-management and -rmi patches and don't see any issues.
On May 12, 2014, at 12:42 PM, Alan Bateman alan.bate...@oracle.com wrote:
On 12/05/2014 11:03, Paul Sandoz wrote:
It covers many areas and i have grouped the patches into such areas to aid
reviewing. When commenting please including core-libs.
The groupings are a bit odd
Yeah, definitely
src/share/classes/sun/misc/UUDecoder.java
126 StringBuilder x = new StringBuilder();
Is only filled, but doesn't seem to be used anyhow.
Maybe just delete it?
Sincerely yours,
Ivan
On 12.05.2014 14:03, Paul Sandoz wrote:
Hi,
This is a request for review of Otavio's patch replacing
Hi Paul,
I looked at -management and the changes there look good.
There is just some two spaces vs four space formatting in
http://cr.openjdk.java.net/~psandoz/jdk9/sb/JDK-8041679-buffer-to-builder-management/webrev/src/share/classes/com/sun/jndi/cosnaming/CNNameParser.java.frames.html
line 99.
On 05/12/2014 12:42 PM, Alan Bateman wrote:
On 12/05/2014 11:03, Paul Sandoz wrote:
It covers many areas and i have grouped the patches into such areas
to aid reviewing. When commenting please including core-libs.
The groupings are a bit odd but I looked through the -core, -io,
-management
10 matches
Mail list logo
