RE: OpenJDK SADebugDTest.java test : handling of "Address already in use"

2022-01-02 Thread Baesken, Matthias
Hi Yasumasa, thanks for addressing the issue . I put your patch into our internal nightly test queue . Best regards, Matthias > >> `testResult` and `portInUse` are important variables in this logic, >> however they are overwritten in lambda expression - they won't affect >> to the caller. >> (I

Re: OpenJDK SADebugDTest.java test : handling of "Address already in use"

2021-12-31 Thread Yasumasa Suenaga
I've sent PR for this problem: https://github.com/openjdk/jdk/pull/6941 `testResult` and `portInUse` are important variables in this logic, however they are overwritten in lambda expression - they won't affect to the caller. (I wonder why the test can compile without any error...) They are c

Re: OpenJDK SADebugDTest.java test : handling of "Address already in use"

2021-12-31 Thread Yasumasa Suenaga
Hi Matthias, I think SADebugDTest.java wouldn't work that we expect. ``` 114 Process debugd = startProcess("debugd", pb, null, 115 l -> { 116 if (!useRmiPort && l.contains(GOLDEN)) { 117 testResul

OpenJDK SADebugDTest.java test : handling of "Address already in use"

2021-12-30 Thread Baesken, Matthias
Hello, I have a question regarding the test SADebugDTest.java . The test https://github.com/openjdk/jdk/blob/master/test/hotspot/jtreg/serviceability/sa/sadebugd/SADebugDTest.java seems to handle already cases where "Address already in use" is found in the output (see line 120 ). However in o