Hi Yasumasa,
Changes look and and passed all my testing.
thanks,
Chris
On 7/19/18 10:13 PM, Yasumasa Suenaga wrote:
Hi Chris,
Thank you for your comment.
I uploaded new webrev. Could you review again?
http://cr.openjdk.java.net/~ysuenaga/JDK-8205992/webrev.02/
I tested my change on Linu
Hi Chris,
Thank you for your comment.
I uploaded new webrev. Could you review again?
http://cr.openjdk.java.net/~ysuenaga/JDK-8205992/webrev.02/
I tested my change on Linux x64, but I cannot check it on other
platform (includes older Linux).
However SA tests are included in HotSpot tier 1 test
Hi Yasumasa,
84 // It maps the LWPID in the host to it in the container.
"it" -> "the PID"
286 // Get LWPID in the host from the container's LWPID.
287 public int getHostPID(int id) {
288 try {
289 return nspidMap.get(id);
290 } catch (NullPointerE
PING:
Could you review it?
JBS:https://bugs.openjdk.java.net/browse/JDK-8205992
webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8205992/webrev.01/
This change has been reviewed by Jini.
We need a Reviewer.
Thanks,
Yasumasa
On 2018/07/12 13:42, Yasumasa Suenaga wrote:
Thanks Jin
Thanks Jini!
I'm waiting for Reviewer.
Yasumasa
2018-07-12 14:09 GMT+09:00 Jini George :
> Looks good to me.
>
> Thanks!
> Jini (Not a Reviewer).
>
>
> On 7/12/2018 10:12 AM, Yasumasa Suenaga wrote:
>>
>> Thanks Jini,
>>
>> I uploaded new webrev. It contains some comments and removing extra s
Looks good to me.
Thanks!
Jini (Not a Reviewer).
On 7/12/2018 10:12 AM, Yasumasa Suenaga wrote:
Thanks Jini,
I uploaded new webrev. It contains some comments and removing extra space.
http://cr.openjdk.java.net/~ysuenaga/JDK-8205992/webrev.01/
Yasumasa
2018-07-12 2:32 GMT+09:00 Jini Geor
Thanks Jini,
I uploaded new webrev. It contains some comments and removing extra space.
http://cr.openjdk.java.net/~ysuenaga/JDK-8205992/webrev.01/
Yasumasa
2018-07-12 2:32 GMT+09:00 Jini George :
> Hi Yasumasa,
>
> This looks good to me except for one nit. And some more comments would help.
Hi Yasumasa,
This looks good to me except for one nit. And some more comments would
help. For e.g., it would help to say that NSPidMap is to map the host to
container lwpids.
The nit:
*
http://cr.openjdk.java.net/~ysuenaga/JDK-8205992/webrev.00/src/jdk.hotspot.agent/linux/native/libsaproc/L
PING: Could you review it?
JBS:https://bugs.openjdk.java.net/browse/JDK-8205992
webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8205992/webrev.00/
Thanks,
Yasumasa
On 2018/06/28 22:12, Yasumasa Suenaga wrote:
Hi all,
Please review this change.
JBS:https://bugs.openjdk.jav
