RE: Proposal: ModuleReferenceImpl.c to use ReleaseStringUTFChars not jvmtiDeallocate

2017-08-29 Thread Lindenmaier, Goetz
August 2017 12:38 > To: Langer, Christoph > Cc: serviceability-dev@openjdk.java.net > Subject: RE: Proposal: ModuleReferenceImpl.c to use ReleaseStringUTFChars > not jvmtiDeallocate > > Hi Christoph / Serguei, > > I see from the bug that was created that the change has

RE: Proposal: ModuleReferenceImpl.c to use ReleaseStringUTFChars not jvmtiDeallocate

2017-08-29 Thread Steve Groeger
Hi Christoph / Serguei, I see from the bug that was created that the change has been pushed to a repository. Thanks for this. However, I may be confused as to the delivery/promote strategy for changes as this change was pushed to the 'hs' (hotspot) repository and not the 'jdk10' (Master + d

Re: Proposal: ModuleReferenceImpl.c to use ReleaseStringUTFChars not jvmtiDeallocate

2017-08-27 Thread serguei.spit...@oracle.com
a.net Subject: Re: Proposal: ModuleReferenceImpl.c to use ReleaseStringUTFChars not jvmtiDeallocate   Hi Serguei,   Thanks for raising th

RE: Proposal: ModuleReferenceImpl.c to use ReleaseStringUTFChars not jvmtiDeallocate

2017-08-27 Thread Langer, Christoph
Steve Groeger Sent: Samstag, 26. August 2017 08:10 To: serguei.spit...@oracle.com Cc: serviceability-dev@openjdk.java.net Subject: Re: Proposal: ModuleReferenceImpl.c to use ReleaseStringUTFChars not jvmtiDeallocate Hi Serguei, Thanks for raising the bug. No I am not an OpenJDK author hence me

Re: Proposal: ModuleReferenceImpl.c to use ReleaseStringUTFChars not jvmtiDeallocate

2017-08-25 Thread Steve Groeger
Hi Serguei, Thanks for raising the bug. No I am not an OpenJDK author hence me asking for a sponsor and information on how to contribute the fix for this issue. Any guidance you can give will be great. Thanks Steve Groeger Sent from my iPhone > On 25 Aug 2017, at 19:12, "serguei.spit...@o

Re: Proposal: ModuleReferenceImpl.c to use ReleaseStringUTFChars not jvmtiDeallocate

2017-08-25 Thread serguei.spit...@oracle.com
Hi Steve, Thank you for reporting this! I've filed the bug:   https://bugs.openjdk.java.net/browse/JDK-8186776     use ReleaseStringUTFChars instead of jvmtiDeallocate to release strings Are you and OpenJDK author? Tha

Proposal: ModuleReferenceImpl.c to use ReleaseStringUTFChars not jvmtiDeallocate

2017-08-25 Thread Steve Groeger
Hello, I would like to propose the change below to src/jdk.jdwp.agent/share/native/libjdwp/ModuleReferenceImpl.c native code so that the getName function use ReleaseStringUTFChars() to release the memory obtained using GetStringUTFChars() instead of the current jvmtiDeallocate() met