RE: [PATCH] EnableTracing: output from multiple threads may be mixed together

2013-05-13 Thread Yunda
t; hotspot-runtime-...@openjdk.java.net > Subject: Re: [PATCH] EnableTracing: output from multiple threads may be mixed > together > > Yunda, > > sorry for taking a while. I created JDK-8014478 for this and I'll sponsor the > change. > > /R > > On May 10, 2013, at 4:32 AM, 云达

Re: [PATCH] EnableTracing: output from multiple threads may be mixed together

2013-05-13 Thread Rickard Bäckman
+if (UseLockedTracing) { >>> + ttyLocker lock; >>> + writeEventContent(); >>> + } else { >>> + writeEventContent(); >>> +} >>> + } >>> + >>> + void writeEventContent() { >>>TraceStream ts(

Re: [PATCH] EnableTracing: output from multiple threads may be mixed together

2013-05-09 Thread David Holmes
4:53 PM To: 云达(Yunda) Cc: David Holmes; serviceability-dev@openjdk.java.net; hotspot-runtime-...@openjdk.java.net Subject: Re: [PATCH] EnableTracing: output from multiple threads may be mixed together Looks good to me! /R On May 9, 2013, at 8:38 AM, 云达(Yunda) wrote: Rickard, Actually I&#x

RE: [PATCH] EnableTracing: output from multiple threads may be mixed together

2013-05-09 Thread Yunda
serviceability-dev@openjdk.java.net; > hotspot-runtime-...@openjdk.java.net > Subject: Re: [PATCH] EnableTracing: output from multiple threads may be mixed > together > > Looks good to me! > > /R > > On May 9, 2013, at 8:38 AM, 云达(Yunda) wrote: > > > Rickard, >

Re: [PATCH] EnableTracing: output from multiple threads may be mixed together

2013-05-09 Thread Rickard Bäckman
tent() { > TraceStream ts(*tty); > ts.print(": ["); > > > > Regards, > Yunda > >> -Original Message- >> From: Rickard Bäckman [mailto:rickard.back...@oracle.com] >> Sent: Wednesday, May 08, 2013 3:03 PM >> To: David Holme

RE: [PATCH] EnableTracing: output from multiple threads may be mixed together

2013-05-09 Thread Yunda
olmes > Cc: 云达(Yunda); serviceability-dev@openjdk.java.net; > hotspot-runtime-...@openjdk.java.net > Subject: Re: [PATCH] EnableTracing: output from multiple threads may be mixed > together > > One option could be to move the content of writeEvent() to its own method > (maybe writ

Re: [PATCH] EnableTracing: output from multiple threads may be mixed together

2013-05-08 Thread Rickard Bäckman
); >> +} >> TraceStream ts(*tty); >> ts.print(": ["); >> >> ts.print("]\n"); >> +if (UseLockedTracing) { >> + ttyLocker::release_tty(holder); >> + } >> } >> }; >> >> &g

Re: [PATCH] EnableTracing: output from multiple threads may be mixed together

2013-05-07 Thread David Holmes
t(": ["); Regards, Yunda -Original Message- From: David Holmes [mailto:david.hol...@oracle.com] Sent: Tuesday, May 07, 2013 10:39 AM To: 云达(Yunda) Cc: hotspot-runtime-...@openjdk.java.net; serviceability-dev@openjdk.java.net Subject: Re: [PATCH] EnableTracing: output f

RE: [PATCH] EnableTracing: output from multiple threads may be mixed together

2013-05-07 Thread Yunda
Sent: Tuesday, May 07, 2013 5:50 PM > To: 云达(Yunda) > Cc: hotspot-runtime-...@openjdk.java.net; > serviceability-dev@openjdk.java.net > Subject: Re: [PATCH] EnableTracing: output from multiple threads may be mixed > together > > On 7/05/2013 7:43 PM, 云达(Yunda) wrote: > >

Re: [PATCH] EnableTracing: output from multiple threads may be mixed together

2013-05-07 Thread David Holmes
To: 云达(Yunda) Cc: hotspot-runtime-...@openjdk.java.net; serviceability-dev@openjdk.java.net Subject: Re: [PATCH] EnableTracing: output from multiple threads may be mixed together Hi Yunda, There is a potential problem with using a ttyLocker here, depending on exactly what events are being traced

RE: [PATCH] EnableTracing: output from multiple threads may be mixed together

2013-05-07 Thread Yunda
lue" mode="write-data"/> > > Regards, > Yunda > > > -Original Message- > > From: David Holmes [mailto:david.hol...@oracle.com] > > Sent: Tuesday, May 07, 2013 10:39 AM > > To: 云达(Yunda) > > Cc: hotspot-runtime-...@openjdk.java.net; > >

RE: [PATCH] EnableTracing: output from multiple threads may be mixed together

2013-05-07 Thread Yunda
[mailto:david.hol...@oracle.com] > Sent: Tuesday, May 07, 2013 10:39 AM > To: 云达(Yunda) > Cc: hotspot-runtime-...@openjdk.java.net; > serviceability-dev@openjdk.java.net > Subject: Re: [PATCH] EnableTracing: output from multiple threads may be mixed > together > > Hi Yunda, &g

Re: [PATCH] EnableTracing: output from multiple threads may be mixed together

2013-05-06 Thread David Holmes
Hi Yunda, There is a potential problem with using a ttyLocker here, depending on exactly what events are being traced and from where - you must always be in code where it is both safe to acquire the lock, and safe to block waiting for the lock if it is not available. I think I would prefer t

RE: [PATCH] EnableTracing: output from multiple threads may be mixed together

2013-05-02 Thread Yunda
_ From: Kirk Pepperdine [k...@kodewerk.com] Sent: Thursday, May 02, 2013 21:49 To: 云达(Yunda) Cc: Staffan Larsen; serviceability-dev@openjdk.java.net; hotspot-runtime-...@openjdk.java.net Subject: Re: [PATCH] EnableTracing: output from multiple threads may be mixed together Hi Yunda, Sorry for n

RE: [PATCH] EnableTracing: output from multiple threads may be mixed together

2013-05-02 Thread Yunda
from multiple threads may be mixed together Looks good. (not a reviewer) /Staffan On 2 maj 2013, at 05:07, 云达(Yunda) mailto:yunda@taobao.com>> wrote: Could anyone review this for me, please? Regards, Yunda From: 云达(Yunda) Sent: Friday, April 19, 2013 4:26 PM To: hotspot-r

RE: [PATCH] EnableTracing: output from multiple threads may be mixed together

2013-05-02 Thread Yunda
] EnableTracing: output from multiple threads may be mixed together Yunda, the change looks good (not a Reviewer). /R On May 2, 2013, at 5:07 AM, 云达(Yunda) wrote: > Could anyone review this for me, please? > > Regards, > Yunda > > From: 云达(Yunda) > Sent: Friday, April 19, 2013

Re: [PATCH] EnableTracing: output from multiple threads may be mixed together

2013-05-02 Thread Kirk Pepperdine
Sent: Thursday, May 02, 2013 21:05 > To: Staffan Larsen > Cc: 云达(Yunda); serviceability-dev@openjdk.java.net; > hotspot-runtime-...@openjdk.java.net > Subject: Re: [PATCH] EnableTracing: output from multiple threads may be mixed > together > > What effect with this have on

RE: [PATCH] EnableTracing: output from multiple threads may be mixed together

2013-05-02 Thread Yunda
n Larsen Cc: 云达(Yunda); serviceability-dev@openjdk.java.net; hotspot-runtime-...@openjdk.java.net Subject: Re: [PATCH] EnableTracing: output from multiple threads may be mixed together What effect with this have on the other mixed up log files? Regards, Kirk On 2013-05-02, at 2:57 PM,

Re: [PATCH] EnableTracing: output from multiple threads may be mixed together

2013-05-02 Thread Kirk Pepperdine
What effect with this have on the other mixed up log files? Regards, Kirk On 2013-05-02, at 2:57 PM, Staffan Larsen wrote: > Looks good. (not a reviewer) > > /Staffan > > On 2 maj 2013, at 05:07, 云达(Yunda) wrote: > >> Could anyone review this for me, please? >> >> Regards, >> Yunda >> >

Re: [PATCH] EnableTracing: output from multiple threads may be mixed together

2013-05-02 Thread Staffan Larsen
Looks good. (not a reviewer) /Staffan On 2 maj 2013, at 05:07, 云达(Yunda) wrote: > Could anyone review this for me, please? > > Regards, > Yunda > > From: 云达(Yunda) > Sent: Friday, April 19, 2013 4:26 PM > To: hotspot-runtime-...@openjdk.java.net; serviceability-dev@openjdk.java.net > Subje

Re: [PATCH] EnableTracing: output from multiple threads may be mixed together

2013-05-01 Thread Rickard Bäckman
Yunda, the change looks good (not a Reviewer). /R On May 2, 2013, at 5:07 AM, 云达(Yunda) wrote: > Could anyone review this for me, please? > > Regards, > Yunda > > From: 云达(Yunda) > Sent: Friday, April 19, 2013 4:26 PM > To: hotspot-runtime-...@openjdk.java.net; serviceability-dev@openjdk.j

RE: [PATCH] EnableTracing: output from multiple threads may be mixed together

2013-05-01 Thread Yunda
Could anyone review this for me, please? Regards, Yunda From: 云达(Yunda) Sent: Friday, April 19, 2013 4:26 PM To: hotspot-runtime-...@openjdk.java.net; serviceability-dev@openjdk.java.net Subject: [PATCH] EnableTracing: output from multiple threads may be mixed together Hi all, I found that the