Re: RFR(XS): 8245521: Remove STACK_BIAS

2020-05-26 Thread Mikael Vidstedt
David/Matthias/Vladimir, thanks for the reviews! Change pushed. Cheers, Mikael > On May 26, 2020, at 12:01 PM, Vladimir Kozlov > wrote: > > On 5/21/20 9:11 PM, David Holmes wrote: >> Hi Mikael, >> Looks good. > > +1 > >> I assume the change to GraalHotSpotVMConfig.java is to allow it to

Re: RFR(XS): 8245521: Remove STACK_BIAS

2020-05-26 Thread Vladimir Kozlov
On 5/21/20 9:11 PM, David Holmes wrote: Hi Mikael, Looks good. +1 I assume the change to GraalHotSpotVMConfig.java is to allow it to work with older VMs? Yes. stackBias will be set to 0 if STACK_BIAS is not present. Otherwise it will be set to STACK_BIAS value. Thanks, Vladimir

RE: RFR(XS): 8245521: Remove STACK_BIAS

2020-05-22 Thread Baesken, Matthias
Hi Mikael, looks good, thanks for the cleanup . Best regards, Matthias -Original Message- From: ppc-aix-port-dev On Behalf Of Mikael Vidstedt Sent: Freitag, 22. Mai 2020 05:37 To: hotspot compiler ; hotspot-runtime-...@openjdk.java.net runtime ; serviceability-dev ;

Re: RFR(XS): 8245521: Remove STACK_BIAS

2020-05-21 Thread David Holmes
Hi Mikael, Looks good. I assume the change to GraalHotSpotVMConfig.java is to allow it to work with older VMs? Thanks, David On 22/05/2020 1:36 pm, Mikael Vidstedt wrote: Please review this small change which removes the STACK_BIAS constant and its uses: JBS: