Sent: Samstag, 14. September 2019 00:18
To: Baesken, Matthias ; Thomas Stüfe
Cc: serviceability-dev@openjdk.java.net
Subject: Re: RFR [XS]: 8230901: missing ReleaseStringUTFChars in servicability
native code
Hi Matthias,
On 9/12/19 4:52 AM, Baesken, Matthias wrote:
Hi Thomas, thanks for the
tthias
*Cc:* serviceability-dev@openjdk.java.net
*Subject:* Re: RFR [XS]: 8230901: missing ReleaseStringUTFChars in
servicability native code
Hi Matthias,
your changes look good.
an additional bug:
http://cr.openjdk.java.net/~mbaesken/webrevs/8230901.0/src/jdk.hotspot.agent/solaris/native/lib
Hi Matthias,
The fix looks good to me.
Thank you for catching and fixing this!
Thanks,
Serguei
On 9/13/19 3:01 AM, Baesken, Matthias wrote:
Hello , my colleague Ralf pointed out that the NULL-check of the
result of GetStringUTFChars
should be done right after the GetStringUTFChars
Hello , my colleague Ralf pointed out that the NULL-check of the result of
GetStringUTFChars
should be done right after the GetStringUTFChars so I moved the
NULL-check up :
http://cr.openjdk.java.net/~mbaesken/webrevs/8230901.2/
Best regards, Matthias
Hi Thomas, thanks for the
/java.desktop/unix/native/common/awt/X11Color.c:782:cmapsize =
atoi(getenv("CMAPSIZE"));
Should I open a bug for these ?
Best regards, Matthias
From: Thomas Stüfe
Sent: Donnerstag, 12. September 2019 12:22
To: Baesken, Matthias
Cc: serviceability-dev@openjdk.ja
Hi Matthias,
your changes look good.
an additional bug:
http://cr.openjdk.java.net/~mbaesken/webrevs/8230901.0/src/jdk.hotspot.agent/solaris/native/libsaproc/saproc.cpp.frames.html
698 #ifndef _LP64
699 atoi(cmdLine_cstr);
700 if (errno) {
Behaviour of atoi() in error case is
