Re: [OpenJDK 2D-Dev] RFR(L): 8024854: Basic changes and files to build the class library on AIX

2013-10-17 Thread Volker Simonis
Hi Phil, thanks a lot for the review. Please see my comments inline: On Wed, Oct 16, 2013 at 12:48 AM, Phil Race philip.r...@oracle.com wrote: Hello Volker, I just remembered got back to these changes - my email inbox isn't a very good reminder system. I am OK with everything I see in the

Re: [OpenJDK 2D-Dev] RFR(L): 8024854: Basic changes and files to build the class library on AIX

2013-10-15 Thread Phil Race
Hello Volker, I just remembered got back to these changes - my email inbox isn't a very good reminder system. I am OK with everything I see in the client areas except as below :- /* Very basic start for AIX - feel free to complete .. 169 */ We should remove this comment. If that means

Re: RFR(L): 8024854: Basic changes and files to build the class library on AIX

2013-09-26 Thread Sean Mullan
On 09/16/2013 12:30 PM, Volker Simonis wrote: src/share/lib/security/java.security-aix - Provide default java.security-aix for AIX. The login.configuration.provider property should be set to: sun.security.provider.ConfigFile See 8016848 for more info. After you make this change,

RE: [OpenJDK 2D-Dev] RFR(L): 8024854: Basic changes and files to build the class library on AIX

2013-09-20 Thread Iris Clark
Hi, Volker. Just wanted to say that in addition to preparing for JavaOne (next week!), we're also busy fixing bugs in anticipation of JDK 8 ZBB milestone on 24 Oct [1]. Thanks, iris [1]: http://openjdk.java.net/projects/jdk8/milestones -Original Message- From: Phil Race Sent:

Re: RFR(L): 8024854: Basic changes and files to build the class library on AIX

2013-09-20 Thread Staffan Larsen
Volker, The serviceability-related changes look ok to me (not a Reviewer). /Staffan On 16 sep 2013, at 21:30, Volker Simonis volker.simo...@gmail.com wrote: Resending this to more lists as requested by Alan Bateman with the kind request to anybody to review the parts for which he feels

Re: RFR(L): 8024854: Basic changes and files to build the class library on AIX

2013-09-20 Thread Chris Hegarty
Volker, I skimmed over the networking part of the changes, and nothing jumps out at me. I'd like to spend a little more time doing a more detailed review, but I will not have time to do this until after JavaOne. -Chris. On 09/16/2013 08:30 PM, Volker Simonis wrote: Resending this to more

Re: RFR(L): 8024854: Basic changes and files to build the class library on AIX

2013-09-20 Thread Michael McMahon
A few comments: 1) Seems to be two macros _AIX and AIX. Is this intended? NetworkInterface.c 2) line 1098: new style of variable declaration. First time we would have that in this code. I think it should be okay though 3) Can't comment on the AIX functionality, except I

Re: [OpenJDK 2D-Dev] RFR(L): 8024854: Basic changes and files to build the class library on AIX

2013-09-19 Thread Phil Race
Hi, w.r.t the one issue below : is the awt load library code the only place you need/are doing this ? If someone else (hotspot, core-libs) already assented to this then I guess I could too but I'd like to hear for sure that hotspot and core-libs teams both agree to this approach and whether

Re: [OpenJDK 2D-Dev] RFR(L): 8024854: Basic changes and files to build the class library on AIX

2013-09-19 Thread Volker Simonis
Hi Phil, I'm open to any good ideas. The current solution is pragmatic, simple and it has no impact on existing platforms. The other possibility I see is to put the 'dladdr' implantation into its own library (something equivalent to libjli) and link that library to libawt. But I currently don't

Re: [OpenJDK 2D-Dev] RFR(L): 8024854: Basic changes and files to build the class library on AIX

2013-09-18 Thread Phil Race
Volker, I've skimmed the client related changes - mostly based on the descriptions. I'll look in more detail as soon as I can after JavaOne. We also have some engineers out on vacation who might want to look at these too. A couple of things that stood out : On AIX, fontconfig is not a standard