d Holmes mailto:david.hol...@oracle.com,
serviceability-dev mailto:serviceability-dev@openjdk.java.net,
mailto:hotspot-gc-...@openjdk.java.net mailto:hotspot-gc-...@openjdk.java.net
Subject: Re: RFR(L): 8215624: add parallel heap inspection support for jmap
histo(G1)(Internet mail)
Hi Lin,
The latest web
at 1:06 AM
To: "linzang(臧琳)"
Cc: "Hohensee, Paul" , Stefan Karlsson
, David Holmes ,
serviceability-dev ,
"hotspot-gc-...@openjdk.java.net"
Subject: Re: RFR(L): 8215624: add parallel heap inspection support for jmap
histo(G1)(Internet mail)
Hi Lin,
Thanks you for
n , David
Holmes , serviceability-dev
,
"hotspot-gc-...@openjdk.java.net"
Subject: Re: RFR(L): 8215624: add parallel heap
inspection support for jmap histo(G1)(Internet mail)
at 4:23 AM
To: "linzang(臧琳)"
Cc: "Hohensee, Paul" , Stefan Karlsson
, David Holmes ,
serviceability-dev ,
"hotspot-gc-...@openjdk.java.net"
Subject: Re: RFR(L): 8215624: add parallel heap inspection support for jmap
histo(G1)(Internet mail)
Hi Lin,
The latest webr
viceability-dev ,
"hotspot-gc-...@openjdk.java.net"
Subject: Re: RFR(L): 8215624: add parallel heap inspection support for jmap
histo(G1)(Internet mail)
Hi Lin,
The latest webrev looks good to me.
Just want to double check, how did you check no regressions are introduced with
your f
I will made a new changeset with following changes:
>>> > * Print
error message + usage when parameter check fail in Jmap.java
>>> > *Retrive
the histo logic that if “all” and “live” are set at same time,
us
undefined options, will setup a new issue in JBS and
fix it separately soon.
>>>
>>>
>>> BRs,
>>> Lin
>>>
>>> From: "serguei.spit...@oracle.com"
>>> Date: Tuesday, Aug
ately soon.
BRs,
Lin
From: "serguei.spit...@oracle.com"
Date: Tuesday, August 11, 2020 at 8:40 AM
To: "linzang(臧琳)" , "Hohensee, Paul" , Stefan Karlsson
, David Holmes , serviceability-dev ,
"hotspot-gc-...@openjdk.java.net"
Subject: Re: RFR(L): 8215624: add paralle
l setup a new issue in JBS and fix
>> it separately soon.
>>
>>
>> BRs,
>> Lin
>>
>> From: "serguei.spit...@oracle.com"
>> Date: Tuesday, August 11, 2020 at 8:40 AM
>> To: "linzang(臧琳)" , "Hohensee, Paul"
>
David Holmes , serviceability-dev ,
"hotspot-gc-...@openjdk.java.net"
Subject: Re: RFR(L): 8215624: add parallel heap inspection support for jmap
histo(G1)(Internet mail)
Hi Lin,
A couple of things.
First, the CSR does not include any update for 'live' and 'all' options, does
it?
If so, t
e, Paul"
, Stefan Karlsson , David
Holmes , serviceability-dev
, "hotspot-gc-...@openjdk.java.net"
Subject: Re: RFR(L): 8215624: add parallel heap inspection support for jmap
histo(G1)(Internet mail)
Hi Lin,
A couple of things.
First, the CSR does not include any update for 'live' an
e enhancement about spec is reasonable ?
Thanks!
BRs,
Lin
From: "serguei.spit...@oracle.com"
Date: Tuesday, August 11, 2020 at 5:11 AM
To: "linzang(臧琳)" , "Hohensee, Paul" , Stefan Karlsson , David Holmes , serviceability-dev , "hotspot-gc-.
te: Tuesday, August 11, 2020 at 5:11 AM
To: "linzang(臧琳)" , "Hohensee, Paul"
, Stefan Karlsson , David
Holmes , serviceability-dev
, "hotspot-gc-...@openjdk.java.net"
Subject: Re: RFR(L): 8215624: add parallel heap inspection support for jmap
histo(G1)(Int
ng(臧琳)"
, "Hohensee, Paul"
, Stefan Karlsson
, David Holmes
, serviceability-dev
,
"hotspot-gc-...@openjdk.java.net"
Subject: Re: RFR(L): 8215624: add parallel heap
" , "Hohensee, Paul"
> , Stefan Karlsson ,
> David Holmes , serviceability-dev
> , "hotspot-gc-...@openjdk.java.net"
>
> *Subject: *Re: RFR(L): 8215624: add parall
" , "Hohensee, Paul"
> , Stefan Karlsson ,
> David Holmes , serviceability-dev
> , "hotspot-gc-...@openjdk.java.net"
>
> *Subject: *Re: RFR(L): 8215624: add parallel heap inspection support f
> , Stefan Karlsson
,
> David Holmes ,
serviceability-dev
> ,
"hotspot-gc-...@openjdk.java.net"
>
> *Subject: *Re: RFR(L): 8215624: add parallel heap
i
ay, August 5, 2020 at 1:02 PM
> *To: *"linzang(臧琳)" , "Hohensee,
Paul"
> , Stefan Karlsson
,
> David Holmes ,
serviceability-dev
> ,
"hotspot-gc-...@openjdk.java.net"
, August 5, 2020 at 1:02 PM
> *To: *"linzang(臧琳)" , "Hohensee,
Paul"
> , Stefan Karlsson
,
> David Holmes , serviceability-dev
> ,
"hotspot-gc-...@openjdk.java.net"
hensee, Paul"
> , Stefan Karlsson
,
> David Holmes , serviceability-dev
> ,
"hotspot-gc-...@openjdk.java.net"
>
> *Subject: *Re: RFR(L): 8215624: add parallel heap inspection
support for
*"linzang(臧琳)" , "Hohensee, Paul"
> , Stefan Karlsson
,
> David Holmes , serviceability-dev
> ,
"hotspot-gc-...@openjdk.java.net"
>
> *Subject: *Re: RFR(L): 8215624: add parall
t;
> , Stefan Karlsson ,
> David Holmes , serviceability-dev
> ,
"hotspot-gc-...@openjdk.java.net"
>
> *Subject: *Re: RFR(L): 8215624: add parallel heap inspection support
for
> jmap histo(G1)(Internet mail)
>
nzang(臧琳)" , "Hohensee, Paul"
> , Stefan Karlsson ,
> David Holmes , serviceability-dev
> , "hotspot-gc-...@openjdk.java.net"
>
> *Subject: *Re: RFR(L): 8215624: add parallel heap inspection support for
> jmap histo(G1)(Internet
*Wednesday, August 5, 2020 at 1:02 PM
*To: *"linzang(臧琳)" , "Hohensee, Paul"
, Stefan Karlsson ,
David Holmes , serviceability-dev
, "hotspot-gc-...@openjdk.java.net"
*Subject: *Re: RFR(L): 8215624: add parallel heap inspection support for
jmap histo(G1)(Internet mai
, Stefan Karlsson
, David Holmes
, serviceability-dev
,
"hotspot-gc-...@openjdk.java.net"
Subject: Re: RFR(L): 8215624: add parallel heap
inspection
avid Holmes , serviceability-dev , "hotspot-gc-...@openjdk.java.net"
Subject: RE: RFR(L): 8215624: add parallel heap inspection support for jmap histo(G1)(Internet mail)
Just small things.
heapInspection.cpp:
In ParHeapInspect
acle.com" , David Holmes , serviceability-dev , "hotspot-gc-...@openjdk.java.net"
Subject: RE: RFR(L): 8215624: add parallel heap inspection support for jmap histo(G1)(Internet mail)
Just small things.
heapInspection.cpp:
##
>
>
> Here is the webrev
http://cr.openjdk.java.net/~lzang/jmap-8214535/8215624/webrev_08/
>
> BRs,
> Lin
> ---------------------
>
-
From: "Hohensee, Paul"
Date: Thursday, July 23, 2020 at 6:48 AM
To: "linzang(臧琳)" , Stefan Karlsson ,
"serguei.spit...@oracle.com" , David Holmes , serviceability-dev
, "hotspot-gc-...@openjdk.ja
aul"
Date: Thursday, July 23, 2020 at 6:48 AM
To: "linzang(臧琳)" , Stefan Karlsson
, "serguei.spit...@oracle.com"
, David Holmes ,
serviceability-dev ,
"hotspot-gc-...@openjdk.java.net"
Subject:
ev ,
"hotspot-gc-...@openjdk.java.net"
Subject: RE: RFR(L): 8215624: add parallel heap inspection support
for jmap histo(G1)(Internet mail)
Just small things.
heapInspection.cpp:
In ParHeapInspectTask::work, remove the final return st
Date: Thursday, July 23, 2020 at 6:48 AM
To: "linzang(臧琳)" , Stefan Karlsson
, "serguei.spit...@oracle.com"
, David Holmes ,
serviceability-dev ,
"hotspot-gc-...@openjdk.java.net"
Subject: RE: RFR(L): 8215624: add parallel heap inspectio
cle.com"
, David Holmes ,
serviceability-dev ,
"hotspot-gc-...@openjdk.java.net"
Subject: RE: RFR(L): 8215624: add parallel heap inspection support for jmap
histo(G1)(Internet mail)
Just small things.
heapInspection.cpp:
In ParHeapInspectTask::work, remove the
.spit...@oracle.com"
, David Holmes ,
serviceability-dev ,
"hotspot-gc-...@openjdk.java.net"
Subject: RE: RFR(L): 8215624: add parallel heap inspection support for jmap
histo(G1)(Internet mail)
Just small things.
heapInspection.cpp:
In ParHeapInspectTask::work, remove the final retu
Upload a new webrev at
http://cr.openjdk.java.net/~lzang/jmap-8214535/8215624/webrev_07/
It fix a potential issue that unexpected number of threads maybe calculated
for "parallel" option of jmap -histo in container.
As shown at
Hi Paul,
Thanks for reviewing!
>>
>> I'd move all the argument parsing code to JMap.java and just pass
the results to Hotspot. Both histo() in JMap.java and code in attachListener.*
parse the command line arguments, though the code in histo() doesn't parse the
argument to
I'd like to see this feature added. :)
The CSR looks good, as does the basic parallel inspection algorithm. Stefan's
done the GC part, so I'll stick to the non-GC part (fwiw, the GC part lgtm).
I'd move all the argument parsing code to JMap.java and just pass the results
to Hotspot. Both
Dear All,
Sorry to bother again, I just want to make sure that is this change
worth to be continue to work on? If decision is made to not. I think I can drop
this work and stop asking for help reviewing...
Thanks for all your help about reviewing this previously.
BRs,
Lin
On
Dear All,
May I ask your help again for review the latest change? Thanks!
BRs,
Lin
On 2020/4/28, 1:54 PM, "linzang(臧琳)" wrote:
Hi Stefan,
>> - Adding Atomic::load/store.
>> - Removing the time measurement in the run_task. I renamed G1's
function
>> to
Hi Stefan,
>> - Adding Atomic::load/store.
>> - Removing the time measurement in the run_task. I renamed G1's function
>> to run_task_timed. If we need this outside of G1, we can rethink the API
>> at that point.
>> - ZGC style cleanups
Thanks for revising the patch, they
Hi Lin,
On 2020-04-26 05:10, linzang(臧琳) wrote:
Hi Stefan and Paul，
I have made a new patch based on your comments and Stefan's Poc code:
Webrev: http://cr.openjdk.java.net/~lzang/jmap-8214535/8215624/webrev_03/
Delta(based on Stefan's change:) :
Hi Stefan and Paul，
I have made a new patch based on your comments and Stefan's Poc code:
Webrev: http://cr.openjdk.java.net/~lzang/jmap-8214535/8215624/webrev_03/
Delta(based on Stefan's change:) :
Thanks Paul! I agree with using "parallel", will make the update in next patch,
Thanks for help update the CSR.
BRs,
Lin
On 2020/4/23, 4:42 AM, "Hohensee, Paul" wrote:
For the interface, I'd use "parallel" instead of "parallelThreadNum". All
the other options are lower case, and it's
For the interface, I'd use "parallel" instead of "parallelThreadNum". All the
other options are lower case, and it's a lot easier to type "parallel". I took
the liberty of updating the CSR. If you're ok with it, you might want to change
variable names and such, plus of course JMap.usage.
Dear Stefan,
Thanks a lot! I agree with you to decouple the heap inspection code
with GC's.
I will start from your POC code, may discuss with you later.
BRs,
Lin
On 2020/4/22, 5:14 PM, "Stefan Karlsson" wrote:
Hi Lin,
I took a look at this earlier and
45 matches
Mail list logo
