David Holmes [mailto:david.hol...@oracle.com]
Sent: Mittwoch, 14. Dezember 2016 11:42
To: Lindenmaier, Goetz ;
daniel.daughe...@oracle.com; 'Dmitry Samersoff'
; Java Core Libs ; serviceability-dev (serviceability-
d...@openjdk.java.net)
Subject: Re: RFR(M): 8170663: Fix minor issues
racle.com]
> >> Sent: Mittwoch, 14. Dezember 2016 12:29
> >> To: Lindenmaier, Goetz ;
> >> daniel.daughe...@oracle.com; 'Dmitry Samersoff'
> >> ; Java Core Libs >> d...@openjdk.java.net>; serviceability-dev (serviceability-
> >> d...@openjdk
racle.com]
Sent: Mittwoch, 14. Dezember 2016 11:42
To: Lindenmaier, Goetz ;
daniel.daughe...@oracle.com; 'Dmitry Samersoff'
; Java Core Libs ; serviceability-dev (serviceability-
d...@openjdk.java.net)
Subject: Re: RFR(M): 8170663: Fix minor issues in corelib and servicabilty
codin
ughe...@oracle.com; 'Dmitry Samersoff'
> ; Java Core Libs d...@openjdk.java.net>; serviceability-dev (serviceability-
> d...@openjdk.java.net)
> Subject: Re: RFR(M): 8170663: Fix minor issues in corelib and servicabilty
> coding.
>
> On 14/12/2016 9:00 PM, Lindenmaier,
Goetz ;
daniel.daughe...@oracle.com; 'Dmitry Samersoff'
; Java Core Libs ; serviceability-dev (serviceability-
d...@openjdk.java.net)
Subject: Re: RFR(M): 8170663: Fix minor issues in corelib and servicabilty
coding.
On 14/12/2016 8:23 PM, Lindenmaier, Goetz wrote:
Hi David,
I found
t; From: David Holmes [mailto:david.hol...@oracle.com]
> >> Sent: Mittwoch, 14. Dezember 2016 11:04
> >> To: Lindenmaier, Goetz ;
> >> daniel.daughe...@oracle.com; 'Dmitry Samersoff'
> >> ; Java Core Libs >> d...@openjdk.java.net>; serviceability-dev
z ;
daniel.daughe...@oracle.com; 'Dmitry Samersoff'
; Java Core Libs ; serviceability-dev (serviceability-
d...@openjdk.java.net)
Subject: Re: RFR(M): 8170663: Fix minor issues in corelib and servicabilty
coding.
On 14/12/2016 7:48 PM, Lindenmaier, Goetz wrote:
Hi,
8066474 has not been
. Dezember 2016 11:04
> To: Lindenmaier, Goetz ;
> daniel.daughe...@oracle.com; 'Dmitry Samersoff'
> ; Java Core Libs d...@openjdk.java.net>; serviceability-dev (serviceability-
> d...@openjdk.java.net)
> Subject: Re: RFR(M): 8170663: Fix minor issues in corelib and se
ty-dev (serviceability-
d...@openjdk.java.net)
Subject: Re: RFR(M): 8170663: Fix minor issues in corelib and servicabilty
coding.
On 9/12/2016 7:31 AM, Daniel D. Daugherty wrote:
On 12/8/16 1:59 PM, David Holmes wrote:
On 9/12/2016 12:21 AM, Lindenmaier, Goetz wrote:
Hi David,
thanks for looking at the
Dezember 2016 23:03
> To: daniel.daughe...@oracle.com; Lindenmaier, Goetz
> ; 'Dmitry Samersoff'
> ; Java Core Libs d...@openjdk.java.net>; serviceability-dev (serviceability-
> d...@openjdk.java.net)
> Subject: Re: RFR(M): 8170663: Fix minor issues in corelib and servicabi
Goetz
> ; 'Dmitry Samersoff'
> ; Java Core Libs d...@openjdk.java.net>; serviceability-dev (serviceability-
> d...@openjdk.java.net)
> Subject: Re: RFR(M): 8170663: Fix minor issues in corelib and servicabilty
> coding.
>
> On 9/12/2016 7:31 AM, Daniel D. Daughert
sday, December 07, 2016 2:43 PM
To: Lindenmaier, Goetz ; Java Core Libs
; serviceability-dev (serviceability-
d...@openjdk.java.net)
Subject: Re: RFR(M): 8170663: Fix minor issues in corelib and
servicabilty
coding.
Goetz,
SDE.c:
You might combine if at ll. 260 and 263 to one but it's just
matter of
mitry Samersoff'
; Java Core Libs ; serviceability-dev (serviceability-
d...@openjdk.java.net)
Subject: Re: RFR(M): 8170663: Fix minor issues in corelib and
servicabilty
coding.
Hi Goetz,
On 8/12/2016 1:26 AM, Lindenmaier, Goetz wrote:
Hi Dmitry,
yes, new_jvmpath is consistent with the oth
le.com]
Sent: Wednesday, December 07, 2016 2:43 PM
To: Lindenmaier, Goetz ; Java Core Libs
; serviceability-dev (serviceability-
d...@openjdk.java.net)
Subject: Re: RFR(M): 8170663: Fix minor issues in corelib and servicabilty
coding.
Goetz,
SDE.c:
You might combine if at ll. 260 and 263 to one but
er 2016 09:14
> To: Lindenmaier, Goetz ; 'Dmitry Samersoff'
> ; Java Core Libs d...@openjdk.java.net>; serviceability-dev (serviceability-
> d...@openjdk.java.net)
> Subject: Re: RFR(M): 8170663: Fix minor issues in corelib and servicabilty
> coding.
>
> Hi Goetz,
ndenmaier, Goetz ; Java Core Libs
; serviceability-dev (serviceability-
d...@openjdk.java.net)
Subject: Re: RFR(M): 8170663: Fix minor issues in corelib and servicabilty
coding.
Goetz,
SDE.c:
You might combine if at ll. 260 and 263 to one but it's just matter of test.
if (sti == baseStratumIndex || sti
nesday, December 07, 2016 2:43 PM
> > To: Lindenmaier, Goetz ; Java Core Libs
> > ; serviceability-dev (serviceability-
> > d...@openjdk.java.net)
> > Subject: Re: RFR(M): 8170663: Fix minor issues in corelib and
> servicabilty
> > coding.
> >
> > Goetz,
&
a Core Libs
>> ; serviceability-dev (serviceability-
>> d...@openjdk.java.net)
>> Subject: Re: RFR(M): 8170663: Fix minor issues in corelib and servicabilty
>> coding.
>>
>> Goetz,
>>
>> SDE.c:
>>
>> You might combine if at ll. 260 and 263 to one but i
samers...@oracle.com]
> Sent: Wednesday, December 07, 2016 2:43 PM
> To: Lindenmaier, Goetz ; Java Core Libs
> ; serviceability-dev (serviceability-
> d...@openjdk.java.net)
> Subject: Re: RFR(M): 8170663: Fix minor issues in corelib and servicabilty
> coding.
>
> Goetz,
>
> SD
Goetz,
SDE.c:
You might combine if at ll. 260 and 263 to one but it's just matter of test.
if (sti == baseStratumIndex || sti < 0) {
return; /* Java stratum - return unchanged */
}
> I'm not sure what you mean. I tried to fix it, but please
> double-check the new webrev.
if cnt is <=
ibs > d...@openjdk.java.net>; serviceability-dev (serviceability-
>> d...@openjdk.java.net)
>> Subject: Re: RFR(M): 8170663: Fix minor issues in corelib and servicabilty
>> coding.
>>
>> On 7/12/2016 6:37 PM, Lindenmaier, Goetz wrote:
>>> Hi Dmit
d...@openjdk.java.net>; serviceability-dev (serviceability-
> d...@openjdk.java.net)
> Subject: Re: RFR(M): 8170663: Fix minor issues in corelib and servicabilty
> coding.
>
> On 7/12/2016 6:37 PM, Lindenmaier, Goetz wrote:
> > Hi Dmitry,
> >
> > thanks
On 7/12/2016 6:37 PM, Lindenmaier, Goetz wrote:
Hi Dmitry,
thanks for looking at my change!
Updated webrev:
http://cr.openjdk.java.net/~goetz/wr16/8170663-corlib_s11y/webrev.02
* src/java.base/unix/native/libjli/java_md_solinux.c
Is this line correct?
519 jvmpath = JLI_StringDup(jv
Hi Dmitry,
thanks for looking at my change!
Updated webrev:
http://cr.openjdk.java.net/~goetz/wr16/8170663-corlib_s11y/webrev.02
> * src/java.base/unix/native/libjli/java_md_solinux.c
> Is this line correct?
> 519 jvmpath = JLI_StringDup(jvmpath);
It seems pointless. Should I remove
Goetz,
For serviceability code, please see comments below:
* src/java.base/share/native/libjli/java.c
No comments
* src/java.base/unix/native/libjli/java_md_solinux.c
Is this line correct?
519 jvmpath = JLI_StringDup(jvmpath);
* src/jdk.jdwp.agent/share/native/libjdwp/SDE.c
It m
Hi,
This change fixes some minor issues found in our code scans.
I hope this correctly addresses corelib and serviceability issues.
Please review:
http://cr.openjdk.java.net/~goetz/wr16/8170663-corlib_s11y/webrev.01/
Best regards,
Goetz.
Changes in detail:
e_asin.c
Code scan reports missing
26 matches
Mail list logo
