Re: RFR(M) : 8177507 : line number sensitive tests for jdi should be unified

Misha, David, Serguei, Thank you for review! -- Igor

Re: RFR(M) : 8177507 : line number sensitive tests for jdi should be unified

Looks good to me. Misha On 4/3/17, 4:54 PM, David Holmes wrote: On 4/04/2017 9:09 AM, Igor Ignatyev wrote: yes, David you are right. it's so embarrassing ... besides uploading webrev w/o all changes, I have also tested it w/o all changes, I should have noticed that. Thank you for catching that

Re: RFR(M) : 8177507 : line number sensitive tests for jdi should be unified

On 4/04/2017 9:09 AM, Igor Ignatyev wrote: yes, David you are right. it's so embarrassing ... besides uploading webrev w/o all changes, I have also tested it w/o all changes, I should have noticed that. Thank you for catching that. I have fixed that, tested and uploaded new webrev -- _http://cr.

Re: RFR(M) : 8177507 : line number sensitive tests for jdi should be unified

It is good now. Thanks, Serguei On 4/3/17 16:09, Igor Ignatyev wrote: yes, David you are right. it's so embarrassing ... besides uploading webrev w/o all changes, I have also tested it w/o all changes, I should have noticed that. Thank you for catching that. I have fixed that, tested and u

Re: RFR(M) : 8177507 : line number sensitive tests for jdi should be unified

yes, David you are right. it's so embarrassing ... besides uploading webrev w/o all changes, I have also tested it w/o all changes, I should have noticed that. Thank you for catching that. I have fixed that, tested and uploaded new webrev -- http://cr.openjdk.java.net/~iignatyev/8177507/webrev.

Re: RFR(M) : 8177507 : line number sensitive tests for jdi should be unified

On 4/3/17 13:53, David Holmes wrote: On 4/04/2017 2:46 AM, Igor Ignatyev wrote: looks like I have uploaded the webrev before I saved files... uploaded a new webrev w/ all mentioned changes: http://cr.openjdk.java.net/~iignatyev/8177507/webrev.02 I don't see how the change to LambdaBreakpointTe

Re: RFR(M) : 8177507 : line number sensitive tests for jdi should be unified

On 4/04/2017 2:46 AM, Igor Ignatyev wrote: looks like I have uploaded the webrev before I saved files... uploaded a new webrev w/ all mentioned changes: http://cr.openjdk.java.net/~iignatyev/8177507/webrev.02 I don't see how the change to LambdaBreakpointTest can possibly work. The new test st

Re: RFR(M) : 8177507 : line number sensitive tests for jdi should be unified

Hi Igor, It looks good. Thank you for the update! Thanks, Serguei On 4/3/17 09:46, Igor Ignatyev wrote: looks like I have uploaded the webrev before I saved files... uploaded a new webrev w/ all mentioned changes: http://cr.openjdk.java.net/~iignatyev/8177507/webrev.02

Re: RFR(M) : 8177507 : line number sensitive tests for jdi should be unified

looks like I have uploaded the webrev before I saved files... uploaded a new webrev w/ all mentioned changes: http://cr.openjdk.java.net/~iignatyev/8177507/webrev.02 -- Igor > On Apr 2, 2017, at 1:31 PM, David Holmes

Re: RFR(M) : 8177507 : line number sensitive tests for jdi should be unified

Hi Igor, On 3/04/2017 3:09 AM, Igor Ignatyev wrote: Hi, http://cr.openjdk.java.net/~iignatyev//8177507/webrev.01 is the next iteration w/ copyright years fixed, test/com/sun/jdi/BreakpointTest.java also needs fixing - says 2015. LineNumberOnBraceTarg and test/com/sun/jdi/LineNumberOnBrac

Re: RFR(M) : 8177507 : line number sensitive tests for jdi should be unified

Hi, http://cr.openjdk.java.net/~iignatyev//8177507/webrev.01 is the next iteration w/ copyright years fixed, LineNumberOnBraceTarg and LambdaBreakpointTest made more unified w/ the rest. Thanks, -- Igor > On Mar 29, 2017, at 12:57 PM,

Re: RFR(M) : 8177507 : line number sensitive tests for jdi should be unified

Hi Igor, +1 to the Mikhailo's comment. This one also does not look unified: http://cr.openjdk.java.net/~iignatyev/8177507/webrev.00/test/com/sun/jdi/LambdaBreakpointTest.java.udiff.html But I do not have a strong opinion on it and leave it up to you. Thanks, Serguei On 3/29/17 11:08, Mikha

Re: RFR(M) : 8177507 : line number sensitive tests for jdi should be unified

Hi Igor, Looks good. One style nit: LineNumberOnBraceTarg: All other Java tests use style of CAP_UNDERSCORE (e.g. STOP_LINE) for line number variables, but this test uses 'stopLine'. Consider changing it to STOP_LINE (and STOP_LINE_2) to be uniform. The rest looks good to me (+ David's co

Re: RFR(M) : 8177507 : line number sensitive tests for jdi should be unified

Hi David, thank you for review. please see my answers inlined. > On Mar 28, 2017, at 6:37 PM, David Holmes wrote: > > Hi Igor, > > This cleanup looks good to me! One query: > > test/com/sun/jdi/LineNumberOnBraceTest.java > > The old version seems to have the wrong line numbers - was it faili

Re: RFR(M) : 8177507 : line number sensitive tests for jdi should be unified

Hi Igor, This cleanup looks good to me! One query: test/com/sun/jdi/LineNumberOnBraceTest.java The old version seems to have the wrong line numbers - was it failing? Two nits: - test/com/sun/jdi/FetchLocals.java - test/com/sun/jdi/LambdaBreakpointTest.java Second copyright year should be 2017

Re: RFR(M) : 8177507 : line number sensitive tests for jdi should be unified

Hi, still looking for a reviewer, anyone? -- Igor > On Mar 24, 2017, at 1:56 PM, Igor Ignatyev wrote: > > http://cr.openjdk.java.net/~iignatyev/8177507/webrev.00 >> 295 lines changed: 176 ins; 15 del; 104 mod; > > Hi all, > > could you please review this fix for 8177507? > > due to their nat

RFR(M) : 8177507 : line number sensitive tests for jdi should be unified

http://cr.openjdk.java.net/~iignatyev/8177507/webrev.00 > 295 lines changed: 176 ins; 15 del; 104 mod; Hi all, could you please review this fix for 8177507? due to their nature, some of jdi tests are line number sensitive. unfortunately different tests indicate that differently, so it's quite e