Re: RFR/C: 8218922: SA: Enable best-effort implementation of live regions iteration for ZGC

2019-02-18 Thread Kevin Walls
Great, thanks Stefan, that collection of changes builds for me and I've seem the histogram from a live process using ZGC, and a core of the same.  Fantastic. 8-) On 15/02/2019 19:06, Stefan Karlsson wrote: Hi Kevin, On 2019-02-15 13:14, Kevin Walls wrote: Hi Stefan, This is great - if I

Re: RFR/C: 8218922: SA: Enable best-effort implementation of live regions iteration for ZGC

2019-02-18 Thread Stefan Karlsson
Thanks, Erik. StefanK On 2019-02-18 10:35, Erik Österlund wrote: Hi Stefan, Looks good! Thanks, /Erik On 2019-02-15 20:25, Stefan Karlsson wrote: Testing showed that the re-enabling of the retiring of TLABs was broken. This has been fixed with this patch: http://cr.openjdk.java.net/~stefa

Re: RFR/C: 8218922: SA: Enable best-effort implementation of live regions iteration for ZGC

2019-02-18 Thread Erik Österlund
Hi Stefan, Looks good! Thanks, /Erik On 2019-02-15 20:25, Stefan Karlsson wrote: Testing showed that the re-enabling of the retiring of TLABs was broken. This has been fixed with this patch: http://cr.openjdk.java.net/~stefank/8218922/webrev.03.delta http://cr.openjdk.java.net/~stefank/82189

Re: RFR/C: 8218922: SA: Enable best-effort implementation of live regions iteration for ZGC

2019-02-15 Thread Stefan Karlsson
Testing showed that the re-enabling of the retiring of TLABs was broken. This has been fixed with this patch: http://cr.openjdk.java.net/~stefank/8218922/webrev.03.delta http://cr.openjdk.java.net/~stefank/8218922/webrev.03 During mark start we change what's considered the "good" view of the h

Re: RFR/C: 8218922: SA: Enable best-effort implementation of live regions iteration for ZGC

2019-02-15 Thread Stefan Karlsson
Hi Kevin, On 2019-02-15 13:14, Kevin Walls wrote: Hi Stefan, This is great - if I want to try it out, what order do the changes apply, does the 8218746 webrev apply to create ZExternalBitMap.java and then the 8218922 webrev? This is my patch queue of outgoing patches:  zSA.fixVMObjectFactory

Re: RFR/C: 8218922: SA: Enable best-effort implementation of live regions iteration for ZGC

2019-02-15 Thread Kevin Walls
Hi Stefan, This is great - if I want to try it out, what order do the changes apply, does the 8218746 webrev apply to create ZExternalBitMap.java and then the 8218922 webrev? Thanks Kevin On 14/02/2019 17:12, Stefan Karlsson wrote: Hi again, I've separated the live regions iteration refac

Re: RFR/C: 8218922: SA: Enable best-effort implementation of live regions iteration for ZGC

2019-02-15 Thread Stefan Karlsson
Thanks, Yasumasa! StefanK On 2019-02-15 01:54, Yasumasa Suenaga wrote: Hi Stefan, Both changes look good to me! Thanks, Yasumasa 2019年2月15日(金) 2:12 Stefan Karlsson : Hi again, I've separated the live regions iteration refactoring into this patch: https://cr.openjdk.java.net/~stefank/821

Re: RFR/C: 8218922: SA: Enable best-effort implementation of live regions iteration for ZGC

2019-02-14 Thread Yasumasa Suenaga
Hi Stefan, Both changes look good to me! Thanks, Yasumasa 2019年2月15日(金) 2:12 Stefan Karlsson : > > Hi again, > > I've separated the live regions iteration refactoring into this patch: > https://cr.openjdk.java.net/~stefank/8219003/webrev.01/ > > And use this RFE for the ZGC specific parts: > h

Re: RFR/C: 8218922: SA: Enable best-effort implementation of live regions iteration for ZGC

2019-02-14 Thread Stefan Karlsson
Hi again, I've separated the live regions iteration refactoring into this patch: https://cr.openjdk.java.net/~stefank/8219003/webrev.01/ And use this RFE for the ZGC specific parts: https://cr.openjdk.java.net/~stefank/8218922/webrev.02/ Thanks, StefanK On 2019-02-14 14:39, Stefan Karlsson wro

Re: RFR/C: 8218922: SA: Enable best-effort implementation of live regions iteration for ZGC

2019-02-14 Thread Stefan Karlsson
Hi Yasumasa, On 2019-02-14 14:11, Yasumasa Suenaga wrote: Hi Stefan, Maybe this is enough to enable a bit more SA debugging capabilities when running with ZGC? What do you think, should we bring in this change? I think it should be brought this in. I filed same issue as JDK-8207843, but I've

Re: RFR/C: 8218922: SA: Enable best-effort implementation of live regions iteration for ZGC

2019-02-14 Thread Yasumasa Suenaga
Hi Stefan, Maybe this is enough to enable a bit more SA debugging capabilities when running with ZGC? What do you think, should we bring in this change? I think it should be brought this in. I filed same issue as JDK-8207843, but I've not yet worked. So I will close it as duplicate of your cha

Re: RFR/C: 8218922: SA: Enable best-effort implementation of live regions iteration for ZGC

2019-02-14 Thread Stefan Karlsson
If this patch is accepted we also need this patch to turn on the SA hprof implementation: http://cr.openjdk.java.net/~stefank/8218970/webrev.01/ StefanK On 2019-02-13 15:52, Stefan Karlsson wrote: Hi all, Please review / comment on this patch to enable a best-effort live heap region iteratio

Re: RFR/C: 8218922: SA: Enable best-effort implementation of live regions iteration for ZGC

2019-02-14 Thread Stefan Karlsson
Thanks for taking a look at this! StefanK On 2019-02-14 10:58, Erik Österlund wrote: Hi Stefan, I think this makes things better. I like the cleanups and I like the partial support for heap parsing. I think we should bring this in, and it looks good to me. Of course we can always improve t

Re: RFR/C: 8218922: SA: Enable best-effort implementation of live regions iteration for ZGC

2019-02-14 Thread Erik Österlund
Hi Stefan, I think this makes things better. I like the cleanups and I like the partial support for heap parsing. I think we should bring this in, and it looks good to me. Of course we can always improve this further at some point in the future to deal with broken Klass pointers better. Th

RFR/C: 8218922: SA: Enable best-effort implementation of live regions iteration for ZGC

2019-02-13 Thread Stefan Karlsson
Hi all, Please review / comment on this patch to enable a best-effort live heap region iteration implementation in ZGC. http://cr.openjdk.java.net/~stefank/8218922/webrev.01/ https://bugs.openjdk.java.net/browse/JDK-8218922 The SA has functionally that relies on live heap region information f