Thank you, David!
/R
On 05/14/2012 01:29 PM, David Holmes wrote:
On 14/05/2012 6:55 PM, Rickard Bäckman wrote:
this has been out on review for a while, without any OK or objections.
So I'll ask again, can I have a review or two on this small change?
Sorry Rickard I got distracted from my ear
On 14/05/2012 6:55 PM, Rickard Bäckman wrote:
this has been out on review for a while, without any OK or objections.
So I'll ask again, can I have a review or two on this small change?
Sorry Rickard I got distracted from my earlier start on this.
Reviewed!
David
-
Thanks
/R
On 05/03/20
Well it looks ok to me anyway..
Regards,
Nils Loodin
On May 14, 2012, at 10:55 , Rickard Bäckman wrote:
> Hi,
>
> this has been out on review for a while, without any OK or objections.
> So I'll ask again, can I have a review or two on this small change?
>
> Thanks
> /R
>
> On 05/03/2012 11:3
Hi,
this has been out on review for a while, without any OK or objections.
So I'll ask again, can I have a review or two on this small change?
Thanks
/R
On 05/03/2012 11:39 AM, Rickard Bäckman wrote:
Hi all,
I've made a refactoring of thread_id in OSThread, which reduces the
amount of duplica
On 05/07/2012 10:55 AM, David Holmes wrote:
On 7/05/2012 5:21 PM, Rickard Bäckman wrote:
David,
I can't find that code in any of the modified files (only as "blue" text
in osThread_bsd.hpp, but that is removed code).
Sorry the frames view of the webrev confused me. It is "blue" but that
is no
On 7/05/2012 5:21 PM, Rickard Bäckman wrote:
David,
I can't find that code in any of the modified files (only as "blue" text
in osThread_bsd.hpp, but that is removed code).
Sorry the frames view of the webrev confused me. It is "blue" but that
is normally added or modified code, while "red" i
David,
I can't find that code in any of the modified files (only as "blue" text
in osThread_bsd.hpp, but that is removed code).
There is a set_thread_id in osThread.hpp
118 void set_thread_id(thread_id_t id) { _thread_id = id; }
Thanks
/R
On 05/06/2012 02:10 PM, David Holmes
Hi Rickard,
One initial comment. Isn't this redundant:
102 #ifdef _ALLBSD_SOURCE
103 #ifdef __APPLE__
104 void set_thread_id(thread_t id) {
105 _thread_id = id;
106 }
107 #else
108 void set_thread_id(pthread_t id) {
109 _thread_id = id;
110 }
111 #endif
112 #else
113
Hi all,
I've made a refactoring of thread_id in OSThread, which reduces the
amount of duplicated code.
Please review this change at:
http://cr.openjdk.java.net/~rbackman/7161732/webrev/
Thanks
/R
Hi,
after some internal discussions it is clear that there are a couple of problems
with this change.
Please ignore it for now.
Thanks
/R
On Apr 18, 2012, at 8:16 AM, Rickard Bäckman wrote:
> Hi all,
>
> can I have some reviews for my attempt at making OSThread a bit more generic,
> reducing
Hi all,
can I have some reviews for my attempt at making OSThread a bit more
generic, reducing the code duplication.
Webrev: http://cr.openjdk.java.net/~rbackman/7161732/webrev/
Thanks
/R
11 matches
Mail list logo
