Re: RFR: 8009615: JvmtiClassFileReconstituter does not create BootstrapMethod attributes

Looks good. I've overlooked it too. :( Thanks, Serguei On 5/6/13 10:58 PM, Staffan Larsen wrote: On 6 maj 2013, at 23:58, John Rose > wrote: On May 2, 2013, at 1:50 AM, Staffan Larsen > wrote: JvmtiClassFileReconstituter does

Re: RFR: 8009615: JvmtiClassFileReconstituter does not create BootstrapMethod attributes

On 6 maj 2013, at 23:58, John Rose wrote: > On May 2, 2013, at 1:50 AM, Staffan Larsen wrote: > >> JvmtiClassFileReconstituter does not create BootstrapMethod attributes when >> re-creating a class for retransformation. This fix uses the operands in the >> constant pool to re-create the Boot

Re: RFR: 8009615: JvmtiClassFileReconstituter does not create BootstrapMethod attributes

On May 2, 2013, at 1:50 AM, Staffan Larsen wrote: > JvmtiClassFileReconstituter does not create BootstrapMethod attributes when > re-creating a class for retransformation. This fix uses the operands in the > constant pool to re-create the BootstrapMethod attributes in the class file. > > webre

Re: RFR: 8009615: JvmtiClassFileReconstituter does not create BootstrapMethod attributes

Can I have a second review of this change, please? /Staffan On 2 maj 2013, at 10:50, Staffan Larsen wrote: > JvmtiClassFileReconstituter does not create BootstrapMethod attributes when > re-creating a class for retransformation. This fix uses the operands in the > constant pool to re-create t

Re: RFR: 8009615: JvmtiClassFileReconstituter does not create BootstrapMethod attributes

Thanks Serguei! I'll fix both of these before pushing. /Staffan On 2 maj 2013, at 12:24, serguei.spit...@oracle.com wrote: > This looks good. > Thank you for discovering and fixing it! > > A couple of cosmetic comments: > 352 //} >Indent for "}" is needed > > 376 u2 bootstrap_argu

Re: RFR: 8009615: JvmtiClassFileReconstituter does not create BootstrapMethod attributes

This looks good. Thank you for discovering and fixing it! A couple of cosmetic comments: 352 //} Indent for "}" is needed 376 u2 bootstrap_arguments = cpool()->operand_argument_index_at(n, arg); It is about one argument. Should the variable name be: "bootstrap_argument" ? T

RE: RFR: 8009615: JvmtiClassFileReconstituter does not create BootstrapMethod attributes

does not create BootstrapMethod attributes JvmtiClassFileReconstituter does not create BootstrapMethod attributes when re-creating a class for retransformation. This fix uses the operands in the constant pool to re-create the BootstrapMethod attributes in the class file. webrev: http

RFR: 8009615: JvmtiClassFileReconstituter does not create BootstrapMethod attributes

JvmtiClassFileReconstituter does not create BootstrapMethod attributes when re-creating a class for retransformation. This fix uses the operands in the constant pool to re-create the BootstrapMethod attributes in the class file. webrev: http://cr.openjdk.java.net/~sla/8009615/webrev.00/ bug: htt