On 31/12/2014 11:16, Jaroslav Bachorik wrote:
:
I guess something like "// 8028357 removed old, inefficient debug
logging" in place of the DEBUG declaration in each affected file
wouldn't be too busy and also give future maintainers a handle to this
changeset and thus this discussion. Would tha
On 30.12.2014 23:22, Claes Redestad wrote:
On 2014-12-30 18:35, Jaroslav Bachorik wrote:
The affected files are pretty stable so we could remove *all* the
logging related methods. When a necessity arises to have a
configurable logging we would just need to re-introduce it properly.
Right, I'l
On 2014-12-30 18:35, Jaroslav Bachorik wrote:
The affected files are pretty stable so we could remove *all* the
logging related methods. When a necessity arises to have a
configurable logging we would just need to re-introduce it properly.
Right, I'll leave the patch as-is when it comes to c
On 30.12.2014 17:07, Claes Redestad wrote:
Hi Jaroslav, thanks for looking at this!
On 2014-12-30 14:43, Jaroslav Bachorik wrote:
While it's good to see the dead code gone I would prefer keeping the
logging code just commented out - the logging code could be useful
when investigating any futur
Hi Jaroslav, thanks for looking at this!
On 2014-12-30 14:43, Jaroslav Bachorik wrote:
While it's good to see the dead code gone I would prefer keeping the
logging code just commented out - the logging code could be useful
when investigating any future failures.
Do you mean all of it, or ju
On 29.12.2014 16:51, Claes Redestad wrote:
Hi,
some classes in jvmstat/perfdata code contains debug logging code
predating the logging APIs, which
provokes some unnecessary allocation in certain applications.
Since the debug logging can't have been used for quite some time, I
propose to remove
Hi,
some classes in jvmstat/perfdata code contains debug logging code
predating the logging APIs, which
provokes some unnecessary allocation in certain applications.
Since the debug logging can't have been used for quite some time, I
propose to remove it altogether
rather than converting it
