It’s been a very useful little test when changing the code in utf.c. Not sure
why it has to be removed.
/Staffan
On 8 apr 2014, at 17:30, Vladimir Kempik vladimir.kem...@oracle.com wrote:
Hello
Please review this changeset:
File jdk/src/share/npt/utf.c contains a testcase that shouldn't
Staffan,
We can move it to separate file and put to test directory (with no
intention to run it automatically).
Other options is just change define to keep the test code but don't
compile it to production libnpt.
-Dmitry
On 2014-04-09 11:12, Staffan Larsen wrote:
It’s been a very useful
I would prefer to keep the test where it is but change the “#if 1” to “#if 0”
on line 399.
Thanks,
/Staffan
On 9 apr 2014, at 14:03, Dmitry Samersoff dmitry.samers...@oracle.com wrote:
Staffan,
We can move it to separate file and put to test directory (with no
intention to run it
Staffan,
On 2014-04-09 16:20, Staffan Larsen wrote:
I would prefer to keep the test where it is but change the “#if 1” to “#if 0”
on line 399.
Are you OK with
#ifdef COMPILE_WITH_UTF_TEST
-Dmitry
Thanks,
/Staffan
On 9 apr 2014, at 14:03, Dmitry Samersoff dmitry.samers...@oracle.com
Sure.
On 9 apr 2014, at 14:24, Dmitry Samersoff dmitry.samers...@oracle.com wrote:
Staffan,
On 2014-04-09 16:20, Staffan Larsen wrote:
I would prefer to keep the test where it is but change the “#if 1” to “#if
0” on line 399.
Are you OK with
#ifdef COMPILE_WITH_UTF_TEST
-Dmitry
Vladimir,
Please change define to
#ifdef COMPILE_WITH_UTF_TEST
-Dmitry
On 2014-04-09 16:28, Staffan Larsen wrote:
Sure.
On 9 apr 2014, at 14:24, Dmitry Samersoff dmitry.samers...@oracle.com
mailto:dmitry.samers...@oracle.com wrote:
Staffan,
On 2014-04-09 16:20, Staffan Larsen wrote:
Hello
Thanks for comments.
Updated webrev: http://cr.openjdk.java.net/~vkempik/8039368/webrev.01/
Vladimir.
On 09.04.2014 16:32, Dmitry Samersoff wrote:
Vladimir,
Please change define to
#ifdef COMPILE_WITH_UTF_TEST
-Dmitry
On 2014-04-09 16:28, Staffan Larsen wrote:
Sure.
On 9 apr
Reviewed.
Thanks,
/Staffan
On 9 apr 2014, at 14:49, Vladimir Kempik vladimir.kem...@oracle.com wrote:
Hello
Thanks for comments.
Updated webrev: http://cr.openjdk.java.net/~vkempik/8039368/webrev.01/
Vladimir.
On 09.04.2014 16:32, Dmitry Samersoff wrote:
Vladimir,
Please change
Vladimir,
Looks good for me!
-Dmitry
On 2014-04-09 16:49, Vladimir Kempik wrote:
Hello
Thanks for comments.
Updated webrev: http://cr.openjdk.java.net/~vkempik/8039368/webrev.01/
Vladimir.
On 09.04.2014 16:32, Dmitry Samersoff wrote:
Vladimir,
Please change define to
#ifdef
Hello
Please review this changeset:
File jdk/src/share/npt/utf.c contains a testcase that shouldn't be in
production library.
bug: https://bugs.openjdk.java.net/browse/JDK-8039368
webrev: http://cr.openjdk.java.net/~vkempik/8039368/webrev.00/
Thanks, Vladimir.
10 matches
Mail list logo