Re: RFR: 8145153: Convert TraceMonitorInflation to Unified Logging

2015-12-14 Thread Marcus Larsson
On 2015-12-14 05:19, David Holmes wrote: Hi Rachel, On 12/12/2015 3:41 AM, Rachel Protacio wrote: Hi David, Thanks for the review! Updated webrev: http://cr.openjdk.java.net/~rprotacio/8145153.01/ You still aren't building the testlibrary in the test. More below ... On 12/10/2015 7:53 PM

Re: RFR: 8145153: Convert TraceMonitorInflation to Unified Logging

2015-12-13 Thread David Holmes
Hi Rachel, On 12/12/2015 3:41 AM, Rachel Protacio wrote: Hi David, Thanks for the review! Updated webrev: http://cr.openjdk.java.net/~rprotacio/8145153.01/ You still aren't building the testlibrary in the test. More below ... On 12/10/2015 7:53 PM, David Holmes wrote: Hi Rachel, On 11/12

Re: RFR: 8145153: Convert TraceMonitorInflation to Unified Logging

2015-12-11 Thread Rachel Protacio
Hi David, Thanks for the review! Updated webrev: http://cr.openjdk.java.net/~rprotacio/8145153.01/ On 12/10/2015 7:53 PM, David Holmes wrote: Hi Rachel, On 11/12/2015 8:21 AM, Rachel Protacio wrote: Hello! Please review another product flag logging change. This one's pretty small. Converts

Re: RFR: 8145153: Convert TraceMonitorInflation to Unified Logging

2015-12-10 Thread David Holmes
Hi Rachel, On 11/12/2015 8:21 AM, Rachel Protacio wrote: Hello! Please review another product flag logging change. This one's pretty small. Converts TraceMonitorInflation to -Xlog:monitorinflation=debug Conversion looks fine. internally, with an alias for the old option. I've again patched

RFR: 8145153: Convert TraceMonitorInflation to Unified Logging

2015-12-10 Thread Rachel Protacio
Hello! Please review another product flag logging change. This one's pretty small. Converts TraceMonitorInflation to -Xlog:monitorinflation=debug internally, with an alias for the old option. I've again patched in Max's alias table code in the arguments.cpp and .hpp files since my previous ch